altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
8050 commits 1 branch 0 tags 2.6 GiB
Commit graph

76 commits

Author SHA1 Message Date
Robert Sparks 1ea983a1c2 Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065. Commit ready for merge. 
- Legacy-Id: 12505
 2016-12-12 21:42:53 +00:00
Henrik Levkowetz 3c956c9896 Added migrations for new timezone data, validation on ReviewerSettings.filter_re, and new docevent types. 
- Legacy-Id: 12493
 2016-12-09 12:41:38 +00:00
Henrik Levkowetz ef301c0f31 Merged in [12479] from olau@iola.dk: 
Add missing team constraint in the check for previous reviews by a
reviewer.
 - Legacy-Id: 12481
Note: SVN reference [12479] has been migrated to Git commit 3f98a1a182
 2016-12-08 16:43:45 +00:00
Ole Laursen 3f98a1a182 Add missing team constraint in the check for previous reviews by a 
reviewer. Commit ready for merge.
 - Legacy-Id: 12479
 2016-12-08 12:49:56 +00:00
Henrik Levkowetz e79368f15e Added new display columns to the reviewer settings admin page. 
- Legacy-Id: 12442
 2016-12-04 13:07:16 +00:00
Henrik Levkowetz 5959b3a46a Added a validator for the reviewer settings' Filter Regexp field, to make sure that we don't later hit exceptions when trying to compile and use the regexp entered. 
- Legacy-Id: 12439
 2016-12-01 21:30:39 +00:00
Henrik Levkowetz ca4ab7b402 Added a migration for updated help text on some review fields. 
- Legacy-Id: 12422
 2016-11-30 14:31:52 +00:00
Ole Laursen 7d8baf0015 Add reviewer name and completion date to previous reviews in manage 
review page
 - Legacy-Id: 12397
 2016-11-25 10:53:37 +00:00
Ole Laursen 1970cbab16 Modify importer to take deadline from the document log if at all 
possible, also add an extra assignment fallback using deadline =
assignment time + 30 days for early reviews that never had a deadline
(a few left in secdir)
 - Legacy-Id: 12381
 2016-11-17 17:16:00 +00:00
Ole Laursen d302875381 Don't limit the team choices for ResultUsedInReviewTeam, otherwise 
it's not possible to make a new team
 - Legacy-Id: 12363
 2016-11-16 10:42:18 +00:00
Ole Laursen 4826de8c5e Decode timestamps from the previous review tool as being in UTC 
- Legacy-Id: 12349
 2016-11-14 14:11:36 +00:00
Ole Laursen 39d674b4ca Add missing resource and missing test review secretary settings 
- Legacy-Id: 12313
 2016-11-09 10:07:49 +00:00
Ole Laursen ceec1254f2 Add review team secretary reminders, like those for reviewers 
- Legacy-Id: 12283
 2016-11-08 16:24:28 +00:00
Ole Laursen cde7cfacd5 Modify the reviewer overview page to display up to 10 historic reviews 
per person from the past year instead of only 5.

Add basic reviewer stats to the assignment select box.
 - Legacy-Id: 12279
 2016-11-07 22:32:53 +00:00
Ole Laursen c3e8cabafb Revamp the layout in the manage review requests page. Drop the table 
and instead provide more information about each document to be
reviewed, to help the secretaries determine locally on that page what
action to take. The new layout should also make it easier to fit in
more info, in case it is still found lacking.

The public review request page still provides the previous information
in the summarized tabular form, so the overview can be found there.
 - Legacy-Id: 12278
 2016-11-07 21:20:15 +00:00
Ole Laursen 19a3f10f69 Fix bug in telechat code, a previous rewrite to fix a possible problem 
was misguided - we should always only look at the latest telechat
event
 - Legacy-Id: 12265
 2016-11-03 23:43:01 +00:00
Ole Laursen ac1b93a8a2 Base the assignment checks on persons rather than email addresses - 
otherwise people may use a new email address and not be caught in a
check
 - Legacy-Id: 12264
 2016-11-03 21:01:41 +00:00
Ole Laursen 7461409f7f Fix bug in suggestion algorithm, it was pruning suggestions with 
review requests from all teams, not just the team under consideration
 - Legacy-Id: 12257
 2016-11-03 20:31:44 +00:00
Ole Laursen 010c20801e When importing next reviewer, set it to the reviewer following the one 
that the old tool was pointing to, as it was pointing to the
last one having completed a review (despite being named next)
 - Legacy-Id: 12255
 2016-11-03 20:13:00 +00:00
Ole Laursen b16a829ec7 Modify review import to read result data for genart from an extra dataset 
- Legacy-Id: 12248
 2016-11-03 12:49:50 +00:00
Ole Laursen 54bc9ff596 Modify importer to close review requests for done documents as status 
"Unknown" instead of auto-closing those where the IESG state is
further in the process on - this seems to leave more requests in
genart open, but hopefully the extra data for genart will fix this
problem shortly.
 - Legacy-Id: 12247
 2016-11-02 16:58:03 +00:00
Ole Laursen 67e6423cb4 Modify importer to pick deadline from documents when there's an exact 
match, otherwise prefer what's stored with the review request (fixes
a bunch of cases with multiple reviews of the same draft)
 - Legacy-Id: 12246
 2016-11-02 12:37:47 +00:00
Ole Laursen b9d5352afd Display the reviewed revision in reviewer overview page 
- Legacy-Id: 12245
 2016-11-02 11:33:25 +00:00
Ole Laursen 70dfb760cb Don't import reviewer roles for completely unavailable reviewers who were marked as away until after 2020 
- Legacy-Id: 12244
 2016-11-01 20:57:34 +00:00
Ole Laursen 77d7d8b236 Add totals to review statistics tables and make it possible to select 
multiple teams in the graph and get accumulated counts shown
 - Legacy-Id: 12223
 2016-10-27 21:36:02 +00:00
Ole Laursen 3835532d71 Insert iconic link to review statistics from the team pages 
- Legacy-Id: 12215
 2016-10-26 13:35:32 +00:00
Ole Laursen 2548153894 Fix permission bug, secretaries should be able to request reviews 
- Legacy-Id: 12191
 2016-10-20 19:57:39 +00:00
Ole Laursen 95bbabf384 Ignore duplicate review requests in importer - genart has had quite a 
few of these
 - Legacy-Id: 12171
 2016-10-18 13:50:10 +00:00
Ole Laursen d95be38ee7 Implement a reviewer blacklist in the importer and add "alice" in 
genart to it
 - Legacy-Id: 12170
 2016-10-18 11:51:33 +00:00
Ole Laursen 2ce2f8d067 Change default of ReviewerSettings.min_interval to null - if it's not 
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12169
 2016-10-18 10:37:03 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not 
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
 2016-10-18 10:36:42 +00:00
Ole Laursen 78e4fa623e Tweak the sort order so that the minimum interval between reviews is 
considered of lower importance compared to previous reviews/wishes to
review the document
 - Legacy-Id: 12167
 2016-10-17 21:52:07 +00:00
Ole Laursen 6b492ccf59 Only suggest I-Ds for review, not other types of documents 
- Legacy-Id: 12165
 2016-10-17 21:38:15 +00:00
Ole Laursen e11a911d86 Include from in the list of messages when completing a review and 
searching for the review email, redo layout somewhat to accommodate
this and improve the presentation of the message date.
 - Legacy-Id: 12163
 2016-10-17 21:26:36 +00:00
Ole Laursen 399bb3bf4d Make UnavailablePeriod.start_date nullable and import the unavailable 
periods from the Perl tool with start date null as we don't know when
they started.
 - Legacy-Id: 12161
 2016-10-17 19:37:56 +00:00
Ole Laursen e1f69171b5 xslugify the last name part when constructing a name for the review document 
- Legacy-Id: 12147
 2016-10-14 09:42:34 +00:00
Ole Laursen 9de2d49823 Fixup some of the migrations a bit upon the merge with trunk. 
- Legacy-Id: 12135
 2016-10-13 19:20:26 +00:00
Ole Laursen 60ec861bd6 Shorten the verbose names a bit, they make Django complain 
- Legacy-Id: 12130
 2016-10-13 17:10:04 +00:00
Ole Laursen 8f497af6e6 Add admin.py for review models 
- Legacy-Id: 12128
 2016-10-13 16:16:34 +00:00
Ole Laursen 336e2bbc5e In case the review data contains a proper name for a person we already 
know, use that - this prevents problems with email addresses being
embedded in review document names.
 - Legacy-Id: 12126
 2016-10-13 15:53:14 +00:00
Ole Laursen bf55237112 Add statistics section with review statistics. Fix a couple of missing tests. 
- Legacy-Id: 12124
 2016-10-13 15:20:04 +00:00
Ole Laursen 59180240af Add a simple reminder system for reviewers so that they can opt in to 
being reminded X days before deadline of an assignment
 - Legacy-Id: 12101
 2016-10-07 16:43:29 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting 
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
 2016-10-06 14:47:41 +00:00
Ole Laursen 037556bc8f Set request time for auto-suggested review requests to the time where 
the triggering event happened - this is probably only marginally
useful at the moment, but could perhaps be used for statistics later
on (e.g. comparing earliest possible request time vs. assignment time)
 - Legacy-Id: 12085
 2016-10-05 13:04:07 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page 
- Legacy-Id: 12081
 2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review 
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
 2016-10-03 15:52:32 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of 
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
 2016-09-21 16:52:50 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing 
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
 2016-09-19 16:05:32 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it 
- Legacy-Id: 11923
 2016-09-06 10:17:12 +00:00
Ole Laursen 119f7256f1 Fix a bug in emailing review request change notifications 
- Legacy-Id: 11920
 2016-09-02 20:28:51 +00:00