Commit graph

1210 commits

Author SHA1 Message Date
Henrik Levkowetz 13b20f83cb Merged in [15720] from rjsparks@nostrum.com:
invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes #2630.
 - Legacy-Id: 15760
Note: SVN reference [15720] has been migrated to Git commit f1c1b9fc6c
2018-11-12 15:38:17 +00:00
Henrik Levkowetz 3b811ecb41 Merged in [15708] and [15730] from housley@vigilsec.com:
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 19:30:32 +00:00
Henrik Levkowetz 0d9c97c5ca Added a test that checks the mailarch search failure return, and tweaks the no-result return handling.
- Legacy-Id: 15745
2018-11-10 19:06:40 +00:00
Henrik Levkowetz 236ee7639d Merged in [15706] from kivinen@iki.fi:
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126.
 - Legacy-Id: 15744
Note: SVN reference [15706] has been migrated to Git commit f9eeee0cc9
2018-11-09 21:23:45 +00:00
Henrik Levkowetz 89ef806013 Merged in [15701] from kivinen@iki.fi:
Changed format of the reviewer statistics in lists. Fixes #2131.
 - Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
2018-11-07 05:24:25 +00:00
Russ Housley d525ade0b0 Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge.
- Legacy-Id: 15730
2018-11-06 07:26:30 +00:00
Henrik Levkowetz e4af908a74 Merged in [15698] from rjsparks@nostrum.com:
Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440.
 - Legacy-Id: 15729
Note: SVN reference [15698] has been migrated to Git commit 43374969f6
2018-11-06 07:13:56 +00:00
Robert Sparks f1c1b9fc6c invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes #2630. Commit ready for merge.
- Legacy-Id: 15720
2018-11-05 22:43:02 +00:00
Tero Kivinen f9eeee0cc9 Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126. Commit ready for merge.
- Legacy-Id: 15706
2018-11-03 11:08:18 +00:00
Tero Kivinen 56acd00c6c Changed format of the reviewer statistics in lists. Fixes #2131. Commit ready for merge.
- Legacy-Id: 15701
2018-11-03 09:04:57 +00:00
Henrik Levkowetz 3b8d9ae832 Merged in [15684] from rjsparks@nostrum.com:
Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524.
 - Legacy-Id: 15700
Note: SVN reference [15684] has been migrated to Git commit 128c0a6dbb
2018-11-03 09:01:59 +00:00
Robert Sparks 43374969f6 Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440. Commit ready for merge.
- Legacy-Id: 15698
2018-11-03 08:13:10 +00:00
Robert Sparks 5db8831b81 Clearly label cancelled sessions on the week-view on the agenda page. Fixes #2619. Commit ready for merge.
- Legacy-Id: 15694
2018-11-03 06:57:59 +00:00
Henrik Levkowetz 95161df4f4 Merged in [15679] from mahoney@nostrum.com:
Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482.
 - Legacy-Id: 15685
Note: SVN reference [15679] has been migrated to Git commit 194d8c89d1
2018-11-03 04:37:41 +00:00
Robert Sparks 128c0a6dbb Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524. Commit ready for merge.
- Legacy-Id: 15684
2018-11-03 04:28:50 +00:00
Jean Mahoney 194d8c89d1 Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482. Commit ready for merge.
- Legacy-Id: 15679
2018-11-03 03:38:52 +00:00
Robert Sparks b76ea7bcd5 Let a reviewer indicate that an AD should give this review early attention. Fixes #2553. Commit ready for merge.
- Legacy-Id: 15676
2018-11-02 21:23:27 +00:00
Robert Sparks c7bf147b1d Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544. Commit ready for merge.
- Legacy-Id: 15675
2018-11-02 20:18:06 +00:00
Henrik Levkowetz 282a410f3f Merged in [15613] from rjsparks@nostrum.com:
Make having a trailing slash optional for doc/html/docname. Fixes #2247.
 - Legacy-Id: 15618
Note: SVN reference [15613] has been migrated to Git commit 7593230edde63d4d2e8ec04c455e862aa5e71f21
2018-10-30 14:02:46 +00:00
Henrik Levkowetz 90e773aafa Merged in [15601] from rjsparks@nostrum.com:
Corrected some DocTypeName entries' prefix value. Made the search code more robust against DocTypeName objects that have an empty prefix value. Fixes #2599.
 - Legacy-Id: 15604
Note: SVN reference [15601] has been migrated to Git commit 22d459362aec2a06854a515fbcebfec54e8a6e69
2018-10-21 12:36:01 +00:00
Henrik Levkowetz 3508f59f52 Merged in [15596] from rjsparks@nostrum.com:
improved coverage for several tests.
 - Legacy-Id: 15600
Note: SVN reference [15596] has been migrated to Git commit 6f18ae882532433ba86322b33c34f5f1b0350cb9
2018-10-19 14:27:13 +00:00
Henrik Levkowetz ef3cbf4684 Merged in [15595] from rjsparks@nostrum.com:
Converted stats, submit, sync. and utils/test to use factories. Excluded utils/test_data from coverage checks.
 - Legacy-Id: 15599
Note: SVN reference [15595] has been migrated to Git commit 39e76a836996ec9ed8ea449c92bdfae91c3dbaae
2018-10-19 12:54:58 +00:00
Henrik Levkowetz 15c8ab9506 Ensure the send_mail argument to save_position is a boolean.
- Legacy-Id: 15547
2018-10-09 16:34:45 +00:00
Henrik Levkowetz 22a2e29db8 Added an send_email field to BallotPostitionDocEvent to reflect whether the 'Send email' button was used to save the ballot position. Reverted a different earlier schema change which had the same purpose. Added icons on documents' IESG evaluation record to reflect this.
- Legacy-Id: 15526
2018-10-07 15:08:17 +00:00
Henrik Levkowetz 9e0e5d66b3 Merged in [15492] from rjsparks@nostrum.com:
Use factories for ipr tests.
 - Legacy-Id: 15516
Note: SVN reference [15492] has been migrated to Git commit 775addc616
2018-10-01 17:51:17 +00:00
Henrik Levkowetz cfb214c48a Added a BallotCommentDocEvent, which extends DocEvent with a send_mail field, in order to better be able to show whether ballot discusses and comments were posted with with the 'send email' button or not.
- Legacy-Id: 15515
2018-10-01 13:31:17 +00:00
Robert Sparks 775addc616 Use factories for ipr tests. Commit ready for merge.
- Legacy-Id: 15492
2018-09-28 23:16:46 +00:00
Henrik Levkowetz 89b8fe6c1b Moved document methods rfc_number() and rfcnum() to the abstract parent class to have them available also for historical document records. Should fix the recent server 500 on /doc/draft-ietf-aaa-diameter/17/.
- Legacy-Id: 15454
2018-09-14 20:29:07 +00:00
Robert Sparks d9b53a5d6c Use unversioned links in ics agendas. Partially fixes #2542. Commit ready for merge.
- Legacy-Id: 15446
2018-09-10 20:12:09 +00:00
Robert Sparks fd8af4b6f7 Review assignment email includes a link to the review request that ensures the reviewer is logged in. Fixes #2543. Commit ready for merge
- Legacy-Id: 15444
2018-09-06 21:39:10 +00:00
Henrik Levkowetz caa3ec98b4 Changed the menu listing of review dirs and their display on the Directorates page back to what it was before the 'reviews' group type was split out. Added a 'Reviews' column to the Directoratges page.
- Legacy-Id: 15420
2018-08-01 18:53:44 +00:00
Henrik Levkowetz 70c5dcc8c4 Merged in [15387] from rjsparks@nostrum.com:
Use factories for ietf.iesg.tests.
 - Legacy-Id: 15406
Note: SVN reference [15387] has been migrated to Git commit 705e4c84d9
2018-07-24 08:25:07 +00:00
Henrik Levkowetz ac55203499 Merged in [15380] from rjsparks@nostrum.com:
Use factories for ietf.idindex.tests.
 - Legacy-Id: 15405
Note: SVN reference [15380] has been migrated to Git commit 2159fdd975
2018-07-24 07:22:26 +00:00
Henrik Levkowetz 85aa1ecc25 Tweaked a test to prevent failures when looking for a specific string in line-wrapped text.
- Legacy-Id: 15397
2018-07-19 15:54:18 +00:00
Robert Sparks 705e4c84d9 Use factories for ietf.iesg.tests. Commit ready for merge.
- Legacy-Id: 15387
2018-07-19 13:13:05 +00:00
Henrik Levkowetz db2c326e73 Merged in [15354] from kivinen@iki.fi:
Added default to review completion draft version number. If the reviewer
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes #2125.
 - Legacy-Id: 15386
Note: SVN reference [15354] has been migrated to Git commit dc3e8ee810
2018-07-18 22:36:01 +00:00
Henrik Levkowetz b054a142d9 Merged in [15349] from kivinen@iki.fi:
Removed the requirement for review_content field to be mandatory when
using \'link\' method. This partially addresses #2520. Commit ready for
merge.
 - Legacy-Id: 15383
Note: SVN reference [15349] has been migrated to Git commit 0783890fa5
2018-07-18 18:20:21 +00:00
Henrik Levkowetz e8e2db50b3 Merged in [15347] from kivinen@iki.fi:
Add review request date to the top. Add tooltips for drafts versions
providing the date they were sumbmitted. Fixes #2218. Commit ready for
merge.
 - Legacy-Id: 15382
Note: SVN reference [15347] has been migrated to Git commit dcabfc84f1
2018-07-18 16:36:35 +00:00
Robert Sparks 2159fdd975 Use factories for ietf.idindex.tests. Commit ready for merge.
- Legacy-Id: 15380
2018-07-18 15:35:20 +00:00
Henrik Levkowetz 7abece146c Merged in [15344] from mahoney@nostrum.com:
email confirming interim meeting request now says 'the Area Director of the <area>' instead of '<area> Area Director'. Fixes issue #2522.
 - Legacy-Id: 15378
Note: SVN reference [15344] has been migrated to Git commit 3c478e5c52
2018-07-18 13:16:02 +00:00
Henrik Levkowetz 5b77d01a48 Merged in [15331] from housley@vigilsec.com:
Add test for downref in Last Call announcement
 - Legacy-Id: 15366
Note: SVN reference [15331] has been migrated to Git commit e2808b1c0b
2018-07-16 16:54:56 +00:00
Tero Kivinen dc3e8ee810 Added default to review completion draft version number. If the reviewer
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes #2125. Commit ready for merge.
 - Legacy-Id: 15354
2018-07-14 21:54:04 +00:00
Tero Kivinen 0783890fa5 Removed the requirement for review_content field to be mandatory when
using "link" method. This partially addresses #2520. Commit ready for
merge.
 - Legacy-Id: 15349
2018-07-14 20:12:32 +00:00
Tero Kivinen dcabfc84f1 Add review request date to the top. Add tooltips for drafts versions
providing the date they were sumbmitted. Fixes #2218. Commit ready for
merge.
 - Legacy-Id: 15347
2018-07-14 20:07:36 +00:00
Jean Mahoney 3c478e5c52 email confirming interim meeting request now says 'the Area Director of the <area>' instead of '<area> Area Director'. Fixes issue #2522. Commit ready to merge.
- Legacy-Id: 15344
2018-07-14 18:52:38 +00:00
Russ Housley e2808b1c0b Add test for downref in Last Call announcement
- Legacy-Id: 15331
2018-07-14 16:41:22 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Henrik Levkowetz 9fe1820640 Tweaked the 'Related documents' part of the Document admin page to more intuitively show the relationships.
- Legacy-Id: 15259
2018-06-14 19:22:55 +00:00
Henrik Levkowetz 41a5f5dca4 Merged in [15248] from rjsparks@nostrum.com:
Improvements to tests after converting to factories suggested by studying coverage_changes.
 - Legacy-Id: 15255
Note: SVN reference [15248] has been migrated to Git commit b86bd84278
2018-06-14 13:11:29 +00:00
Henrik Levkowetz b3301de22e Fixed a pyflakes nit.
- Legacy-Id: 15253
2018-06-14 12:35:16 +00:00