Robert Sparks
87de06c97c
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes #2776 . Commit ready for merge.
...
- Legacy-Id: 16647
2019-08-13 18:13:50 +00:00
Henrik Levkowetz
bdc73e771a
Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
...
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz
8c6eb3a30a
Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
...
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz
ea8c84d2f6
Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods.
...
- Legacy-Id: 16455
2019-07-15 18:01:26 +00:00
Henrik Levkowetz
2d7c9629aa
Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
...
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz
36cac48063
Fixed a bunch of str/bytes issues.
...
- Legacy-Id: 16341
2019-06-30 20:54:09 +00:00
Henrik Levkowetz
4b080c8042
Added a simple functional test for hash_list_message_id()
...
- Legacy-Id: 16337
2019-06-30 17:55:54 +00:00
Henrik Levkowetz
484dcece5f
Changed all model __unicode__() methods to __str__()
...
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz
3ec7e864be
Converted leading tabs to spaces in ietf/**/*.py
...
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz
d7f5c84182
Initial 2to3 patch with added copyright statement updates.
...
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz
7270d5f67a
Added the option to order API resource lists by primary key, for stable ordering when paging through a list.
...
- Legacy-Id: 16284
2019-06-18 12:40:19 +00:00
Henrik Levkowetz
426870b766
Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
...
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz
a2cafded25
Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
...
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz
815602351f
This is a series of 50 migrations that changes the Document and DocAlias
...
primary keys from character strings to integers, and makes corresponding code
changes.
This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.
Changing the primary keys to integers should also improve efficiency.
Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time. The total set of migrations are expected to have
a runtime on the order of 2 hours.
- Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz
cfbaf5b1a9
Fixed a pyflakes issue.
...
- Legacy-Id: 16193
2019-05-06 14:38:34 +00:00
Henrik Levkowetz
fae7444df8
Updated the ReviewAssignment api resource to match the current model.
...
- Legacy-Id: 16189
2019-05-06 13:36:16 +00:00
Henrik Levkowetz
9282195d6c
Fixed some migrations issues that prevented the review assignment refactoring migrations from being reversed and re-applied.
...
- Legacy-Id: 16182
2019-05-02 13:49:14 +00:00
Henrik Levkowetz
ca1f3340c0
Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability.
...
- Legacy-Id: 16181
2019-05-02 12:38:41 +00:00
Henrik Levkowetz
8726e74709
Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
...
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz
3ec9d7b678
Updated the role handling to use GroupFeatures.groupman_roles consistently for group management access. Fixes a IRTF RG delegate permissions issue.
...
- Legacy-Id: 16160
2019-04-25 13:19:30 +00:00
Henrik Levkowetz
bb4fe3fbbf
Undid previous commit
...
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz
cfcefc2e32
Merged in [16144] from housley@vigilsec.com:
...
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057 .
- Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Henrik Levkowetz
82672519df
Undid previous merge
...
- Legacy-Id: 16113
2019-03-28 11:05:25 +00:00
Henrik Levkowetz
6a159ebdfd
Merged in [16094] from magnus.westerlund@ericsson.com:
...
Added sortable columns to Review Team Reviewers page. Partially addresses issue #2656
- Legacy-Id: 16112
Note: SVN reference [16094] has been migrated to Git commit 0c0e75861e
2019-03-28 11:02:52 +00:00
Robert Sparks
6dc25cae1a
Bring time series stats back into line with what was before. Note there was an off-by-one-day bug in the month-binning in prior releases.
...
- Legacy-Id: 16075
2019-03-20 20:04:06 +00:00
Robert Sparks
81c5b5091a
Made some docevent creation more consistent. Addressed the TODOs added during the refactor.
...
- Legacy-Id: 16049
2019-03-19 18:48:05 +00:00
Robert Sparks
da3174ab68
Improved several views.
...
- Legacy-Id: 16038
2019-03-18 19:41:07 +00:00
Robert Sparks
4b147f2ef8
More cleanup and correction. Caught a pervasive misuse of a state-name
...
- Legacy-Id: 16036
2019-03-15 20:39:06 +00:00
Robert Sparks
3678d20b0b
Some cleanup around stats. Things are well except for the time series graphs.
...
- Legacy-Id: 16035
2019-03-15 16:50:59 +00:00
Robert Sparks
334767fa6f
Some admin tweaks and removal of a dead template. Tests all pass now. Functionality is still not right.
...
- Legacy-Id: 16032
2019-03-14 19:14:33 +00:00
Robert Sparks
a4db66564c
Checkpoint. Ended up chasing group.views_review before stats.
...
- Legacy-Id: 16030
2019-03-13 22:02:10 +00:00
Robert Sparks
073ce55f6c
Checkpoint. ReviewTests pass, but others still fail of course. Next step is to address stats.
...
- Legacy-Id: 16021
2019-03-12 17:48:19 +00:00
Henrik Levkowetz
682ddee8e4
Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
...
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Robert Sparks
b85052fe63
Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half.
...
- Legacy-Id: 16012
2019-03-07 23:08:14 +00:00
Henrik Levkowetz
8a669909bc
Changed ietf/utils/mail.py to use unicode strings, and changed a call in ietf/reviv/utils.py to use unicode for mail Subject, to fix a server 500 issue.
...
- Legacy-Id: 16007
2019-03-06 16:57:00 +00:00
Henrik Levkowetz
435a0da12d
Added on_behalf_of() calls for from addresses needing it throughout the code.
...
- Legacy-Id: 15992
2019-03-04 20:14:19 +00:00
Robert Sparks
82025f9dca
Continuing to checkpoint.
...
- Legacy-Id: 15986
2019-03-01 23:23:39 +00:00
Robert Sparks
e91d706d5b
Checkpointing. This is an incomplete idea. The tests will fail massively.
...
- Legacy-Id: 15985
2019-03-01 23:19:47 +00:00
Henrik Levkowetz
57a4c9f41f
Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
...
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Robert Sparks
87dd249415
Cleanup: removed the infrastructure for importing reviews from the old review tool. Commit ready for merge.
...
- Legacy-Id: 15865
2019-01-03 21:04:13 +00:00
Henrik Levkowetz
da380342bc
Merged in [15808] from rjsparks@nostrum.com:
...
Allow notify_ad_when to be blank.
- Legacy-Id: 15815
Note: SVN reference [15808] has been migrated to Git commit 6d14714f19
2018-12-13 17:22:14 +00:00
Henrik Levkowetz
f65fcdd2c4
Merged in [15804] from rjsparks@nostrum.com:
...
Add history to ReviewerSettings. Fixes #2147 .
- Legacy-Id: 15811
Note: SVN reference [15804] has been migrated to Git commit cb707248e2
2018-12-13 14:29:58 +00:00
Robert Sparks
6d14714f19
Allow notify_ad_when to be blank. Commit ready for merge.
...
- Legacy-Id: 15808
2018-12-06 21:18:26 +00:00
Robert Sparks
cb707248e2
Add history to ReviewerSettings. Fixes #2147 . Commit ready for merge.
...
- Legacy-Id: 15804
2018-12-03 22:23:01 +00:00
Henrik Levkowetz
e024cca8c4
Merged in [15708] and [15730] from housley@vigilsec.com:
...
Added a mail alias for all review team secretaries. Fixes #2139 . Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15747
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 20:32:42 +00:00
Henrik Levkowetz
3b811ecb41
Merged in [15708] and [15730] from housley@vigilsec.com:
...
Added a mail alias for all review team secretaries. Fixes #2139 . Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 19:30:32 +00:00
Henrik Levkowetz
0d9c97c5ca
Added a test that checks the mailarch search failure return, and tweaks the no-result return handling.
...
- Legacy-Id: 15745
2018-11-10 19:06:40 +00:00
Henrik Levkowetz
236ee7639d
Merged in [15706] from kivinen@iki.fi:
...
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126 .
- Legacy-Id: 15744
Note: SVN reference [15706] has been migrated to Git commit f9eeee0cc9
2018-11-09 21:23:45 +00:00
Henrik Levkowetz
89ef806013
Merged in [15701] from kivinen@iki.fi:
...
Changed format of the reviewer statistics in lists. Fixes #2131 .
- Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
2018-11-07 05:24:25 +00:00
Russ Housley
d525ade0b0
Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge.
...
- Legacy-Id: 15730
2018-11-06 07:26:30 +00:00