From 56acd00c6ce378116202a0729526b5f6bdd90612 Mon Sep 17 00:00:00 2001 From: Tero Kivinen Date: Sat, 3 Nov 2018 09:04:57 +0000 Subject: [PATCH] Changed format of the reviewer statistics in lists. Fixes #2131. Commit ready for merge. - Legacy-Id: 15701 --- ietf/doc/tests_review.py | 2 +- ietf/review/utils.py | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ietf/doc/tests_review.py b/ietf/doc/tests_review.py index 5c2e36629..d2b79bb44 100644 --- a/ietf/doc/tests_review.py +++ b/ietf/doc/tests_review.py @@ -355,7 +355,7 @@ class ReviewTests(TestCase): self.assertIn("unavailable indefinitely", reviewer_label) self.assertIn("skip next 1", reviewer_label) self.assertIn("#1", reviewer_label) - self.assertIn("no response 0/1", reviewer_label) + self.assertIn("1 completed", reviewer_label) # assign empty_outbox() diff --git a/ietf/review/utils.py b/ietf/review/utils.py index dc0d56289..2c518b947 100644 --- a/ietf/review/utils.py +++ b/ietf/review/utils.py @@ -833,7 +833,10 @@ def make_assignment_choices(email_queryset, review_req): could_have_completed = [d for d in req_data if d.state in ["part-completed", "completed", "no-response"]] if could_have_completed: no_response = sum(1 for d in could_have_completed if d.state == "no-response") - stats.append("no response {}/{}".format(no_response, len(could_have_completed))) + if no_response > 0: + stats.append("{} no response, {} completed".format(no_response, len(could_have_completed) - no_response)) + else: + stats.append("{} completed".format(len(could_have_completed))) if stats: explanations.append(", ".join(stats))