altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
16350 commits 1 branch 0 tags 2.6 GiB
Commit graph

108 commits

Author SHA1 Message Date
Ben Campbell cc96709957 Give ADs the red Clear Ballot button 
- Legacy-Id: 14848
 2018-03-17 16:35:35 +00:00
Henrik Levkowetz a04e187f0f Removed some old debug print statements. 
- Legacy-Id: 14823
 2018-03-14 22:11:06 +00:00
Henrik Levkowetz 3dd66eba65 Fixed an UnboundLocalError (only partial variable initialization) bug. 
- Legacy-Id: 14620
 2018-02-07 06:13:19 +00:00
Henrik Levkowetz e1fa3ba381 Limited the iesg ballot position API to ADs (excluding secretariat). 
- Legacy-Id: 14444
 2017-12-19 14:10:43 +00:00
Henrik Levkowetz 6567e707ce Merged in ^/personal/henrik/6.64.2-ballotapi@14426. This provides personal API keys and a ballot position API at /api/iesg/position. Also added an endpoint description at /api/. 
- Legacy-Id: 14430
 2017-12-17 23:43:44 +00:00
Henrik Levkowetz a08c8dc76f Added an API endpoint to support automation of IESG ballot position posting, at /api/iesg/position. Added tests for the API endpoint, and updated the apikey validation decorator tests. Tweaked the decorator to handle a weakness found during testing. 
- Legacy-Id: 14429
 2017-12-17 21:55:27 +00:00
Henrik Levkowetz b0863c8963 Modified some names. 
- Legacy-Id: 14428
 2017-12-16 18:43:08 +00:00
Henrik Levkowetz e7209c6e50 Added a new personal event table to keep track of personal API key logins, and a management command to send out reports about activity to users with API keys. Added a weekly cronjob script to trigger weekly reports, and a monthly script for future use. Added a @require_api_key decorator to validate API keys for API key views and log in the API key owner. Modified the API key management urls to use create and disable rather than add and delete. Updated the API key list view. Added an API placeholder view function for ballot position setting, for test purposes. Added tests for the decorator and management command. 
- Legacy-Id: 14426
 2017-12-16 18:37:52 +00:00
Henrik Levkowetz abb69338e2 Added a warning message for the user if ballot creation failed due to an already open ballot. This is a bad state, and should prevented by stricter checks before changing state, but is better than the current situation until we decide exactly which checks to implement. 
- Legacy-Id: 14382
 2017-11-30 16:10:38 +00:00
Henrik Levkowetz e7f3d7ecb1 Added the last call end date to the first line of the last call announcement event description, on request from worley@ariadne.com. 
- Legacy-Id: 13845
 2017-07-12 15:03:17 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code. 
- Legacy-Id: 12978
 2017-03-06 15:08:21 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view 
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
 2017-02-26 23:21:49 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/. 
- Legacy-Id: 12897
 2017-02-22 11:40:55 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's, 
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
 2017-02-11 14:43:01 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets. 
- Legacy-Id: 12711
 2017-01-23 17:38:56 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances. 
- Legacy-Id: 12637
 2017-01-09 21:26:30 +00:00
Henrik Levkowetz 17a7f59cd6 Deprecation fixes: Use request.GET or request.POST as appropriate, instead of request.REQUEST. 
- Legacy-Id: 12533
 2016-12-15 13:21:33 +00:00
Henrik Levkowetz 8e56935cfd Undid commit 12527, which contained much too much. 
- Legacy-Id: 12528
 2016-12-15 10:38:54 +00:00
Henrik Levkowetz e3c6e0ac6b Changed the state shown in all_id.txt for drafts which have entered IESG processing, but then been replaced, to show as 'Replaced' instead of 'In IESG Processing'. This is consistent with how they are shown in all_id2.txt. 
- Legacy-Id: 12527
 2016-12-15 10:36:15 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method. 
- Legacy-Id: 11840
 2016-08-23 10:52:08 +00:00
Russ Housley 6cf8680a16 Allow IAB, IRTF, and Independent streams to use new capability for RFC Editor Notes. Do not display of document shepherd and shepherd writeup for non-IETF stream documents. Do not display IESG information for IAB stream documents. 
- Legacy-Id: 10834
 2016-02-11 22:12:52 +00:00
Russ Housley 4b5ac9e09e Indicate on the IESG Telechat Agenda if a document has an RFC Editor Note. To accomplish this, the RFC Editor Note needed to be separated from the rest of the ballot write up. Fixes #1230. 
- Legacy-Id: 10770
 2016-02-04 13:32:24 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems 
- Legacy-Id: 10298
 2015-10-27 10:37:06 +00:00
Ole Laursen ec54a59cc6 Summary: Be more careful when generating writeups so that we wait with 
saving newly generated writeups until we see a POST (problem found by
the test crawler)
 - Legacy-Id: 10137
 2015-10-06 16:20:12 +00:00
Ole Laursen e1f0917659 Summary: Add new document saving API, Document.save_with_history(events). 
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.

To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.

While revising the existing code to work with this API, a couple of
missing events was discovered:

- In draft expiry, a "Document has expired" event was only generated
  in case an IESG process had started on the document - now it's
  always generated, as the document changes its state in any case

- Synchronization updates like title and abstract amendmends from the
  RFC Editor were silently (except for RFC publication) applied and
  not accompanied by a descriptive event - they now are

- do_replace in the Secretariat tools now adds an event

- Proceedings post_process in the Secretariat tools now adds an event

- do_withdraw in the Secretariat tools now adds an event

A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
 - Legacy-Id: 10101
 2015-09-28 14:01:03 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger 
- Legacy-Id: 10090
 2015-09-17 20:03:45 +00:00
Robert Sparks e5306eda00 Instrumented issuing ballots. Simplified the ballot-issued email significantly. Deferred adding ballot_saved mail for the automatic yes positions. 
- Legacy-Id: 10068
 2015-08-28 17:33:49 +00:00
Robert Sparks 4e61776c89 Smarter send_ballot_comment form 
- Legacy-Id: 10054
 2015-08-24 18:25:39 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow 
- Legacy-Id: 10040
 2015-08-23 18:15:06 +00:00
Robert Sparks f30f5c39f1 checkpoint 
- Legacy-Id: 10017
 2015-08-13 21:16:21 +00:00
Robert Sparks 839d0f89ad checkpoint 
- Legacy-Id: 10016
 2015-08-13 19:41:02 +00:00
Robert Sparks 79d373fa71 checkpoint. 
- Legacy-Id: 10011
 2015-08-11 21:52:28 +00:00
Robert Sparks 15538ded7e checkpoint 
- Legacy-Id: 10010
 2015-08-11 17:26:53 +00:00
Robert Sparks 7649397f5b Better app and model names. Some model hygiene. Added admin. 
- Legacy-Id: 9993
 2015-08-09 20:11:26 +00:00
Robert Sparks c0acadf222 Working checkpoint 
- Legacy-Id: 9985
 2015-08-06 21:39:49 +00:00
Robert Sparks b84d4d3a20 Add a checkbox to cc the group list address on ballot positions if a document belongs to a group. Add better tests of the checkboxes on that form. Commit ready for merge. 
- Legacy-Id: 9505
 2015-04-15 14:53:42 +00:00
Ole Laursen d0999c8b5e Merge facelift-r8510 branch with trunk. The IPR tool still has some non-facelifted parts and ideosyncracies. Fix a couple of minor bugs (including infamous empty licensing choice) in the IPR code, and port the IPR views to use the render shortcut. 
- Legacy-Id: 8896
 2015-01-22 17:38:05 +00:00
Robert Sparks 601575a3d5 Verify that add_state_change_event returned something before trying to use attributes of the return value. Fixes bug #1566. Commit ready for merge. 
- Legacy-Id: 8801
 2014-12-18 20:23:57 +00:00
Ole Laursen b5a0ab81a6 Fix some Http404() to Http404 which seems to be the preferred style in Python 
- Legacy-Id: 8528
 2014-10-31 17:18:01 +00:00
Henrik Levkowetz 55cef621bd Merged in [8305] from rjsparks@nostrum.com:\n Replaces the return_to_url notion with logic that uses the session object. Related to bug #1430. 
- Legacy-Id: 8483
Note: SVN reference [8305] has been migrated to Git commit feb57a04f0
 2014-10-26 19:35:10 +00:00
Henrik Levkowetz fc3773bcb4 Merged in [8256] from rjsparks@nostrum.com:\n Allow defer for status change documents. Fixes bug #1397. 
- Legacy-Id: 8367
Note: SVN reference [8256] has been migrated to Git commit 1a29f28361b11bc32432be8b31e78d933a4d04d8
 2014-09-28 19:13:31 +00:00
Henrik Levkowetz cea60ad8df Merged in [8255] from rjsparks@nostrum.com:\n Combined defer/undefer tests from doc/tests_ballot and iesg/tests, extending them to demonstrate current reported bugs. 
Made doc.active_defer_event() look for the events that are currently being created. This remains brittle.
Added email notifying the IESG of an undefer analagous to the defer email.
Guarded against deferring an already deferred document or undeferring a document that hasn't been deferred.
Guarded against deferring a document that's not scheduled for a telechat.
Fixes bugs 1417, 1465, 1417
 - Legacy-Id: 8366
Note: SVN reference [8255] has been migrated to Git commit 0b49f402b4ec9145cb290b8a968755cc9ebdef92
 2014-09-28 18:59:10 +00:00
Robert Sparks feb57a04f0 Replaces the return_to_url notion with logic that uses the session object. Related to bug #1430. 
- Legacy-Id: 8305
 2014-09-11 20:41:59 +00:00
Robert Sparks cb458b1689 Protect against cases where add_state_change_event can return None. Fixes bug # 1383. Commit ready for merge. 
- Legacy-Id: 7677
 2014-04-30 22:17:01 +00:00
Henrik Levkowetz c19268f6a1 A second pass of pyflakes cleanup, removing additional bulk imports, fixing a bug in get_initial_notify(), and removing some dead (and buggy) code. 
- Legacy-Id: 7509
 2014-03-16 22:15:46 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean. 
- Legacy-Id: 7462
 2014-03-15 16:09:47 +00:00
Ole Laursen 87ca10d122 Remove usage of log_state_changed (and duplicate in 
doc/utils_charter.py) in favour of add_state_change_event which has
slightly better API but otherwise does basically the same except it
sets an event type we can later search for. Also expand tests slightly
to exercise three more templates.
 - Legacy-Id: 7129
 2014-01-15 17:52:00 +00:00
Ole Laursen 7f277a8fbb Replace user.get_profile() with user.person, the profile stuff is deprecated since Django 1.5 
- Legacy-Id: 6968
 2013-12-18 10:13:40 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead 
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
 2013-12-17 10:23:42 +00:00
Ole Laursen 6a98fec2c3 Use built-in json module in Python instead of simplejson bundled with Django 
- Legacy-Id: 6883
 2013-12-11 16:59:19 +00:00
Ole Laursen e63ac36b8f Remove shim layer from ietfauth, delete some dead code and migrate 
remaining importers of ietfauth.decorators to ietfauth.utils
 - Legacy-Id: 6797
 2013-12-05 16:24:03 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch 
- Legacy-Id: 6764
 2013-11-27 12:55:50 +00:00
Henrik Levkowetz 697dcc450a If an exception is raised earlier in field validation, the 
position field may not be set when we get to this point and
try to retrieve the value of a different field than the one
we're processing. Don't cause a new exception in that case.
 - Legacy-Id: 6416
 2013-10-11 12:31:50 +00:00
Ole Laursen b552ff31aa Replace the announcement pages with a new page collecting all IESG 
review decisions. Add migration to split up iesg_approve/disapprove
events of the form "IESG has approved ... and state has been changed
..." into the approve/disapprove event and a synthesized state change
event. Also regularize the descriptions a bit. This simplifies the
code in the new page.
 - Legacy-Id: 6340
 2013-10-02 15:37:44 +00:00
Henrik Levkowetz 71f85f96c7 Merged in a fix from rjsparks@nostrum.com for incorrect IANA notification email addresses. 
- Legacy-Id: 6152
 2013-09-13 22:23:55 +00:00
Ole Laursen 6ac0920af0 Move idrfc/ templates to doc/ and subdirectories in doc/, move ported ballot_icon template tag, delete dead code 
- Legacy-Id: 6052
 2013-08-14 14:10:46 +00:00
Ole Laursen 742dbace24 Move views and templatetags from idrfc/ to doc, the I-D specific views 
go into views_draft.py and tests in tests_draft.py; what's left in
idrfc is wrapper code, templates and the ballot_icon templatetag
 - Legacy-Id: 6051
 2013-08-14 10:32:25 +00:00
Renamed from ietf/idrfc/views_ballot.py (Browse further)