altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 4 Packages Projects Releases Wiki Activity
16350 commits 1 branch 0 tags 2.6 GiB
Commit graph

108 commits

Author SHA1 Message Date
Matthew Holloway ff8898186b
fix: Ballot return to url via url params rather than session (#7788) 
* fix: #7287 ballot return params

* fix: Moving Ballot edit position ballot_edit_return_point from session to query param

* fix: tests for return_to_path param

* chore: removing Playwright tests until we can figure out a plan

* feat: return_to path utility refactoring

* fix: throw HTTP 400 in view rather than bubbling up a 500

* fix: return http400 rather than raising
 2024-08-09 09:24:04 -05:00
Robert Sparks 17e0f573b3
fix: check correct state machine when clearing status change ballots (#7684) 
* fix: check correct state machine when clearing status change ballots

Fixes #7335

* fix: Improve ballot clearing tests

* fix: look at the right state machines for defer state for a ballot

* fix: also do the right thing with conflrev defers
 2024-07-15 16:33:00 -05:00
Robert Sparks ac3813f1af
fix: improve warnings on ballot issue view. Fixes #7490. (#7491) 2024-06-04 12:38:54 -05:00
Jennifer Richards 08e953995a
feat: better reject null characters in forms (#7472) 
* feat: subclass ModelMultipleChoiceField to reject nuls

* refactor: Use custom ModelMultipleChoiceField

* fix: handle value=None
 2024-05-28 10:34:55 -05:00
Robert Sparks 4946430159
chore: checkpoint: halfway through removing docalias 2023-08-15 09:11:53 -05:00
Jennifer Richards 48d4072eeb
Merge branch 'feat/rfc' into main-merge 
# Conflicts:
#	ietf/doc/factories.py
#	ietf/doc/tests_status_change.py
#	ietf/name/fixtures/names.json
#	ietf/templates/doc/document_info.html
 2023-08-03 18:34:06 -03:00
PriyankaN 00c0389c1f
fix:no history entry when changing RFC Editor note for doc (#6021) 
* fix:no history entry when changing RFC Editor note for doc

* fix:no history entry when changing RFC Editor note for doc

---------

Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>
 2023-07-22 17:33:11 -07:00
Robert Sparks 81734443a5
fix: continued repair of code/tests re: RelatedDocument model change 2023-07-20 09:25:14 -05:00
Robert Sparks cf3a270cd2
Merge branch 'feat/rfc' into related_no_alias 2023-07-19 17:48:22 -05:00
Jennifer Richards 8f0b459050
refactor: Replace is_rfc() tests (#5925) 
* refactor: Remove is_rfc() - test type_id instead

* fix: Guard against unknown pub_date

This should not ever come up - we have a published_rfc event for
every rfc. Should investigate fixing pub_date() to always return a val.
 2023-07-06 12:07:53 -03:00
Robert Sparks ad0071fd7d
chore: merge feat/rfc 2023-06-26 13:12:15 -05:00
Jennifer Richards f2c2957925
refactor: Represent RFCs as their own DocType (#5835) 
* feat: Add RFC DocTypeName, StateType, and States

* refactor: Rename rfc_number() to deprecated_rfc_number()

* feat: Add rfc_number field to DocInfo

* feat: Add DocRelationshipName "became-rfc"

* chore: First-pass migration to create rfc Documents

* chore: create_rfc_documents migration depends on new names

* refactor: Rename variable

* fix: Fix revname / downcase name for "became-rfc" DocRelationshipName

* chore: Remove debugging print statements

* feat: Point rfc aliases at rfc Documents

* test: Refactor RFC factories

* refactor: Rewrite is_rfc() in terms of type_id

* test: Use RfcFactory as base for IndividualRfcFactory

* refactor: Replace calls to deprecated_rfc_number()

* refactor: Remove deprecated_rfc_number() method

* test: Import WgRfcFactory
 2023-06-20 15:28:16 -03:00
Robert Sparks 769d85a6c4
chore: explore architecture change in RelatedDocument 2023-06-16 14:58:42 -05:00
Lars Eggert f8b48f4c43
fix: use Internet-Draft more consistently across the UI (#5104) 
* s/Internet Draft/Internet-Draft/i

* s/draft/Internet-Draft/i or s/draft/I-D/i

* s/ID/I-D/

* Fix tests

* a -> an

* Undo case-change to ASCII

* Address code review comments

* Add migrations

* Add merged migration

* fix: straighten out migrations

* fix: finish straightening out migrations

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-02-11 10:09:28 -06:00
Robert Sparks afac1f8f19
feat: enable editorial stream adoption and balloting (#5011) 
* feat: enable editorial stream adoption and balloting

* fix: bring tests into line with refactor

* feat: force intended_std_level to Informational when adopting into a non-ietf stream.

* fix: improve blocking position labels and email content

* fix: simplify pointer to group on doc main page for rswg docs

* fix: recover from merge typos

* fix: correct defer and clear ballot behavior

* fix: improve publication request access logic

* fix: clean up broken editorial state

* fix: adjust test to match migrations
 2023-01-31 13:50:51 -06:00
Jennifer Richards 56505147e0
fix: handle timezones in a bunch of places 2022-09-23 16:11:49 -03:00
Jennifer Richards 32054111df
fix: fix failing tests and eliminate naive datetime warnings (#4402) 
* test: fix timestamp construction in several doc tests

* refactor: rename date2datetime to datetime_from_date and clarify code

* chore: helper to get tzinfo for PRODUCTION_TIMEZONE

* fix: fix timezone handling in make_last_call()

* test: fix datetime generation in doc.tests_charter

* refactor: remove PRODUCTION_TIMEZONE setting

Replaces the PRODUCTION_TIMEZONE setting with a constant,
DEADLINE_TZINFO, in ietf.utils.timezone.

* test: be more careful about timezone in tests_charter.py

* test: be more careful about timezone in doc/tests.py

* fix: fix timezone handling affecting doc.tests_draft

* fix: fix timezone handling affecting tests_irsg_ballot.py

* fix: fix timezone handling affecting tests_review.py

* fix: fix timezone handling affecting last ietf.doc tests

* fix: fix timezone handling affecting last ietf.group tests

* fix: fix timezone handling affecting ietf.iesg tests

* fix: handle timezones in get_8989_eligibility_querysets

* fix: handle timezones affecting ietfauth tests

* fix: return tz-aware datetime from utc_from_string

* fix: specify timezone for constants in ipr_rfc_number()

* fix: specify tz for ipr deadlines

* fix: handle timezones affecting liaisons tests

* fix: treat leap day in get_8989_eligibility_querysets()

Manual cherry-pick of 248d6474

* test: treat leap day properly in nomcom tests

* fix: fix timezone handling affecting nomcom tests

* test: fix timezone handling in review tests

* fix: fix timezone handling affecting secr.meetings tests

* fix: handle both pytz and zoneinfo timezones in ietf.utils.timezone

* fix: fix timezone handling affecting secr.proceedings tests

* refactor: use make_aware() helper in secr.meetings tests

* test: fix timezone handling in secr.telechat tests

* fix: fix timezone handling affecting stats tests

* fix: eliminate tz-naive helpers affecting sync email parsing

* fix: include timezone data when serializing DeletedEvent data

* fix: fix timezone handling affecting sync tests

* style: remove unused import
 2022-09-01 13:07:28 -03:00
Robert Sparks 9c236ea2a2
chore: remove unneeded logging and code marked unreachable that has not been reached. (#4305) 
* chore: remove unneeded logging and code marked unreachable that has not been reached.

* fix: remove noop save override
 2022-08-04 11:25:31 -05:00
Robert Sparks de4f1feed2
fix: send status change eval and lc to IANA. Fixes #3504. (#4244) 2022-07-23 12:36:00 -05:00
Lars Eggert 3234f1a121
test: Validate HTML rendered during tests (#3782) 2022-04-07 13:30:38 -03:00
Lars Eggert 64d2ba2558 Run tidy as part of tests, and fix HTML issues it finds. 
- Legacy-Id: 19904
 2022-02-01 16:11:34 +00:00
Jennifer Richards e11583a87f Allow assignment of Person as "action holder" for a Doc, plus rudimentary automation of assignment. Fixes #3146. Commit ready for merge. 
- Legacy-Id: 18829
 2021-02-12 20:31:00 +00:00
Robert Sparks e94f5c15ff Allow ballot text to be edited after the ballot is approved. Fixes #3157. Related to #3119. Commit ready to merge. 
- Legacy-Id: 18791
 2021-01-11 22:59:11 +00:00
Russ Housley 89ec802a5b Automatically move the IESG document state when a ballot is issued, prevent a writeup change or re-issue of ballot if the document is already approved, and warn about issuing ballots before the IETF Last Call is finished. Fixes #3119. 
- Legacy-Id: 18719
 2020-11-23 22:59:41 +00:00
Henrik Levkowetz 9125104065 Merged in [18324] from rjsparks@nostrum.com: 
Send extra mail to yangdoctors chairs when a draft with yang checks goes into IETF LC. Fixes #2419.
 - Legacy-Id: 18363
Note: SVN reference [18324] has been migrated to Git commit cb58810705
 2020-08-13 11:23:22 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403. 
- Legacy-Id: 18339
 2020-08-06 10:59:52 +00:00
Robert Sparks cb58810705 Send extra mail to yangdoctors chairs when a draft with yang checks goes into IETF LC. Fixes #2419. Commit ready to merge. 
- Legacy-Id: 18324
 2020-07-30 21:44:02 +00:00
Jennifer Richards 6e97a89786 Notify IRSG when an IRSG ballot is created. Fixes #2978. Commit ready for merge. 
- Legacy-Id: 18162
 2020-07-13 16:45:45 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports. 
- Legacy-Id: 17391
 2020-03-05 23:53:42 +00:00
Henrik Levkowetz 32e9692f54 Fixed a py2/py3 issue in sync.rfceditor.post_approved_draft(), and enhanced tests to execute the failing code (with Mock functions) instead of skipping the code. 
- Legacy-Id: 17265
 2020-01-28 22:37:50 +00:00
Henrik Levkowetz 6482254a03 Merged in ^/branch/akayla/irsg/6.113.1.dev0 from peter@akayla.com. 
This provides support for IRSG ballots, similar to the IESG ballots support which has been in use for quite some time.  The IRSG ballots differ from IESG ballots in a number of ways, described in detail in the RFP and SoW for this work and implemented here.
 - Legacy-Id: 17164
 2019-12-20 15:00:55 +00:00
Peter E. Yee 8313b0adbf Fixes for questions for you. Does not include any changes in docker/ 
- Legacy-Id: 17150
 2019-12-13 23:01:06 +00:00
Peter E. Yee bb7e504d14 12/13 merged into 6.113.1.dev0 with migration ordering failure 
- Legacy-Id: 17149
 2019-12-13 19:53:45 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3 
- Legacy-Id: 16446
 2019-07-15 15:40:51 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates. 
- Legacy-Id: 16309
 2019-06-27 14:40:54 +00:00
Henrik Levkowetz 33e0f8c35d Merged in [16126] from housley@vigilsec.com: 
Allow Secretariat to handle downrefs when they approve a document
 - Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
 2019-04-08 17:02:02 +00:00
Russ Housley 8c7e75101d Allow Secretariat to handle downrefs when they approve a document 
- Legacy-Id: 16126
 2019-04-01 19:46:14 +00:00
Robert Sparks fbfd204eb9 Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672. Commit ready for merge. 
- Legacy-Id: 16110
 2019-03-28 10:07:11 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly. 
- Legacy-Id: 16020
 2019-03-11 17:01:33 +00:00
Henrik Levkowetz 435a0da12d Added on_behalf_of() calls for from addresses needing it throughout the code. 
- Legacy-Id: 15992
 2019-03-04 20:14:19 +00:00
Robert Sparks 43374969f6 Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440. Commit ready for merge. 
- Legacy-Id: 15698
 2018-11-03 08:13:10 +00:00
Henrik Levkowetz 15c8ab9506 Ensure the send_mail argument to save_position is a boolean. 
- Legacy-Id: 15547
 2018-10-09 16:34:45 +00:00
Henrik Levkowetz 22a2e29db8 Added an send_email field to BallotPostitionDocEvent to reflect whether the 'Send email' button was used to save the ballot position. Reverted a different earlier schema change which had the same purpose. Added icons on documents' IESG evaluation record to reflect this. 
- Legacy-Id: 15526
 2018-10-07 15:08:17 +00:00
Henrik Levkowetz cfb214c48a Added a BallotCommentDocEvent, which extends DocEvent with a send_mail field, in order to better be able to show whether ballot discusses and comments were posted with with the 'send email' button or not. 
- Legacy-Id: 15515
 2018-10-01 13:31:17 +00:00
Henrik Levkowetz a3c12d937f Removed two instances of log.assertion(); we have enough data on these now. 
- Legacy-Id: 15252
 2018-06-14 12:03:02 +00:00
Robert Sparks ee346edaba Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in. Commit ready for merge. 
- Legacy-Id: 15084
 2018-04-25 19:52:44 +00:00
Robert Sparks 7df28d8bac Marked a couple of functions as unreachable. Commit ready for merge. 
- Legacy-Id: 15080
 2018-04-25 15:10:55 +00:00
Henrik Levkowetz 2ed9face25 Modified the IESG position setting API to send email messages about positions set. 
- Legacy-Id: 15049
 2018-04-17 11:38:40 +00:00
Henrik Levkowetz a9fbea113b Changed incorrect use of 404 status code in api to 400. Fixes issue #2498. 
- Legacy-Id: 15044
 2018-04-13 11:11:48 +00:00
Henrik Levkowetz bd205ae29b Merged in [14849] from ben@nostrum.com: 
Give ADs the red Clear Ballot button
 - Legacy-Id: 14904
Note: SVN reference [14849] has been migrated to Git commit 7bf02077fd
 2018-03-24 13:31:48 +00:00