altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
16118 commits 1 branch 0 tags 2.6 GiB
Commit graph

12516 commits

Author SHA1 Message Date
Paul Selkirk 2bec81da95
fix: Don't include csrf_token in GET-only form (#6549) 2023-11-07 09:50:23 +01:00
Ryan Cross 6986e65665
fix: prevent creation of duplicate MeetingRegistration records (#6593) 
* fix: prevent creation of duplicate MeetingRegistration records

* fix: use get_or_create to prevent duplicate MeetingRegistrations

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-11-06 18:22:42 +01:00
Peter Yee f1425e4a52
fix: move meeting management from base Docs to Meeting (#6586) 
* fix: move meeting management from base Docs to Meeting

* fix: add permission check for ability to request an interim meeting

* fix: guard against no user being logged in

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-11-06 17:45:07 +01:00
Tero Kivinen f8a06f663e
fix: Add history entry when approving the slides. (#6588) 
* Added history entry when approving the slides.

Also changed os.rename to shutils.move as the submissions and
proceedings are on the separate filesystems on the docker image,
and this same thing might happen in the real environment in the
future.

* Add migrations for the docevents type.
 2023-11-06 17:19:32 +01:00
Robert Sparks 37c796ebef
fix: repair ad-dashboard test 2023-11-06 09:39:10 +01:00
Robert Sparks b78eb448a5
chore: remove some unused code 2023-11-06 09:12:40 +01:00
Robert Sparks 195926ada7
fix:bring rfc-index sync test into sync with function changes 2023-11-05 14:47:43 +01:00
Robert Sparks bdeab001e6
chore: sync subseries index test with view changes 2023-11-05 13:56:50 +01:00
Robert Sparks 801b79fbb1
fix: repair is_downref 2023-11-05 13:49:56 +01:00
Robert Sparks 3fea443f59
fix: use valid ids on subseries index page 2023-11-05 12:35:34 +01:00
Paul Selkirk b5ee9ec9ab
fix: Don't allow group chair to change group parent (#6496) 
* fix: Don't allow group chair to change group parent (#6037)

* test: Fix test_edit_parent_field, add test_edit_parent (whole form)

* test: Verify that the chair can't circumvent the system to change the group parent

* fix: 403 if user tries to edit an unknown or hidden field

* fix: Give edwg GroupFeatures a parent type

This tracks a change that was made directly in the production database
to fix the immediate cause of #6037.

* Empty commit to trigger github unit test
 2023-11-05 12:32:03 +01:00
Paul Selkirk a3b4162841
fix: Don't redirect user to the login page when logging in (#6570) 
* fix: Don't redirect user to the login page when logging in (#5876)

(Embrace and extend c4bf508cd8.)

* test: Add test case for login button

* refactor: The template filter just strips off a path prefix, so rename/recode accordingly

Also test with a non-trivial redirect target.
 2023-11-05 11:09:07 +01:00
Lars Eggert 1df7319e26
fix: Remove time from materials cell (#6584) 
Fixes #6542
 2023-11-05 11:04:25 +01:00
Lars Eggert 275b3b2b0a
fix: Make authors take at least two lines in HTMLized (#6606) 
From 32f8003712

Fixes #6575
 2023-11-05 10:40:34 +01:00
Tero Kivinen 2f5bbebf70
Add link to review request page to review result page. (#6596) 
Remove link to self on review result page.
 2023-11-05 09:57:04 +01:00
Tero Kivinen 53d0014826
feat: add "add comment" feature to the review requests. (#6603) 2023-11-05 09:29:25 +01:00
Robert Sparks 9a2b0cf947
fix: better empty text and prettystdname on subseries index view 2023-11-01 16:21:05 -05:00
Robert Sparks 3836f76052
feat: add subseries to main menu 2023-11-01 16:20:18 -05:00
Robert Sparks 575560a885
fix: don't parameterize search for subseries types. 2023-11-01 16:08:39 -05:00
Robert Sparks 71a760f05a
feat: show references to and from subseries 2023-11-01 15:57:34 -05:00
Robert Sparks 1f82fab2cd
fix: silenced (and explained) several warnings 2023-11-01 15:20:29 -05:00
Robert Sparks 942c4d42af
fix: better message on first import of subseries membership 2023-11-01 13:29:12 -05:00
Robert Sparks 986e002c1d
chore: repair merge damage 2023-11-01 12:41:15 -05:00
Robert Sparks 8e3e59079a
chore: reorder migrations 2023-11-01 11:45:23 -05:00
Robert Sparks 28c3e1bd5d
chore: merge branch 'main' into feat/rfc 2023-11-01 10:54:29 -05:00
Robert Sparks e65c4c3f7f
fix: use clearer descriptions on docevents for initial sync run 2023-10-31 16:36:47 -05:00
Robert Sparks 320ca6232b
chore: remove spurious whitespace change 2023-10-31 15:54:15 -05:00
Robert Sparks 0afe496aa3
fix: preserve RelatedDocument references to subseries 2023-10-31 15:52:11 -05:00
Robert Sparks 466921728f
chore: reorder migrations 2023-10-31 11:56:44 -05:00
Lars Eggert d246879069
Fix code review comments 2023-10-27 17:29:09 -07:00
Robert Sparks 1130f1f790
Merge branch 'main' into feat-md-bs 2023-10-25 20:46:00 -05:00
Lars Eggert 6d87279895
fix: BCPs can normatively cite all other standards levels (#6530) 
* fix: BCPs can normatively cite all other standards levels

Fixes #6524

* Revise the logic and add tests

* Fix bug in truth table
 2023-10-25 20:43:05 -05:00
Lars Eggert 5f8bf4b6f7
Merge branch 'main' into feat-md-bs 2023-10-25 20:23:33 +02:00
Ryan Cross 601ab53db9
refactor: remove secr IPR admin link (#6540) 2023-10-25 12:45:22 -05:00
Jennifer Richards be4a6ef6f5
chore: Revert agenda editor font change (#6538) 
* Revert "fix: Change some colors to make agenda tool work in dark mode (#6428)"

This reverts commit 699a8e2d9e.

* Revert "Revert "fix: Change some colors to make agenda tool work in dark mode (#6428)""

This reverts commit 5adafac4cb7896e9dd309a3385ec9aab5035e7d3.

* chore: Revert only font-family change

* chore: Add comment to ietf.scss
 2023-10-25 12:43:17 -05:00
Lars Eggert c2a44dbad0
fix: Use d-none class instead of hide (#6535) 
Fixes #6531
 2023-10-25 08:37:14 -05:00
Lars Eggert 888a4f2efe
fix: Add link to session to material metadata (#6536) 
* fix: Add link to session to material metadata

Fixes #6533

* Fix CI
 2023-10-25 08:28:50 -05:00
Lars Eggert e7639e94ed
Merge branch 'main' into feat-md-bs 2023-10-24 19:49:17 +02:00
Lars Eggert fd03ab13d7
Small fixes 2023-10-23 17:44:12 -07:00
Martin Thomson 902d657c9f
Icons for sidebar collapse/expand (#6465) 
This change uses [bi-arrow-bar-left](https://icons.getbootstrap.com/icons/arrow-bar-left/) and [bi-arrow-bar-right](https://icons.getbootstrap.com/icons/arrow-bar-right/).  This is a minimal change, but changes from .

I started off with just changing the open one to use [bi-layout-sidebar](https://icons.getbootstrap.com/icons/layout-sidebar/), which is the mirror of the collapsed icon.  I also considered changing the icon that shows when collapsed to [bi-layout-sidebar-text-reverse](https://icons.getbootstrap.com/icons/layout-text-sidebar-reverse/).  Both of those seemed less clear than these.

Note that the "shown"/"collapsed" classes on these elements appear to be reversed.  I didn't touch that.
 2023-10-23 18:40:24 -05:00
Lars Eggert 0a4fc286cd
fix: More darkmode fixes (#6477) 
* fix: More dark mode fixes

This first commit increases contrast of the leftmenu text.

* Fix own ballot position highlight in dark mode

* Fix dark mode axis color in timeline diagrams

* Enable highcharts dark mode

* Fix template

* Properly import our customized bs5 everywhere

* Fix #6499

* Use bs5 color for border-left

* Remove superfluous load
 2023-10-23 18:38:35 -05:00
Lars Eggert 699a8e2d9e
fix: Change some colors to make agenda tool work in dark mode (#6428) 
This is not a proper fix. This tool doesn't bootstrap much and is
hence full of custom CSS. Really needs a redo.
 2023-10-23 18:34:59 -05:00
Lars Eggert caa4e837ad
fix: Remove menu item for outdated tutorials list (#6521) 
Fixes #6473

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-10-23 18:32:08 -05:00
Ryan Cross c9e14cb45a
refactor: remove unused physical bluesheet functions (#6525) 
* refactor: remove unused secr/console app

* refactor: remove unused secr/areas app

* refactor: remove unused physical bluesheets functions

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-10-23 18:31:47 -05:00
Lars Eggert 3bfe90e755
fix: Add "numeric" option to localecompare (#6520) 
Fixes #6493
 2023-10-23 15:08:56 -05:00
Lars Eggert f5507daef1
feat: Render markdown agendas with bs5 styles 
So that the look is consistent with the rest of the datatracker.
 2023-10-23 18:55:31 +03:00
Jennifer Richards dc14308700
refactor: Drop submission validation via libmagic (#6500) 
* refactor: Update parsers/base.py for Python3

* style: Black

* refactor: Remove mime type check from FileParser

* refactor: Validate that submission is UTF-8

The mime check distinguished us-ascii from UTF-8,
but as far as I can tell the code relying on it
treated both as equally valid.

* feat: Clear error when file is not valid XML

* chore: Remove unused import

* test: Update tests to match changes

* fix: Count bytes starting from 1

* test: Add tests of FileParser validations

* fix: Fix / simplify regexp

* test: Test error caused by bad XML submission

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-10-23 10:00:04 -05:00
Paul Selkirk a6a39a04dc
feat: Show/edit shepherd for IAB-stream documents (#6498) 
* feat: Show/edit shepherd for IAB-stream documents (#4810)

* style: Shepherd for IAB documents is called 'IAB shepherd'
 2023-10-23 09:57:23 -05:00
Ryan Cross 4575864bfe
refactor: remove unused secr/areas app (#6509) 
* refactor: remove unused secr/areas app
 2023-10-23 09:55:54 -05:00
Ryan Cross 16c876b24d
refactor: remove unused secr/console app (#6508) 2023-10-23 09:53:57 -05:00
Martin Thomson 6e3c663484
fix: hide sidebar and dark/light toggles from print (#6502) 
Fixes #6501.
 2023-10-20 08:08:55 -05:00
Robert Sparks 431856eb5f
Merge pull request #6478 from pselkirk/fix-6474 
feat: Update ISE state when entering/exiting IETF conflict review
 2023-10-16 12:51:03 -05:00
Robert Sparks c84199630b
Merge pull request #6470 from pselkirk/feat-5440 
feat: Send mail when slides are approved
 2023-10-16 12:46:13 -05:00
Paul Selkirk f6a2d8c534 refactor: More efficient mail construction/sending 2023-10-13 19:22:06 -04:00
Paul Selkirk bdf71caaf1 feat: Update ISE state when entering/exiting IETF conflict review (#6474) 
This extends PR #6424 to cover ISE as well as IRTF documents.
 2023-10-13 17:50:05 -04:00
Robert Sparks 6e502fa20e
fix: de-docalias merge from main (#6471) 2023-10-13 14:53:43 -03:00
Robert Sparks c036bc6822
Merge pull request #6476 from larseggert/fix-better-nomcom-fb-buttons 
fix: Use smaller buttons for NomCom feedback and color the count bubble
 2023-10-13 09:03:32 -05:00
Lars Eggert ba66d25372
fix: Use smaller buttons for NomCom feedback and color the count bubble 2023-10-13 16:14:59 +03:00
Lars Eggert e9a8c341e8
fix: Nicer formatting for group milestone tables 2023-10-13 14:07:20 +03:00
Paul Selkirk 6f634a049a fix: Don't forget to empty_outbox 2023-10-12 16:28:26 -04:00
Robert Sparks ab931f0510
chore: merge main into feat/rfc 2023-10-12 15:11:02 -05:00
Paul Selkirk b04ffe1631 feat: Send mail when slides are approved (#5440) 2023-10-12 13:13:14 -04:00
Lars Eggert fa00abf9de
fix: Add remote instructions and date/time to interim agenda page (#6442) 
* fix: Add remote instructions to interim agenda page

Fixes #6433
Fixes #6249

* Also add date and time

* Fix HTML

* Fix CI fail

* Address code review comments

* More suggestions from @rjsparks

* Fix HTML

* Add suffix
 2023-10-12 06:29:03 -05:00
Lars Eggert 0f6b403904
fix: Fix "Is Accepting Feedback: yes" action for NomCom (#6467) 
Fixes #6466

While I'm here, apply list styling more consistently across NomCom pages.
 2023-10-12 06:15:14 -05:00
Paul Selkirk 16f9e0e974
fix: Adjust IRTF charter approval email headers (#5917) (#6460) 2023-10-11 11:09:10 -05:00
Lars Eggert a02812bf7c
fix: Use String.prototype.localeCompare() when sorting table rows (#6441) 
Fixes #6437
 2023-10-10 10:10:30 -05:00
Paul Selkirk 72fef7bc69
fix: Don't allow ADs to set docs to -sent states (#6445) 2023-10-10 10:09:04 -05:00
Paul Selkirk f19d1047c4
feat: Update IRTF state when entering/exiting IETF conflict review (#6424) 
* feat: Update IRTF state when entering/exiting IETF conflict review (#3469)

* fix: Update IRTF state in approve_conflict_review() as well

* chore: Add "new_state != prev_state" guard
 2023-10-09 15:01:35 -05:00
David Schinazi 5e0d1bef0f
fix: Remove incorrect line from submission API info web page (#6432) 
* Submit can replace

* Empty commit for CI

* revert change to api_submit_info
 2023-10-09 12:15:47 -05:00
Lars Eggert 7dbfc0208a
feat: Remove document notes from the datatracker (#6387) 
* Remove doc.note

* Address comments from @rjsparks

* Consistently display doc notes
 2023-10-09 12:15:18 -05:00
Lars Eggert 0f16012c73
fix: Add html-validate suppression that should have been part of #6356 (#6440) 2023-10-09 11:30:45 -05:00
Robert Sparks a97f306555
fix: improve handling malformed new specific ipr submissions (#6420) 2023-10-04 16:41:24 -05:00
Robert Sparks 4b1274c44d
fix: teach search about rfcs and subseries (#6431) 
* fix: teach search about rfcs and subseries

* fix: more general manipulation of searches for rfc and subseries

* fix: only tweak subseries search if the thing after the subseries id is digits
 2023-10-04 17:12:01 -03:00
Robert Sparks 9a09bf1f7b
fix: make statement published time match statement doc time (#6419) 
* fix: make statement published time match statement doc time

* test: improve testing of creating statements
 2023-10-02 09:51:33 -05:00
Lars Eggert 250e045ec3
Simpler fix 2023-10-02 11:43:11 +03:00
Lars Eggert 510570521d
fix: Limit group names to 80 characters 
Fixes #6416
 2023-10-02 10:40:43 +03:00
Robert Sparks d6f5564a82
ci: merge release to main 2023-09-29 14:02:18 -05:00
Robert Sparks c5a955d798
fix: restore interim announce ability (#6410) 2023-09-29 11:33:14 -05:00
Robert Sparks 486a4f5370
Merge pull request #6345 from larseggert/fix-6343 
fix: Add link to public pages to private NomCom pages
 2023-09-29 10:13:58 -05:00
Robert Sparks e48eb84f44
Merge pull request #6397 from larseggert/feat-rerun-tests 
feat: Add the ability to rerun a test suite until a failure occurs
 2023-09-29 10:12:58 -05:00
Robert Sparks 18c6c12f24
Merge pull request #6406 from pselkirk/fix-5943 
fix: The NomCom chair is not eligible for NomCom
 2023-09-29 10:12:35 -05:00
Robert Sparks 40dc24e44b
chore: tweak comments 2023-09-29 07:52:32 -05:00
Paul Selkirk cbd49a737f fix: Disqualify the nomcom chair from volunteering for the nomcom 2023-09-28 14:55:06 -04:00
Paul Selkirk 658f7edeef test: Add test for RFC8713 section 4.15 disqualified roles 2023-09-28 14:53:38 -04:00
Lars Eggert 8abbaae0c0
Update ietf/utils/test_runner.py 2023-09-28 11:34:03 +03:00
Lars Eggert abe93a42b2
feat: Add the ability to rerun a test suite until a failure occurs 
More quickly than looping in the shell around a non-zero error code.
This only incurs all the setup and scaffolding overheads once.
 2023-09-28 11:31:16 +03:00
Lars Eggert 7398ea0523
Merge branch 'main' into fix-6393 2023-09-28 11:29:59 +03:00
Lars Eggert 37e98d3b5c
Fix the actual issue 2023-09-28 11:28:41 +03:00
Paul Selkirk c718fedb6c
feat: Allow review rejections to be undone (#6312) 
* feat: Allow reviewer to accept a review they're previously rejected

* feat: Add a reviewer who has previously rejected a review to the list of suggested reviewers.

This largely un-does d105f8b, at the request of at least one team secretary.

* fix: Went a little overboard on the previous commit

one_assignment still has to exclude reviewers who rejected the assignment,
or they could end up being the suggested reviewer.

* fix: Actually do the assignment

* fix: If there's an existing assignment, don't create a new one

* style: Restructure conditional for clarity

* test: Add test cases for accepting or assigning a review assignment after rejecting it
 2023-09-27 08:57:34 -05:00
Lars Eggert d282cd3a37
Merge branch 'main' into fix-6393 2023-09-27 16:27:41 +03:00
Lars Eggert c2c02273c3
fix: Allow filtering for nominees who have not declined (#6382) 
* fix: Allow filtering for nominees who have not declined

Fixes #6380

* Update views.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-09-27 08:21:36 -05:00
Lars Eggert a469f08d63
Remove debug prints 2023-09-27 16:01:21 +03:00
Lars Eggert 4f6caa89b2
fix: Make sure groups in test have different acronyms 
Fixes #6393
 2023-09-27 15:59:59 +03:00
Jennifer Richards 82c70a2d5d
Merge pull request #6374 from rjsparks/more_docalias_removal 
fix: cleaner search_result_row diff links for recent drafts replacing other drafts
 2023-09-26 22:24:17 -03:00
Robert Sparks 4ba62bf149
fix: put rfc history on left 2023-09-26 17:17:04 -05:00
Robert Sparks 1b32fde588
fix: cleaner sync test (#6372) 2023-09-26 17:11:10 -05:00
Lars Eggert a8f50f50b0
fix: Only enable city/country entry for in-person interims (#6383) 
Was probably broken during the bs5 transition.

Fixes #6346
 2023-09-26 12:00:05 -05:00
Lars Eggert 7e18a0fad2
fix: Allow editing of interim meeting subject lines (#6385) 
Also change "readonly" to "disabled" to give a visual hint about which
fields are not changeable.

Fixes #6310
 2023-09-26 08:10:46 -05:00
Lars Eggert 5db70b2787
fix: State descriptions can have HTML in them, mark them safe (#6384) 2023-09-26 08:09:39 -05:00
Lars Eggert 6acc7aa848
fix: Restore the ability to search in tables (#6386) 
This was broken by 57030e4303
 2023-09-26 08:03:29 -05:00
Robert Sparks 9e4166393d
fix: cleaner search_result_row diff links for recent drafts replacing other drafts 2023-09-25 15:39:48 -05:00
Lars Eggert 73008596ee
fix: Enable editing of related liaison statement information (#6371) 
Fixes #6264
 2023-09-25 10:17:35 -05:00
Jennifer Richards 8f0a0da5a3
fix: Typo 2023-09-25 12:01:27 -03:00
Lars Eggert a42ef589f3
Unsplit conditionals 2023-09-25 17:41:30 +03:00
Lars Eggert 9efcce227d
Be less clever 2023-09-25 13:42:15 +03:00
Lars Eggert d0de2294a3
Merge remote-tracking branch 'origin/main' into fix-6343 2023-09-25 13:05:31 +03:00
Robert Sparks 092e572e16
feat: move errata tags 2023-09-22 16:35:54 -05:00
Lars Eggert 910a266126
fix: Prevent duplicate HTML IDs on photo page (#6356) 
* fix: Prevent duplicate HTML IDs on photo page

Fixes #6355

* Just don't slugify the ID.

See https://mathiasbynens.be/notes/html5-id-class
 2023-09-22 12:50:43 -05:00
Robert Sparks 8732dcb706
fix: bring tests up current. add subseries names to rfc view. fix html. 2023-09-22 12:40:15 -05:00
Lars Eggert 26f34f4aef
Merge branch 'main' into fix-6343 2023-09-22 08:32:17 +03:00
Robert Sparks 48cb06d20d
fix: subseries specific docevent types. get_or_create contain relationship. remove spurious " 2023-09-21 16:38:41 -05:00
Jennifer Richards b08d26d36e
feat: Scout monitoring for celery workers (#6342) 
* feat: Scout APM instrumentation for celery

* fix: Remove guard that caused problem on production
 2023-09-21 14:43:19 -05:00
Robert Sparks 0390f1868f
feat: subseries 2023-09-21 12:54:17 -05:00
Lars Eggert e76201103f
Fix pyflake 2023-09-21 18:15:12 +03:00
Lars Eggert 9391985cbb
fix: Add link to public pages to private NomCom pages 
Fixes #6343

Also fix highlighting of the active tab in the nav tab bar while I'm here.
 2023-09-21 17:20:38 +03:00
Jennifer Richards f15960d32d
Merge pull request #6328 from rjsparks/dochistory_rfcnumber 
fix: populate rfc_number on DocHistory with type_id rfc
 2023-09-15 20:41:43 -03:00
Jennifer Richards f4629bc750
Merge pull request #6326 from rjsparks/email_expansions 
fix: tune mailtrigger recipients and set relevant expansions for rfcs
 2023-09-15 20:12:39 -03:00
Robert Sparks a39a058a01
fix: populate rfc_number on DocHistory with type_id rfc 2023-09-15 17:33:05 -05:00
Robert Sparks 88e66048da
fix: make Was link go to the right place. Remove unreachable code. 2023-09-15 16:49:21 -05:00
Robert Sparks bc177b08ea
chore: black 2023-09-15 16:15:47 -05:00
Robert Sparks edadd99044
fix: tune mailtrigger recipients and set relevant expansions for rfcs 2023-09-15 16:02:08 -05:00
Robert Sparks e0e647fa75
chore: repair merge damage 2023-09-15 13:59:19 -05:00
Robert Sparks 4811374014
chore: reorder migrations (#6325) 2023-09-15 13:10:19 -05:00
Robert Sparks 621528ad03
ci: Merge branch 'main' into feat/rfc 2023-09-15 11:48:44 -05:00
Lars Eggert 303ff70e64
fix: Linkify email address lists one-by-one (#6315) 
* fix: Linkify email address lists one-by-one

Seems to work around a bug in mozilla/bleach.

Fixes #6307

* Cosmetic change

* Fix test
 2023-09-15 10:45:58 -05:00
Jennifer Richards b635045aab
Merge pull request #6309 from rjsparks/crawl-fixes 
fix: missed docalias artifact removal. Better use of became_rfc.
 2023-09-15 11:55:27 -03:00
Robert Sparks 4ddf132efb
fix: remove leftover docalias detritus 2023-09-15 09:51:15 -05:00
Robert Sparks 20f427e013
chore: remove unused view (#6304) 
* chore: remove unused view

* chore: deflake

* chore: deflake
 2023-09-14 17:10:26 -05:00
Robert Sparks 536c1fb6fc
fix: missed docalias artifact removal. Better use of became_rfc. 2023-09-14 16:43:26 -05:00
Robert Sparks 42c4c275d2
fix: move fewer docevents 2023-09-14 12:07:09 -05:00
Tero Kivinen a3fb6a49a3
fix: add review team setting allowing reviewers to reject assignments past the deadline (#5418) 
* Added a new review team setting
allow_reviewer_to_reject_after_deadline that will allow rejecting
review requests, even after the deadline is past. Also modified that
the secretary, or whoever manages the reviews is always allowed to
reject the review regardless of the deadline as he/she could change
the deadline anyways.

* Fixed but in view_reviews (wrong variable name), added more test
cases to the test_reviews.py for different reject cases.

* test: More thoroughly exercise assignment rejection

* chore: Renumber migration

* test: Unrelated user cannot reject assignments

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
 2023-09-14 11:48:28 -05:00
Robert Sparks 92ea5a6a89
fix: correct cache variable assignment 2023-09-13 15:46:21 -05:00
Lars Eggert d3d2f0d35f
fix: Enable js functionality on sortable tables (#6301) 
Fixes #6263

Also fix the non-js "untrack_document" page while I'm here.
 2023-09-13 15:31:01 -05:00
Jennifer Richards 69fd3a059e
fix: Validate string before calling int() (#6268) 2023-09-13 15:29:16 -05:00
Robert Sparks a571151b03
fix: allow looking at slide revisions when the slides doc name starts with rfc 2023-09-13 14:17:27 -05:00
Robert Sparks ececc456ab
fix: repair broken html 2023-09-13 14:10:29 -05:00
Robert Sparks 3a733a36db
fix: memoize became_rfc. Address review comments. 2023-09-13 14:07:40 -05:00
Jennifer Richards 8bc4507def
feat: Give AD the action in ad-f-up doc state (#6272) 
* refactor: Add helper class to compare tag changes

* feat: Give AD the action in ad-f-up state

* refactor: Remove unnecessary check

* refactor: Reorganize update_action_holders()

* refactor: Remove unnecessary guard

* test: Update test for new AD handling

* test: Update another test

* test: Test ad-f-up effect on action holders

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-09-12 09:44:33 -05:00
Robert Sparks bf50f88863
chore: remove debug 2023-09-12 09:37:13 -05:00
Robert Sparks a307e0616c
chore: Merge branch 'feat/rfc' into rfc_htmlized 2023-09-12 09:33:45 -05:00
Robert Sparks 0c85c4169d
fix: repairs to the timeline graphic 2023-09-12 09:23:01 -05:00
Robert Sparks 5bbea70cb0
fix: repair many revision related issues with the main and htmlized views 2023-09-12 08:55:38 -05:00
Robert Sparks be77cc9226
fix: correct missed replumbing of iprdisclosurebase 2023-09-12 08:54:11 -05:00
Robert Sparks 72d44d56c4
chore: black 2023-09-12 08:52:15 -05:00
Robert Sparks b58ddd7674
fix: move rfc dochistory objects to rfc document objects 2023-09-12 08:51:17 -05:00
Jennifer Richards 18a1af22f8
fix: Reject nul characters in ipr search parameters (#6292) 
* fix: Reject nul characters in ipr search parameters

Really ought to rework this as a form, but in the meantime
this should prevent 500s. Could probably reduce the number
of places we check the value.

* fix: Guard against absent parameters

* fix: Remove stray junk

* fix: Use correct response code (400, not 405)

* test: Test handling of null chars in IPR search

* refactor: Simplify branch statements

This helps my code validator see that "start" is
always set.
 2023-09-12 08:32:16 -05:00
Paul Selkirk febdeff85f
feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6231) 
* feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6088)

* chore: Move PUBLISH_IPR_STATES from settings_local to settings

* fix: Add migration for removed_objfalse in IprEventTypeName

* fix: De-conflict migration

* fix: De-conflict migration

* style: Move PUBLISH_IPR_STATES ahead of not-production block
 2023-09-11 13:14:46 -05:00
Robert Sparks 6b6c881353
fix: construct double-submit test correctly (#6168) 
* fix: construct double-submit test correctly

* chore: remove unused import
 2023-09-08 13:02:18 -05:00
Robert Sparks 7391ea7239
fix: rationalize document_rfc.html and the view driving it 2023-09-07 13:11:33 -05:00
Robert Sparks 7f074bf37f
fix: avoid redirects in mailarchive links (#6282) 2023-09-07 10:40:20 -05:00
Robert Sparks d0bac8913d
fix: use type instead of state in templates 2023-09-05 18:04:16 -05:00
Paul Selkirk cd56d43736
fix: Allow secretariat to change the state of a dead draft (#6253) 
* fix: Allow secretariat to change the state of a dead draft (#6051)

* refactor: Move the secretariat-can-edit-dead-state enablement to the template to limit side-effects.

* style: Correct whitespace to fully revert file

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-09-05 12:58:56 -05:00
Lars Eggert fb4002dbbd
fix: Don't show deferred I-Ds in AD's missing ballot list (#6162) 
* fix: Don't show deferred I-Ds in AD's missing ballot list

Fixes #6152

* Address code review comments
 2023-09-05 12:16:33 -05:00
Robert Sparks e0f27b9d52
ci: merge branch 'main' into feat/rfc 2023-09-05 12:02:07 -05:00
Robert Sparks 3c1fc3c0f9
chore: use factory-boy 3.3 (#6269) 2023-09-05 09:54:30 -05:00
Robert Sparks 87f0781ff3
chore: make some old things kept for documentation a little safer (#6260) 
* chore: make some old things kept for documentation a little safer

* fix: sh syntax
 2023-09-01 14:34:49 -05:00
Robert Sparks f2dc32a310
chore: remove unused scipts from ietf/bin (#6259) 2023-09-01 14:31:23 -05:00
Robert Sparks b5bf6789da
chore: remove one shot iab artifact importers (#6258) 2023-08-31 17:14:18 -05:00
Robert Sparks c8c1ebdf12
chore: remove unnecessary .gitignore files (#6262) 2023-08-31 17:12:01 -05:00
Robert Sparks 232536c593
fix: migration order and names fixture 2023-08-31 13:12:21 -05:00
Robert Sparks 4b778c155d
fix: reorder name migrations 2023-08-31 08:49:09 -05:00
Robert Sparks c2c48ff08d
chore: repair more damage 2023-08-30 17:32:55 -05:00
Robert Sparks fda5edf256
chore: clean up after cleanup 2023-08-30 17:14:13 -05:00
Robert Sparks ad1aabb4ad
chore: repair merge damage and adjust new files 2023-08-30 17:12:31 -05:00
Robert Sparks f9c9644263
chore: merge main and fix conflicts 2023-08-30 16:35:20 -05:00
Robert Sparks 3efd44fa2f
chore: remove unnecessary list construction 2023-08-30 11:24:52 -05:00
Robert Sparks 852f9d90b9
feat: move IAB appeals into the datatracker (#6229) 
* feat: basic models for appeals

* fix: modify appeal model to point to group

* fix: explicit date on Appeal objects

* feat: appeals importing management command

* feat: display appeals

* feat: admin for appeals

* fix: limit admin contentype choices

* feat: tastypie resources

* feat: factories and tests

* chore: update group migration

* fix: remove charset from pdf content type

* test: unittest download_name

* fix: admin for new name
 2023-08-29 14:07:30 -05:00
Jennifer Richards 7f8cbaa211
feat: Distinguish failed from not-applied checkers (#6220) 
* feat: Distinguish failed from not-applied checkers

* refactor: Only return applied checks from latest_checks()

* refactor: Use latest_checks() in submission_status view

* chore: Fix incorrectly phrased comment

* test: Test submission check summary
 2023-08-28 11:06:35 -05:00
Jennifer Richards 6adead355d
fix: Improve status page for canceled submissions (#6221) 
* fix: Show quieter alert for metadata error in canceled submission

* fix: Suppress metadata errors and show warning for canceled submissions

* style: Fix indentation in HTML

* fix: Give better notice of a processing error
 2023-08-26 15:58:40 -05:00
Jennifer Richards c65cd20f0c
fix: Move submission files using shutil.move() (#6217) 
* fix: Use shutil.move in move_files_to_repository()

* refactor: Use shutil.move in rename_submission_files()
 2023-08-25 11:47:28 -05:00
Lars Eggert b304e07008
fix: Change color of error reporting link in menu bar (#6213) 
Fixes #6179
 2023-08-25 09:21:07 -05:00
Lars Eggert 16c250fa33
fix: Add theme switcher to document view (#6202) 
* fix: Add theme switcher to document view

And reduce duplication in the page structure while I'm here.

Fixes #6200

* Fix tests
 2023-08-24 13:46:03 -05:00
Jennifer Richards 2bcb2c04f9
chore: Fix (mostly harmless) quoting error (#6209) 2023-08-24 13:45:17 -05:00
Robert Sparks bce70e74bc
feat: import iab agendas from iab website (#6197) 
* feat: import iab agendas from wiki

* chore: adjust command help text
 2023-08-24 11:53:10 -05:00
Lars Eggert 06d87b4097
fix: Reword I-D announcement emails to make first sentence more useful (#6193) 
Fixes #6092
 2023-08-24 08:19:30 -05:00
Lars Eggert a8e904400d
fix: Color agenda table row based on AD position (#6192) 
Fixes #6184
 2023-08-23 09:43:03 -05:00
Robert Sparks 8ad4ab0a8d
fix: unrepair a migration 2023-08-22 08:50:22 -05:00
Robert Sparks 9649004159
chore: remove unused imports 2023-08-19 13:22:41 -05:00
Robert Sparks 7f229c9755
chore: add copyright 2023-08-19 13:22:14 -05:00
Robert Sparks b646e183fe
chore: update names fixture 2023-08-19 13:19:54 -05:00
Robert Sparks d801716e47
fix: include migrations 2023-08-19 13:19:30 -05:00
Robert Sparks 96fae0c436
feat: remove DocAlias 2023-08-19 13:17:21 -05:00
Robert Sparks 94e9f433f6
chore: moved away more legacy code 2023-08-19 13:11:51 -05:00
Robert Sparks 5489fea9f7
fix: untangle stats and iana sync 2023-08-19 12:58:01 -05:00
Robert Sparks 1ae0c0b838
fix: follow became_rfc in ipr searches 2023-08-19 09:33:04 -05:00
Robert Sparks 05b71bb50c
chore: flip sense of all_ids rfc dict 2023-08-18 18:10:10 -05:00
Robert Sparks c0e2bb4521
chore: flip sense of all_ids2 rfc dict 2023-08-18 18:07:29 -05:00
Robert Sparks 63c3f23767
chore: fix test construction 2023-08-18 17:35:54 -05:00
Robert Sparks c631cb17cb
chore: more bulk change damage repair 2023-08-18 16:48:01 -05:00
Robert Sparks 90ca856afa
chore: repair damage from bulk changes 2023-08-18 13:44:05 -05:00
Lars Eggert aa955f0e9b
fix: Replace deprecated bootstrap CSS classes with 5.3 ones (#6166) 
* fix: Replace deprecated bootstrap CSS classes with 5.3 ones

* Fix test

* Remove debug print
 2023-08-18 13:41:02 -05:00
Robert Sparks 823281ba6c
chore: first pass at clearing out canonical_name 2023-08-18 10:59:55 -05:00
Robert Sparks 53be2c3793
feat: require draft revisions in ipr disclosures. Explain missing ones. (#6160) 
* feat: require draft revisions in ipr disclosures. Explain missing ones.

* chore: update copyrights

* chore: address review comments

* fix: draft should be Internet-Draft

* test: cover single revision case
 2023-08-18 07:47:12 -05:00
Robert Sparks 3b067a468a
fix: name corrections, flake removal 2023-08-17 16:34:26 -05:00
Robert Sparks 22dc5b6dc7
chore: cleanup typos 2023-08-17 16:24:22 -05:00
Robert Sparks 7441413032
chore: merge in and adjust rfceditor.py changes 2023-08-17 16:03:17 -05:00
Robert Sparks 9b59717b39
Merge branch 'feat/rfc' into nomoredocalias 2023-08-17 15:55:49 -05:00
Jennifer Richards 4706ac2a37
fix: Restore old handling of draft-iesg state 
Missing state -> idexists, idexists -> idexists, anything
else becomes pub.
 2023-08-16 11:53:58 -03:00
Robert Sparks 383899c5c4
chore: checkpoint: docalias mostly removed 2023-08-15 16:49:17 -05:00
Robert Sparks 4946430159
chore: checkpoint: halfway through removing docalias 2023-08-15 09:11:53 -05:00