Commit graph

88 commits

Author SHA1 Message Date
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports.
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output.
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz 36cac48063 Fixed a bunch of str/bytes issues.
- Legacy-Id: 16341
2019-06-30 20:54:09 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz ca1f3340c0 Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability.
- Legacy-Id: 16181
2019-05-02 12:38:41 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Robert Sparks 81c5b5091a Made some docevent creation more consistent. Addressed the TODOs added during the refactor.
- Legacy-Id: 16049
2019-03-19 18:48:05 +00:00
Robert Sparks f57fb6b8a6 Added the ability to withdraw individual assignments. Added the ability to mark individual assignments no-response.
- Legacy-Id: 16039
2019-03-18 21:15:20 +00:00
Robert Sparks da3174ab68 Improved several views.
- Legacy-Id: 16038
2019-03-18 19:41:07 +00:00
Robert Sparks 4b147f2ef8 More cleanup and correction. Caught a pervasive misuse of a state-name
- Legacy-Id: 16036
2019-03-15 20:39:06 +00:00
Robert Sparks 0856990683 Checkpoint. Most tests do not fail. Oddness with an API resource, and with one template's coverage
- Legacy-Id: 16031
2019-03-14 18:39:40 +00:00
Robert Sparks 073ce55f6c Checkpoint. ReviewTests pass, but others still fail of course. Next step is to address stats.
- Legacy-Id: 16021
2019-03-12 17:48:19 +00:00
Robert Sparks b85052fe63 Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half.
- Legacy-Id: 16012
2019-03-07 23:08:14 +00:00
Robert Sparks e91d706d5b Checkpointing. This is an incomplete idea. The tests will fail massively.
- Legacy-Id: 15985
2019-03-01 23:19:47 +00:00
Henrik Levkowetz 68c48f19a0 Improved resolution of an issue with the To: and Cc: addresses of extra review email to responsible AD.
- Legacy-Id: 15778
2018-11-20 13:36:12 +00:00
Henrik Levkowetz 9821406f60 Fixed an issue with the To: and Cc: addresses of extra review email to responsible AD.
- Legacy-Id: 15777
2018-11-20 13:20:16 +00:00
Henrik Levkowetz 0d9c97c5ca Added a test that checks the mailarch search failure return, and tweaks the no-result return handling.
- Legacy-Id: 15745
2018-11-10 19:06:40 +00:00
Henrik Levkowetz 236ee7639d Merged in [15706] from kivinen@iki.fi:
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126.
 - Legacy-Id: 15744
Note: SVN reference [15706] has been migrated to Git commit f9eeee0cc9
2018-11-09 21:23:45 +00:00
Tero Kivinen f9eeee0cc9 Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126. Commit ready for merge.
- Legacy-Id: 15706
2018-11-03 11:08:18 +00:00
Robert Sparks b76ea7bcd5 Let a reviewer indicate that an AD should give this review early attention. Fixes #2553. Commit ready for merge.
- Legacy-Id: 15676
2018-11-02 21:23:27 +00:00
Robert Sparks c7bf147b1d Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544. Commit ready for merge.
- Legacy-Id: 15675
2018-11-02 20:18:06 +00:00
Robert Sparks fd8af4b6f7 Review assignment email includes a link to the review request that ensures the reviewer is logged in. Fixes #2543. Commit ready for merge
- Legacy-Id: 15444
2018-09-06 21:39:10 +00:00
Tero Kivinen dc3e8ee810 Added default to review completion draft version number. If the reviewer
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes #2125. Commit ready for merge.
 - Legacy-Id: 15354
2018-07-14 21:54:04 +00:00
Tero Kivinen 0783890fa5 Removed the requirement for review_content field to be mandatory when
using "link" method. This partially addresses #2520. Commit ready for
merge.
 - Legacy-Id: 15349
2018-07-14 20:12:32 +00:00
Tero Kivinen dcabfc84f1 Add review request date to the top. Add tooltips for drafts versions
providing the date they were sumbmitted. Fixes #2218. Commit ready for
merge.
 - Legacy-Id: 15347
2018-07-14 20:07:36 +00:00
Robert Sparks ba8b4d3a38 Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233. Commit ready for merge.
- Legacy-Id: 14549
2018-01-22 21:43:53 +00:00
Henrik Levkowetz 8786b5c700 Tweaked the error message for review message URLs which cannot be retrieved.
- Legacy-Id: 14297
2017-11-03 19:52:34 +00:00
Henrik Levkowetz e79397d6ad Added cleaning of review_url from the review completion form, to make sure it's retrievable.
- Legacy-Id: 14227
2017-10-27 05:54:34 +00:00
Henrik Levkowetz 76628be3fd Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync).
- Legacy-Id: 13479
2017-05-31 20:59:26 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Henrik Levkowetz 487019883f Merged in [13120] from rjsparks@nostrum.com:
Be more explicit on review message subject lines. Fixes #2103.
 - Legacy-Id: 13153
Note: SVN reference [13120] has been migrated to Git commit da5a2363d6
2017-03-27 18:12:22 +00:00
Henrik Levkowetz 6ae137944d Merged in [13115] from mahoney@nostrum.com:
Added draftname to email subject for review request (addresses #2144).
 - Legacy-Id: 13151
Note: SVN reference [13115] has been migrated to Git commit b0cbf9a1c9
2017-03-27 17:09:48 +00:00
Robert Sparks da5a2363d6 Be more explicit on review message subject lines. Fixes #2103. Commit ready for merge.
- Legacy-Id: 13120
2017-03-25 20:45:08 +00:00
Jean Mahoney b0cbf9a1c9 Added draftname to email subject for review request (addresses #2144). Commit ready for merge.
- Legacy-Id: 13115
2017-03-25 19:52:15 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz c006c44423 Added setting of document author for review document objects.
- Legacy-Id: 12957
2017-03-03 19:40:09 +00:00
Henrik Levkowetz 541085b1a8 Changed email notifications for reviews done to save the message as a Message instance before sending it. Added test code to check that a Message instance is created and matches what goes out.
- Legacy-Id: 12955
2017-03-03 15:45:29 +00:00
Robert Sparks 8577a5e84a Use the Role email associated with a reviewer as the From when emailing a review. Fixes #2201. Commit ready for merge.
- Legacy-Id: 12930
2017-02-28 18:40:09 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/.
- Legacy-Id: 12897
2017-02-22 11:40:55 +00:00
Henrik Levkowetz b8815b00c5 Don't use person.plain_name() when constructing email addresses, as it can contain unicode characters which the current email pipeline can't handle correctly. Use person.plain_ascii() instead (or person.formatted_email()).
- Legacy-Id: 12865
2017-02-16 22:59:53 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0
- Legacy-Id: 12756
2017-01-30 23:13:02 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets.
- Legacy-Id: 12711
2017-01-23 17:38:56 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148.
- Legacy-Id: 12670
2017-01-19 14:23:09 +00:00
Robert Sparks 6ca953ae24 Improve the team review content templates. Related to #2075. Commit ready for merge.
- Legacy-Id: 12595
2016-12-20 05:38:02 +00:00