Commit graph

114 commits

Author SHA1 Message Date
Henrik Levkowetz 798f7697af Merged [4600] from rjsparks@nostrum.com:
* Adds a new document type for conflict reviews, with a ballot for the IESG 5742 response to a review request
* Integrated the new document type into the iESG agenda views (including RSS feeds)* Removed the Edit and Add buttons from the document main view.
* Replaced Add with actions appropriate for the document type, such as "Begin IESG Processing" or "Begin IETF Conflict Review", and made most data directly editable on the document's main page, depending on access permissions.
* Removed a manual editing step that the secretariat had to perform when sending conflict review messages. The view now composes the message correctly given the stream.
* Added a pencil icon motif to differentiate fields that are editable.
* Generalized several views and helper functions to use Document instead of (e.g.) IdWrapper
* Generalized reading documents from the repository
* Added a way to get from IdWrapper  to the underlying Document to facilitate migrating way from the Wrapper classes* Added many helpers to Document to assist with migrating off IdWrapper
* Minor fixes and other changes
  * Fixes to document main view to avoid (silent) template failures. 
  * Began removing some of the code that is no longer reachable post-migration  * Corrected the behavior of the undefer code and added test cases for it
  * Improved initial population of notification lists and added the ability to regenerate the initial list
* Made the test code that scans for template coverage more robust
* Deployment notes:
  * new setting: CONFLICT_REVIEW_PATH. The associated directory will need to be created

This branch fixes bugs #805, #744 and #812
 - Legacy-Id: 4652
Note: SVN reference [4600] has been migrated to Git commit 798e7a50e7
2012-07-28 16:29:28 +00:00
Henrik Levkowetz 0c49999fc9 Updated utils/draft.py and modified the submit app code accordingly.
New features (keep in mind that utils/draft.py can be run standalone
to do extraction of draft author data, too):

  * The handling of author info formatted in columns causes problems
    in the face of an author named for instance A. Author with the
    company 'Al Author and Associates', causing breakage of email
    addresses longer than 'Al Author and'.  Tweaked the recognition
    of column data to require multiple (not only one) space around
    'and'.

  * Added support for extraction of author affiliation.

  * Tweaked the meaning of -t, --timestamp and added --notimestamp; and
    made the default be to emit leading timestamps based ont the draft
    file time.

  * Added support for running author extraction on RFCs, by not bailing
    out on not finding a draft name when RFC information is available.

  * Added support for additional date formats and author name formats.

  * Improved creation date extraction -- previously, the first supported
    date format which was recognized on the first page of the draft would
    be used, rather than the first date in a supported format.  This could
    cause errors if the Status of Memo section or Abstract contained a
    date occurring at the start of a line.

  * Tweaked the honorific regex to make things work better for the case
    when the full name in the author's address section includes a first
    name which isn't part of the first-page abbreviated name.  Fixes
    problems with draft-chiappa-lisp-introduction and similar.

  * Added a special case for people who provide their email address as
    'foo&cisco.com' instead of 'foo@cisco.com'.  Bah.

  * Added an alternative, more human-readable key-value-pair attribute
    output mode with a '-a' switch.

  * Tweaded the first-name regex to capture cases where the first name
    is indicated with an alternate first letter: 'Y(J) Stein'.  Fixes
    problems with draft-anavi-tdmoip and similar.
 - Legacy-Id: 4612
2012-07-11 12:51:33 +00:00
Robert Sparks f3fd4db35c Merge forward complete - checkpointing before fixing popup position dialogs
- Legacy-Id: 4595
2012-07-04 19:35:46 +00:00
Henrik Levkowetz 1bc2f7daa2 Tweak test setup message for site_id change.
- Legacy-Id: 4567
2012-07-03 13:42:36 +00:00
Henrik Levkowetz aa00b6e35d Remove old duplicate debug.py
- Legacy-Id: 4565
2012-07-03 11:31:30 +00:00
Henrik Levkowetz 350914da15 Minor cleanup of test_runner.py. Added guards against settings which can make tests inexplicably fail. Updated check to avoid running tests on production server.
- Legacy-Id: 4564
2012-07-03 11:31:11 +00:00
Robert Sparks 51ab8123d9 merged in from 4.20-ise
- Legacy-Id: 4502
2012-06-22 20:25:17 +00:00
Henrik Levkowetz 839df60480 Merged in charter branch fixes from olau@iola.dk, from r4354 through r4381.
- Legacy-Id: 4382
2012-05-04 11:47:30 +00:00
Ole Laursen 3ec4dffd24 Check and sanitize text file upload (code is factored out in a new
helper so it can be reused elsewhere in the future).
 - Legacy-Id: 4380
2012-05-04 11:37:16 +00:00
Henrik Levkowetz bcd28cc45f Merged in fixes to the migration from olau@iola.dk. Merged in charter branch from olau@iola.dk. Added various fixes and correction of merge errors.
- Legacy-Id: 4353
2012-05-02 19:35:32 +00:00
Ole Laursen 8a8ddb0cc6 Add started_iesg_process event back in in test data as it's still
useful there
 - Legacy-Id: 4276
2012-04-16 13:57:18 +00:00
Ole Laursen e4a9d8c7aa Finish ballot support for charters (apart from non-generic ballot
deferral), remove a bunch of now obsolete charter code.
 - Legacy-Id: 4255
2012-04-04 18:09:03 +00:00
Ole Laursen 480cb04cd6 Save announcements generated by the system as Messages, adding an
extra relation to be able to associate a draft with the message
 - Legacy-Id: 3917
2012-02-08 21:05:28 +00:00
Ole Laursen 980d4e6444 Move new schema models from redesign/ to ietf/
- Legacy-Id: 3855
2012-01-24 17:17:24 +00:00
Ole Laursen f3685e7af1 Turn expiration into an explicit expires attribute on document, set
that on submission of new revision and resurrection
 - Legacy-Id: 3801
2012-01-12 12:03:45 +00:00
Ole Laursen 31aef86164 Merge charter branch with the UI hooks disabled for the time being
- Legacy-Id: 3800
2012-01-11 15:04:13 +00:00
Ole Laursen 9ae5f6a456 Make test runner multi-DB-aware
- Legacy-Id: 3786
2011-12-23 13:15:27 +00:00
Ole Laursen de0fc12ce8 Port telechat dates
- Legacy-Id: 3774
2011-12-20 13:12:12 +00:00
Ole Laursen 498dc38507 Port to Django 1.2, replacing built-in patched Django with Django 1.2.7 (with patches applied on top) and replacing South with South 0.7.3
- Legacy-Id: 3773
2011-12-15 14:13:54 +00:00
Ole Laursen 79ea179ff9 Comment out verbose mail server debug output for the time being
- Legacy-Id: 3719
2011-11-28 17:52:27 +00:00
Ole Laursen 03d1877802 Interpret settings.EMAIL_COPY_TO="" as "don't send a copy"
- Legacy-Id: 3717
2011-11-28 17:21:29 +00:00
Ole Laursen ea4e79cacb Fix empty_outbox to actually work as intended when outbox is imported elsewhere
- Legacy-Id: 3702
2011-11-24 16:36:19 +00:00
Ole Laursen 367d6b2116 Port recently merged stream delegate management in ietfworkflows to new schema
- Legacy-Id: 3687
2011-11-22 21:15:49 +00:00
Ole Laursen 5a4c23ea92 Merge with trunk
- Legacy-Id: 3676
2011-11-21 16:41:21 +00:00
Ole Laursen 5d291f222c Remove .state and .*_state on Document in favour of generic states
mapping, port the codebase to use these states
 - Legacy-Id: 3660
2011-11-16 18:18:06 +00:00
Ole Laursen ce74be89ef Use the test mode in the mail code when running automated tests instead of
reinventing the wheel in test_runner
 - Legacy-Id: 3620
2011-11-15 11:24:33 +00:00
Ole Laursen ea7f45d56e Port ietfworkflows and wgchairs to new schema, fix missing state
setting in I-D submission, add tests
 - Legacy-Id: 3617
2011-11-14 19:40:20 +00:00
Ole Laursen f7eefe8ee2 Finally get the mail system during automated test to send the real
message (i.e. pretend to do) instead of sending a copy, should make it
a bit easier to write tests
 - Legacy-Id: 3595
2011-11-08 11:48:57 +00:00
Henrik Levkowetz 5351319a9d Change the signatures of ietf.utils.mail functions using toUser to reflect that it's used as a boolean, not something else.
- Legacy-Id: 3522
2011-10-26 13:30:20 +00:00
Henrik Levkowetz f46f893de9 Don't try to output draft metadata (in standalone mode) for a file if the extraction failed.
- Legacy-Id: 3505
2011-10-25 13:58:55 +00:00
Henrik Levkowetz 43f1d5da93 Improved extraction of draft title during submission. Fixed a problem where the scan for an author's email address was prematurely terminated because another author's affiliation also was part of this author's address information.
- Legacy-Id: 3445
2011-10-13 14:36:26 +00:00
Ole Laursen 6f10d2f3f7 Port submit to new schema, adding a set of tests and fixing some bugs
- Legacy-Id: 3436
2011-09-21 19:29:50 +00:00
Ole Laursen 022bc51e23 Move unaccent helpers
- Legacy-Id: 3426
2011-09-16 11:32:33 +00:00
Ole Laursen 5c5d534104 Add person foreign key on Role to link the role and person directly instead of through Email, this will allow us to use non-personal emails on roles
- Legacy-Id: 3418
2011-09-14 14:01:17 +00:00
Henrik Levkowetz 7f8eea3b9d * Speeded up things and increased reliability by looking for a
recognizable author's address section, and not searching for
    author names earlier in the document if found.  Fixes a known
    bad case where the author name occurred in the middle of a draft.

  * Added handling for the case where an author name is followed by 
    parentheses which are not closed on the same line.

  * Some refactoring.
 - Legacy-Id: 3417
2011-09-14 12:31:48 +00:00
Ole Laursen 7f5fd62a3d Add simple test for ID submission, needs more extensive checking
- Legacy-Id: 3416
2011-09-05 17:14:47 +00:00
Ole Laursen 0769a07756 Port add delegate, add test, fix bug with first form in delegate
adding not checking whether found persons have a login
 - Legacy-Id: 3393
2011-08-29 14:08:27 +00:00
Ole Laursen 646e8b8615 Port WG Delegate deletion with new test
- Legacy-Id: 3383
2011-08-26 17:37:44 +00:00
Ole Laursen f11b558d00 Refactor slightly to get rid of clunky "ex-ad" role, any future uses
should use GroupHistory/RoleHistory instead
 - Legacy-Id: 3370
2011-08-24 20:49:30 +00:00
Ole Laursen b9e1753ef6 Port and proxy liaison views to new schema and add a bunch of tests
- Legacy-Id: 3350
2011-08-22 23:15:35 +00:00
Martin Qvist b73c5358e7 Added corrections and tests as discussed with Ole.
- Legacy-Id: 3349
2011-08-22 19:54:25 +00:00
Ole Laursen 2bf8e0a45d Move fixture generation for names to name app, add liaison edit test,
fix some liaison bugs
 - Legacy-Id: 3347
2011-08-22 12:37:56 +00:00
Ole Laursen e831dc3e89 Add generic find_history_active_at(obj, time), refactor to use it
- Legacy-Id: 3303
2011-08-12 09:41:50 +00:00
Ole Laursen 67e317d535 Merged in changes from conversion branch fixing a couple of problems
- Legacy-Id: 3285
2011-08-04 15:09:54 +00:00
Henrik Levkowetz 804e7cb795 Add some debug output utility functions.
- Legacy-Id: 3262
2011-07-27 16:33:50 +00:00
Ole Laursen af768fb633 Fix a bunch of merge bugs
- Legacy-Id: 3191
2011-06-29 13:05:11 +00:00
Ole Laursen 03bed41630 Merged in changes from the conversion branch
- Legacy-Id: 3187
2011-06-28 18:20:20 +00:00
Henrik Levkowetz 494b3c77fd Fix a problem with author extraction when a given name is the same as the surname.
- Legacy-Id: 3135
2011-05-23 21:42:34 +00:00
Henrik Levkowetz e904041ea9 Don't try to do string join on None, in case any address in an address list given to the mail sending routines is missing and represented by None.
- Legacy-Id: 3111
2011-05-10 12:13:40 +00:00
Henrik Levkowetz 101fe5f3dd When extracting meta-information from drafts, it is required that some data reside on the first page. Split unpaginated drafts into chunks so we can adhere better to this.
- Legacy-Id: 3083
2011-05-03 14:10:43 +00:00