Added the new version of the shepherd writeup as a comment when it's edited.
The new version works like this:
- Any shepherd writeups done before the document is submitted for
publication are not disclosed in the history.
- When the document is submitted for publication the available writeup (if
available) is added to history.
- Any further writeups after the document has been submitted for publication
are disclosed in the history.
- Legacy-Id: 6662
Note: SVN reference [6641] has been migrated to Git commit a0a451881b
Refactored the mails sent when state is changed along with annotation tags.
Don't send emails for only comment changes, just add a history entry. For
state changes and annotation changes, only send one email, containing
information about both state changes and annotation tag changes.
Fixes issue #1127.
- Legacy-Id: 6660
Note: SVN reference [6626] has been migrated to Git commit 74c7230842
Note: SVN reference [6640] has been migrated to Git commit 629816a2cb
Include confirmation addresses in ID-Submission success notice.
Fixes issue #1097.
- Legacy-Id: 6653
Note: SVN reference [6638] has been migrated to Git commit 72885f4524
Add document titles to status change request email. Fixes issue #1069.
- Legacy-Id: 6648
Note: SVN reference [6630] has been migrated to Git commit bb539aa0c2
Allow wgchairs to edit replaces relationships.
This actually allows anyone with can_edit_stream_info permission
to edit the list. This does draft name completion, but does not
currently filter those names for likely replacements. Styling is
also basically non-existent.
Fixes#1002
- Legacy-Id: 6639
Note: SVN reference [6629] has been migrated to Git commit 9ef29a323f
Added \'Last Call Issued:\' to front of last call atom feed entry subjects.
- Legacy-Id: 6634
Note: SVN reference [6624] has been migrated to Git commit 139b886458
Refines Bill Fenner's regex based search through documents for references.
Populates RelatedDocument with relations for references for each type draft Document.
Replaces these reference relationships with updated copies on draft submission.
Note to deployer: There is a script to run in patches/fill_in_references.py that does the work of bringing the database up to date. It takes around 10 minutes to complete on a fast development laptop.
fixes bug #1173
- Legacy-Id: 6633
Note: SVN reference [6622] has been migrated to Git commit a677a70df3
Took care of #841 by moving <span> correctly outside <a> altogether.
It used to be unbalanced:
<a><span></a></span>, but now
<span><a></a></span>
- Legacy-Id: 6632
Note: SVN reference [6614] has been migrated to Git commit b60865b3c5
This actually allows anyone with can_edit_stream_info permission
to edit the list. This does draft name completion, but does not
currently filter those names for likely replacements. Styling is
also basically non-existent.
Fixes#1002
- Legacy-Id: 6629
case: Only annotation tags changed -> Send annotation tags changed email (no state change mails)
case: Only comment changed -> *No emails*. Just add a history entry.
case: State changed -> Send state change emails. Include comments in the email if any were entered. If annotation tags were also changed, send a separate annotation tag change email.
- Legacy-Id: 6626
Ticket #1153: Fixes IPR disclosures being counted multiple times and counting of \'not yet approved\' IPR disclosures.
- Legacy-Id: 6623
Note: SVN reference [6613] has been migrated to Git commit b72c8a7cfd
Populates RelatedDocument with relations for references for each type draft Document.
Replaces these reference relationships with updated copies on draft submission.
Note to deployer: There is a script to run in patches/fill_in_references.py that does the work of bringing the database up to date. It takes around 10 minutes to complete on a fast development laptop.
fixes bug #1173
- Legacy-Id: 6622
Add the last call expiration date to the document header,
and remove duplicate code for producing the iest state summary.
- Legacy-Id: 6619
Note: SVN reference [6612] has been migrated to Git commit 5e00182ade
Reverted materials.html and the view that drives it to before the 4.70 merge.
Tweaked the view to get (I hope) the right things.
- Legacy-Id: 6581
Note: SVN reference [6580] has been migrated to Git commit 7a84ffe197
Slightly more than minimal changes to have questionnaire reminders go only to those nominees who have accepted but have not yet sent in a questionnaire for a given position
- Legacy-Id: 6573
Note: SVN reference [6486] has been migrated to Git commit 2a1b4c7775
Populates RelatedDocument with relations for references for each type draft Document.
Replaces these reference relationships with updated copies on draft submission.
Note to deployer: This migration takes around 10 minutes to complete on a fast development laptop.
- Legacy-Id: 6572
ical files, based on the timezone setting for a meeting, fetched from a pre-
generated file; and Session.ical_status(), which provides a string appropriate
for use in ical STATUS: entries.
- Legacy-Id: 6536
on standard in, also when providing an emtpy string as input.
This is now different from providing 'None' as the input
argument, or omitting it.
- Legacy-Id: 6485
Added the ability to send reminders to complete questionnaires to nominees in
the accepted state. Changed the send_reminders management command to not take
any arguments and run against all active nomcoms. Removed bugs from the
send_reminders management command and added tests for it. Adjusted several
dbtemplate titles and content.
Fixes bug 1157
- Legacy-Id: 6471
Note: SVN reference [6465] has been migrated to Git commit 22f356434a
Note: SVN reference [6466] has been migrated to Git commit a461e6c4a4
Now incumbent can be None in positions.
Fixes#1156.
- Legacy-Id: 6470
Note: SVN reference [6468] has been migrated to Git commit d4e37ac7a0d7fddc0317b0d95670a8de8cd32c2d
Note: SVN reference [6469] has been migrated to Git commit 0a315723ad6dd610d0c17e78edce2027b6868d4e
Changed the send_reminders management command to not take any arguments and run against all active nomcoms.
Removed bugs from the send_reminders management command and added tests for it.
Adjusted several dbtemplate titles and content.
Fixes bug 1157
Commit ready for merge
- Legacy-Id: 6465
with agenda_info() and the view functions that use it. Also changed
meeting/tests/agenda.py to accept matching return values. Reverted old
supporting models and proxy models to 4.72 versions, too, in meeting/proxy.py
and proceedings/models.py. Updated the proxy models which rely on TimeSlot
to work properly with the m2m sessions field, and adjusted some other
functions, such as session_agenda() to also understand the m2m sessions
field (and its reverse). Added an understanding of the "bof-conc" state
to the code which returns 'BOF' or 'WG' for agenda templates.
- Legacy-Id: 6452
replaced the noTable block construct with start/end table_content blocks
in order to not have to open and close tables in different blocks, and
not have empty tables lying about.
- Legacy-Id: 6439
and tweaked it to work with the new Timeslot model's sessions field.
Reverted the html agenda view code to use legacy_get_agenda_info(), based
on the release 4.72 code. This is a fix to display the html agenda for
now, and will need more cleanup, but this should be done without introducing
scheduledsession instances to the template.
- Legacy-Id: 6437
but based on the 'sessions' m2m field filtered with the meeting agenda.
This is right for the main meeting agenda, but not for personal schedule
layouts, so this isn't a final fix.
- Legacy-Id: 6436
position field may not be set when we get to this point and
try to retrieve the value of a different field than the one
we're processing. Don't cause a new exception in that case.
- Legacy-Id: 6416
Removed redundant call to not_duplicated from the nomcom/private_index template
It was already applied in the view, and interacted badly with the
list comprehension method of filtering for NomineePositions that
had associated questionnaire responses.
Fixes bug 1151.
- Legacy-Id: 6415
Note: SVN reference [6413] has been migrated to Git commit 3814b60c5d
It was already applied in the view, and interacted badly with the
list comprehension method of filtering for NomineePositions that
had associated questionnaire responses.
Fixes bug 1151
Commit ready for merge
- Legacy-Id: 6413
to be agenda_package.txt and that file already includes the links that
are enabled by the flag - perhaps it predates the user modeling that
allows ADs and Secretariat to see the links
- Legacy-Id: 6398
utilities to agenda.py, fix a couple of things, remove obsolete test
versions of agenda view, add support for viewing future IESG agendas
through /agenda/YYYY-MM-DD/* (useful when testing)
- Legacy-Id: 6395
is the way it should look. If something else is produced, it's not right.
The order of sessions on this agenda is sorted first on area on then on
acronym. This is the known good agenda.
- Legacy-Id: 6375
review decisions. Add migration to split up iesg_approve/disapprove
events of the form "IESG has approved ... and state has been changed
..." into the approve/disapprove event and a synthesized state change
event. Also regularize the descriptions a bit. This simplifies the
code in the new page.
- Legacy-Id: 6340
be able to add fixtures once and for all for all tests, instead of loading
them again and again for each test, if running on a database that supports
transaction rollbacks. In this case, fixtures specified in the perma_fixtures
class attribute will be loaded permanently, and not re-loaded. Fixtures
specifice as before, in a fixtures class attribute, will be treated as
before.
The downside of this is that as fixtures are loaded and not unloaded, they
can conflict with each other. The requirements on consistency becomes much
greater. The effect of this has been to require quite a bit of changes to
the simplified creations of various objects in make_test_data() in cases
where identically named objects occur in fixtures. Where completely
fictitious objects are created, no conflicts appear.
Also re-wrote parts of test_runner.py to permit global fixtures, loaded
before any tests are run and shared by all.
- Legacy-Id: 6318
ballot text for drafts processed by the IESG) - it has not worked
since the switch to the new schema as it's based on the old numeric
primary keys which we no longer have
- Legacy-Id: 6313
just I-Ds, sort by latest first, limit to documents on current and
future telechats (as the description says) to speed it up, add simple
test of the feed
- Legacy-Id: 6312
a link to both the email and the person (but didn't originally with
the new schema) so is better than the going through the email only, do
a couple of extra cleanups too while at it
- Legacy-Id: 6301
port associated tests, make the recommended next states clickable with
Javascript so a standard state change is just two clicks (next state
and save button)
- Legacy-Id: 6288
doc/ together with test and utilities, rewrite the UI to be more in
line with the rest of the edit pages (including the revamped stream
state change UI)
- Legacy-Id: 6269
ietfworkflows, add streams_menu template tag for outputting the
streams menu instead of the one in ietfworkflows, move
base_wgmenu.html and base_leftmenu.html templates to base/ (together
with base/streams_menu.html), get rid of "first" madness in
base/left_menu.html which is now obsolete anyway because we have a
Settings headline which is always first
- Legacy-Id: 6255
- Made Publication Request (for documents from IETF working groups) an
explicit action rather than a side-effect.
- Simplified the working group state edit form.
- Added hints to the WG state edit form to use the document's main page to
request publication.
- If a document is moved into IESG processing directly by the secretariat or
an AD (old processing path), set working group state accordingly.
- Legacy-Id: 6120
Simplified the working group state edit form.
Added hints to the WG state edit form to use the document's main page to request publication.
If a document is moved into IESG processing directly by the secretariat or an AD (old processing path), set working group state accordingly.
- Legacy-Id: 6119
* Made reporting IPR consistant across document searches, IPR searches, AD document queues, last calls, and agendas. All these points now report on the document(s) being directly queried, and the documents those transitively replace or obsolete.
* Brought search results against WGs and document titles into consistency with results from searching for individual documents
* Added the IPR count to the link on the documents main page (when not zero)
* Built on Henrik's reimplementation of all_related_*, making the *_related_* functions return DocAlias? lists consistently, and added corresponding _relations_ functions to get lists of actual RelatedDocument? objects.
* Added getting the DocAlias? with the same name to Document
* Added getting related IPR disclosures (as described in the first bullet) to Document
* Simplified ipr/related.py
* Removed the use of DraftLikeDocAlias? and IETFWG from ipr/search.py. Retooled the various search functions and templates to use DocAlias? and IprDocAlias? directly.
* Removed dead code from ipr/search.py
* Removed the special handling of WG 2000 from ipr/search.py
This fixes bug #1071
- Legacy-Id: 6083
* Brought search results against WGs and document titles into consistency with results from searching for individual documents
* Added the IPR count to the link on the documents main page (when not zero)
* Built on Henrik's reimplementation of all_related_*, making the *_related_* functions return DocAlias lists consistently, and added corresponding _relations_ functions to get lists of actual RelatedDocument objects.
* Added getting the DocAlias with the same name to Document
* Added getting related IPR disclosures (as described in the first bullet) to Document
* Simplified ipr/related.py
* Removed the use of DraftLikeDocAlias and IETFWG from ipr/search.py. Retooled the various search functions and templates to use DocAlias and IprDocAlias directly.
* Removed dead code from ipr/search.py
* Removed the special handling of WG 2000 from ipr/search.py
Fixes bug 1071
- Legacy-Id: 6042
Added support and scripts for generation of wg- and draft-aliases. Fixes issue #713.
- Legacy-Id: 5937
Note: SVN reference [5902] has been migrated to Git commit e5b551f4ce
Note: SVN reference [5904] has been migrated to Git commit e68e51cc55
Added tooltip capability to document tabs, and tooltips for disabled IESG Evaluation/Review tab. Fixes bug #448.
- Legacy-Id: 5931
Note: SVN reference [5903] has been migrated to Git commit d87379c177
Added a document link to the emails sent on discuss/comment changes. Fixes bug #916
- Legacy-Id: 5930
Note: SVN reference [5901] has been migrated to Git commit 30dec0ec09
Adds related documents to the set of documents checked for IPR declarations when building last call text. Partially addresses #1071.
- Legacy-Id: 5929
Note: SVN reference [5900] has been migrated to Git commit c69a33217e
When working group chairs added an annotation to a document, the date on the
history entry was wrong. It has now been fixed. Fixes issue #1046.
- Legacy-Id: 5928
Note: SVN reference [5899] has been migrated to Git commit 60bab5fe50
Fixes the last call processing code to identify the new placeholder writeup.
Fixes issue #884.
- Legacy-Id: 5927
Note: SVN reference [5897] has been migrated to Git commit 8d4a171431
additional tweaks from henrik: Added the capability to search for all kinds
of documents in the main datatracker search page. Fixes bug #838.
- Legacy-Id: 5926
Note: SVN reference [5898] has been migrated to Git commit b14a8d0cee
(-r5465:HEAD from branch/iola/shimfree). Copying relevant
commit messages here:
- Deleted dead code in many places.
- Renamed id-something to draft-something, make the "is
this eligible for expiration" logic clearer
- Added a name for IPR search URL
- Revamped the ballot popup view
- URL reversed the IPR search link instead of hardcoding it
- Cleaned up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.
idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
- Fixed output bug in test crawler and print referrer upon errors so it's
easier to figure out where a link came from
- Added /doc/in-last-call/ to crawler, report original page as referrer in
a redirect chain rather than intermediate URL
- Ported idindex to new schema, speed them up, add tests, refactor index
page in views_search to share code with the text index file, get rid
of some special-case idindex filters from ietf_filters, move
"/drafts/" redirects to a file in /doc/
- Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
drafts in IESG process to new schema in /doc/iesg/ and
/doc/iesg/last-call/
- Added redirects for all of /idtracker/*, removed all view code and other
dead code from idtracker/
- Removed the idtracker sitemap indexing drafts - in its current form,
it adds nothing of value to the HTML-based /doc/all/ view, and it's
pretty slow
- Ported idtracker feeds to new schema, move them to doc/, cleaned up
idtracker/ - only templatetags/ietf_filters and proxy code is left
- Legacy-Id: 5836
messages about there being a couple of minutes delay between submission and
the appearance of htmlized document and diff on the tools servers.
- Legacy-Id: 5835
(-r5194:5465 from branch/iola/shimfree). Copying relevant
commit messages here:
- Removed .related many to many relationship, it's not really useful
since we always have to restrict on the relationship type anyway,
instead add two helpers for doing the necessary queries (in both
directions)
- Added migration for transforming the .desc on the new_revision events
into something more akin to what is actually shown in the history page
- Added migration for blanking IESG notes that just consist of "RFC
XXXX", these have been superfluous for some time
- Grant stream chairs access to changing the stream on a draft
- Hacked the format_history_text filter to be less weird, using the same
formatting for snippets and full text, also link up legacy ballot set
events
- Moved the decoraters + utilities to new ietfauth/utils.py file
- Added simple helper to Email to identify invalid email addresses (from
legacy author entries)
- Used new new_revision .desc format for when drafts are submitted
- Improved the looks of the button class by adding extra contrast and a
linear gradient. Currently the gradient is only visible in fairly
recent browsers.
- Rewrote draft and RFC tabs in terms of the new schema, porting
write-up and history tabs as well
- Fixed two bugs in RFC Editor syncing: make sure documents we don't know
beforehand get a "draft" type and make sure individually submitted
drafts get the type="individ" group instead of NULL
- Made the CSS-styled button feel a bit nicer to use by flattening the
active state, also introduce some temporary styles until browsers
catch up with the standard syntax
- Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
RFCs that didn't get their doc.type set, 3) a big bunch of historic
stand-alone RFCs that have doc.group=None - set these to the
individual submission "none" group for the time being so the view code
doesn't have to deal with a special case.
In some cases this is wrong since there actually was a WG associated
but unfortunately fixing them properly requires detective work
(probably parsing the RFCs) and in at least some cases recreating
historic WGs. In case someone ends up doing this, the documents to
check can still be found with
Document.objects.filter(name__startswith="rfc", group__type="individ")
since there are almost no new RFCs that didn't went through the I-D
process.
- Merged the I-D and RFC views by showing I-D information on RFCs too.
I-Ds that have been published as RFCs redirect to the RFC URL. Also
support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.
- Fixed revision augmentation so events after RFC publication gets a "RFC"
designation
- Fixed a bug with tabs not using provided name but rather doc.name
- Displaying draft-iesg state rather than doc.friendly_state as IESG state,
also show a notice that the IESG state refers to post-RFC processing
if it does, like the old separate RFC page did
- Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
XXX" notes too, use the opportunity to remove inserted HTML tags from
notes and rely on linebreaksbr filter instead (the other thing was a
left-over from the Perl days), update the various uses of the note to
reflect that
- Refactored slightly to make views_doc.py independent of other idrfc code
- Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
somewhat fragile simple URL tests for views_doc.py with ordinary unit
tests. The new tests are still fairly basic but at least test more
than the URL tests did.
- Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
RFC0123 in the alias table with a new migration and a change to the
RFC Editor sync, this in turn makes /doc/std1/ do the right thing
- Now /doc/std1/ works, we can actually do a local link in
urlize_ietf_docs rather than linking to the tools.ietf.org server
- Fixed history text formatter: sanitize HTML before adding linebreaks and
non-breaking spaces, this cuts the time to render a history page with
long comments in half
- Added a test crawler that walks through the crawlable part of the site,
reporting errors and slow pages
- Got rid of initial "No record" positions when showing old positions,
it's just noise
- Added a .select_related() to the document main tab to reduce the number
of DB queries, unfortunately it seems it doesn't really help with
Django 1.2.x due to a bug (Document inherits from DocumentInfo which
makes things a bit more complicated)
- Introduced a simple cache in doc.get_state so repeated reads don't
cause a DB query
- Cleaned up the search code in preparation for removal of the shim-layer;
use a static button and don't send extraneous GET parameters
- Removed dead code in several places
- Legacy-Id: 5830
(for instance with InnoDB).
Added settings.DATABASE_TEST_OPTIONS which can be used to force for instance
InnoDB use during testing.
Using this has the potential of reducing the time it takes to run the test
suite substantially; a few test runs indicate a reduction in test run time by
50% on a run-of-the-mill linux server.
- Legacy-Id: 5823
* Skip IANA - Review Needed and Version Changed - Review Needed changes from
IANA as it turns out that the Datatracker is the authoritative source on
these states. Also improve logging so that the raw JSON from IANA is
dumped, the parsed JSON on imported changes is dumped and we write to
syslog before starting a sync script in the notification view.
* Only add charter state change link when chartering, it doesn't make sense
for an approved charter. Fixes#861.
* Don't display group.comments on the charter document page. Apparently
group.comments have been used by the Secretariat in the past for
chartering comments, but it's not possible to edit the field and the whole
thing doesn't make sense from a modelling perspective - a feature like
this should probably use the note field on the charter. Fixes issue
#1048.
* Don't crash if an attachment has been created already, just reuse it -
this case shouldn't actually happen, but apparently sometimes does,
probably due to a concurrency issue
* Add link to charter pages from the milestones editing page (besides the
cancel button), fixes#1044.
* Special-case proposed working groups with respect to milestones, they get
the charter milestones on the WG charter page rather than the current set
* Show approved milestones on /doc/charter-xyz/ page if the charter is
approved instead of only showing proposed milestones for proposed charters
- Legacy-Id: 5812
Note: SVN reference [5794] has been migrated to Git commit a603b8e056
Note: SVN reference [5800] has been migrated to Git commit 0f69f87a56
from IANA as it turns out that the Datatracker is the authoritative
source on these states. Also improve logging so that the raw JSON from
IANA is dumped, the parsed JSON on imported changes is dumped and we
write to syslog before starting a sync script in the notification view.
- Legacy-Id: 5800
group.comments have been used by the Secretariat in the past for
chartering comments, but it's not possible to edit the field and the
whole thing doesn't make sense from a modelling perspective - a
feature like this should probably use the note field on the charter.
Fixes issue #1048.
- Legacy-Id: 5798
