altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
16633 commits 1 branch 0 tags 2.6 GiB
Commit graph

230 commits

Author SHA1 Message Date
Henrik Levkowetz 60fdfa2c83 Fixed template and view to restore previous review display on the Manage Unassigned Reviews page. Fixes issue #2718. 
- Legacy-Id: 16205
 2019-05-13 12:19:05 +00:00
Henrik Levkowetz 5def83ef16 Removed links to the old MHonArc mail archives, and related view. 
- Legacy-Id: 16179
 2019-05-01 21:24:41 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself. 
- Legacy-Id: 16177
 2019-04-30 16:54:06 +00:00
Henrik Levkowetz 3ec9d7b678 Updated the role handling to use GroupFeatures.groupman_roles consistently for group management access. Fixes a IRTF RG delegate permissions issue. 
- Legacy-Id: 16160
 2019-04-25 13:19:30 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit 
- Legacy-Id: 16153
 2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com: 
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
 2019-04-22 17:39:26 +00:00
Henrik Levkowetz 93593a07c4 Merged in [16094] from magnus.westerlund@ericsson.com: 
Added sortable columns to Review Team Reviewers page. Partially addresses issue #2656
 - Legacy-Id: 16115
Note: SVN reference [16094] has been migrated to Git commit 0c0e75861e
 2019-03-28 11:08:06 +00:00
Henrik Levkowetz 82672519df Undid previous merge 
- Legacy-Id: 16113
 2019-03-28 11:05:25 +00:00
Henrik Levkowetz 6a159ebdfd Merged in [16094] from magnus.westerlund@ericsson.com: 
Added sortable columns to Review Team Reviewers page. Partially addresses issue #2656
 - Legacy-Id: 16112
Note: SVN reference [16094] has been migrated to Git commit 0c0e75861e
 2019-03-28 11:02:52 +00:00
Robert Sparks 3678d20b0b Some cleanup around stats. Things are well except for the time series graphs. 
- Legacy-Id: 16035
 2019-03-15 16:50:59 +00:00
Robert Sparks a4db66564c Checkpoint. Ended up chasing group.views_review before stats. 
- Legacy-Id: 16030
 2019-03-13 22:02:10 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly. 
- Legacy-Id: 16020
 2019-03-11 17:01:33 +00:00
Henrik Levkowetz 267e9eebc6 Transitioned group/views.py to unicode strings 
- Legacy-Id: 16011
 2019-03-07 14:58:49 +00:00
Henrik Levkowetz 435a0da12d Added on_behalf_of() calls for from addresses needing it throughout the code. 
- Legacy-Id: 15992
 2019-03-04 20:14:19 +00:00
Robert Sparks e91d706d5b Checkpointing. This is an incomplete idea. The tests will fail massively. 
- Legacy-Id: 15985
 2019-03-01 23:19:47 +00:00
Henrik Levkowetz 6c1b57509d Increased the document count for group document lists from the default(200) to 500, as MPLS now exceeds 200. 
- Legacy-Id: 15961
 2019-02-21 19:53:25 +00:00
Henrik Levkowetz d53f9db779 Modified a view function to fill in missing default CommunityLists for groups with features.has_documents == True. 
- Legacy-Id: 15957
 2019-02-18 12:12:46 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code. 
- Legacy-Id: 15908
 2019-01-22 18:11:46 +00:00
Henrik Levkowetz 55935eadd4 Merged in [15828] from rjsparks@nostrum.com: 
Show more group types on the concluded groups page. Fixes #2643.
 - Legacy-Id: 15871
Note: SVN reference [15828] has been migrated to Git commit ac4deed500
 2019-01-07 13:39:20 +00:00
Robert Sparks ac4deed500 Show more group types on the concluded groups page. Fixes #2643. Commit ready for merge. 
- Legacy-Id: 15828
 2018-12-17 21:34:30 +00:00
Henrik Levkowetz f65fcdd2c4 Merged in [15804] from rjsparks@nostrum.com: 
Add history to ReviewerSettings. Fixes #2147.
 - Legacy-Id: 15811
Note: SVN reference [15804] has been migrated to Git commit cb707248e2
 2018-12-13 14:29:58 +00:00
Robert Sparks cb707248e2 Add history to ReviewerSettings. Fixes #2147. Commit ready for merge. 
- Legacy-Id: 15804
 2018-12-03 22:23:01 +00:00
Henrik Levkowetz 44e28707cc Merged in [15709] from rjsparks@nostrum.com: 
Show counts on the active groups page and on the active wgs page. Fixes #2060.
 - Legacy-Id: 15755
Note: SVN reference [15709] has been migrated to Git commit cb02df1681
 2018-11-12 12:24:41 +00:00
Robert Sparks cb02df1681 Show counts on the active groups page and on the active wgs page. Fixes #2060. Commit ready for merge. 
- Legacy-Id: 15709
 2018-11-04 01:33:34 +00:00
Russ Housley 6ff552640e Do not show reasons for review team member unavailability outside the team. Fixes #2614. Commit ready for merge. 
- Legacy-Id: 15683
 2018-11-03 04:24:32 +00:00
Henrik Levkowetz caa3ec98b4 Changed the menu listing of review dirs and their display on the Directorates page back to what it was before the 'reviews' group type was split out. Added a 'Reviews' column to the Directoratges page. 
- Legacy-Id: 15420
 2018-08-01 18:53:44 +00:00
Henrik Levkowetz 0c732d6538 Guard against comparing email origin with username of None. 
- Legacy-Id: 15419
 2018-07-31 14:27:31 +00:00
Henrik Levkowetz ed208a5ebb Merged in [15342] from peter@akayla.com: 
Added optional reviewer unavailability reason support.  Fixes issue #2146.
 - Legacy-Id: 15375
Note: SVN reference [15342] has been migrated to Git commit f4eba7d4df
 2018-07-17 15:27:20 +00:00
Peter E. Yee f4eba7d4df Added optional reviewer unavailability reason support. Fixes issue #2146. Commit ready for merge. 
- Legacy-Id: 15342
 2018-07-14 18:04:31 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held 
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
 2018-07-12 10:51:48 +00:00
Henrik Levkowetz e87442f33a Merged in [15282] from housley@vigilsec.com: 
Set reply-to for I-D Announcements that include a CC to a mail list.  Fixes #2530.
 - Legacy-Id: 15289
Note: SVN reference [15282] has been migrated to Git commit 733c304e3d
 2018-07-10 17:16:47 +00:00
Henrik Levkowetz c9cc9ff214 Upped the permitted number of search results for the /stream/ise/ page (and friends) from 200 to 1000. Fixes issue #2527. 
- Legacy-Id: 15281
 2018-06-26 16:43:40 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase. 
- Legacy-Id: 15149
 2018-05-17 16:56:26 +00:00
Henrik Levkowetz 421621eb51 Another round of iesg page optimizations. Reduced additional instances of individual lookups to a single lookup followed by annotation of document objects. Reduced several instances of repeating the same work multiple times (queries for telechat documents, queries for telechat dates). 
- Legacy-Id: 15010
 2018-04-05 11:03:26 +00:00
Adam Roach 3c4c0f2584 Updated (deprecated, unregistered) 'text/json' with 'application/json' everwhere. Commit ready for merge. 
- Legacy-Id: 14843
 2018-03-17 15:14:57 +00:00
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11 
- Legacy-Id: 14695
 2018-02-25 19:55:16 +00:00
Henrik Levkowetz 5192440c9e Rewrote the head-of-rotation review assignment loop to guarantee that it will terminate. This should fix the 'gateway timeout' issues we've seen lately, when review request volume in some review teams have been such that multiple assignments to the head of queue members have triggered the issue. 
- Legacy-Id: 14684
 2018-02-22 22:18:19 +00:00
Henrik Levkowetz 36b5e2ef8e Changed name from .rel to .remote_field for remote accessors. 
- Legacy-Id: 14665
 2018-02-21 23:56:36 +00:00
Henrik Levkowetz 1825406695 Added a presence check before removing a list element. Addresses a 500 in unassigned review form POST. 
- Legacy-Id: 14642
 2018-02-14 14:32:33 +00:00
Robert Sparks 7b89db153e Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts r14570. Fixes #2443. Commit ready for merge. 
- Legacy-Id: 14623
 2018-02-07 17:58:27 +00:00
Henrik Levkowetz bf7157341f Merged in [14572] from rjsparks@nostrum.com: 
Corrected the filter for closed review requests. Fixes #2152.
 - Legacy-Id: 14573
Note: SVN reference [14572] has been migrated to Git commit 68725913b5
 2018-01-26 20:02:23 +00:00
Robert Sparks 13e8f8982c Add the ability to add a comment to a group's history. Fixes #1483. Commit ready for merge. 
- Legacy-Id: 14468
 2017-12-28 20:48:58 +00:00
Tero Kivinen 5c1f1dfbd7 Fixed save-continue to work. Fixes #2383. Commit ready for merge 
- Legacy-Id: 14359
 2017-11-11 07:23:50 +00:00
Robert Sparks 2c92aa213d Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so. Commit ready for merge. 
- Legacy-Id: 13832
 2017-07-11 19:12:21 +00:00
Henrik Levkowetz b97d45f5ba Call can_manage_group_type() with the right information. Fixes an issue with chartering buttons not being visible for ADs. 
- Legacy-Id: 13778
 2017-07-06 10:56:08 +00:00
Henrik Levkowetz 108c00a0a3 Merged in [13731] from rjsparks@nostrum.com: 
Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes #2305.
 - Legacy-Id: 13743
Note: SVN reference [13731] has been migrated to Git commit 7f5cef056ade1641f1d815b0a5f35962077d6d01
 2017-06-30 20:16:22 +00:00
Henrik Levkowetz ce1b655fa2 Code reorganization, doing away with multiple urls_* and views_ files in ietf.group. No intentional functionality changes. 
- Legacy-Id: 13709
 2017-06-22 15:18:08 +00:00
Henrik Levkowetz f5298d7bb8 Fixed a bug in which operations were available on the /group/chartering/ 'Chartering or re-chartering' page, so that not only operations on groups in a chartering state is shown, but also the options to start chartering. Fixes issue #2312. 
- Legacy-Id: 13584
 2017-06-12 19:25:39 +00:00
Henrik Levkowetz d82b8bf036 Reverted one of the changes in [13296], and added a comment explaining the relationship between the role list in roles_for_group_type() and the fields in the following GroupForm. 
- Legacy-Id: 13297
Note: SVN reference [13296] has been migrated to Git commit a59331dd63
 2017-05-10 13:22:16 +00:00
Henrik Levkowetz a59331dd63 Align the roles edit buttons on a group's about page with the roles that the group edit GroupForm will accept. Avoids edit forms without any fields and some server 500 errors. 
- Legacy-Id: 13296
 2017-05-10 13:05:51 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view 
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
 2017-02-26 23:21:49 +00:00
Henrik Levkowetz 23ebe5d35d This addresses ease of editing various group attributes, and in particular is 
intended to make it easier to see that you can edit things like the
external/additional URLs:

 - Added the ability to edit individual fields in a group's about page, and
   added edit buttons for editable fields on the about page, just as for
   documents (the ability to edit all editable fields already was available
   from the 'Edit group' button on the /group//about/ page).

 - Made the tab label for the group-about tab consistently say 'About',
   instead of 'Charter' for some groups.

 = Shifted the position of the about tab to the start of the tab line.

 - Removed the datatracker account requirement information at the top of the
   group edit page for users logged in to their account.

 - Tweaked the 'Show update' link on the 'Status Update' line.

 - Changed the label for the external URLs from 'More Info' to 'Additional
   URLs', which was already in use on the edit form.
 - Legacy-Id: 12904
 2017-02-23 20:55:38 +00:00
Henrik Levkowetz 0922c6c984 Added ordering by name to group personnel lists in edit and about views. This ordering is by the person's profile name, without attempting to determine which name part is family name or given name. Fixes #2184. 
- Legacy-Id: 12817
 2017-02-10 22:02:29 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0 
- Legacy-Id: 12756
 2017-01-30 23:13:02 +00:00
Henrik Levkowetz 2ab4caa90f Merged in [12722] from rjsparks@nostrum.com: 
Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about.
 - Legacy-Id: 12725
Note: SVN reference [12722] has been migrated to Git commit e0ea8b0f57
 2017-01-24 21:30:10 +00:00
Robert Sparks e0ea8b0f57 Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about. Commit ready for merge. 
- Legacy-Id: 12722
 2017-01-24 19:55:49 +00:00
Henrik Levkowetz e2640f358b Changed semantics for can_manage_group() to include chairs etc, and changed calls with the old semantics to use can_manage_group_type(). Rewrote can_manage_group() in terms of can_manage_group_type() and additional checks. Fixes issue #2155. 
- Legacy-Id: 12719
 2017-01-23 22:54:36 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets. 
- Legacy-Id: 12711
 2017-01-23 17:38:56 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review 
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
 2016-10-03 15:52:32 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing 
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
 2016-09-19 16:05:32 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it 
- Legacy-Id: 11923
 2016-09-06 10:17:12 +00:00
Ole Laursen 1f7d4870a8 Refactor role handling in group editing slightly and add support for 
editing reviewer roles in review teams. Also fix a couple of review
related bugs.
 - Legacy-Id: 11921
 2016-09-05 12:33:54 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the 
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
 2016-08-23 14:55:42 +00:00
Ole Laursen 1f71268da1 More polish on manage review requests page: Add save and continue 
editing button, reverse sort order so latest (and probably most
interesting) is at the top, disable save buttons when there are no
changes to save
 - Legacy-Id: 11843
 2016-08-23 12:12:24 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method. 
- Legacy-Id: 11840
 2016-08-23 10:52:08 +00:00
Ole Laursen 5eba7bf38e Fix a bug 
- Legacy-Id: 11807
 2016-08-17 16:12:17 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time 
- Legacy-Id: 11801
 2016-08-17 15:10:39 +00:00
Robert Sparks 9b2d73b365 add status reports to proceedings. add a view for the applicable status report for a given meeting. Commit ready for merge. 
- Legacy-Id: 11766
 2016-08-09 15:42:40 +00:00
Henrik Levkowetz 85fb050b2e Brought back, by popular demand, a tab with the link to a group's tools pages (which was removed in release 6.25.0). 
- Legacy-Id: 11559
 2016-07-08 11:17:58 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage 
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
 2016-07-01 16:06:16 +00:00
Henrik Levkowetz 54fc7adb9a Fixed a typo. 
- Legacy-Id: 11443
 2016-06-21 18:59:44 +00:00
Henrik Levkowetz 7c53eb1843 Renamed group.views.all_photos() back to chair_photos(). Added differentiated ordering by role to group photo pages. Moved the external links (dependency graph and tools pages) off of the tabs, to the charter page. 
- Legacy-Id: 11303
 2016-06-09 21:58:01 +00:00
Henrik Levkowetz 7edecaee27 Added photo page support for individual groups, and tweaked some names. This provides a photo page for the IAB, but also as a benefit photo pages for other groups. 
- Legacy-Id: 11287
 2016-06-06 16:33:24 +00:00
Henrik Levkowetz c5e0814e11 Made the photo url and view function names more generic. Shortened a tab name. 
- Legacy-Id: 11272
 2016-06-05 09:49:24 +00:00
Henrik Levkowetz 14a4ea177c Merged in ^/personal/rjs/6.21.1.dev0@11257 
- Legacy-Id: 11259
 2016-06-01 16:37:01 +00:00
Henrik Levkowetz 92214726fd Renamed some files under ietf/group/ which contained views but didn't have 'views' in the name. 
- Legacy-Id: 11190
 2016-05-13 15:59:10 +00:00
Ole Laursen 5ba00a9362 Move stream views to views_stream.py 
- Legacy-Id: 6266
 2013-09-26 09:48:37 +00:00
Ole Laursen 5f6f966355 Add stream edit page for setting delegates 
- Legacy-Id: 6254
 2013-09-24 16:55:23 +00:00
Henrik Levkowetz 23cdddf696 Added overview pages for non-ietf-stream documents (ise, iab, irtf). 
- Legacy-Id: 6202
 2013-09-19 18:21:16 +00:00