Commit graph

126 commits

Author SHA1 Message Date
Ole Laursen c15063f3c2 Adjust the import path for feeds
- Legacy-Id: 6879
2013-12-11 16:40:49 +00:00
Ole Laursen cfa0d47ca0 Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django
- Legacy-Id: 6878
2013-12-11 16:36:09 +00:00
Ole Laursen 19da33d8ff Make the search for specific draft name in IPR support both drafts and RFCs, clean up some related cruft
- Legacy-Id: 6775
2013-12-02 17:29:17 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Ole Laursen 52583aa850 Add extra newline, forgot to commit that with previous commit
- Legacy-Id: 6489
2013-10-25 13:55:49 +00:00
Ole Laursen d202c65835 Add tests of document placement in the agenda
- Legacy-Id: 6488
2013-10-25 12:54:39 +00:00
Ole Laursen 9842eef405 For no good reason, agenda_data took request as first parameter, remove this as it makes testing harder
- Legacy-Id: 6487
2013-10-25 12:53:54 +00:00
Ole Laursen 10dceef26d Refactor IESG agenda pages, put the agenda structure in a helper function in agenda.py, build the agenda up around this structure, and reuse this everywhere instead of duplicating the structure in various templates and the JSON view - this also fixes a couple of minor bugs where the copy-pasted copies were not entirely in sync
- Legacy-Id: 6454
2013-10-16 13:07:09 +00:00
Ole Laursen ec7e01481d Fix a potential bug with milestones_needing_review and ad-less groups
- Legacy-Id: 6430
2013-10-11 14:50:30 +00:00
Ole Laursen 87aaf4a47e Remove unused idtracker import from iesg/models.py
- Legacy-Id: 6429
2013-10-11 14:38:50 +00:00
Ole Laursen a17c07f282 Remove unused fixtures/sieve-charter.txt
- Legacy-Id: 6428
2013-10-11 14:37:11 +00:00
Ole Laursen 5f337e3c70 Remove obsolete testurl.list tests from IESG, the tests in
iesg/tests.py together with the test crawler has better coverage
 - Legacy-Id: 6427
2013-10-11 14:35:30 +00:00
Ole Laursen b24a20d328 Add test for /iesg/discusses/
- Legacy-Id: 6425
2013-10-11 14:31:50 +00:00
Ole Laursen b6c4f725b9 Fix accidental debug slicing in IESG discusses - of note is that the
discusses page now supports more than just I-Ds
 - Legacy-Id: 6420
2013-10-11 13:06:38 +00:00
Ole Laursen 1975ff27d0 Port IESG discusses to new schema
- Legacy-Id: 6418
2013-10-11 13:03:40 +00:00
Ole Laursen f6ff2a8082 Delete all old WGAction stuff, it's superceded by the WG charter
support, clean up iesg/models.py a bit
 - Legacy-Id: 6411
2013-10-10 16:12:34 +00:00
Ole Laursen 77aa4723bf Use the right path for other document types in
/iesg/agenda/telechat-YYYY-MM-DD-docs.tgz which now as a side-effect
of the port can bundle more than just drafts
 - Legacy-Id: 6410
2013-10-10 15:57:00 +00:00
Ole Laursen 72cc997151 Add test for /iesg/agenda/telechat-YYYY-MM-DD-docs.tgz
- Legacy-Id: 6408
2013-10-10 15:53:24 +00:00
Ole Laursen 21b32e72a3 Port /iesg/agenda/telechat-YYYY-MM-DD-docs.tgz, use tarfile.addfile
and StringIO to avoid the temporary file
 - Legacy-Id: 6407
2013-10-10 11:12:13 +00:00
Ole Laursen a81af95500 Add simple test for /iesg/agenda/documents/
- Legacy-Id: 6406
2013-10-10 10:38:59 +00:00
Ole Laursen 0860342e34 Port /iesg/agenda/documents/ to new schema, fix problem with rows
being colored for ADs with their position even if a ballot icon is not
shown (issue #1128)
 - Legacy-Id: 6405
2013-10-10 10:31:28 +00:00
Ole Laursen a728468711 Fix some problems highlighted by the tests, making the code a bit more
robust in case of unexpected data
 - Legacy-Id: 6402
2013-10-09 16:28:36 +00:00
Ole Laursen bb952fa281 Add test for agenda_documents_txt
- Legacy-Id: 6401
2013-10-09 16:27:36 +00:00
Ole Laursen 516a5fcc92 Port /iesg/agenda/documents.txt to new schema, compose the table in
Python instead of using a template to make the code easier to read
 - Legacy-Id: 6400
2013-10-09 15:55:45 +00:00
Ole Laursen 53c59e56e3 Remove vary_on_cookie on agenda view, it's not needed anymore, Django
already adds the vary: cookie header automatically
 - Legacy-Id: 6399
2013-10-09 12:55:28 +00:00
Ole Laursen be9fd53d55 Remove the ?private thing in /iesg/agenda/, the only use of it appears
to be agenda_package.txt and that file already includes the links that
are enabled by the flag - perhaps it predates the user modeling that
allows ADs and Secretariat to see the links
 - Legacy-Id: 6398
2013-10-09 12:53:13 +00:00
Ole Laursen b99cf963ae Move /iesg/milestones to /iesg/milestones/, apparently the URL (by accident) didn't include the ending slash
- Legacy-Id: 6397
2013-10-09 12:43:45 +00:00
Ole Laursen bd34270cbc Port IESG agenda pages to new schema, add tests for them, move agenda
utilities to agenda.py, fix a couple of things, remove obsolete test
versions of agenda view, add support for viewing future IESG agendas
through /agenda/YYYY-MM-DD/* (useful when testing)
 - Legacy-Id: 6395
2013-10-09 12:40:42 +00:00
Ole Laursen 11f3efdec7 Add test of ReviewDecisions
- Legacy-Id: 6380
2013-10-07 17:56:29 +00:00
Ole Laursen 5fe7ce62ff Add timeframe to IESG Review Decisions page
- Legacy-Id: 6348
2013-10-03 11:41:47 +00:00
Ole Laursen b552ff31aa Replace the announcement pages with a new page collecting all IESG
review decisions. Add migration to split up iesg_approve/disapprove
events of the form "IESG has approved ... and state has been changed
..." into the approve/disapprove event and a synthesized state change
event. Also regularize the descriptions a bit. This simplifies the
code in the new page.
 - Legacy-Id: 6340
2013-10-02 15:37:44 +00:00
Henrik Levkowetz e4f4467725 Changed tests to use our own subclassed TestCase, and changed almost all fixtures to be perma_fixtures.
- Legacy-Id: 6320
2013-09-30 20:36:20 +00:00
Ole Laursen d9ccff1889 Get rid of the view behind /iesg/ann/0-9+/ (apparently for displaying
ballot text for drafts processed by the IESG) - it has not worked
since the switch to the new schema as it's based on the old numeric
primary keys which we no longer have
 - Legacy-Id: 6313
2013-09-30 12:49:08 +00:00
Ole Laursen 5c6ee01bf7 drafts -> docs in /feed/iesg-agenda/ since we're returning more than
just I-Ds, sort by latest first, limit to documents on current and
future telechats (as the description says) to speed it up, add simple
test of the feed
 - Legacy-Id: 6312
2013-09-30 12:17:38 +00:00
Ole Laursen c191a691e0 Remove "names" fixture from all tests, since it's now loaded once just
after creating the test database through the global test fixture
mechanism - this speeds up multiple tests considerably
 - Legacy-Id: 6305
2013-09-29 17:35:59 +00:00
Ole Laursen 8bc5df166b Get rid of unused ietfworkflows import
- Legacy-Id: 6256
2013-09-24 17:28:43 +00:00
Ole Laursen b4988b2b45 Make IESG discusses use doc/search/status_columns.html with a quick hack to break dependency on ietfworkflows, remove now unused idrfc/status_columns.html, remove unused iesg/agenda_documents_row_status.html
- Legacy-Id: 6220
2013-09-20 15:55:28 +00:00
Ole Laursen d2b9adf3cb Move ietf_filters templatetag from idtracker/ to doc/
- Legacy-Id: 6053
2013-08-14 15:11:24 +00:00
Ole Laursen 2cf79bb04c Move update_telechat from idrfc.utils to doc.utils, port remaining
code to using log_state_changed from doc.utils, remove idrfc/utils.py
 - Legacy-Id: 6050
2013-08-13 16:44:07 +00:00
Ole Laursen ec2f0cabbf Delete dead code from idrfc, and delete some obsolete imports too
- Legacy-Id: 6001
2013-08-09 14:55:51 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz 47c25227d9 Always show IANA state (not only for certain states)
- Legacy-Id: 5756
2013-05-23 17:57:10 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Henrik Levkowetz 7a98fff79c Merged [5476] from rjsparks@nostrum.com:
* Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's \'My Documents\' page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5629
Note: SVN reference [5476] has been migrated to Git commit 10b4f7a4dc
2013-04-07 19:11:18 +00:00
Ole Laursen e94d1df549 Clean up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.

idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
 - Legacy-Id: 5611
2013-04-04 13:42:57 +00:00
Henrik Levkowetz 2f3476690f In order that document states (which may be used by old documents) should not need to be removed when state machines change and states go out of use, all document states have a 'used' field. The code which accesses the state fields have not been requiring that used=True for the states returned, which is an error. Fixed this by adding 'used=True' to all State.objects.get() and State.objects.filter() call where it's relevant.
- Legacy-Id: 5486
2013-03-05 23:24:41 +00:00
Robert Sparks 10b4f7a4dc * Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's "My Documents" page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5476
2013-03-01 15:47:51 +00:00
Henrik Levkowetz 2f0ca59a3c Apply patch for iesg/agenda/agenda.json from housely@vigilsec.com, and re-apply previous patch which was lost in the statesync merge.
- Legacy-Id: 5353
2013-02-02 18:44:08 +00:00
Robert Sparks 1cff6187f5 Put status changes on the agenda, moderator, and package pages
- Legacy-Id: 5331
2013-01-28 20:16:17 +00:00