Commit graph

99 commits

Author SHA1 Message Date
Peter E. Yee bb7e504d14 12/13 merged into 6.113.1.dev0 with migration ordering failure
- Legacy-Id: 17149
2019-12-13 19:53:45 +00:00
Henrik Levkowetz 2c28cb3eb0 When group secretary email addresses occurred in some mailtrigger To: entries, they were given with both name and address parts, while when occurring in Cc: entries, no names were present. Fixed one case of this, and adjusted a test case for consistency. Also added a more general utility function to exclude selected email addresses from email address lists.
- Legacy-Id: 17107
2019-11-27 21:49:22 +00:00
Henrik Levkowetz b7fba956fd Merged in [16825] from rjsparks@nostrum.com:
Don't copy early reviews to ietf_last_call by default.
 - Legacy-Id: 16884
Note: SVN reference [16825] has been migrated to Git commit 54c221b6e03b573041600645d34316292e058d66
2019-10-21 14:28:22 +00:00
Henrik Levkowetz 496eb50253 Merged in [16824] from rjsparks@nostrum.com:
Use last-call@ietf.org.
 - Legacy-Id: 16882
Note: SVN reference [16824] has been migrated to Git commit 039d62370dd27764a54c62c7d70959d43f36e880
2019-10-21 14:08:11 +00:00
Henrik Levkowetz 678f8a5787 Merged in [16765] from sasha@dashcare.nl:
Refs #2277 - Send daily reminders of overdue reviews to secretaries
 - Legacy-Id: 16839
Note: SVN reference [16765] has been migrated to Git commit cc64992204
2019-10-08 10:41:37 +00:00
Henrik Levkowetz 4af77bbc8e Fixed a bug in gather_submission_submitter().
- Legacy-Id: 16808
2019-10-02 04:07:00 +00:00
Henrik Levkowetz 25ac3b67f5 Merged in [16680] from sasha@dashcare.nl:
Fix #2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
 - Legacy-Id: 16794
Note: SVN reference [16680] has been migrated to Git commit 1390ae073c
2019-10-01 13:35:52 +00:00
Henrik Levkowetz 70380cb8ea Merged in [16672] from sasha@dashcare.nl:
Fix #2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
 - Legacy-Id: 16793
Note: SVN reference [16672] has been migrated to Git commit 88b7b45b0e
2019-10-01 13:06:48 +00:00
Henrik Levkowetz 902f7769d1 Fixed incorrect type hints for Migration.dependencies.
- Legacy-Id: 16776
2019-09-30 16:25:58 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Sasha Romijn cc64992204 Refs #2277 - Send daily reminders of overdue reviews to secretaries
Commit ready for merge.
 - Legacy-Id: 16765
2019-09-30 12:27:43 +00:00
Sasha Romijn 1390ae073c Fix #2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.

Commit ready for merge.
 - Legacy-Id: 16680
2019-08-30 17:40:55 +00:00
Sasha Romijn 88b7b45b0e Fix #2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.

Commit ready for merge.
 - Legacy-Id: 16672
2019-08-27 15:15:13 +00:00
Henrik Levkowetz 3d35cb028b Added another check before building submitter email for mailtrigger entries.
- Legacy-Id: 16550
2019-07-19 00:16:11 +00:00
Henrik Levkowetz ee369934b2 Added a check for submitter found before trying to get name and email.
- Legacy-Id: 16519
2019-07-18 17:08:55 +00:00
Henrik Levkowetz 9170395905 Added a email gather handler for submission_submitter that tries an Alias name lookuup if the submitter doesn't look as if it contains an email address.
- Legacy-Id: 16508
2019-07-17 14:29:42 +00:00
Henrik Levkowetz ea8c84d2f6 Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods.
- Legacy-Id: 16455
2019-07-15 18:01:26 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports.
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output.
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__()
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz e39ac52071 Removed 2to3-generated list() around .items() iterator in for loops.
- Legacy-Id: 16315
2019-06-27 18:11:17 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 13705976e2 Merged in [16287] from rjsparks@nostrum.com:
Send mail to a list when a new IETF WG -00 is submitted. Fixes #2730.
 - Legacy-Id: 16289
Note: SVN reference [16287] has been migrated to Git commit 9ace7db719
2019-06-19 14:32:25 +00:00
Robert Sparks 9ace7db719 Send mail to a list when a new IETF WG -00 is submitted. Fixes #2730. Commit ready for merge.
- Legacy-Id: 16287
2019-06-18 21:24:49 +00:00
Henrik Levkowetz 2ab2bd09f1 Merged in [16248] from rjsparks@nostrum.com:
Removed the IETF chair as a recipient of new IPR disclosures if there is no group or active document to send them to. Fixes #2727.
 - Legacy-Id: 16274
Note: SVN reference [16248] has been migrated to Git commit 427d9fe34e
2019-06-17 13:08:51 +00:00
Robert Sparks 427d9fe34e Removed the IETF chair as a recipient of new IPR disclosures if there is no group or active document to send them to. Fixes #2727. Commit ready for merge.
- Legacy-Id: 16248
2019-06-14 18:18:11 +00:00
Robert Sparks becad91b0b Allow logged in users to propose slides for meeting sessions. Fixes #2547 and #2403. Commit ready for merge.
- Legacy-Id: 16102
2019-03-25 16:10:00 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Henrik Levkowetz e024cca8c4 Merged in [15708] and [15730] from housley@vigilsec.com:
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15747
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 20:32:42 +00:00
Henrik Levkowetz 3b811ecb41 Merged in [15708] and [15730] from housley@vigilsec.com:
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 19:30:32 +00:00
Russ Housley d525ade0b0 Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge.
- Legacy-Id: 15730
2018-11-06 07:26:30 +00:00
Russ Housley 6067dcbfef Allow a mail alias for all review team secretaries. Fixes #2139. Commit ready for merge.
- Legacy-Id: 15708
2018-11-03 11:55:07 +00:00
Robert Sparks 43374969f6 Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440. Commit ready for merge.
- Legacy-Id: 15698
2018-11-03 08:13:10 +00:00
Robert Sparks 24b83240e0 Tune the recipients when a teams settings or a reviewer indicate ADs should be notified about a review. Commit ready for merge.
- Legacy-Id: 15677
2018-11-03 00:16:41 +00:00
Robert Sparks c7bf147b1d Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544. Commit ready for merge.
- Legacy-Id: 15675
2018-11-02 20:18:06 +00:00
Robert Sparks 5c57cf1b91 Used factories instead of make_test_data for malinglists, mailtrigger, message, person, secr/announcement, and secr/areas tests. Commit ready for merge.
- Legacy-Id: 15551
2018-10-10 05:36:34 +00:00
Robert Sparks 6b779e9d4c Send email when the responsible AD for a conflict review is changed. Include the stream manager and stream steering group when the responsible AD changes or when the telechat date changes. Fixes #2497. Commit ready for merge.
- Legacy-Id: 15152
2018-05-21 22:02:34 +00:00
Henrik Levkowetz ea7728b501 Changed calls to .related_that*() and .relations_that*() to use tuples rather than lists (a slight optimization).
- Legacy-Id: 15029
2018-04-07 10:47:16 +00:00
Henrik Levkowetz e859a556f7 Removed unused imports
- Legacy-Id: 14670
2018-02-22 00:06:24 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Robert Sparks 13e8f8982c Add the ability to add a comment to a group's history. Fixes #1483. Commit ready for merge.
- Legacy-Id: 14468
2017-12-28 20:48:58 +00:00
Henrik Levkowetz dedc7e6d56 Modified the mailtrigger clean_duplicates to reduce email address list entries with the same address but different names to one instance, and use consistent unicode names for authors if known.
- Legacy-Id: 14122
2017-09-16 09:19:20 +00:00
Robert Sparks 2c92aa213d Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so. Commit ready for merge.
- Legacy-Id: 13832
2017-07-11 19:12:21 +00:00
Henrik Levkowetz a28940fc1e Name/email formatting tweaks, to complement [13536].
- Legacy-Id: 13540
Note: SVN reference [13536] has been migrated to Git commit 55d36e284d
2017-06-06 08:11:31 +00:00
Henrik Levkowetz 55d36e284d Changed the '%s <%s>'%(name,email) idiom in several places to use email.utils.formataddr() instead, to avoid future problems with names that would need quotes. Added comments in 2 places where this change would not be appropriate.
- Legacy-Id: 13536
2017-06-05 22:40:11 +00:00