Commit graph

1159 commits

Author SHA1 Message Date
Henrik Levkowetz 5446ae642a Changed the signature of some document methods to not accept lists (but still accept tuples) in order to make caching possible. Added @memoize to some methods.
- Legacy-Id: 15024
2018-04-06 21:25:56 +00:00
Henrik Levkowetz d44c2dc92c Added another prefetch to search doc query results.
- Legacy-Id: 15023
2018-04-06 21:24:07 +00:00
Henrik Levkowetz 6b27daa58a Imposed sort order (most recent docs first) on document search results, in order to retain the most recent docs in case we have to chop the result list due too many hits.
- Legacy-Id: 15022
2018-04-06 21:23:14 +00:00
Henrik Levkowetz 248c2dd055 Added back the on-agenda calendar links to document lists, now in an implementation with better performance characteristics.
- Legacy-Id: 15020
2018-04-06 15:17:18 +00:00
Henrik Levkowetz 583d8882c5 Fixed an issue where the change of slide naming between IETF 96 and 97 caused the datatracker to not provide correct link to pre-IETF-97 materials. Thanks to tjw.ietf@gmail.com for the heads-up.
- Legacy-Id: 15017
2018-04-05 20:34:56 +00:00
Henrik Levkowetz 6a32a363cc Merged in [15012] from ford@isoc.org:
Add IRTF State option to Additional Search Criteria pulldown.
 - Legacy-Id: 15016
Note: SVN reference [15012] has been migrated to Git commit cd912600e6
2018-04-05 14:50:40 +00:00
Mat Ford cd912600e6 Add IRTF State option to Additional Search Criteria pulldown. Commit ready for merge.
- Legacy-Id: 15012
2018-04-05 11:56:37 +00:00
Henrik Levkowetz 421621eb51 Another round of iesg page optimizations. Reduced additional instances of individual lookups to a single lookup followed by annotation of document objects. Reduced several instances of repeating the same work multiple times (queries for telechat documents, queries for telechat dates).
- Legacy-Id: 15010
2018-04-05 11:03:26 +00:00
Henrik Levkowetz 67a17bb227 Fixed a number of tests to deal correctly with model method caching.
- Legacy-Id: 15009
2018-04-05 10:55:27 +00:00
Henrik Levkowetz 15d45b4d22 Changed the ballot_icon template tag to use an already found ballot if available, rather than doing lookups to find it (twice!).
- Legacy-Id: 15007
2018-04-04 17:12:08 +00:00
Henrik Levkowetz 1ec98fdd59 Added @memoize to two Document methods
- Legacy-Id: 15006
2018-04-04 17:10:06 +00:00
Henrik Levkowetz 43a9291053 Added an index for (doc, type) on DocEvent to speed up latest_event() queries.
- Legacy-Id: 14990
2018-04-01 19:33:16 +00:00
Henrik Levkowetz 675c652052 Additional changes to speed up the IESG agenda docs page: Changed telechat_page_count() to accept a list of documents if that's already been generated, to avoid double work. Changed the reviewed_by_teams list to provide acronyms directly, to avoid group lookups during template rendering. Provided page counts directly to the template instead of repeated (costly) filtering through telechat_page_count, with new document lookups. Removed the telechat_page_count template filter, due to its cost. Tweaked some lookups in fill_in_document_table_attributes() . Added to the select_related() list for documents in IESG agenda_documents().
- Legacy-Id: 14988
2018-04-01 18:51:48 +00:00
Henrik Levkowetz 60a60de94b Replaced inline database lookups with get_active_ads().
- Legacy-Id: 14987
2018-04-01 18:38:50 +00:00
Henrik Levkowetz db3a4eb20e Changed some instances of .slug to _id
- Legacy-Id: 14985
2018-04-01 18:32:27 +00:00
Henrik Levkowetz 4c297ba4c0 Changed settings so that cache keys used by memcached includes the release version, in order to avoid stale and incorrect cache content on new release deployment. Made it easier to pick out cache key composition by normalizing the variable name. Adjusted cache prefix and the composition of some keys to have a unique and consistent cache key prefix.
- Legacy-Id: 14943
2018-03-26 21:26:20 +00:00
Henrik Levkowetz c0eb9e3aa6 Merged in [14899] from rjsparks@nostrum.com:
Cleaner charter factory simplifies test code.
 - Legacy-Id: 14914
Note: SVN reference [14899] has been migrated to Git commit 8026f86cd3
2018-03-24 21:24:03 +00:00
Henrik Levkowetz cc717946f5 Merged in [14896] from rjsparks@nostrum.com:
Improved test coverage for ietf/doc/views_charter.py.
 - Legacy-Id: 14912
Note: SVN reference [14896] has been migrated to Git commit f11907b6a0
2018-03-24 17:54:14 +00:00
Henrik Levkowetz 6d5f604d5b Tweaked the document list iCalendar links to not show for presentations on days in the past.
- Legacy-Id: 14908
2018-03-24 15:29:10 +00:00
Henrik Levkowetz f48669a8e4 Merged in [14884] from adam@nostrum.com:
Adding page count to last call page.
 - Legacy-Id: 14907
Note: SVN reference [14884] has been migrated to Git commit e7b984dfa7
2018-03-24 15:09:50 +00:00
Henrik Levkowetz bd205ae29b Merged in [14849] from ben@nostrum.com:
Give ADs the red Clear Ballot button
 - Legacy-Id: 14904
Note: SVN reference [14849] has been migrated to Git commit 7bf02077fd
2018-03-24 13:31:48 +00:00
Robert Sparks 8026f86cd3 Cleaner charter factory simplifies test code. Commit ready for merge.
- Legacy-Id: 14899
2018-03-22 14:01:24 +00:00
Robert Sparks f11907b6a0 Improved test coverage for ietf/doc/views_charter.py. Commit ready for merge.
- Legacy-Id: 14896
2018-03-21 21:59:45 +00:00
Adam Roach e7b984dfa7 Adding page count to last call page. Commit ready for merge.
- Legacy-Id: 14884
2018-03-21 09:12:34 +00:00
Ben Campbell cc96709957 Give ADs the red Clear Ballot button
- Legacy-Id: 14848
2018-03-17 16:35:35 +00:00
Henrik Levkowetz a04e187f0f Removed some old debug print statements.
- Legacy-Id: 14823
2018-03-14 22:11:06 +00:00
Henrik Levkowetz 1fd4a4d1a7 Added session ical links to document lists (WG docs, search results, etc.) for documents on upcoming meeting agendas. Reduced the query and rendering times of document lists some more through additional prefetch_related().
- Legacy-Id: 14799
2018-03-14 19:16:50 +00:00
Henrik Levkowetz fdba464808 Added result caching for a couple of Document methods.
- Legacy-Id: 14795
2018-03-14 19:11:18 +00:00
Henrik Levkowetz 6e9bb00f13 Changed html cleaning to differentiate between fragment cleaning and document cleaning. Added an lxml-based cleaner for document cleaning, also permitting <style> tags (but not external style sheets).
- Legacy-Id: 14775
2018-03-13 12:48:22 +00:00
Henrik Levkowetz 2c0348cc7a Found that django's urlize() does not deal well with adjacent parantheses. Replaced it with a filter based on bleach.linkify, which does better.
- Legacy-Id: 14752
2018-03-09 15:07:04 +00:00
Henrik Levkowetz 1df3c715d0 Replaced the use of (at least in Django 1.11) buggy urlize() with bleach.linkify(), to avoid some exceptions caused by malformed urlize output, exposed by the new sanitize_html(). Also removed some dead code.
- Legacy-Id: 14751
2018-03-09 12:00:15 +00:00
Robert Sparks 975522af35 Make a more appropriate review message when a BoF has an initial charter under consideration. Fixes #2458. Commit ready for merge.
- Legacy-Id: 14715
2018-02-28 20:54:56 +00:00
Henrik Levkowetz 6e1d4d45d8 Added some missing migrations
- Legacy-Id: 14697
2018-02-25 20:08:37 +00:00
Henrik Levkowetz 1389775488 Added some missing migrations.
- Legacy-Id: 14696
2018-02-25 20:06:50 +00:00
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11
- Legacy-Id: 14695
2018-02-25 19:55:16 +00:00
Henrik Levkowetz dc90fa3940 Changed user.is_authenticated and .is_anonymous from method calls to attribute access.
- Legacy-Id: 14668
2018-02-22 00:03:30 +00:00
Henrik Levkowetz 6184170828 Changed import path from a deprecated path to the kosher one.
- Legacy-Id: 14667
2018-02-22 00:01:01 +00:00
Henrik Levkowetz 26bf387356 Replaced direct assignment to m2m fields with .clear() and .set()
- Legacy-Id: 14666
2018-02-21 23:58:25 +00:00
Henrik Levkowetz 36b5e2ef8e Changed name from .rel to .remote_field for remote accessors.
- Legacy-Id: 14665
2018-02-21 23:56:36 +00:00
Henrik Levkowetz a4768bb514 Removed unused imports. Added some explicit orderings to avoid pagination issues.
- Legacy-Id: 14664
2018-02-21 23:54:31 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Henrik Levkowetz cdc295bab8 Merged in [14655] from housley@vigilsec.com:
Strip the HTML tags around the new values in the mail produced by email_iesg_processing_document. Also, provide the previously missing URL at the end of the message. Fixes 2455.
 - Legacy-Id: 14657
Note: SVN reference [14655] has been migrated to Git commit 6ea0881a89
2018-02-19 17:36:09 +00:00
Russ Housley 6ea0881a89 Strip the HTML tags around the new values in the mail produced by email_iesg_processing_document. Also, provide the previously missing URL at the end of the message. Fixes 2455.
- Legacy-Id: 14655
2018-02-18 20:40:49 +00:00
Henrik Levkowetz 3dd66eba65 Fixed an UnboundLocalError (only partial variable initialization) bug.
- Legacy-Id: 14620
2018-02-07 06:13:19 +00:00
Henrik Levkowetz a00532694d Merged in [14549] from rjsparks@nostrum.com:
Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233.
 - Legacy-Id: 14555
Note: SVN reference [14549] has been migrated to Git commit ba8b4d3a38
2018-01-23 19:24:39 +00:00
Henrik Levkowetz 535cd0bccf Expanded the fields that the 'author' entry of the document search form is applied to, from just author name, to author name, email addresses, and affiliation. Fixes issue #2415.
- Legacy-Id: 14552
2018-01-23 18:12:10 +00:00
Robert Sparks ba8b4d3a38 Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233. Commit ready for merge.
- Legacy-Id: 14549
2018-01-22 21:43:53 +00:00
Henrik Levkowetz 649433874f Merged in [14539] from rjsparks@nostrum.com:
Warn when putting a draft on a telechat that is so close that directorates will probably not have time to complete a review. Fixes #2381.
 - Legacy-Id: 14542
Note: SVN reference [14539] has been migrated to Git commit dfc1d2aa9a
2018-01-19 15:22:16 +00:00
Robert Sparks dfc1d2aa9a Warn when putting a draft on a telechat that is so close that directorates will probably not have time to complete a review. Fixes #2381. Commit ready for merge.
- Legacy-Id: 14539
2018-01-18 22:14:30 +00:00
Henrik Levkowetz 07fd714c88 Refined the URL patterns and handling of alternative meeting material file formats, which were broken by an earlier refactoring (v6.57.0). Fixes issue #2436.
- Legacy-Id: 14521
2018-01-14 21:09:28 +00:00
Henrik Levkowetz 97206c6eeb Added user notification about ballots closed automatically when creating a new ballot.
- Legacy-Id: 14471
2017-12-29 15:24:37 +00:00
Henrik Levkowetz 4488fd82a4 Merged in [14467] from housley@vigilsec.com:
Close any previous ballots when a charter goes to Internal Review or Extrernal Review.  Fixes #2421.
 - Legacy-Id: 14470
Note: SVN reference [14467] has been migrated to Git commit de6121c6c1
2017-12-29 13:40:10 +00:00
Russ Housley de6121c6c1 Close any previous ballots when a charter goes to Internal Review or Extrernal Review. Fixes #2421.
- Legacy-Id: 14467
2017-12-28 20:09:56 +00:00
Robert Sparks 0a9737a5d2 Include information about previous team reviews in assignement emails. Fixes #2392. Commit ready for merge.
- Legacy-Id: 14466
2017-12-26 22:13:13 +00:00
Henrik Levkowetz b12bb3ca3c Guard document replacement following methods against infinite recursion on circular relationships.
- Legacy-Id: 14457
2017-12-22 19:28:59 +00:00
Henrik Levkowetz 7d7b7de54f Fixed an ungarded object attribute access.
- Legacy-Id: 14446
2017-12-19 14:38:02 +00:00
Henrik Levkowetz e1fa3ba381 Limited the iesg ballot position API to ADs (excluding secretariat).
- Legacy-Id: 14444
2017-12-19 14:10:43 +00:00
Henrik Levkowetz 6567e707ce Merged in ^/personal/henrik/6.64.2-ballotapi@14426. This provides personal API keys and a ballot position API at /api/iesg/position. Also added an endpoint description at /api/.
- Legacy-Id: 14430
2017-12-17 23:43:44 +00:00
Henrik Levkowetz a08c8dc76f Added an API endpoint to support automation of IESG ballot position posting, at /api/iesg/position. Added tests for the API endpoint, and updated the apikey validation decorator tests. Tweaked the decorator to handle a weakness found during testing.
- Legacy-Id: 14429
2017-12-17 21:55:27 +00:00
Henrik Levkowetz b0863c8963 Modified some names.
- Legacy-Id: 14428
2017-12-16 18:43:08 +00:00
Henrik Levkowetz e7209c6e50 Added a new personal event table to keep track of personal API key logins, and a management command to send out reports about activity to users with API keys. Added a weekly cronjob script to trigger weekly reports, and a monthly script for future use. Added a @require_api_key decorator to validate API keys for API key views and log in the API key owner. Modified the API key management urls to use create and disable rather than add and delete. Updated the API key list view. Added an API placeholder view function for ballot position setting, for test purposes. Added tests for the decorator and management command.
- Legacy-Id: 14426
2017-12-16 18:37:52 +00:00
Henrik Levkowetz 1f976da5c1 Third part of document read refactoring, after [14406] and [14410]. This replaces all usage of the non-unicode-aware get_document_content() function with unicode-aware Document.text() or Document.text_or_error() methods. This was triggered by yet another report of unicode content not being shown properly, and should fix all instances of document (drafts, agendas, minutes, etc.) display in the datatracker not handling unicode characters properly.
- Legacy-Id: 14411
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d

Note: SVN reference [14410] has been migrated to Git commit 660c81c272
2017-12-11 16:23:51 +00:00
Henrik Levkowetz 660c81c272 Tweaked the file content read refactoring in [14406] to try latin-1 conversion if unicode doesn't work.
- Legacy-Id: 14410
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d
2017-12-10 17:48:09 +00:00
Henrik Levkowetz 967ece7e7d Started refactoring of reading text from document files (drafts, charters, etc.) in order to normalise on one way of doing this, and making that return unicode rather than undecoded bytes. This is the first step of two, in order to gauge the possible issues and report on discrepancies.
- Legacy-Id: 14406
2017-12-08 21:51:11 +00:00
Henrik Levkowetz 4b5e354abe Merged in [14386] from rjsparks@nostrum.com:
Add a per-year RFC feed.
 - Legacy-Id: 14391
Note: SVN reference [14386] has been migrated to Git commit 6ab819bdde
2017-12-04 15:29:15 +00:00
Robert Sparks 6ab819bdde Add a per-year RFC feed. Commit ready for merge.
- Legacy-Id: 14386
2017-12-01 17:19:51 +00:00
Henrik Levkowetz ddfddb61ca Made the ballot type representation string more expressive, showing both name and doc_type.
- Legacy-Id: 14383
2017-12-01 09:27:28 +00:00
Henrik Levkowetz abb69338e2 Added a warning message for the user if ballot creation failed due to an already open ballot. This is a bad state, and should prevented by stricter checks before changing state, but is better than the current situation until we decide exactly which checks to implement.
- Legacy-Id: 14382
2017-11-30 16:10:38 +00:00
Henrik Levkowetz 98d234cd86 Refactored the handling of BallotDocEvent in tests, only creating them as needed, in preparation for stricter checks on state transitions to avoid mismatches between state and ballot.
- Legacy-Id: 14380
2017-11-30 16:02:31 +00:00
Henrik Levkowetz 64653b1aa3 Merged in [14374] from kivinen@iki.fi:
If draft name has rfcXXXX-bis or rfcXXXXbis then add rfcXXXX to diff context menu. Fixes #460 (7 years old ticket).
 - Legacy-Id: 14375
Note: SVN reference [14374] has been migrated to Git commit 23d053ea53
2017-11-16 08:16:38 +00:00
Tero Kivinen 23d053ea53 If draft name has rfcXXXX-bis or rfcXXXXbis then add rfcXXXX to diff context menu. Fixes #460 (7 years old ticket). Commit ready for merge
- Legacy-Id: 14374
2017-11-15 11:33:02 +00:00
Henrik Levkowetz b931be0a07 Merged in [14365] from kivinen@iki.fi:
Added closed date column to closed review list. Fixes #2150.
 - Legacy-Id: 14366
Note: SVN reference [14365] has been migrated to Git commit 7b4727541a
2017-11-13 06:58:42 +00:00
Tero Kivinen 7b4727541a Added closed date column to closed review list. Fixes #2150. Commit ready for merge
- Legacy-Id: 14365
2017-11-11 11:30:00 +00:00
Henrik Levkowetz a942bffbc6 Merged in [14355] from suresh@kaloom.com:
Fixes #2109
 - Legacy-Id: 14360
Note: SVN reference [14355] has been migrated to Git commit 51fa1deef2
2017-11-11 08:18:13 +00:00
Henrik Levkowetz 8499beb010 Added a 'Recent documents' to the IESG pages.
- Legacy-Id: 14300
2017-11-04 12:36:13 +00:00
Henrik Levkowetz 8786b5c700 Tweaked the error message for review message URLs which cannot be retrieved.
- Legacy-Id: 14297
2017-11-03 19:52:34 +00:00
Henrik Levkowetz e899ed6e4d Permit ADs to do wg session materials upload.
- Legacy-Id: 14293
2017-11-03 14:38:50 +00:00
Henrik Levkowetz 0d15cb0e14 Permit document urls to be up to 512 bytes, rather than the default 200
- Legacy-Id: 14230
2017-10-30 11:07:45 +00:00
Henrik Levkowetz e79397d6ad Added cleaning of review_url from the review completion form, to make sure it's retrievable.
- Legacy-Id: 14227
2017-10-27 05:54:34 +00:00
Henrik Levkowetz 4f83548b49 Added a new field Meeting.days to capture the length of a meeting. This is necessary now that we have previous meetings officially starting Sunday, lasting to Friday, and future meetings starting Saturday, Lasting to Friday. We use Meeting.days to calculate Meeting.end_date(). Meeting.get_ietf_monday() and two cut_off() methods have also been updated to be instance methods instead of class methods, and to not assume that a meeting starts on Sunday.
- Legacy-Id: 14225
2017-10-25 13:38:15 +00:00
Henrik Levkowetz 53eb7c8ae8 Added migrations for document url model changes. Updated the name fixtures. Added ability for individual draft authors to edit document urls.
- Legacy-Id: 14172
2017-09-27 16:37:13 +00:00
Henrik Levkowetz 92d425fd9b Added 'Additional URLs' for documents, the same way we have them for groups.
This could be used to point to a document source repository, to extracted
  yang module files, document wikis, and other relevant resources.
 - Legacy-Id: 14166
2017-09-27 10:52:32 +00:00
Henrik Levkowetz cbda2679a9 Removed some unreachable code.
- Legacy-Id: 14150
2017-09-22 14:45:21 +00:00
Henrik Levkowetz da23da1e8e Tweaked Document.relations_that_doc() to accept unicode relationship strings, in order to let it be called from modules importing __future__.unicode_literals.
- Legacy-Id: 14124
2017-09-16 09:24:29 +00:00
Henrik Levkowetz 4174196af0 Fixed a problem with missing extensions for external materials URLs, introduced in earlier doc.href() normalization work.
- Legacy-Id: 14077
2017-08-24 19:18:54 +00:00
Henrik Levkowetz 2ad08d6c59 Merged in [14056] from rjsparks@nostrum.com:
Straightened out some DocHistory timestamps that did not align with the respective DocEvent timestamps. Fixes #1972.
 - Legacy-Id: 14063
Note: SVN reference [14056] has been migrated to Git commit cebcd61b08
2017-08-21 21:25:48 +00:00
Henrik Levkowetz 9312b59153 Merged in [14055] from rjsparks@nostrum.com:
Improved what initial states are offered when the IRTF chair or RG personnel manage adoption of a document. Fixes #2319.
 - Legacy-Id: 14061
Note: SVN reference [14055] has been migrated to Git commit 09a7d720a1
2017-08-21 12:45:49 +00:00
Robert Sparks cebcd61b08 Straightened out some DocHistory timestamps that did not align with the respective DocEvent timestamps. Fixes #1972. Commit ready for merge.
- Legacy-Id: 14056
2017-08-14 20:33:24 +00:00
Robert Sparks 09a7d720a1 Improved what initial states are offered when the IRTF chair or RG personnel manage adoption of a document. Fixes #2319. Commit ready for merge.
- Legacy-Id: 14055
2017-08-14 19:35:48 +00:00
Henrik Levkowetz 55003bdf87 Simplified and corrected some code which uses doc.href(), based on the recent updates to href().
- Legacy-Id: 14026
2017-08-03 18:11:46 +00:00
Henrik Levkowetz 4dad8cdf9a Added a test to check for missing admin models, and added the admin models that were currently missing.
- Legacy-Id: 14021
2017-08-01 14:00:29 +00:00
Henrik Levkowetz e54a24b931 Added a couple of missing migrations.
- Legacy-Id: 14010
2017-07-31 12:11:08 +00:00
Henrik Levkowetz b33b62824e Added a document name validator to avoid new documents with unwanted characters in the name.
- Legacy-Id: 13998
2017-07-28 22:48:30 +00:00
Henrik Levkowetz 4295396891 Make Document.href() point at the rfc when doc.is_rfc().
- Legacy-Id: 13988
2017-07-27 15:28:11 +00:00
Henrik Levkowetz 3c88cf822b Replaced some group-specific agenda and minutes urls with session-specific urls, and more consistently pointed at explicitly named meeting materilas. Related to [13964].
- Legacy-Id: 13968
Note: SVN reference [13964] has been migrated to Git commit a5d8cc85d3
2017-07-24 17:41:49 +00:00
Henrik Levkowetz 7751f54742 Make materials links on the ietf materials page visible to group delegates.
- Legacy-Id: 13939
2017-07-19 11:45:35 +00:00
Henrik Levkowetz 39dbf43da4 Merged in [13918] from kivinen@iki.fi:
Unified the review request views to use same template, so they all
show same data, in same format.
 - Legacy-Id: 13936
Note: SVN reference [13918] has been migrated to Git commit b6e036b63e
2017-07-18 12:57:56 +00:00
Henrik Levkowetz c65015c30d Merged in [13916] from alireza.mohammadi@icann.org:
Better punctuation during state change by adding \" before and after
old and new state.  Fixes issue #1545.
 - Legacy-Id: 13931
Note: SVN reference [13916] has been migrated to Git commit 07c3fe97fd
2017-07-17 14:25:29 +00:00
Henrik Levkowetz 391d5e9ec5 Added a guard for the case that slides might be removed from a session while agenda page construction is in flight.
- Legacy-Id: 13926
2017-07-17 09:22:06 +00:00