Fix#2277 - Do not allow reviewers to reject overdue reviews.
If a review request is past the deadline, reviewers will no longer be
able to reject the assignment.
- Legacy-Id: 16909
Note: SVN reference [16883] has been migrated to Git commit 3c2b01b3ff
Adds docs with blocking positions to the ADs my-documents page. Fixes#2800.
- Legacy-Id: 16906
Note: SVN reference [16875] has been migrated to Git commit f7d4600371b3f2a3c92aa184b517ed4ebee3a118
Be resilient to statistics queries that provide a state but not a substate. Fixes#2813.
- Legacy-Id: 16905
Note: SVN reference [16860] has been migrated to Git commit 654ae848f657957d2f7d259293ba523619d81cb5
Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes#2812.
- Legacy-Id: 16900
Note: SVN reference [16854] has been migrated to Git commit b158807134e2d26b3e013b6414b6fcbaa0e39f77
Changes to displaying the ballot_icon to account for IRSG ballots.
- Legacy-Id: 16896
Note: SVN reference [16836] has been migrated to Git commit 6375aa3bedbd612cd519bf3dccced2465b145593
Improve alerts when looking at non-current versions of a charter document. Fixes#2774.
- Legacy-Id: 16845
Note: SVN reference [16785] has been migrated to Git commit 07637c27e1a76d3cbb92cc22b987b9f1426d8d52
Populate completed_on when rejecting a ReviewAssignment. Migrate past rejected assignments accordingly. Fixes#2782.
- Legacy-Id: 16841
Note: SVN reference [16770] has been migrated to Git commit 661e4c5369dc0d165bfcb56e3278906fe1de3b55
Allow responsible AD to be None for documents in iesg states idexists and dead. Fixes#2803 and #993.
- Legacy-Id: 16838
Note: SVN reference [16763] has been migrated to Git commit 9f54af355d4e2b17404caa1755be74d22b5edad1
Fix#2478 - When completing review, show which addresses it is posted to.
- Legacy-Id: 16795
Note: SVN reference [16688] has been migrated to Git commit 68ea11a916
Fix#2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
- Legacy-Id: 16794
Note: SVN reference [16680] has been migrated to Git commit 1390ae073c
Fix#2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
- Legacy-Id: 16793
Note: SVN reference [16672] has been migrated to Git commit 88b7b45b0e
Fix#2590 - Allow secretary to adjust date when completing a review.
This also fixes other issues identified in #2590, around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
created, set to current date/time.
- When the secretary records a review in the datatracker, they may
set a different completion date, which is autofilled if an email
is selected. One event is generated for the original completion
date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
existing events.
- Legacy-Id: 16791
Note: SVN reference [16670] has been migrated to Git commit 3942f9acc7
Guard against attempts to use the review request view with a ReviewRequest id that does not match the document for the ReviewRequest. This would have exposed #2776 much earlier.
- Legacy-Id: 16710
Note: SVN reference [16649] has been migrated to Git commit 01ceeba131
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
Commit ready for merge.
- Legacy-Id: 16680
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
Commit ready for merge.
- Legacy-Id: 16672
This also fixes other issues identified in #2590, around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
created, set to current date/time.
- When the secretary records a review in the datatracker, they may
set a different completion date, which is autofilled if an email
is selected. One event is generated for the original completion
date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
existing events.
- Legacy-Id: 16670
Remove a debug statement from the command
- Legacy-Id: 16661
Note: SVN reference [16603] has been migrated to Git commit d27096f39022e9bee1ffa84631d5ae847af9be3e
A management command to correct the state of several slide presentations uploaded during IETF105, and perform some missed powerpoint to pdf conversions.
- Legacy-Id: 16659
Note: SVN reference [16601] has been migrated to Git commit a14188d95cf200dfbdd93485b89808f3336b0649
Added encoding='utf-8' parameter to io.open operations in tests that starting failing since adding unicode_literals.
- Legacy-Id: 16588
Note: SVN reference [16562] has been migrated to Git commit d332bfd91d
Partially addresses issue #1926 still displaying markdown as text. Fixes#2704.
- Legacy-Id: 16576
Note: SVN reference [16557] has been migrated to Git commit f76c46bef0
