Commit graph

12040 commits

Author SHA1 Message Date
Robert Sparks 852f9d90b9
feat: move IAB appeals into the datatracker (#6229)
* feat: basic models for appeals

* fix: modify appeal model to point to group

* fix: explicit date on Appeal objects

* feat: appeals importing management command

* feat: display appeals

* feat: admin for appeals

* fix: limit admin contentype choices

* feat: tastypie resources

* feat: factories and tests

* chore: update group migration

* fix: remove charset from pdf content type

* test: unittest download_name

* fix: admin for new name
2023-08-29 14:07:30 -05:00
Jennifer Richards 7f8cbaa211
feat: Distinguish failed from not-applied checkers (#6220)
* feat: Distinguish failed from not-applied checkers

* refactor: Only return applied checks from latest_checks()

* refactor: Use latest_checks() in submission_status view

* chore: Fix incorrectly phrased comment

* test: Test submission check summary
2023-08-28 11:06:35 -05:00
Jennifer Richards 6adead355d
fix: Improve status page for canceled submissions (#6221)
* fix: Show quieter alert for metadata error in canceled submission

* fix: Suppress metadata errors and show warning for canceled submissions

* style: Fix indentation in HTML

* fix: Give better notice of a processing error
2023-08-26 15:58:40 -05:00
Jennifer Richards c65cd20f0c
fix: Move submission files using shutil.move() (#6217)
* fix: Use shutil.move in move_files_to_repository()

* refactor: Use shutil.move in rename_submission_files()
2023-08-25 11:47:28 -05:00
Lars Eggert b304e07008
fix: Change color of error reporting link in menu bar (#6213)
Fixes #6179
2023-08-25 09:21:07 -05:00
Lars Eggert 16c250fa33
fix: Add theme switcher to document view (#6202)
* fix: Add theme switcher to document view

And reduce duplication in the page structure while I'm here.

Fixes #6200

* Fix tests
2023-08-24 13:46:03 -05:00
Jennifer Richards 2bcb2c04f9
chore: Fix (mostly harmless) quoting error (#6209) 2023-08-24 13:45:17 -05:00
Robert Sparks bce70e74bc
feat: import iab agendas from iab website (#6197)
* feat: import iab agendas from wiki

* chore: adjust command help text
2023-08-24 11:53:10 -05:00
Lars Eggert 06d87b4097
fix: Reword I-D announcement emails to make first sentence more useful (#6193)
Fixes #6092
2023-08-24 08:19:30 -05:00
Lars Eggert a8e904400d
fix: Color agenda table row based on AD position (#6192)
Fixes #6184
2023-08-23 09:43:03 -05:00
Lars Eggert aa955f0e9b
fix: Replace deprecated bootstrap CSS classes with 5.3 ones (#6166)
* fix: Replace deprecated bootstrap CSS classes with 5.3 ones

* Fix test

* Remove debug print
2023-08-18 13:41:02 -05:00
Robert Sparks 53be2c3793
feat: require draft revisions in ipr disclosures. Explain missing ones. (#6160)
* feat: require draft revisions in ipr disclosures. Explain missing ones.

* chore: update copyrights

* chore: address review comments

* fix: draft should be Internet-Draft

* test: cover single revision case
2023-08-18 07:47:12 -05:00
Paul Selkirk 73c2a6aa8b
feat: Download questionnaire responses (#6111)
* feat: Download questionnaire responses (#4981)

* style: Expand "questio" to "questionnaire"
2023-08-14 16:06:23 -05:00
Robert Sparks e1c1daa13b
fix: allow rswg as a scheduling conflict (#6133) 2023-08-12 13:03:08 -05:00
Robert Sparks f30d348765
fix: link from session details to group about (#6134) 2023-08-12 13:02:52 -05:00
Robert Sparks a94ba22f5f
chore: log direct auth attempts (#6132) 2023-08-11 14:14:36 -05:00
Robert Sparks bb6360f56c
feat: add the IAB to the group menu (#6130) 2023-08-11 11:22:19 -05:00
Robert Sparks 73137364cc
chore: rename test settings and shorten runserver instructions (#6131) 2023-08-11 11:21:38 -05:00
Lars Eggert 540c4895bf
fix: Fix logo display under some dark/light mode settings (#6129)
Fixes #6126
2023-08-11 10:28:41 -05:00
Robert Sparks 0faac4aafc
fix: address hard html validation complaint (#6121) 2023-08-10 11:10:42 -05:00
Lars Eggert 57f23f5198
chore: feat/dark-mode <- main (#6103)
* chore: Remove unused "rendertest" stuff (#6015)

* fix: restore ability to create status change documents (#5963)

* fix: restore ability to create status change documents

Fixes #5962

* chore: address review comment

* fix: Provide human-friendly status in submission status API response (#6011)

Co-authored-by: nectostr <bastinda96@gmail.com>

* fix: Make name/email lookups case-insensitive (#5972) (#6007)

* fix: Make name/email lookups case-insensitive (#5972)

Use icontains so that looking up name or email is case insensitive
Added a test

Fixes: 5972

* fix: Use __iexact not __icontains

* fix: Clarify no-action-needed (#5918) (#6020)

When a draft is submitted for manual processing, clarify that
no action is needed; the Secretariat has the next steps.

Fixes: #5918

* fix: Fix menu hover issue (#6019)

* fix: Fix menu hover issue

Fixes #5702

* Fix leftmenu hover issue

* fix: Server error from api_get_session_materials() (#6025)

Fixes #5877

* fix: Clarify Questionnaire label (#4688) (#6017)

When filtering nominees, `Questionnaire` implies `Accepted == yes`
so fix the dropdown test tosay that.

Fixes: #4688

* chore: Merge from @martinthomson's rfc-txt-html (#6023)

* fix:no history entry when changing RFC Editor note for doc (#6021)

* fix:no history entry when changing RFC Editor note for doc

* fix:no history entry when changing RFC Editor note for doc

---------

Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>

* fix: avoid deprecation warning on view_list() for objs without CommunityList

Fixes #5942

* fix: return 404 for non-existing revisions (#6014)

* fix: return 404 for non-existing revisions
Links to non-existing revisions to docs should return 404

* fix: change rfc/rev and search behaviour

* refactor: fix tab level

* fix: return 404 for rfc revision for bibtex

* fix: provide date for revisions in bibtex output (#6029)

* fix: provide date for revisions in bibtex output

* refactor: change walrus to if's

* fix: specify particular revision for events

* fix: review refactoring issue

fixes #5447

* fix:  Remove automatically suggested document for document that is already has review request (fixes #3211) (#5425)

* Added check that if there is already review request for the document
in question, ignore the automatic suggestion for that document.
Fixes #3211.

* fix: dont block on open requests for a previous version. Add tests

---------

Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* feat: IAB statements (#5940)

* feat: support iab and iesg statements. Import iab statements. (#5895)

* feat: infrastructure for statements doctype

* chore: basic test framework

* feat: basic statement document view

* feat: show replaced statements

* chore: black

* fix: state help for statements

* fix: cleanout non-relevant email expansions

* feat: import iab statements, provide group statements tab

* fix: guard against running import twice

* feat: build redirect csv for iab statements

* fix: set document state on import

* feat: show published date on main doc view

* feat: handle pdf statements

* feat: create new and update statements

* chore: copyright block updates

* chore: remove flakes

* chore: black

* feat: add edit/new buttons for the secretariat

* fix: address PR #5895 review comments

* fix: pin pydantic until inflect catches up (#5901) (#5902)

* chore: re-un-pin pydantic

* feat: include submitter in email about submitted slides (#6033)

* feat: include submitter in email about submitted slides

fixes #6031

* chore: remove unintended whitespace change

* chore(dev): update .vscode/settings.json with new taskExplorer settings

* fix: Add editorial stream to proceedings (#6027)

* fix: Add editorial stream to proceedings

Fixes #5717

* fix: Move editorial stream after the irtf in proceedings

* fix: Add editorial stream to meeting materials (#6047)

Fixes #6042

* fix: Shows requested reviews for doc fixes (#6022)

* Fix: Shows requested reviews for doc

* Changed template includes to only give required variables to them.

* feat: allow openId to choose an unactive email if there are none active (#6041)

* feat: allow openId to choose an unactive email if there are no active ones

* chore: correct typo

* chore: rename unactive to inactive

* fix: Make review table more responsive (#6053)

* fix: Improve layout of review table

* Progress

* Progress

* Final changes

* Fix tests

* Remove fluff

* Undo commits

* ci: add --validate-html-harder to tests

* ci: add  --validate-html-harder to build.yml workflow

* fix: Set colspan to actual number of columns (#6069)

* fix: Clean up view_feedback_pending (#6070)

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* docs: Update LICENSE year

* fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065)

* fix: Correctly order "last call requested" column in the IESG dashboard (#6079)

* ci: update dev sandbox init script to start memcached

* feat: Reclassify nomcom feedback (#6002)

* fix: Clean up view_feedback_pending

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* feat: Reclassify nomcom feedback (#4669)

- There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`.

- I overloaded `view_feedback*` URLs with a `?reclassify` parameter.

- This adds a checkbox to each feedback message, and a `Reclassify` button
at the bottom of each feedback page.

- "Reclassifying" basically de-classifies the feedback, and punts it back
to the "Pending emails" view for reclassification.

- If a feedback has been applied to multiple nominees, declassifying it
from one nominee removes it from all.

* fix: Remove unused local variables

* fix: Fix some missing and mis-nested html

* test: Add tests for reclassifying feedback

* refactor: Substantial redesign of feedback reclassification

- Break out reclassify_feedback* as their own URLs and views,
  and revert changes to view_feedback*.html.

- Replace checkboxes with a Reclassify button on each message.

* fix: Remember to clear the feedback associations when reclassifying

* feat: Add an 'Overcome by events' feedback type

* refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page

* fix: De-conflict migration with 0004_statements

Also change the coding style to match, and add a reverse migration.

* fix: Fix a test case to account for new feedback type

* fix: 842e730 broke the Back button

* refactor: Reclassify feedback directly instead of putting it back in the work queue

* fix: Adjust tests to new workflow

* refactor: Further refine reclassification to avoid redirects

* refactor: Impose a FeedbackTypeName ordering

Also add FeedbackTypeName.legend field, rather than synthesizing it every
time we classify or reclassify feedback.

In the reclassification forms, only show the relevant feedback types.

* refactor: Merge reclassify_feedback_* back into view_feedback_*

This means the "Reclassify" button is always present, but eliminates some
complexity.

* refactor: Add filter(used=True) on FeedbackTypeName querysets

* refactor: Add the new FeedbackTypeName to the reclassification success message

* fix: Secure reclassification against rogue nomcom members

* fix: Print decoded key and fully clean up test nomcom (#6094)

* fix: Delete Person records when deleting a test nomcom

* fix: Decode test nomcom private key before printing

* test: Use correct time zone for test_statement_doc_view (#6064)

* chore(deps): update all npm dependencies for playwright (#6061)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* chore(deps): update all npm dependencies for dev/diff (#6062)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* chore(deps): update all npm dependencies for dev/coverage-action (#6063)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* fix: Hash cache key for default memcached cache (#6089)

* feat: Show docs that an AD hasn't balloted on that need ballots to progress (#6075)

* fix(doc): Unify help texts for document states (#6060)

* Fix IESG State help text link (only)

* Intermediate checkpoint

* Correct URL filtering of state descriptions

* Unify help texts for document states

* Remove redundant load static from template

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* ci: fix sandbox start.sh memcached user

* fix: refactor how settings handles cache definitions (#6099)

* fix: refactor how settings handles cache definitions

* chore: more english-speaker readable expression

* fix: Cast cache key to str before calling encode (#6100)

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Liubov Kurafeeva <liubov.kurafeeva@gmail.com>
Co-authored-by: nectostr <bastinda96@gmail.com>
Co-authored-by: Rich Salz <rsalz@akamai.com>
Co-authored-by: PriyankaN <priyanka@amsl.com>
Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>
Co-authored-by: Ali <alireza83@gmail.com>
Co-authored-by: Roman Beltiukov <maybe.hello.world@gmail.com>
Co-authored-by: Tero Kivinen <kivinen@iki.fi>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Kesara Rathnayake <kesara@fq.nz>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
Co-authored-by: Paul Selkirk <paul@painless-security.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Jim Fenton <fenton@bluepopcorn.net>
2023-08-10 09:49:15 -05:00
Lars Eggert 1d22e39a52
fix: Use icons in addition to colors for review-related badges (#6012)
* fix: Use icons in addition to colors for review-related badges

* Remove comment

* Remove debug print
2023-07-23 10:09:16 -07:00
Lars Eggert 97c7dd4d67
fix: Use correct logo in dark mode menubar (#6016)
Also use the "nor" variant elsewhere the logo is small.
2023-07-22 12:56:06 -07:00
Robert Sparks 4ec22dae19
Merge branch 'main' into feat/dark-mode 2023-07-22 13:49:24 -05:00
Lars Eggert 8e439df7c5
fix: HTML-escape person name in tests (#5986)
* fix: Add `mark_safe` to `person_link` to prevent HTML escaping

Fixes part of #5834, namely https://github.com/ietf-tools/datatracker/issues/5834#issuecomment-1627454562

* fix: Fix tests instead of marking name safe
2023-07-21 15:52:19 -07:00
Lars Eggert 3a47871f5e
fix: More dark mode fixes (#6001)
* fix: More small dark mode fixes

* "badge rounded-pill bg-" -> "badge rounded-pill text-bg-"

This sets the text color correctly for more readable badges.

* Same for cards

* Fix tests
2023-07-20 13:48:52 -05:00
Robert Sparks f52d0ddcf8
test: verify newsubmissiondocevent count by day is correct (#6000) 2023-07-20 08:53:23 -05:00
Jennifer Richards ba356397c0
fix: Specify UTC for TruncDate (#5996) 2023-07-20 08:29:30 -05:00
Nicolas Giard 05644a16ff
feat: agenda / floor-plan dark mode support (#5995) 2023-07-19 18:23:37 -05:00
Robert Sparks a20d1f4d9b
Merge remote-tracking branch 'ietf-tools/main' into feat/dark-mode 2023-07-19 12:18:07 -05:00
Lars Eggert d8c0ae5faf
fix: Add numeric localhost addresses to CSRF_TRUSTED_ORIGINS (#5989) 2023-07-19 09:55:22 -05:00
Lars Eggert 9d5d9d5172
fix: replace deprecated bootstrap things (#5858)
* text-muted -> text-body-secondary

* navbar-dark is deprecated

* Remove FIXME block, not an issue anymore

* Remove `navbar-light`
2023-07-18 12:22:28 -05:00
Paul Selkirk 3f228c788d
feat: Add totals to nominee feedback page (#5977)
* feat: Add totals to nominee feedback page (#4727)

* test: Add a unit test for feedback totals

Also remember to wrap the totals in a <tr> tag.
2023-07-18 09:17:06 -05:00
Lars Eggert bd9d3285b5
fix: #timeline -> #doc-timeline (#5985)
Fixes #5923
2023-07-18 09:01:43 -05:00
Lars Eggert 57843d8538
fix: Import fix from 7a946424c1 (#5984) 2023-07-18 08:58:22 -05:00
Paul Selkirk 0693a4357d
feat: Add "generate email" to action on nominees page (#4893) (#5959)
* feat: Add "generate email" to action on nominees page (#4893)

* fix: Use bare email address for now
2023-07-17 16:00:16 -05:00
Robert Sparks 3fe1fcf122
fix: send the whole txt submission to te DraftParser (#5956) 2023-07-12 08:58:08 -05:00
Jennifer Richards 8267f4b452
test: Fix typo in names.json (#5939) 2023-07-07 15:10:47 -05:00
Paul Selkirk bae204862d
feat: Add bibxml button to document info page (#5921)
* feat: Add bibxml button to document info page (#5908)

* fix: No bibxml for RFCs
2023-07-07 08:23:15 -05:00
Jennifer Richards 09f347727b
chore: Remove temporary pin on pydantic (#5911)
* chore: Remove temporary pin on pydantic

* test: Guarantee ordering of sessions in test

Should fix an intermittent test failure.
2023-07-05 08:50:50 -05:00
Jennifer Richards 60dc60234d
fix: Better match xml2rfc date parsing (#5914)
* refactor: Split up get_creation_date to ease testing

* test: Add tests of parse_creation_date()

Note change in expected output when date_elt is None:
instead of returning None, this expects today's date.

* fix: Return today instead of None when date is absent

* fix: Handle empty string for day attribute

* test: Check a couple more parse_creation_date cases

* fix: Revert to returning None when date elt is absent

* style: black
2023-07-05 08:23:37 -05:00
Jennifer Richards 1db267dd7d
fix: Set has_onsite_tool correctly in no_session() view (#5879)
This will prevent a session that was changed from "notmeet" to
 being scheduled from having its has_onsite_tool flag left as False
2023-06-26 16:10:51 -05:00
Paul Selkirk 98bf7afeab
feat: Display and bulk-edit nomcom position flags (#4681) (#5878)
This adds a table to show the state of all nomcom positions, and lets the
chair set or un-set multiple state flags at the same time.

As a consequence, it moves the email templates to the "Edit position" form.
2023-06-26 16:10:05 -05:00
Lars Eggert f250a653a2
fix: Remove IESG-related about tabs from non-IETF-stream docs (#5515)
* fix: Remove IESG-related about tabs from non-IETF-stream docs

Fixes #5514

* Fix code review comments

* Address review comments

* Address code review comments
2023-06-22 10:35:59 -05:00
Paul Selkirk 53b5e23612
fix: Be a little clearer when feedback is closed (or not yet open). (#5861) 2023-06-22 08:13:32 -05:00
Lars Eggert 62523eb02c
fix: More dark mode fixes (#5852)
* fix: Correctly indicate "auto" theme is default

* fix: .pnp.js changes were missing

* fix: Use a "-subtle" background color for the menu bar

Because those change correctly with theme changes. That the
non-"-subtle" ones may be a bs5 bug, but enough people complained
about the yellow background in dev mode in dark mode that this change
may be worth it.

* fix: Try and recolor black colors in SVGs for dark mode

* Apply suggestions from @martinthomson
2023-06-21 11:46:16 -05:00
Jennifer Richards 0144ee991e
fix: Include time zone information in v1 api datetimes (#5851)
* fix: Include time zone information in v1 api datetimes

* fix: Use Z suffix instead of offset in API datetimes
2023-06-21 11:43:19 -05:00
Lars Eggert a6cc12c14b
fix: Don't (re)sort obsoleted/updated info (#5391)
* fix: Don't (re)sort obsoleted/updated info

Rebased against feat/postgres

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Fix review comments

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-06-20 12:07:45 -05:00
Robert Sparks 3c016cc5c8
feat: v3-era aware feed for rfcs (#5828)
* feat: v3-era aware feed for rfcs

* chore: remove obviated comment

* test: improve rfc feed tests
2023-06-16 15:52:42 -05:00
Robert Sparks ac65232115
fix: improve when Message objects are created (#5836)
* fix: improve when Message objects are created

* test: further improve feedback test

* fix: improve and test another form

* test: Restructure test infrastructure
2023-06-16 15:51:31 -05:00