Commit graph

59 commits

Author SHA1 Message Date
Henrik Levkowetz e4f4467725 Changed tests to use our own subclassed TestCase, and changed almost all fixtures to be perma_fixtures.
- Legacy-Id: 6320
2013-09-30 20:36:20 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Henrik Levkowetz becd10a81d Merged [5570] from rjsparks@nostrum.com:
Moves the interface to edit shepherds and sheperd writeups out of the 
wgtracker interface and into the doc views (via idrfc).
Added a little to the simple authorization code (can_edit_) in idrfc.
Added a way to reset the writeup to the current templates (leaving 
extension points to take templates for non-ietf stream documents).
Fixes bug #967.

Implementation notes:
Currently reused EmailsField -- in the long 
run a better approach will be to build a similar PersonField.

This also fixes tickets #834 and #691 (which were effectively duplicates 
of #967)
 - Legacy-Id: 5631
Note: SVN reference [5570] has been migrated to Git commit 3bc9e9a7add65bf135d669381cb5d93c5a2e3e19
2013-04-07 20:40:15 +00:00
Henrik Levkowetz 2f3476690f In order that document states (which may be used by old documents) should not need to be removed when state machines change and states go out of use, all document states have a 'used' field. The code which accesses the state fields have not been requiring that used=True for the states returned, which is an error. Fixed this by adding 'used=True' to all State.objects.get() and State.objects.filter() call where it's relevant.
- Legacy-Id: 5486
2013-03-05 23:24:41 +00:00
Henrik Levkowetz 2a0b758f08 Changed some tests to work with cssselect 0.7.1 (we've previously had 0.6.1 or possibly other lower versions).
- Legacy-Id: 5475
2013-02-28 21:39:29 +00:00
Ole Laursen 619b1d870e Remove dead code
- Legacy-Id: 5465
2013-02-25 11:50:25 +00:00
Ole Laursen b19f6d8060 Merge in milestones branch
- Legacy-Id: 5091
2012-12-03 14:36:30 +00:00
Henrik Levkowetz 3a7480520f Merged [4999] from jmh@joelhalpern.com:
Correct test of final shepherd update flag.
 - Legacy-Id: 5014
Note: SVN reference [4999] has been migrated to Git commit aba18e8f38364ad17d451d0ed7e33aa01dfbeb52
2012-11-07 12:50:38 +00:00
Henrik Levkowetz 7c46b9b61b Change the wgchairs.ManageWriteupTestCase to not expect the writeup page to be restricted. This adapts the test to the change made in [4218] to make writeups readable by all.
- Legacy-Id: 4300
Note: SVN reference [4218] has been migrated to Git commit 0e3de35834
2012-04-22 15:37:56 +00:00
Suresh Krishnan 19dbc6c9bb Making doc writeup available as read-only text to regular users who are not shepherd/AD/Secretariat etc.
Adding a link for viewing a writeup to the main datatracker page.
 - Legacy-Id: 4213
2012-03-24 15:03:11 +00:00
Ole Laursen 679fd4f502 Fix bug in is_area_director_for_group
- Legacy-Id: 4017
2012-03-01 18:45:14 +00:00
Ole Laursen d43159cd90 Add support for incoming ADs with a new "pre-ad" role
- Legacy-Id: 3900
2012-02-03 16:22:31 +00:00
Ole Laursen 980d4e6444 Move new schema models from redesign/ to ietf/
- Legacy-Id: 3855
2012-01-24 17:17:24 +00:00
Ole Laursen fc88964298 Go through the code and replace uses of Person.name with Person.plain_name()
- Legacy-Id: 3849
2012-01-23 20:22:45 +00:00
Ole Laursen 31aef86164 Merge charter branch with the UI hooks disabled for the time being
- Legacy-Id: 3800
2012-01-11 15:04:13 +00:00
Ole Laursen 498dc38507 Port to Django 1.2, replacing built-in patched Django with Django 1.2.7 (with patches applied on top) and replacing South with South 0.7.3
- Legacy-Id: 3773
2011-12-15 14:13:54 +00:00
Ole Laursen 8153a1c130 Patch up to pass request object to send mail in the instances where
it's possible (i.e. when not run in cron) in preparation for better
mail test handling
 - Legacy-Id: 3711
2011-11-25 18:24:14 +00:00
Ole Laursen 1a1476fa01 Remove unused import
- Legacy-Id: 3710
2011-11-25 15:47:22 +00:00
Ole Laursen 227a426bfd Fix merge-related bug
- Legacy-Id: 3684
2011-11-22 18:59:56 +00:00
Ole Laursen 5a4c23ea92 Merge with trunk
- Legacy-Id: 3676
2011-11-21 16:41:21 +00:00
Ole Laursen 5d291f222c Remove .state and .*_state on Document in favour of generic states
mapping, port the codebase to use these states
 - Legacy-Id: 3660
2011-11-16 18:18:06 +00:00
Ole Laursen ce74be89ef Use the test mode in the mail code when running automated tests instead of
reinventing the wheel in test_runner
 - Legacy-Id: 3620
2011-11-15 11:24:33 +00:00
Ole Laursen 3c2293d4e8 Port ietfworkflows and wgchairs to new schema, fix missing state
setting in I-D submission, add tests
 - Legacy-Id: 3618
2011-11-14 19:40:49 +00:00
Henrik Levkowetz 941d22e3d5 Merged /branch/yaco/wgchairs.r3120:r3154-3558 from esanchez@yaco.es. This adds support for alternate streams document tracking, similar to the WG chairs tracking functionality.
- Legacy-Id: 3559
2011-11-02 15:47:44 +00:00
Martin Qvist 8d3ea2f131 Bug in wgchairs
- Legacy-Id: 3431
2011-09-20 06:38:58 +00:00
Ole Laursen 5c5d534104 Add person foreign key on Role to link the role and person directly instead of through Email, this will allow us to use non-personal emails on roles
- Legacy-Id: 3418
2011-09-14 14:01:17 +00:00
Ole Laursen 7e3b621a05 Port shepherd management, adding tests
- Legacy-Id: 3401
2011-08-30 11:33:47 +00:00
Ole Laursen 0769a07756 Port add delegate, add test, fix bug with first form in delegate
adding not checking whether found persons have a login
 - Legacy-Id: 3393
2011-08-29 14:08:27 +00:00
Ole Laursen d6c01d7a48 Port one branch of delegate adding and add test for it
- Legacy-Id: 3388
2011-08-26 18:40:36 +00:00
Ole Laursen 646e8b8615 Port WG Delegate deletion with new test
- Legacy-Id: 3383
2011-08-26 17:37:44 +00:00
Ole Laursen 4fd243d746 Port wgchairs auth to new schema
- Legacy-Id: 3378
2011-08-25 18:24:04 +00:00
Ole Laursen 67e317d535 Merged in changes from conversion branch fixing a couple of problems
- Legacy-Id: 3285
2011-08-04 15:09:54 +00:00
Henrik Levkowetz 413bcdabbd Set up app-specific email addresses so the respective developers will be notified about failures in code they have worked with.
- Legacy-Id: 3205
2011-07-23 12:49:56 +00:00
Henrik Levkowetz 9a6f0e410b Get person without limiting it to iesglogins. WG Chairs will have logins but not IESG logins ...
- Legacy-Id: 3201
2011-07-23 12:15:21 +00:00
Emilio A. Sánchez López 8f196b450d Extend the query that search for allowed to login users. Fixes #681
- Legacy-Id: 3192
2011-06-30 09:44:40 +00:00
Henrik Levkowetz 3ece259476 Set svn:ignore *.pyc in new directories.
- Legacy-Id: 3124
2011-05-12 14:29:37 +00:00
Emilio A. Sánchez López c9241edf7b Changed the "no user with this email" warning when adding delegates/shepherds.
- Legacy-Id: 3016
2011-03-30 19:07:45 +00:00
Emilio A. Sánchez López e4f9bbe1ff Added state definitions in workflow edit form.
Re-order states in workflow edit form.
See #644
 - Legacy-Id: 3014
2011-03-30 18:56:35 +00:00
Emilio A. Sánchez López 8527cdaf6b Freeze global WG states. See #644
- Legacy-Id: 3013
2011-03-30 18:24:33 +00:00
Emilio A. Sánchez López e681c5e3c9 Insert change shepherd and change writeup links in document view.
Insert document view link in shepherd document list.
Allow secretariat to manage shepherds and writeups.
Fixes #643
 - Legacy-Id: 3012
2011-03-30 17:05:10 +00:00
Emilio A. Sánchez López 7e8d51e405 Included MAX_WG_DELEGATES into settings.py
Some minor textual changes in templates.
Fixes #605
 - Legacy-Id: 2874
2011-03-03 11:35:10 +00:00
Emilio A. Sánchez López 256dd73dd4 Detailed stream info view. Fixes #573
- Legacy-Id: 2758
2011-01-23 10:23:45 +00:00
Emilio A. Sánchez López 049b649eb7 Notify shepherd (and wg chairs and delegates) by email if 'Doc Shepherd Follow-up Underway' is updated. Fixes #561
- Legacy-Id: 2748
2011-01-17 19:49:00 +00:00
Emilio A. Sánchez López 242796253e Form to edit or upload a protocol write-up. See #561
- Legacy-Id: 2745
2011-01-17 18:20:06 +00:00
Emilio A. Sánchez López d0e9d95150 Add protocol writeup model. See #561
- Legacy-Id: 2744
2011-01-17 18:18:59 +00:00
Emilio A. Sánchez López 6729180833 Do not allow access to other wg documents. Fixes #558
- Legacy-Id: 2735
2010-12-24 13:50:09 +00:00
Emilio A. Sánchez López 61697ed096 Improve shepherd assignation by email.
Check if multiple persons have the same email.
  If person exist assign him/her directly.
  If person doesn't exists inform by email: person, wg chairs and secretariat.
  Inform the user what's going on in each step.
See #558
 - Legacy-Id: 2734
2010-12-24 13:38:34 +00:00
Emilio A. Sánchez López 204a4dd72b Allow to edit the workflow used in a wg. Fixes #559
- Legacy-Id: 2733
2010-12-24 10:37:01 +00:00
Emilio A. Sánchez López c5dd835e41 Reorder general shepherd view. See #558
- Legacy-Id: 2732
2010-12-24 10:32:15 +00:00