Commit graph

11546 commits

Author SHA1 Message Date
Henrik Levkowetz 3594283549 Added Jay to the release notification email addressees
- Legacy-Id: 17098
2019-11-23 03:30:36 +00:00
Robert Sparks 61f9fbd8f2 Remove unreachable assertion from slide reordering utility function. Commit ready for merge.
- Legacy-Id: 17097
2019-11-22 17:12:19 +00:00
Sasha Romijn 9e2dfbfe7f Fix review migration issue caused by merge
- Legacy-Id: 17095
2019-11-22 12:40:03 +00:00
Sasha Romijn 10a7bee637 Merge reviewer-queue-management on top of 6.111.1.dev0
- Legacy-Id: 17094
2019-11-22 12:35:28 +00:00
Sasha Romijn b64066b742 Fix LeastRecentlyUsed policy ordering.
- Legacy-Id: 17092
2019-11-22 11:00:58 +00:00
Sasha Romijn 384c0ac7af Improve LeastRecentlyUsed performance with select_related() fix
- Legacy-Id: 17091
2019-11-22 10:05:51 +00:00
Robert Sparks a33ba86452 Add pages to assignment email. Fixes #2838. Commit ready for merge.
- Legacy-Id: 17090
2019-11-21 22:41:11 +00:00
Henrik Levkowetz e1086ed1d1 Merged in [17071] from rjsparks@nostrum.com:
Use doc.name explicitly now that name is no lonker the pk. Pointed out by Sasha in #2050.
 - Legacy-Id: 17089
Note: SVN reference [17071] has been migrated to Git commit f0a5fa6f9e
2019-11-21 18:10:19 +00:00
Sasha Romijn 6bf7d15b70 Add a limit to the update_policy_state_for_assignment loop to prevent
infinite loops, e.g. when a team has only a single reviewer.
 - Legacy-Id: 17087
2019-11-21 12:37:02 +00:00
Sasha Romijn 084978e105 Fix issue where reviewers that left the team would be included in LeastRecentlyUsed
- Legacy-Id: 17086
2019-11-21 11:24:33 +00:00
Sasha Romijn 56003f66d8 Fix #2278 - Notify secretary when a review request is closed.
The assigned reviewer was already notified, but secretaries were always
excluded.

Commit ready for merge.
 - Legacy-Id: 17085
2019-11-21 11:03:21 +00:00
Tero Kivinen 90428d6d5f Moved hard coded defaults for max items to show and days to show to
the settings.py. Commit ready for merge.
 - Legacy-Id: 17083
2019-11-21 07:27:20 +00:00
Henrik Levkowetz 0af4504ea4 Set version info and settings back to development mode
- Legacy-Id: 17081
2019-11-21 06:50:37 +00:00
Henrik Levkowetz c6f0b8a91e Set version info to release version 6.111.0 before branching.
- Legacy-Id: 17079
2019-11-21 06:50:26 +00:00
Henrik Levkowetz b96d153032 Changelog entry for 6.111.0
- Legacy-Id: 17078
2019-11-21 06:50:19 +00:00
Henrik Levkowetz 47551df6be Code coverage data for release 6.111.0
- Legacy-Id: 17077
2019-11-21 06:50:10 +00:00
Henrik Levkowetz 424dcfb42d Some tweaks related to the changes related to #2830.
- Legacy-Id: 17076
2019-11-21 06:01:56 +00:00
Henrik Levkowetz c486ec8003 Fixed naming of staged xml draft submission files and tweaked the arguments for the xml2rfc parser invocation for xml draft submissions. Added some more logging.
- Legacy-Id: 17075
2019-11-21 04:35:31 +00:00
Henrik Levkowetz a0c2bf18b1 Normalized ietf/name/fixtures/names.json
- Legacy-Id: 17074
2019-11-21 03:59:19 +00:00
Henrik Levkowetz f0adebbe70 Merged in [17062] from rjsparks@nostrum.com:
Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830.
 - Legacy-Id: 17073
Note: SVN reference [17062] has been migrated to Git commit 38e73b6f89
2019-11-21 01:32:10 +00:00
Robert Sparks f0a5fa6f9e Use doc.name explicitly now that name is no lonker the pk. Pointed out by Sasha in #2050. Commit ready for merge.
- Legacy-Id: 17071
2019-11-20 16:48:08 +00:00
Sasha Romijn dc9546211f Fix #2061 - Improve "complete review" workflow for secretaries.
When a secretary completes a review, "link to a review message"
is automatically selected, and the first non-reply mail is used to
fill in the review details. The secretary can still modify all details.
The order of fields for secretaries is also modified to fit this workflow.

All cases where "link to review message" is used, by reviewers or
secretaries, now attempt to fill in the "reviewed version" if found
in the email subject.

Commit ready for merge.
 - Legacy-Id: 17070
2019-11-20 14:25:05 +00:00
Sasha Romijn 65d84155b6 Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
Commit ready for merge.
 - Legacy-Id: 17069
2019-11-20 11:29:14 +00:00
Henrik Levkowetz e996fa1037 Merged in [17061] and [17024] from rjsparks@nostrum.com:
Allow slides drag-drop between sessions for groups meeting with multiple sessions. Fixes #2700.
 - Legacy-Id: 17068
Note: SVN reference [17024] has been migrated to Git commit 1016b3a514

Note: SVN reference [17061] has been migrated to Git commit fabd2f6ca5
2019-11-20 10:36:16 +00:00
Henrik Levkowetz 19eb5de983 Merged in [17044] from valery@smyslov.net:
Make it clearer that a chair can't revise materials for a meeting once the proceedings deadline has passed

    Fixes issue #2612.
 - Legacy-Id: 17067
Note: SVN reference [17044] has been migrated to Git commit 182dae28a8
2019-11-20 10:10:31 +00:00
Henrik Levkowetz d5f18de71f - Legacy-Id: 17066 2019-11-20 09:58:11 +00:00
Henrik Levkowetz f09c404a5e Merged in [17037] from kivinen@iki.fi:
Added padding to the <th> column in the unavailability period list of
the reviewers page.
 - Legacy-Id: 17065
Note: SVN reference [17037] has been migrated to Git commit c41e5b5ddb
2019-11-20 09:40:08 +00:00
Henrik Levkowetz 8d5bd97423 Merged in [17036] from housley@vigilsec.com:
Drop old 'slides' section from agenda.json
 - Legacy-Id: 17064
Note: SVN reference [17036] has been migrated to Git commit 71a569f714
2019-11-20 07:44:01 +00:00
Henrik Levkowetz b6a82218f6 Merged in [17035] from housley@vigilsec.com:
Improve performance for some agenda-related pages
 - Legacy-Id: 17063
Note: SVN reference [17035] has been migrated to Git commit ff653634c8
2019-11-20 07:00:46 +00:00
Robert Sparks 38e73b6f89 Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830. Commit ready for merge.
- Legacy-Id: 17062
2019-11-19 21:27:23 +00:00
Robert Sparks fabd2f6ca5 python2->3 adjustments for r17025. Commit ready for merge.
- Legacy-Id: 17061
2019-11-19 18:25:06 +00:00
Sasha Romijn 3db8a0f39d Fix issue where queue might not advance correctly while managing
unassigned reviews, when some reviewers have a skip count.
 - Legacy-Id: 17060
2019-11-19 11:53:12 +00:00
Sasha Romijn b1eb2643f0 Cleanup. Branch ready for merge. (see email)
- Legacy-Id: 17059
2019-11-19 11:14:29 +00:00
Sasha Romijn 0c0980c641 Fix #2420 - Add reviewer back to top of the queue after rejected/withdrawn reviews.
- Legacy-Id: 17058
2019-11-19 10:57:56 +00:00
Henrik Levkowetz e070aacc86 Merged in [17034] from kivinen@iki.fi:
Added two new configuration settings for the review team secretary,
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
 - Legacy-Id: 17057
Note: SVN reference [17034] has been migrated to Git commit b5d864499f
2019-11-19 10:24:50 +00:00
Henrik Levkowetz 6070101b4d Fixed a typo.
- Legacy-Id: 17056
2019-11-19 09:38:29 +00:00
Henrik Levkowetz 6333e7d842 Added an instance of force_text() to ensure non_ascii mail subjects are unicode when used for string interpolation, rather than bytes (which will trigger ascii decode()).
- Legacy-Id: 17055
2019-11-19 09:37:55 +00:00
Henrik Levkowetz 91606bd733 Tweaked the docker-init script.
- Legacy-Id: 17054
2019-11-19 09:16:15 +00:00
Sasha Romijn 8bb6955d47 Fix #2418 - Account for previous rejected reviews in recommended assignment order
- Legacy-Id: 17053
2019-11-18 19:50:33 +00:00
Sasha Romijn abedd2d970 Add support for setting reviewer queue policies per team.
- Legacy-Id: 17052
2019-11-18 17:29:25 +00:00
Ole Laursen 0555879777 Rename Meeting.agenda to Meeting.schedule together with a bunch of
related internal things
 - Legacy-Id: 17051
2019-11-18 17:22:19 +00:00
Sasha Romijn 1e8dda0440 Add request_assignment_next to review overview template, missed in [17048]
- Legacy-Id: 17050
Note: SVN reference [17048] has been migrated to Git commit 554a839864
2019-11-18 16:10:57 +00:00
Sasha Romijn 57ec2b3ef8 Add LeastRecentlyUsed reviewer queue policy.
- Legacy-Id: 17049
2019-11-18 14:47:45 +00:00
Sasha Romijn 554a839864 Fix #2336 - Add "select me next for an assignment".
Reviewers can set this flag in their reviewer settings, which triggers
a mail to be sent to the secretary. They are then kept on top of the
recommended assignment order. This flag is automatically reset when any
assignment is made to the reviewer.
 - Legacy-Id: 17048
2019-11-18 12:30:11 +00:00
Sasha Romijn e188da5214 Remove development print statements and rename policy.
This should now be a finished implementation of
https://trac.tools.ietf.org/tools/ietfdb/wiki/ReviewerQueuePolicy
except for missing LeastRecentlyUsed.
 - Legacy-Id: 17047
2019-11-18 10:40:59 +00:00
Sasha Romijn c5ecfab29f Account for previous reviews of ancestor documents (see [16981])
- Legacy-Id: 17046
Note: SVN reference [16981] has been migrated to Git commit f740adcfc1
2019-11-18 10:27:18 +00:00
Valery Smyslov 182dae28a8 Fixes issue #2612. Commit ready for merge.
- Legacy-Id: 17044
2019-11-18 08:48:15 +00:00
Henrik Levkowetz 624ee270e0 Merged in [17033] from kivinen@iki.fi:
Reviewers page template changes. Changed draft names so they never wrap.
Changed the Unavailability period table so it is much narrower.
 - Legacy-Id: 17043
Note: SVN reference [17033] has been migrated to Git commit 996fcf8a54
2019-11-18 07:38:09 +00:00
Henrik Levkowetz d2ceafb0d1 Merged in [17031] from fenton@bluepopcorn.net:
Add edit button for Secreatriat on concluded groups. Fixes #2781.
 - Legacy-Id: 17042
Note: SVN reference [17031] has been migrated to Git commit da2733610c
2019-11-18 06:05:54 +00:00
Henrik Levkowetz 161ac256cb Added a missing string close.
- Legacy-Id: 17041
2019-11-18 05:46:04 +00:00