Commit graph

68 commits

Author SHA1 Message Date
Henrik Levkowetz 9aeda11a29 Removed some Py2 compatibility decorators.
- Legacy-Id: 17673
2020-04-21 13:54:31 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz 0487cfce3e Changed ReviewerSettings history change-reason field to TextField
- Legacy-Id: 17184
2020-01-06 18:50:36 +00:00
Henrik Levkowetz fcb6806d17 Merged in work from sasha@dashcare.nl on Review Queue Managemnt:
This abstracts queue management, making it possible to implement different
policies for each team. It provides two concrete policies:
RotateAlphabeticallyReviewerQueuePolicy, which rotates an alphabetically
ordered reviewer list with consideration for skip indications, and is the
default policy; and LeastRecentlyUsedReviewerQueuePolicy, a simple
least-recently-used policy.  Also see issues #2721 and #2656.
 - Legacy-Id: 17121
2019-12-04 23:02:52 +00:00
Henrik Levkowetz 7ec09554bb Merged in [17069] from sasha@dashcare.nl:
Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
 - Legacy-Id: 17104
Note: SVN reference [17069] has been migrated to Git commit 65d84155b6
2019-11-26 16:09:43 +00:00
Sasha Romijn 10a7bee637 Merge reviewer-queue-management on top of 6.111.1.dev0
- Legacy-Id: 17094
2019-11-22 12:35:28 +00:00
Sasha Romijn 65d84155b6 Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
Commit ready for merge.
 - Legacy-Id: 17069
2019-11-20 11:29:14 +00:00
Sasha Romijn abedd2d970 Add support for setting reviewer queue policies per team.
- Legacy-Id: 17052
2019-11-18 17:29:25 +00:00
Sasha Romijn 554a839864 Fix #2336 - Add "select me next for an assignment".
Reviewers can set this flag in their reviewer settings, which triggers
a mail to be sent to the secretary. They are then kept on top of the
recommended assignment order. This flag is automatically reset when any
assignment is made to the reviewer.
 - Legacy-Id: 17048
2019-11-18 12:30:11 +00:00
Tero Kivinen b5d864499f Added two new configuration settings for the review team secretary,
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
Commit ready for merge.
 - Legacy-Id: 17034
2019-11-16 09:41:55 +00:00
Henrik Levkowetz 4a486a6c4d Merged in [16891] from sasha@dashcare.nl:
Fix #2198 - Set default start date for UnavailabilityPeriod to today.
 - Legacy-Id: 16910
Note: SVN reference [16891] has been migrated to Git commit a7a2ee4a39
2019-10-22 21:20:51 +00:00
Sasha Romijn a7a2ee4a39 Fix #2198 - Set default start date for UnavailabilityPeriod to today.
Commit ready for merge.
 - Legacy-Id: 16891
2019-10-21 15:16:33 +00:00
Henrik Levkowetz 1656b0012c Merged in [16819] from sasha@dashcare.nl:
Fix #2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to 'requested', which means
it will be shown as an unassigned review in all interfaces.
 - Legacy-Id: 16881
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
2019-10-21 13:45:03 +00:00
Henrik Levkowetz be641ac22a Merged in [16792] from sasha@dashcare.nl:
Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
 - Legacy-Id: 16846
Note: SVN reference [16792] has been migrated to Git commit 486b6daa29
2019-10-08 15:57:28 +00:00
Sasha Romijn fdb4c2a055 Fix #2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to "requested", which means
it will be shown as an unassigned review in all interfaces.

Commit ready for merge.
 - Legacy-Id: 16819
2019-10-03 09:02:34 +00:00
Sasha Romijn 486b6daa29 Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.

Commit ready for merge.
 - Legacy-Id: 16792
2019-10-01 13:01:19 +00:00
Sasha Romijn ec56a03ec6 Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.

Commit ready for merge.
 - Legacy-Id: 16705
2019-09-05 15:02:56 +00:00
Henrik Levkowetz ea8c84d2f6 Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods.
- Legacy-Id: 16455
2019-07-15 18:01:26 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__()
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Robert Sparks 81c5b5091a Made some docevent creation more consistent. Addressed the TODOs added during the refactor.
- Legacy-Id: 16049
2019-03-19 18:48:05 +00:00
Robert Sparks da3174ab68 Improved several views.
- Legacy-Id: 16038
2019-03-18 19:41:07 +00:00
Robert Sparks a4db66564c Checkpoint. Ended up chasing group.views_review before stats.
- Legacy-Id: 16030
2019-03-13 22:02:10 +00:00
Robert Sparks e91d706d5b Checkpointing. This is an incomplete idea. The tests will fail massively.
- Legacy-Id: 15985
2019-03-01 23:19:47 +00:00
Robert Sparks 87dd249415 Cleanup: removed the infrastructure for importing reviews from the old review tool. Commit ready for merge.
- Legacy-Id: 15865
2019-01-03 21:04:13 +00:00
Henrik Levkowetz da380342bc Merged in [15808] from rjsparks@nostrum.com:
Allow notify_ad_when to be blank.
 - Legacy-Id: 15815
Note: SVN reference [15808] has been migrated to Git commit 6d14714f19
2018-12-13 17:22:14 +00:00
Henrik Levkowetz f65fcdd2c4 Merged in [15804] from rjsparks@nostrum.com:
Add history to ReviewerSettings. Fixes #2147.
 - Legacy-Id: 15811
Note: SVN reference [15804] has been migrated to Git commit cb707248e2
2018-12-13 14:29:58 +00:00
Robert Sparks 6d14714f19 Allow notify_ad_when to be blank. Commit ready for merge.
- Legacy-Id: 15808
2018-12-06 21:18:26 +00:00
Robert Sparks cb707248e2 Add history to ReviewerSettings. Fixes #2147. Commit ready for merge.
- Legacy-Id: 15804
2018-12-03 22:23:01 +00:00
Henrik Levkowetz 3b811ecb41 Merged in [15708] and [15730] from housley@vigilsec.com:
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 19:30:32 +00:00
Russ Housley 6067dcbfef Allow a mail alias for all review team secretaries. Fixes #2139. Commit ready for merge.
- Legacy-Id: 15708
2018-11-03 11:55:07 +00:00
Robert Sparks c7bf147b1d Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544. Commit ready for merge.
- Legacy-Id: 15675
2018-11-02 20:18:06 +00:00
Peter E. Yee f4eba7d4df Added optional reviewer unavailability reason support. Fixes issue #2146. Commit ready for merge.
- Legacy-Id: 15342
2018-07-14 18:04:31 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Tero Kivinen 7b4727541a Added closed date column to closed review list. Fixes #2150. Commit ready for merge
- Legacy-Id: 14365
2017-11-11 11:30:00 +00:00
Henrik Levkowetz e19290e98d Merged in [13532] from rjsparks@nostrum.com:
Add an expertise field to reviewer settings. Fixes #2308. ,
 - Legacy-Id: 13539
Note: SVN reference [13532] has been migrated to Git commit d845fba8bec765f2f81ae1a4bbca52c9bceb6e02
2017-06-06 07:54:03 +00:00
Henrik Levkowetz 24c9751df4 Merged in [12596] from rjsparks@nostrum.com:
Show other completed reviews of a document on page showing the status of a review request. Fixes #2083.
 - Legacy-Id: 12605
Note: SVN reference [12596] has been migrated to Git commit 2bad0b0bcd
2016-12-21 19:19:31 +00:00
Robert Sparks 2bad0b0bcd Show other completed reviews of a document on page showing the status of a review request. Fixes #2083. Commit ready for merge.
- Legacy-Id: 12596
2016-12-20 22:22:44 +00:00
Henrik Levkowetz fb891ecf05 Merged in [12521] from rjsparks@nostrum.com:
Removes classes obviated in r12520.  Should be held for release after r12520 is released?
 - Legacy-Id: 12590
Note: SVN reference [12521] has been migrated to Git commit 483d9db895
2016-12-19 21:19:49 +00:00
Henrik Levkowetz 8dcc1d20a2 Merged in [12545] from rjsparks@nostrum.com:
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096.
 - Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
2016-12-15 22:45:25 +00:00
Robert Sparks 483d9db895 Removes classes obviated in r12520. Commit ready for merge. Should be held for release after r12520 is released?
- Legacy-Id: 12521
2016-12-15 03:57:21 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge.
- Legacy-Id: 12520
2016-12-14 23:26:32 +00:00
Henrik Levkowetz 5959b3a46a Added a validator for the reviewer settings' Filter Regexp field, to make sure that we don't later hit exceptions when trying to compile and use the regexp entered.
- Legacy-Id: 12439
2016-12-01 21:30:39 +00:00
Ole Laursen d302875381 Don't limit the team choices for ResultUsedInReviewTeam, otherwise
it's not possible to make a new team
 - Legacy-Id: 12363
2016-11-16 10:42:18 +00:00
Ole Laursen ceec1254f2 Add review team secretary reminders, like those for reviewers
- Legacy-Id: 12283
2016-11-08 16:24:28 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
2016-10-18 10:36:42 +00:00