Commit graph

282 commits

Author SHA1 Message Date
Robert Sparks 1a277b00ec This release improves visibility into where and when the datatracker
sends email. It makes where the datatracker sends email for a given 
action data driven, and it shows where email will be sent for actions
on documents and groups.

Commit ready for merge.
 - Legacy-Id: 10186
2015-10-10 23:08:09 +00:00
Henrik Levkowetz a7667fb29e Merged in branch/amsl/liaisons/6.4.1@10160 from rcross@amsl.com, bringing in the new liaison tool.
- Legacy-Id: 10161
2015-10-09 19:48:21 +00:00
Robert Sparks f0f5a51eb6 (Rocky) merge forward.
- Legacy-Id: 10157
2015-10-09 03:16:24 +00:00
Ole Laursen 40308d429b Summary: Make sure liaison edit page is using full URL to attachments
to not confuse the crawler, and make all liaison pages use the setting
from settings instead of hardcoding it
 - Legacy-Id: 10125
2015-10-02 12:15:57 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger
- Legacy-Id: 10090
2015-09-17 20:03:45 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow
- Legacy-Id: 10040
2015-08-23 18:15:06 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing.
- Legacy-Id: 10035
2015-08-21 16:39:00 +00:00
Robert Sparks 5db9e0d6a8 checkpoint
- Legacy-Id: 10029
2015-08-19 19:53:09 +00:00
Henrik Levkowetz 2fe8dcb4c2 Added a very simple html version of the json API, to make it easier to explore the api manually.
- Legacy-Id: 9991
2015-08-09 16:28:55 +00:00
Henrik Levkowetz cc4190f1f0 Merged in [9781] from lars@netapp.com:
Move a (duplicate) style tag from python into the template CSS.
The liaison manager is horrible in the amount of HTML it includes in python.
 - Legacy-Id: 9799
Note: SVN reference [9781] has been migrated to Git commit d41e3db6fc40dcd5bacb9bf5a17b24f459203bd2
2015-07-18 15:14:16 +00:00
Henrik Levkowetz d713728072 Merged in [9595] from rcross@amsl.com:
Fixed an issue where an authorized individual was unable to add an incoming liaison.  Fixed a problem with the incoming liaison form requiring a deadline date for information only statements.
 - Legacy-Id: 9605
Note: SVN reference [9595] has been migrated to Git commit fca04d97e5
2015-05-06 17:22:13 +00:00
Ryan Cross fca04d97e5 Fixes issue where authorized individual unable to add incoming liaison. Fixes problem with incoming liaison form requiring deadline date for information only statements. Commit ready for merge.
- Legacy-Id: 9595
2015-05-01 18:11:00 +00:00
Henrik Levkowetz acc2c59920 Updated a bunch of links from http: to https: based on a patch from lars@netapp.com.
- Legacy-Id: 9556
2015-04-24 21:47:12 +00:00
Henrik Levkowetz 625347cd2f Merged trunk@9354 to facelift copy
- Legacy-Id: 9357
2015-04-02 06:51:34 +00:00
Henrik Levkowetz 6f285a12f4 Changed the handling of some test directory creation and removal code, to be more consistent. Fixed a problem where a test didn't create and remove a test directory it used.
- Legacy-Id: 9203
2015-03-15 16:01:15 +00:00
Ole Laursen a225fd5069 Make new branch from trunk and merge facelift-r9007 into it, fixing a few merge conflicts
- Legacy-Id: 9072
2015-02-12 10:43:52 +00:00
Henrik Levkowetz 7ecfac6308 Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x.
- Legacy-Id: 9028
2015-02-08 21:16:44 +00:00
Henrik Levkowetz 028b7e315a Reverted to [9025] because commit [9026] failed (it was incomplete with a broken working dir).
- Legacy-Id: 9027
Note: SVN reference [9026] has been migrated to Git commit 4a3749a66b
2015-02-08 20:03:16 +00:00
Henrik Levkowetz 4a3749a66b Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x.
- Legacy-Id: 9026
2015-02-08 19:16:46 +00:00
Henrik Levkowetz 24abae6d26 Added back a modified version of get_fieldsets for liaison forms; in this case the parent class doesn't have this method..
- Legacy-Id: 9011
2015-02-06 12:30:51 +00:00
Ole Laursen 4087a9837f End help_texts with period consistently - the default error rendering in the bootstrap3 library depends on it
- Legacy-Id: 8940
2015-01-28 13:25:21 +00:00
Ole Laursen d0999c8b5e Merge facelift-r8510 branch with trunk. The IPR tool still has some non-facelifted parts and ideosyncracies. Fix a couple of minor bugs (including infamous empty licensing choice) in the IPR code, and port the IPR views to use the render shortcut.
- Legacy-Id: 8896
2015-01-22 17:38:05 +00:00
Henrik Levkowetz 030eb5ff9f Merged in [8733] from olau@iola.dk:\n Summary: Fix old bug in liaison tool - WG discussion lists where being
CC'ed with their list_subscribe rather than list_email address, and
the former is usually a URL, not an email address so cause a
validation error when submitting the statement
 - Legacy-Id: 8868
Note: SVN reference [8733] has been migrated to Git commit 7f1683f093
2015-01-15 20:58:37 +00:00
Henrik Levkowetz f4ce5e033c Fix django 1.7 incompatibilities: Remove get_fieldsets() methods which don't work any more because of Django's move from using its own SortedDict to python's OrderedDict (which always is available in python 2.7 and later). The get_fieldsets() method on Form wasn't available in early versions of django, but since it's provided now, we don't need own code for this method.
- Legacy-Id: 8830
2014-12-22 17:54:32 +00:00
Henrik Levkowetz 770b36d575 Added generated (and sometimes manually tweaked) resources.py files.
- Legacy-Id: 8744
2014-12-14 20:33:25 +00:00
Ole Laursen 373644edf4 Port liaison submission/editing to Bootstrap, revamp the select related widget to use select2 rather than the longish popup table
- Legacy-Id: 8738
2014-12-12 17:59:57 +00:00
Ole Laursen 70ad4d1742 Add liaisons migration to fix the few old statements that do not have a title (add an empty initial migration to make South happy)
- Legacy-Id: 8735
2014-12-12 17:30:55 +00:00
Ole Laursen 7f1683f093 Summary: Fix old bug in liaison tool - WG discussion lists where being
CC'ed with their list_subscribe rather than list_email address, and
the former is usually a URL, not an email address so cause a
validation error when submitting the statement
 - Legacy-Id: 8733
2014-12-12 17:06:05 +00:00
Emilio A. Sánchez López a071764c64 Remove unneeded code. Close #1449
- Legacy-Id: 8109
2014-07-18 17:13:00 +00:00
Emilio A. Sánchez López d4831d4e3a Remove restriction with duplicated titles. See #1449
- Legacy-Id: 8108
2014-07-18 17:12:17 +00:00
Emilio A. Sánchez López c414e14597 Fix reply_to and contact fields in form. See #1435
- Legacy-Id: 8107
2014-07-18 17:09:32 +00:00
Emilio A. Sánchez López 1bcb8ca8c6 Fix when an initial value does not exist. See #739
- Legacy-Id: 8104
2014-07-18 16:18:19 +00:00
Emilio A. Sánchez López 0ccbe9144f Allow multiple related liaisons. Close #739
- Legacy-Id: 8103
2014-07-18 16:15:16 +00:00
Emilio A. Sánchez López 439a3b16c7 Replace reply to field with response contacts and remove old response contact field. See #1435
- Legacy-Id: 8052
2014-07-04 12:07:20 +00:00
Emilio A. Sánchez López 00f6bb6023 Mark liaison statements that need action. See #1434. Close #740
- Legacy-Id: 8051
2014-07-04 11:25:10 +00:00
Emilio A. Sánchez López abb74d9977 Search form for liaison statement list. See #1434
- Legacy-Id: 8049
2014-07-04 09:45:13 +00:00
Emilio A. Sánchez López f72b0a1c93 Add log functionality to migrations. Close #1424
- Legacy-Id: 8048
2014-07-04 09:42:29 +00:00
Emilio A. Sánchez López 6c927f11a1 Liaison data migration to new models. See #1424
- Legacy-Id: 7913
2014-06-13 10:34:14 +00:00
Robert Sparks a3437c0a21 Checks that an email address will survive encoding as part of validating a liaison form. Fixes bug 1410. Commit ready for merge.
- Legacy-Id: 7772
2014-05-22 18:45:59 +00:00
Henrik Levkowetz f6cc509fd6 Merged [7416] from olau@iola.dk: Redo the quickfix to the "Send and Post" button bug (mentioned in
issue #1308) so that we still do the validation correctly, but just
always show the button (even if it's unusable)
 - Legacy-Id: 7599
Note: SVN reference [7416] has been migrated to Git commit 649618626e
2014-04-12 18:28:05 +00:00
Henrik Levkowetz b02b0a96df All tests pass, except for some pyflakes tests which I believe are fixed in trunk.
- Legacy-Id: 7579
2014-04-06 20:04:36 +00:00
Henrik Levkowetz 12f6a55dbd Made ietf/liaisons pyflakes-clean, which also fixed several places the code would crash. The IRTF chair can never have been able to use the liaison tool without getting a server 500 ...
- Legacy-Id: 7471
2014-03-15 18:10:35 +00:00
Ole Laursen 649618626e Redo the quickfix to the "Send and Post" button bug (mentioned in
issue #1308) so that we still do the validation correctly, but just
always show the button (even if it's unusable)
 - Legacy-Id: 7416
2014-03-05 17:39:13 +00:00
Henrik Levkowetz 1c6c3835e8 Typo fixes.
- Legacy-Id: 7254
2014-02-17 12:42:43 +00:00
Henrik Levkowetz f59983ccd1 Merged [7236] from rcross@amsl.com: Ticket #1308: fix Liaison Add CSRF token error and missing Post and Send button.
- Legacy-Id: 7246
Note: SVN reference [7236] has been migrated to Git commit ba6d31fd27
2014-02-16 16:58:54 +00:00
Ole Laursen a656cf8a8b Add .prefetch_related on liaison list page to reduce the number of DB
queries (from 571 to 28)
 - Legacy-Id: 6991
2013-12-18 16:30:18 +00:00
Ole Laursen 7f277a8fbb Replace user.get_profile() with user.person, the profile stuff is deprecated since Django 1.5
- Legacy-Id: 6968
2013-12-18 10:13:40 +00:00
Ole Laursen ea24f5c3bd Import slugify from django.utils.text (introduced in Django 1.5)
- Legacy-Id: 6967
2013-12-18 10:00:58 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
2013-12-17 10:23:42 +00:00
Ole Laursen 84a9f49053 mimetype -> content_type (mimetype is deprecated)
- Legacy-Id: 6945
2013-12-16 16:53:47 +00:00
Ole Laursen e6b12350d2 Port IPR and liaisons feed setup to new feed API too
- Legacy-Id: 6943
2013-12-16 16:33:18 +00:00
Ole Laursen 6a98fec2c3 Use built-in json module in Python instead of simplejson bundled with Django
- Legacy-Id: 6883
2013-12-11 16:59:19 +00:00
Ole Laursen 2c930d0f97 Get rid of remaining use of email_re, use validate_email instead
- Legacy-Id: 6882
2013-12-11 16:47:47 +00:00
Ole Laursen 119d76ae26 Get rid of unused import of old generic view
- Legacy-Id: 6881
2013-12-11 16:44:34 +00:00
Ole Laursen 883853f09c Fix bug, TemplateView takes template_name, not template as parameter
- Legacy-Id: 6880
2013-12-11 16:43:34 +00:00
Ole Laursen c15063f3c2 Adjust the import path for feeds
- Legacy-Id: 6879
2013-12-11 16:40:49 +00:00
Ole Laursen cfa0d47ca0 Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django
- Legacy-Id: 6878
2013-12-11 16:36:09 +00:00
Ole Laursen 449436744e Hide unapproved related liaison statement unless during approval it to prevent dead link
- Legacy-Id: 6839
2013-12-07 13:39:56 +00:00
Ole Laursen ae2b0e2bcc Remove use of group proxies from liaisons app, move proxy_personify_role into liaisons for the time being
- Legacy-Id: 6825
2013-12-07 11:56:32 +00:00
Ole Laursen 54464e6db2 Only show related approved liaisons (dead link found by test crawler)
- Legacy-Id: 6824
2013-12-06 18:44:01 +00:00
Ole Laursen 5f002cf0ac Fix some test errors
- Legacy-Id: 6795
2013-12-05 15:30:17 +00:00
Ole Laursen 4250a95556 Remove proxy layer from liaisons tool, do some minor cleanups of
duplicated code, make sure the custom form widgets escape their input.

There's still a bit of custom proxying going on in the IETFHM class
hierarchy.
 - Legacy-Id: 6794
2013-12-05 13:54:48 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Henrik Levkowetz e4f4467725 Changed tests to use our own subclassed TestCase, and changed almost all fixtures to be perma_fixtures.
- Legacy-Id: 6320
2013-09-30 20:36:20 +00:00
Ole Laursen c191a691e0 Remove "names" fixture from all tests, since it's now loaded once just
after creating the test database through the global test fixture
mechanism - this speeds up multiple tests considerably
 - Legacy-Id: 6305
2013-09-29 17:35:59 +00:00
Henrik Levkowetz 6baea429aa Merged in the nomcom app from ejimenez@yaco.es and esanchez@yaco.es, and accompanying dbtemplate app and the (standard) docutils module. Added some tweaks to get all tests to pass and migrations to run.
- Legacy-Id: 5948
2013-08-06 10:09:29 +00:00
Henrik Levkowetz eb10724796 Changed liaison attachment code to use the correct document type slug.
- Legacy-Id: 5822
2013-07-15 07:14:20 +00:00
Ole Laursen fce33cd034 Don't crash if an attachment has been created already, just reuse it - this case shouldn't actually happen, but apparently sometimes does, probably due to a concurrency issue
- Legacy-Id: 5797
2013-06-21 14:15:30 +00:00
Russ Housley f55195e3d6 Send email to statements@ietf.org when a pending liaison statement gets queued.
- Legacy-Id: 5511
2013-03-09 16:49:38 +00:00
Henrik Levkowetz 327ae948b1 Merged [4866] from rjsparks@nostrum.com:
Show link to pending liaison statements to approve to the secretariat.
This fixes bug #878
 - Legacy-Id: 4943
Note: SVN reference [4866] has been migrated to Git commit d1c27fe57a
2012-10-21 18:00:51 +00:00
Henrik Levkowetz d342eee77f Fixed missing import of Role.
- Legacy-Id: 4891
2012-10-04 12:17:06 +00:00
Robert Sparks d1c27fe57a Show link to pending liaison statements to approve to the secretariat.
This fixes bug #878
 - Legacy-Id: 4866
2012-09-19 22:22:58 +00:00
Henrik Levkowetz c90a26ca50 Merged [4772] from rjsparks@nostrum.com:
Liasion Manager:
* Patch from Yaco to avoid resetting the From field when changing other items on the form
* Gave the secretariat the ability to find/approve any unapproved liaisons
* Changed all the email code to use ietf.mail.utils (and removed the fake-mail concept)

Charter documents and the Agenda pages:
* Added charter documents to iesg/agenda and iesg/agenda/documents
* Synced the ordering of drafts on iesg/agenda and iesg/agenda/documents
* Allow setting a responsible AD for charter documents
* Changed the UI of the charter page to use editlink for changing attributes and buttons for actions (to align with drafts and conflict-reviews)

Moderator package:
* Refactor: Simplified access to the current BallotDocEvent from a Document
* Added functions to BallotDocEvents? to faciliate access to BallotPositionDocEvents?, both for all positions, and current AD postions.
* Updated the moderator package to use the Documents from _agenda_data.
* Added a filter to assist with rendering the moderator package.
* Fixed a bug where different functions in idrfc/views_ballot were using log_state_changed expecting different implementations (a cleanup task should reconcile the _three_ implementations in the codebase of that function).

Cleanup from codesprint:
* Removed some duplication between doc/util and doc/models by moving things into doc/models
* Do not show non-empty discuss text when the ballot position is not blocking
* Added a migration to update non-blocking ballot positions that have non-empty discuss text


DEPLOYMENT NOTES
Please be aware that migration step will take a few minutes to complete.

Fixes bug 865
 - Legacy-Id: 4780
Note: SVN reference [4772] has been migrated to Git commit e5c3a5adc5
2012-08-22 12:34:55 +00:00
Henrik Levkowetz d4e8a98346 Merged [4737] from adam@nostrum.com:
Fixed profile update page to keep Alias table up to date. Also, roles for inactive groups are no longer displayed on the profile page.
 - Legacy-Id: 4776
Note: SVN reference [4737] has been migrated to Git commit 6d87558b06
2012-08-22 10:01:52 +00:00
Robert Sparks fb59abd70d Missed this import
- Legacy-Id: 4762
2012-08-14 21:50:48 +00:00
Robert Sparks 1d7883fc01 Patch from yaco to avoid resetting from field. Gave the secretarait the ability to approve any unapproved liaison. Changed all the email code to use ietf.utils.mail
- Legacy-Id: 4761
2012-08-14 21:37:59 +00:00
Henrik Levkowetz 25210ac328 The call to liaison_manager_sdos() in set_organization_field was missing a Person parameter -- add it.
- Legacy-Id: 4739
2012-07-31 22:24:22 +00:00
Henrik Levkowetz 76594a4c4d Added support for IRTF liaisons.
- Legacy-Id: 4625
2012-07-20 11:36:01 +00:00
Henrik Levkowetz d09d9deba5 Patch from esanchez@yaco.es to add a new IETF liaison-sending entity 'IESG and IAB'.
- Legacy-Id: 4537
2012-06-27 20:20:23 +00:00
Ole Laursen 9f880a3aab Port all still relevant changes between trunk before migration and charter branch to new trunk (mostly various minor template fixes), except 0.24 version of draft.py tool which has some interfaces changes that requires changes in the submit tool
- Legacy-Id: 4341
2012-04-30 13:36:56 +00:00
Ole Laursen bbeaa2d022 Fix bug in liaison form that prevents Secretariat users from posting
statements on behalf of SDO liaison managers in some cases.
 - Legacy-Id: 4311
2012-04-23 20:18:23 +00:00
Ole Laursen 9b4415fe51 Fix problem with direct replyto path in liaison form not using role
emails (reported by Stephanie McCammon).
 - Legacy-Id: 4310
2012-04-23 20:14:04 +00:00
Ole Laursen b418e5d141 Fix missing "return" in liaison proxy, fixes problem with from email
on https://datatracker.ietf.org/liaison/1154/ as reported by Stephanie
McCammon.
 - Legacy-Id: 4307
2012-04-23 17:52:22 +00:00
Henrik Levkowetz 8c9404e15e Guard against trying to use .is_authenticated() on a plain string. The error condition can occur when an exception has been triggered before the auth middleware has run. Related to #767 and #768.
- Legacy-Id: 4053
2012-03-07 09:59:59 +00:00
Ole Laursen dbf5e6ab84 Remove a bunch of old admin files, fix a couple of issues with the new ones, add admin for meeting
- Legacy-Id: 3995
2012-02-28 17:29:52 +00:00
Ole Laursen 980d4e6444 Move new schema models from redesign/ to ietf/
- Legacy-Id: 3855
2012-01-24 17:17:24 +00:00
Ole Laursen fc88964298 Go through the code and replace uses of Person.name with Person.plain_name()
- Legacy-Id: 3849
2012-01-23 20:22:45 +00:00
Ole Laursen e20a96333a Fix bug with attachment URLs, make the proxy slightly more future proof
- Legacy-Id: 3825
2012-01-19 13:03:59 +00:00
Ole Laursen 0dabaf96fb Split database into current and legacy, adding importer to copy reused
tables from legacy to new through Django (with minimal cleaning to
have the import go through) and removing migrations from submit and
liaisons as they interfere with the clean slate of the new database,
adjusting IPR model to add null=True on fields with nulls in the
database
 - Legacy-Id: 3778
2011-12-22 18:34:19 +00:00
Ole Laursen 498dc38507 Port to Django 1.2, replacing built-in patched Django with Django 1.2.7 (with patches applied on top) and replacing South with South 0.7.3
- Legacy-Id: 3773
2011-12-15 14:13:54 +00:00
Ole Laursen f74890aec4 Adjust to handle the slightly revamped email_address() on person
- Legacy-Id: 3750
2011-12-07 19:26:53 +00:00
Ole Laursen f5ae4a0496 Add warning comment
- Legacy-Id: 3709
2011-11-25 15:44:25 +00:00
Ole Laursen ce74be89ef Use the test mode in the mail code when running automated tests instead of
reinventing the wheel in test_runner
 - Legacy-Id: 3620
2011-11-15 11:24:33 +00:00
Ole Laursen 08ff44dd18 Fix bug
- Legacy-Id: 3614
2011-11-14 19:24:17 +00:00
Ole Laursen 5c5d534104 Add person foreign key on Role to link the role and person directly instead of through Email, this will allow us to use non-personal emails on roles
- Legacy-Id: 3418
2011-09-14 14:01:17 +00:00
Ole Laursen c0fc54dcb3 Move proxy utility from liaison to proxy_utils
- Legacy-Id: 3387
2011-08-26 18:33:40 +00:00
Ole Laursen e5968e53e7 Skip race-conditioned test assertion
- Legacy-Id: 3374
2011-08-25 12:23:50 +00:00
Ole Laursen a73051678c Allow more levy in constructing feed URLs, fixes test
- Legacy-Id: 3373
2011-08-25 12:22:14 +00:00
Ole Laursen 8f6403bf2f Add migration for new schema
- Legacy-Id: 3372
2011-08-25 11:44:27 +00:00
Ole Laursen 6556f9815b Fix potential problem with user not having a profile
- Legacy-Id: 3365
2011-08-24 16:23:43 +00:00