altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
10028 commits 1 branch 0 tags 2.6 GiB
Commit graph

58 commits

Author SHA1 Message Date
Robert Sparks ba8b4d3a38 Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233. Commit ready for merge. 
- Legacy-Id: 14549
 2018-01-22 21:43:53 +00:00
Henrik Levkowetz 8786b5c700 Tweaked the error message for review message URLs which cannot be retrieved. 
- Legacy-Id: 14297
 2017-11-03 19:52:34 +00:00
Henrik Levkowetz e79397d6ad Added cleaning of review_url from the review completion form, to make sure it's retrievable. 
- Legacy-Id: 14227
 2017-10-27 05:54:34 +00:00
Henrik Levkowetz 76628be3fd Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync). 
- Legacy-Id: 13479
 2017-05-31 20:59:26 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk 
- Legacy-Id: 13159
 2017-03-28 14:36:40 +00:00
Henrik Levkowetz 487019883f Merged in [13120] from rjsparks@nostrum.com: 
Be more explicit on review message subject lines. Fixes #2103.
 - Legacy-Id: 13153
Note: SVN reference [13120] has been migrated to Git commit da5a2363d6
 2017-03-27 18:12:22 +00:00
Henrik Levkowetz 6ae137944d Merged in [13115] from mahoney@nostrum.com: 
Added draftname to email subject for review request (addresses #2144).
 - Legacy-Id: 13151
Note: SVN reference [13115] has been migrated to Git commit b0cbf9a1c9
 2017-03-27 17:09:48 +00:00
Robert Sparks da5a2363d6 Be more explicit on review message subject lines. Fixes #2103. Commit ready for merge. 
- Legacy-Id: 13120
 2017-03-25 20:45:08 +00:00
Jean Mahoney b0cbf9a1c9 Added draftname to email subject for review request (addresses #2144). Commit ready for merge. 
- Legacy-Id: 13115
 2017-03-25 19:52:15 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code. 
- Legacy-Id: 12978
 2017-03-06 15:08:21 +00:00
Henrik Levkowetz c006c44423 Added setting of document author for review document objects. 
- Legacy-Id: 12957
 2017-03-03 19:40:09 +00:00
Henrik Levkowetz 541085b1a8 Changed email notifications for reviews done to save the message as a Message instance before sending it. Added test code to check that a Message instance is created and matches what goes out. 
- Legacy-Id: 12955
 2017-03-03 15:45:29 +00:00
Robert Sparks 8577a5e84a Use the Role email associated with a reviewer as the From when emailing a review. Fixes #2201. Commit ready for merge. 
- Legacy-Id: 12930
 2017-02-28 18:40:09 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/. 
- Legacy-Id: 12897
 2017-02-22 11:40:55 +00:00
Henrik Levkowetz b8815b00c5 Don't use person.plain_name() when constructing email addresses, as it can contain unicode characters which the current email pipeline can't handle correctly. Use person.plain_ascii() instead (or person.formatted_email()). 
- Legacy-Id: 12865
 2017-02-16 22:59:53 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0 
- Legacy-Id: 12756
 2017-01-30 23:13:02 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets. 
- Legacy-Id: 12711
 2017-01-23 17:38:56 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148. 
- Legacy-Id: 12670
 2017-01-19 14:23:09 +00:00
Robert Sparks 6ca953ae24 Improve the team review content templates. Related to #2075. Commit ready for merge. 
- Legacy-Id: 12595
 2016-12-20 05:38:02 +00:00
Robert Sparks fbd2cd493d Provide templates for directly entered review contents for those teams/review-types that have them. Fixes #2075. Commit ready for merge. 
- Legacy-Id: 12594
 2016-12-19 23:21:11 +00:00
Robert Sparks 10f4892eae Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114. Commit ready for merge. 
- Legacy-Id: 12593
 2016-12-19 22:32:03 +00:00
Henrik Levkowetz ff3638e365 Merged in [12549] from rjsparks@nostrum.com: 
allow ads and secretaries to edit the review request comment. Fixes #2096. (Again).
 - Legacy-Id: 12550
Note: SVN reference [12549] has been migrated to Git commit 32b431cf24
 2016-12-15 23:10:28 +00:00
Henrik Levkowetz 8dcc1d20a2 Merged in [12545] from rjsparks@nostrum.com: 
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096.
 - Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
 2016-12-15 22:45:25 +00:00
Henrik Levkowetz eafa070790 Merged in [12543] from rjsparks@nostrum.com: 
Provide defaults on the Request review form. Fixes #2108.
 - Legacy-Id: 12547
Note: SVN reference [12543] has been migrated to Git commit 870fa59d0c
 2016-12-15 22:10:12 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge. 
- Legacy-Id: 12520
 2016-12-14 23:26:32 +00:00
Henrik Levkowetz 57eb5844e5 Merged in [12489] from rjsparks@nostrum.com: 
Save a new reviewrequest for each team requested in the request form. Fixes #2094.
 - Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
 2016-12-09 12:01:48 +00:00
Henrik Levkowetz 8c7a400683 Merged in [12486] from rjsparks@nostrum.com: 
Fill in CC list defaults for review completion mail. Make the mail come from the reviewer instead of the default secretariat address. Fixes #2078 and #2054.
 - Legacy-Id: 12488
Note: SVN reference [12486] has been migrated to Git commit 062707f51b351e1fcd5d682b23af8c7feeb2442d
 2016-12-08 23:44:50 +00:00
Ole Laursen e171aa657e Add support for revising a closed review, mostly to allow reviewers to 
correct historic entries with missing data
 - Legacy-Id: 12314
 2016-11-09 16:20:58 +00:00
Ole Laursen 3835532d71 Insert iconic link to review statistics from the team pages 
- Legacy-Id: 12215
 2016-10-26 13:35:32 +00:00
Ole Laursen e1f69171b5 xslugify the last name part when constructing a name for the review document 
- Legacy-Id: 12147
 2016-10-14 09:42:34 +00:00
Ole Laursen 5a878981fe Guard against reviewer name not being filled in properly (still 
containing a @) on the complete review page
 - Legacy-Id: 12127
 2016-10-13 15:54:11 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting 
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
 2016-10-06 14:47:41 +00:00
Ole Laursen 0aa8f8a7cc Don't automatically open a new review request if there's already 
another open request in the team
 - Legacy-Id: 12086
 2016-10-05 13:34:15 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review 
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
 2016-10-03 15:52:32 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it 
- Legacy-Id: 11923
 2016-09-06 10:17:12 +00:00
Ole Laursen 8b65c3ad65 Support adding CC's to the complete review email 
- Legacy-Id: 11826
 2016-08-19 16:37:46 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time 
- Legacy-Id: 11801
 2016-08-17 15:10:39 +00:00
Ole Laursen 3ecaf54d51 Pre-fill the review type when requesting a review 
- Legacy-Id: 11798
 2016-08-17 14:42:57 +00:00
Ole Laursen 0e808518bc Make it possible to request review for more than one team at the time, 
auto-select the team for team secretaries/delegates
 - Legacy-Id: 11786
 2016-08-15 16:05:56 +00:00
Ole Laursen 1ae302ca07 Add info about last call/scheduled telechat to the request review page, fix a bug 
- Legacy-Id: 11782
 2016-08-15 10:31:50 +00:00
Ole Laursen 78062adc2f Use request.build_absolute_uri instead of grabbing the domain from the 
current Site in the review code
 - Legacy-Id: 11753
 2016-08-03 15:13:55 +00:00
Ole Laursen 308b854d66 Change the naming algorithm for review documents a bit 
- Legacy-Id: 11635
 2016-07-12 16:02:35 +00:00
Ole Laursen e7ee08069e Swap the sort order on the displayed revisions when completing a review 
- Legacy-Id: 11632
 2016-07-12 15:06:49 +00:00
Ole Laursen db4ea01e20 Take a bunch of factors into account when sorting reviewers for 
assignment to a review request
 - Legacy-Id: 11626
 2016-07-12 13:04:14 +00:00
Ole Laursen 5c8be91b08 Improve review assignment slightly by sorting reviewers by latest 
review - still missing a bunch of factors, and unassignment is now
temporarily gone
 - Legacy-Id: 11531
 2016-07-07 12:17:55 +00:00
Ole Laursen 19fff81a4f Rework closing a review request so the logic is reusable, add the more 
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
 - Legacy-Id: 11520
 2016-07-05 16:05:00 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage 
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
 2016-07-01 16:06:16 +00:00
Ole Laursen c1783d4c8b Bit more polish to the review page 
- Legacy-Id: 11370
 2016-06-14 16:10:22 +00:00
Ole Laursen 0ed3d554d6 Add simple /doc/review-<foo> page for displaying a review, fix a 
couple of bugs
 - Legacy-Id: 11362
 2016-06-14 12:48:08 +00:00