Commit graph

132 commits

Author SHA1 Message Date
Robert Sparks 1295f1f1d2 Change stream state to replaced when an ISE, IAB, or IRTF document is replaced. Fixes #1963. Commit ready for merge.
- Legacy-Id: 15119
2018-05-03 21:21:38 +00:00
Henrik Levkowetz b5d62973c7 Tweaked the error return from Document.get_document_content() to be more helpful during development.
- Legacy-Id: 15034
2018-04-09 14:01:37 +00:00
Henrik Levkowetz db3a4eb20e Changed some instances of .slug to _id
- Legacy-Id: 14985
2018-04-01 18:32:27 +00:00
Henrik Levkowetz 36b5e2ef8e Changed name from .rel to .remote_field for remote accessors.
- Legacy-Id: 14665
2018-02-21 23:56:36 +00:00
Robert Sparks dfc1d2aa9a Warn when putting a draft on a telechat that is so close that directorates will probably not have time to complete a review. Fixes #2381. Commit ready for merge.
- Legacy-Id: 14539
2018-01-18 22:14:30 +00:00
Henrik Levkowetz 97206c6eeb Added user notification about ballots closed automatically when creating a new ballot.
- Legacy-Id: 14471
2017-12-29 15:24:37 +00:00
Henrik Levkowetz 4488fd82a4 Merged in [14467] from housley@vigilsec.com:
Close any previous ballots when a charter goes to Internal Review or Extrernal Review.  Fixes #2421.
 - Legacy-Id: 14470
Note: SVN reference [14467] has been migrated to Git commit de6121c6c1
2017-12-29 13:40:10 +00:00
Russ Housley de6121c6c1 Close any previous ballots when a charter goes to Internal Review or Extrernal Review. Fixes #2421.
- Legacy-Id: 14467
2017-12-28 20:09:56 +00:00
Henrik Levkowetz b12bb3ca3c Guard document replacement following methods against infinite recursion on circular relationships.
- Legacy-Id: 14457
2017-12-22 19:28:59 +00:00
Henrik Levkowetz 1f976da5c1 Third part of document read refactoring, after [14406] and [14410]. This replaces all usage of the non-unicode-aware get_document_content() function with unicode-aware Document.text() or Document.text_or_error() methods. This was triggered by yet another report of unicode content not being shown properly, and should fix all instances of document (drafts, agendas, minutes, etc.) display in the datatracker not handling unicode characters properly.
- Legacy-Id: 14411
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d

Note: SVN reference [14410] has been migrated to Git commit 660c81c272
2017-12-11 16:23:51 +00:00
Henrik Levkowetz 660c81c272 Tweaked the file content read refactoring in [14406] to try latin-1 conversion if unicode doesn't work.
- Legacy-Id: 14410
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d
2017-12-10 17:48:09 +00:00
Henrik Levkowetz 967ece7e7d Started refactoring of reading text from document files (drafts, charters, etc.) in order to normalise on one way of doing this, and making that return unicode rather than undecoded bytes. This is the first step of two, in order to gauge the possible issues and report on discrepancies.
- Legacy-Id: 14406
2017-12-08 21:51:11 +00:00
Henrik Levkowetz abb69338e2 Added a warning message for the user if ballot creation failed due to an already open ballot. This is a bad state, and should prevented by stricter checks before changing state, but is better than the current situation until we decide exactly which checks to implement.
- Legacy-Id: 14382
2017-11-30 16:10:38 +00:00
Henrik Levkowetz cbda2679a9 Removed some unreachable code.
- Legacy-Id: 14150
2017-09-22 14:45:21 +00:00
Robert Sparks 7a11217f6f Refined the state changed email message per discussion on tools-development. Fixes #2116. Commit ready for merge.
- Legacy-Id: 13888
2017-07-15 09:36:29 +00:00
Henrik Levkowetz d2395f9521 Merged in [13832] from rjsparks@nostrum.com:
Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so.
 - Legacy-Id: 13836
Note: SVN reference [13832] has been migrated to Git commit 2c92aa213d
2017-07-11 21:57:01 +00:00
Robert Sparks 2c92aa213d Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so. Commit ready for merge.
- Legacy-Id: 13832
2017-07-11 19:12:21 +00:00
Henrik Levkowetz 900174ae57 Added log.unreachable() calls to some functions believed to be unused.
- Legacy-Id: 13818
2017-07-09 15:01:21 +00:00
Henrik Levkowetz 5e6ecfbaf5 Refined the appearance and wording of the 'Manage document's adoption' button.
- Legacy-Id: 13680
2017-06-19 18:09:33 +00:00
Henrik Levkowetz b42f1cbeb5 Replaced the use of unaccent.asciify(), which has similar functionality to unidecode.unidecode(). Changed the draft parser to work exclusively with unicode text, which both makes the removal of unaccent easier, and takes us closer to Py35 compatibility. Adjusted callers of the draft parser to send in unicode.
- Legacy-Id: 13673
2017-06-18 18:23:18 +00:00
Henrik Levkowetz 1905d25aee Made changes to the can_adopt_draft() logic, to make it possible for a chair of multiple groups to correct the mistake if adoption was made for the wrong group.
- Legacy-Id: 13662
2017-06-17 14:28:13 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Lars Eggert e14dcdac8f Rename crawl_history to make_rev_history, which is more descriptive. Fix #2224
(thanks, Robert!) by generating graphs for the entire revision history of a doc,
both forward and backward in time. Commit ready for merge.
 - Legacy-Id: 13109
2017-03-25 18:52:46 +00:00
Henrik Levkowetz 814e1315b5 Added a new document tab for some documents, showing htmlized drafts and RFCs
using the htmlization code previously developed for tools.ietf.org.  As the
generation of the htmlized page is a bit too costly to do on the fly for
often-referenced drafts and RFCs, the part of each page which contains the
htmlized document is cached on file with a cache time of 2 weeks.

Changed all links which pointed to the htmlized version on tools to instead
point at the datatracker htmlized document.

Tweaked some URLs which didn't permit retrieval of intermediate-rev-charters.

Narrowed the pattern for document names to disallow dots in names, and
instead explicitly enumerated the few historical draftw with dots in the
name.

Added a file-system cache for the htmlized documents, and specified a
max_entries value for caches, overriding the default 300 entries.

Tweaked the code for new author email entries to provide a time if missing
in an updated entry.

Changed links in various email templates which pointed at tools.ietf.org
pages to instead point at datatracker pages, where appropriate.

Changed the search result rows to provide links to both the current meta-
information document pages (with a (i) info symbol) and to the new htmlized
document pages.
 - Legacy-Id: 13040
2017-03-20 14:08:52 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/.
- Legacy-Id: 12897
2017-02-22 11:40:55 +00:00
Robert Sparks 7c182375af Change how we display review text to follow the tecnique used with other large blocks of pasted or imported text (shepherds writeups for instance). Fixes #2104. Commit ready for merge.
- Legacy-Id: 12588
2016-12-19 20:38:51 +00:00
Henrik Levkowetz 2c27d5c611 Moved optional text wrapping before html escaping in markup_unicode(), used by get_unicode_document_content(). Fixes a problem with lines being wrapped when they should not be.
- Legacy-Id: 12480
2016-12-08 16:27:05 +00:00
Henrik Levkowetz e4ce339235 Merged in [12461] from rjsparks@nostrum.com:
Added migration to fetch text from reviews in the mail archives and populate the review documents. Fixes #2064.  Will patch into production.
 - Legacy-Id: 12463
Note: SVN reference [12461] has been migrated to Git commit 63a9599bafdcacf49f1bb374b2156d8473da93d1
2016-12-05 21:03:49 +00:00
Henrik Levkowetz c79b40bc88 Changed the handling of DocEvent 'rev' fields in document history. We should give DocEvent a 'rev' field which is always filled in; the current handling is error prone and much to complicated.
- Legacy-Id: 12433
2016-12-01 13:49:36 +00:00
Henrik Levkowetz b914f46313 Merged in ^/branch/iola/review-tracker-r12128@12397, bringing in the review tool functionality described in RFC7735. This adds the ability to set up review management pages for review teams such as genart, secdir, opsdir, etc.; letting the review team secretaries manage requested and completed reviews; letting the reviewers keep track of and document their reviews, and more. See the RFC for full specification, and the branch commit log for a full commit history.
- Legacy-Id: 12419
2016-11-29 14:54:19 +00:00
Henrik Levkowetz 7f1c1e43f2 Replaced the use of plain DocEvent for submission doc events with a SubmissionDocEvent that carries rev and a FK to submission.
- Legacy-Id: 12275
2016-11-07 18:21:34 +00:00
Ole Laursen 958ba5ba95 Make new branch from trunk and merge in review-tracker-r11921
- Legacy-Id: 12129
2016-10-13 16:38:47 +00:00
Henrik Levkowetz 5089651e17 Don't use EmptyQuerySet directly; return Class.objects.none() instead.
- Legacy-Id: 12013
2016-09-21 11:23:57 +00:00
Henrik Levkowetz 22b2953b18 Merged in ^/branch/scow/track-manual-id-posts-6.31.1.dev0, which provides secretariat support for managing draft submissions outside of the automated datatracker draft submission tool. In addition to making the secreatiat handling of draft submissions that come in by email or other paths easier, it also improves the datatracker submission and document history for these documents.
- Legacy-Id: 11959
2016-09-09 17:00:23 +00:00
Henrik Levkowetz 74f7c5782b Added some basic charting support, using highcharts, and charts showing new-revision timelines for document search results.
- Legacy-Id: 11927
2016-09-06 13:19:45 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it
- Legacy-Id: 11923
2016-09-06 10:17:12 +00:00
Henrik Levkowetz b0906f04af Basic charting of new revision activity for document search results.
- Legacy-Id: 11922
2016-09-06 09:47:22 +00:00
Mike Douglass fa3a34389e Merge forward to 6.31.1.dev0
- Legacy-Id: 11899
2016-08-31 03:00:10 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
2016-07-01 16:06:16 +00:00
Ole Laursen 7cbe36fb62 Implement completing a review with tests. One can currently
enter/upload content or retrieve it from an IETF mailarch archive
through integrated searching support. Support for partial completion.
 - Legacy-Id: 11360
2016-06-14 11:28:53 +00:00
Ole Laursen 5dd079e2f8 Add support for assigning a reviewer to a review request, still some
corners missing. Fix a couple of other issues.
 - Legacy-Id: 11227
2016-05-23 16:42:49 +00:00
Ole Laursen b5ef179a6e Add support for rejecting a review assignment
- Legacy-Id: 11225
2016-05-23 13:57:01 +00:00
Ole Laursen 64a65340a2 Add review tracking models, add a request review page (with test), show
review requests on doc page
 - Legacy-Id: 11206
2016-05-19 15:35:30 +00:00
Henrik Levkowetz 63f5af7e4d Guard against use of nonexistant attribute.
- Legacy-Id: 11166
2016-05-05 14:09:07 +00:00
Robert Sparks f8a28077f5 Add page counts to doc.json. Fixes #1936. Commit ready for merge.
- Legacy-Id: 11122
2016-04-15 13:53:04 +00:00
Henrik Levkowetz c9cb6a6cee Merged in [11083] from stephen.farrell@cs.tcd.ie, with some tweaks:
Assigned default consensus for IETF stream documents, partly fixing #1403 - IRTF/IAB may want more, this just does IETF stream.
 - Legacy-Id: 11089
Note: SVN reference [11083] has been migrated to Git commit 9ca4e98d46
2016-04-03 17:56:33 +00:00
Stephen Farrell c93a31034b assigned default consensus for IETF stream documents partly fixing #1403 - IRTF/IAB may want more, this just does IETF stream. Commit ready to merge.
- Legacy-Id: 11073
2016-04-02 19:11:54 +00:00
Henrik Levkowetz 6c8629c4a9 Merged in [10629] from rjsparks@nostrum.com:
This set of changes focuses on improvements to the nomcom portion of
    the datatracker. 

    These changes:

    - Simplify the nomcom form for comments. Make it more obvious who
      receives mail when a comment is supplied. Fixes #1849.

    - Simplify the nomcom form for nominations. Provide a primary workflow
      where nominations choose an existing Person, and a secondary
      workflow for nominating new people. 

    - Allow nominees to add a comment when accepting or declining a
      nomination. Fixes #1845.

    - Organize the list of nominees on the feedback page. Fixes #1786 and
      #1809.

    - Simplify the mechanisms used to display feedback message counts.

    - Regroup the feedback view to make it easier to see where to spend
      review effort. Fixes #1866.

    - Capture when nomcom members last reviewed feedback for a given
      nominee. Add badges when new feedback is avaliable. Improve the
      layout of the feedback index page. Fixes #1850.

    - Reorganize the tab navigation on the nomcom private pages. Made it
      more obvious when the chair is doing something that only the chair
      gets to see. Fixes #1788 and #1795.

    - Regroup multiselect options to make classifying pending feedback
      simpler. Make the control larger and resizable. Fixes #1495.

    - Simplify the chair's views for editing nominee records. Replace the
      merge nominee form with a request to the secretariat to merge Person
      records. Fixes #1847. 

    - Added merging nominees to the secretariat's persson merging script. 

    - Show information for concluded nomcoms. Close feedback and
      nomination for concluded nomcoms. Fixes #1856.

    - Improve the questionnaire templates, reminding the nominee that
      receiving the questionnaire does not imply they have accepted a
      nomination. Fixes #1807.

    - Remove the description field from Postion. Simplify the Position
      list and the Position edit form. Make the nomcom pages more self
      documenting. Add a page to help nomcom chiars through setting up a
      new nomcom. Fixes #1867 and #1768.

    - Remove the type from the template pathname for the requirements
      templates. Make the requirements views work for both types plain and
      rst. Changed the default type for new nomcom requirement templates
      to rst.

    - Remove 'incumbent' from the models. Fixes #1771.

    - Adjust the models for Nominee and Nomination to better associate
      Nominee objects with Person objects.

    - Remove BaseNomcomForm and the implementation of custom fieldsets.

    - Replace the custom message framework with the django provided
      messages framework.

    - Improve SearchablePersonField to show the primary email address for
      any search result where a name appears more than once.

    - Add the use of factory-boy for generating test data. Normalize
      management of a test directory for test nomcom public keys.
      Significantly improve test coverage of the nomcom related code.
 - Legacy-Id: 10703
Note: SVN reference [10629] has been migrated to Git commit c8bbfbad78
2016-01-15 21:59:49 +00:00