Commit graph

9450 commits

Author SHA1 Message Date
Henrik Levkowetz b14cba5f15 Refactored some document methods to align better with Django's get_absolute_url(), and added Person.get_absolute_uri()
- Legacy-Id: 17189
2020-01-07 13:33:02 +00:00
Henrik Levkowetz b2fc68a978 Merged in [17177] from rjsparks@nostrum.com:
Improve can_ballot. Fixes #2856.
 - Legacy-Id: 17188
Note: SVN reference [17177] has been migrated to Git commit eb69b9e14b
2020-01-07 11:47:03 +00:00
Robert Sparks 42e5163b09 Adds support for dateless milestones. Fixes #2799. Commit ready for merge.
- Legacy-Id: 17185
2020-01-06 20:48:53 +00:00
Henrik Levkowetz 0487cfce3e Changed ReviewerSettings history change-reason field to TextField
- Legacy-Id: 17184
2020-01-06 18:50:36 +00:00
Henrik Levkowetz 2961f4dfba Merged in [17173] from rjsparks@nostrum.com:
Works around a problem with displaying IESG evaluation information for non-approve ballot types. Partially addresses #2851.
 - Legacy-Id: 17183
Note: SVN reference [17173] has been migrated to Git commit 5773d62c1b
2020-01-06 18:48:33 +00:00
Ole Laursen b9e5c9b967 Fix problem with assignments to the same session causing a crash.
Commit ready for merge
 - Legacy-Id: 17181
2020-01-06 17:40:23 +00:00
Russ Housley 3460f9242f Add references and referened-by buttons to each RFC listed on the peron profile page. In addition, changed the buttons on the document references and document referenced-by pages to match the buttons on the main document page (the buttons with the long arrows). Fixes #2854, although it does not include the number of references in the button.
- Legacy-Id: 17179
2020-01-05 17:47:17 +00:00
Russ Housley dd07878bb0 Turn text names into links on the stats pages. Fixes #2854
- Legacy-Id: 17178
2020-01-03 21:50:24 +00:00
Robert Sparks eb69b9e14b Improve can_ballot. Fixes #2856. Commit ready for merge.
- Legacy-Id: 17177
2020-01-03 15:55:48 +00:00
Robert Sparks f71e9995a7 Dateless milestone work. Commit in preparation for merging forward.
- Legacy-Id: 17174
2019-12-24 21:38:26 +00:00
Robert Sparks 5773d62c1b Works around a problem with displaying IESG evaluation information for non-approve ballot types. Partially addresses #2851. Commit ready for merge.
- Legacy-Id: 17173
2019-12-23 19:48:21 +00:00
Henrik Levkowetz 49fc0d7a71 Change varchar(100) to text field for HistoricalReviewerSettings.history_change_reason, to accomodate longer change descriptions.
- Legacy-Id: 17171
2019-12-21 19:56:16 +00:00
Henrik Levkowetz c13852df46 Set version info and settings back to development mode
- Legacy-Id: 17169
2019-12-20 15:45:59 +00:00
Henrik Levkowetz 9c1f619f41 Set version info to release version 6.115.0 before branching.
- Legacy-Id: 17167
2019-12-20 15:44:48 +00:00
Henrik Levkowetz 6482254a03 Merged in ^/branch/akayla/irsg/6.113.1.dev0 from peter@akayla.com.
This provides support for IRSG ballots, similar to the IESG ballots support which has been in use for quite some time.  The IRSG ballots differ from IESG ballots in a number of ways, described in detail in the RFP and SoW for this work and implemented here.
 - Legacy-Id: 17164
2019-12-20 15:00:55 +00:00
Henrik Levkowetz 83de8b9f1e Changed print() statements to syslog logging in a cron-invoked script, to remove non-error output. Fixes issue #2849.
- Legacy-Id: 17163
2019-12-20 14:31:28 +00:00
Henrik Levkowetz bdb35274e9 Set version info and settings back to development mode
- Legacy-Id: 17161
2019-12-18 20:39:52 +00:00
Henrik Levkowetz ea40604644 Set version info to release version 6.114.0 before branching.
- Legacy-Id: 17159
2019-12-18 20:39:25 +00:00
Henrik Levkowetz 1d0e8b7527 Merged in [17148] from rjsparks@nostrum.com:
Only gather addresses instead of name_addrs for the group_secretaries Mailtrigger Recipient. Fixes #2847.
 - Legacy-Id: 17156
Note: SVN reference [17148] has been migrated to Git commit d22da6259b
2019-12-18 18:29:26 +00:00
Henrik Levkowetz 1e1bd2f995 Merged in [17147] from rjsparks@nostrum.com:
Show diff controls for a bis -00 document. Fixes #2846.
 - Legacy-Id: 17155
Note: SVN reference [17147] has been migrated to Git commit 18b8a795ad
2019-12-18 16:33:59 +00:00
Henrik Levkowetz 09557af28d Changed import statements.
- Legacy-Id: 17154
2019-12-18 16:29:11 +00:00
Henrik Levkowetz 06fe583351 Merged /branch/iola/meeting-improvement-r16992@17152 from olau@iola.dk:
* Renamed Meeting.agenda to Meeting.schedule together with a bunch of related
   internal things

* Moved Session.status, .requested, and .requested_by to a new SchedulingEvent.

* Turned sessions into regular sessions and non-sessions into misc.
  sessions in the UI and code to avoid ambiguity.

  This doesn't change the data in the DB except for uses of
  TimeSlotTypeName where 'session' is now 'regular'.
 - Legacy-Id: 17153
2019-12-17 23:43:07 +00:00
Henrik Levkowetz 202d112e0d Added handling for a decoding exception during submission processing.
- Legacy-Id: 17151
2019-12-16 13:32:51 +00:00
Peter E. Yee 8313b0adbf Fixes for questions for you. Does not include any changes in docker/
- Legacy-Id: 17150
2019-12-13 23:01:06 +00:00
Peter E. Yee bb7e504d14 12/13 merged into 6.113.1.dev0 with migration ordering failure
- Legacy-Id: 17149
2019-12-13 19:53:45 +00:00
Robert Sparks d22da6259b Only gather addresses instead of name_addrs for the group_secretaries Mailtrigger Recipient. Fixes #2847. Commit ready for merge.
- Legacy-Id: 17148
2019-12-13 18:37:30 +00:00
Robert Sparks 18b8a795ad Show diff controls for a bis -00 document. Fixes #2846. Commit ready for merge.
- Legacy-Id: 17147
2019-12-12 17:17:51 +00:00
Ole Laursen db232ff71c Fix a few missing uses of session (instead of regular) embedded in CSS classes
- Legacy-Id: 17146
2019-12-11 17:09:08 +00:00
Henrik Levkowetz 0fe23c3ae5 Merged in [17120] from rjsparks@nostrum.com:
Add links to the main website and the mailarchive to the search page.
 - Legacy-Id: 17145
Note: SVN reference [17120] has been migrated to Git commit 54fea0ff57
2019-12-10 18:50:03 +00:00
Ole Laursen 173b242e37 Request regular sessions with type session, fix the request test to
check the type
 - Legacy-Id: 17144
2019-12-09 18:20:27 +00:00
Ole Laursen 60a48d4638 Fix bug introduced in previous commit (exclude became filter)
- Legacy-Id: 17143
2019-12-09 18:09:54 +00:00
Ole Laursen de2b6d4072 Fix use of status still referring to the old attribute in the group
meeting page
 - Legacy-Id: 17142
2019-12-09 18:08:37 +00:00
Henrik Levkowetz cbe8da6a71 Set version info and settings back to development mode
- Legacy-Id: 17135
2019-12-07 19:29:18 +00:00
Henrik Levkowetz f4646f2dd9 Set version info to release version 6.113.0 before branching.
- Legacy-Id: 17133
2019-12-07 19:29:01 +00:00
Ole Laursen 568670c060 Turn sessions into regular sessions and non-sessions into misc.
sessions in the UI and code to avoid ambiguity.

This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
 - Legacy-Id: 17128
2019-12-06 20:02:26 +00:00
Ole Laursen 6920c179cd Fix problem with missing names
- Legacy-Id: 17127
2019-12-06 19:56:03 +00:00
Henrik Levkowetz 6f8263eb6e Added fallback handling from utf-8 to latin1 when reading charter text files.
- Legacy-Id: 17126
2019-12-06 14:17:22 +00:00
Ole Laursen defc50caf5 Fix bug in materials page introduced in previous commit with non-WG groups
- Legacy-Id: 17124
2019-12-05 18:11:24 +00:00
Henrik Levkowetz d9c19449ce Fixed a migration overlap issue.
- Legacy-Id: 17123
2019-12-05 18:04:37 +00:00
Ole Laursen 3957743b85 Move Session.status, .requested, and .requested_by to a new SchedulingEvent
- Legacy-Id: 17122
2019-12-05 12:41:09 +00:00
Henrik Levkowetz fcb6806d17 Merged in work from sasha@dashcare.nl on Review Queue Managemnt:
This abstracts queue management, making it possible to implement different
policies for each team. It provides two concrete policies:
RotateAlphabeticallyReviewerQueuePolicy, which rotates an alphabetically
ordered reviewer list with consideration for skip indications, and is the
default policy; and LeastRecentlyUsedReviewerQueuePolicy, a simple
least-recently-used policy.  Also see issues #2721 and #2656.
 - Legacy-Id: 17121
2019-12-04 23:02:52 +00:00
Robert Sparks 54fea0ff57 Add links to the main website and the mailarchive to the search page. Commit ready for merge.
- Legacy-Id: 17120
2019-12-03 21:57:50 +00:00
Henrik Levkowetz ac6b664fa5 Added normalization of draft title extracted from submitted XML.
- Legacy-Id: 17119
2019-12-02 16:24:51 +00:00
Henrik Levkowetz 0a9cea598e Removed code under docker/ from test coverage calculation.
- Legacy-Id: 17118
2019-12-02 16:23:47 +00:00
Henrik Levkowetz 2749759216 Fixed a backwards compatibiltiy issue for the factoryboy lib and updated a dependency requirement.
- Legacy-Id: 17115
2019-11-30 13:15:44 +00:00
Henrik Levkowetz c99763c3ce Set version info and settings back to development mode
- Legacy-Id: 17113
2019-11-27 23:04:31 +00:00
Henrik Levkowetz e1404ccab5 Set version info to release version 6.112.0 before branching.
- Legacy-Id: 17111
2019-11-27 23:04:19 +00:00
Henrik Levkowetz fc0060079a Merged in [17085] from sasha@dashcare.nl:
Fix #2278 - Notify secretary when a review request is closed.
The assigned reviewer was already notified, but secretaries were always
excluded.
 - Legacy-Id: 17108
Note: SVN reference [17085] has been migrated to Git commit 56003f66d8
2019-11-27 22:19:58 +00:00
Henrik Levkowetz 2c28cb3eb0 When group secretary email addresses occurred in some mailtrigger To: entries, they were given with both name and address parts, while when occurring in Cc: entries, no names were present. Fixed one case of this, and adjusted a test case for consistency. Also added a more general utility function to exclude selected email addresses from email address lists.
- Legacy-Id: 17107
2019-11-27 21:49:22 +00:00
Henrik Levkowetz 5cf2cac8d0 Added support for bibxml3 entries using the traditional reference entry name (with 'reference.I-D....'), instead of just the plain draft name.
- Legacy-Id: 17106
2019-11-27 15:31:40 +00:00
Henrik Levkowetz 2bc5606986 Merged in [17070] from sasha@dashcare.nl:
Fix #2061 - Improve 'complete review' workflow for secretaries.
When a secretary completes a review, 'link to a review message'
is automatically selected, and the first non-reply mail is used to
fill in the review details. The secretary can still modify all details.
The order of fields for secretaries is also modified to fit this workflow.
All cases where 'link to review message' is used, by reviewers or
secretaries, now attempt to fill in the 'reviewed version' if found
in the email subject.
 - Legacy-Id: 17105
Note: SVN reference [17070] has been migrated to Git commit dc9546211f
2019-11-26 20:22:56 +00:00
Henrik Levkowetz 7ec09554bb Merged in [17069] from sasha@dashcare.nl:
Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
 - Legacy-Id: 17104
Note: SVN reference [17069] has been migrated to Git commit 65d84155b6
2019-11-26 16:09:43 +00:00
Henrik Levkowetz 47c3afc328 Added a test for bibtex page content-type.
- Legacy-Id: 17103
2019-11-26 01:34:35 +00:00
Henrik Levkowetz 8364e119bc Fixed an incorrect content_type
- Legacy-Id: 17102
2019-11-25 18:47:58 +00:00
Henrik Levkowetz 6ae270a4d8 Merged in [17097] from rjsparks@nostrum.com:
Remove unreachable assertion from slide reordering utility function.
 - Legacy-Id: 17101
Note: SVN reference [17097] has been migrated to Git commit 61f9fbd8f2
2019-11-23 09:09:24 +00:00
Henrik Levkowetz 87ac08fed2 Merged in [17090] from rjsparks@nostrum.com:
Add pages to assignment email. Fixes #2838.
 - Legacy-Id: 17100
Note: SVN reference [17090] has been migrated to Git commit a33ba86452
2019-11-23 05:48:39 +00:00
Henrik Levkowetz 994e5b36b5 Merged in [17083] from kivinen@iki.fi:
Moved hard coded defaults for max items to show and days to show to
the settings.py.
 - Legacy-Id: 17099
Note: SVN reference [17083] has been migrated to Git commit 90428d6d5f
2019-11-23 04:46:51 +00:00
Robert Sparks 61f9fbd8f2 Remove unreachable assertion from slide reordering utility function. Commit ready for merge.
- Legacy-Id: 17097
2019-11-22 17:12:19 +00:00
Sasha Romijn 9e2dfbfe7f Fix review migration issue caused by merge
- Legacy-Id: 17095
2019-11-22 12:40:03 +00:00
Sasha Romijn 10a7bee637 Merge reviewer-queue-management on top of 6.111.1.dev0
- Legacy-Id: 17094
2019-11-22 12:35:28 +00:00
Sasha Romijn b64066b742 Fix LeastRecentlyUsed policy ordering.
- Legacy-Id: 17092
2019-11-22 11:00:58 +00:00
Sasha Romijn 384c0ac7af Improve LeastRecentlyUsed performance with select_related() fix
- Legacy-Id: 17091
2019-11-22 10:05:51 +00:00
Robert Sparks a33ba86452 Add pages to assignment email. Fixes #2838. Commit ready for merge.
- Legacy-Id: 17090
2019-11-21 22:41:11 +00:00
Henrik Levkowetz e1086ed1d1 Merged in [17071] from rjsparks@nostrum.com:
Use doc.name explicitly now that name is no lonker the pk. Pointed out by Sasha in #2050.
 - Legacy-Id: 17089
Note: SVN reference [17071] has been migrated to Git commit f0a5fa6f9e
2019-11-21 18:10:19 +00:00
Sasha Romijn 6bf7d15b70 Add a limit to the update_policy_state_for_assignment loop to prevent
infinite loops, e.g. when a team has only a single reviewer.
 - Legacy-Id: 17087
2019-11-21 12:37:02 +00:00
Sasha Romijn 084978e105 Fix issue where reviewers that left the team would be included in LeastRecentlyUsed
- Legacy-Id: 17086
2019-11-21 11:24:33 +00:00
Sasha Romijn 56003f66d8 Fix #2278 - Notify secretary when a review request is closed.
The assigned reviewer was already notified, but secretaries were always
excluded.

Commit ready for merge.
 - Legacy-Id: 17085
2019-11-21 11:03:21 +00:00
Tero Kivinen 90428d6d5f Moved hard coded defaults for max items to show and days to show to
the settings.py. Commit ready for merge.
 - Legacy-Id: 17083
2019-11-21 07:27:20 +00:00
Henrik Levkowetz 0af4504ea4 Set version info and settings back to development mode
- Legacy-Id: 17081
2019-11-21 06:50:37 +00:00
Henrik Levkowetz c6f0b8a91e Set version info to release version 6.111.0 before branching.
- Legacy-Id: 17079
2019-11-21 06:50:26 +00:00
Henrik Levkowetz 424dcfb42d Some tweaks related to the changes related to #2830.
- Legacy-Id: 17076
2019-11-21 06:01:56 +00:00
Henrik Levkowetz c486ec8003 Fixed naming of staged xml draft submission files and tweaked the arguments for the xml2rfc parser invocation for xml draft submissions. Added some more logging.
- Legacy-Id: 17075
2019-11-21 04:35:31 +00:00
Henrik Levkowetz a0c2bf18b1 Normalized ietf/name/fixtures/names.json
- Legacy-Id: 17074
2019-11-21 03:59:19 +00:00
Henrik Levkowetz f0adebbe70 Merged in [17062] from rjsparks@nostrum.com:
Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830.
 - Legacy-Id: 17073
Note: SVN reference [17062] has been migrated to Git commit 38e73b6f89
2019-11-21 01:32:10 +00:00
Robert Sparks f0a5fa6f9e Use doc.name explicitly now that name is no lonker the pk. Pointed out by Sasha in #2050. Commit ready for merge.
- Legacy-Id: 17071
2019-11-20 16:48:08 +00:00
Sasha Romijn dc9546211f Fix #2061 - Improve "complete review" workflow for secretaries.
When a secretary completes a review, "link to a review message"
is automatically selected, and the first non-reply mail is used to
fill in the review details. The secretary can still modify all details.
The order of fields for secretaries is also modified to fit this workflow.

All cases where "link to review message" is used, by reviewers or
secretaries, now attempt to fill in the "reviewed version" if found
in the email subject.

Commit ready for merge.
 - Legacy-Id: 17070
2019-11-20 14:25:05 +00:00
Sasha Romijn 65d84155b6 Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
Commit ready for merge.
 - Legacy-Id: 17069
2019-11-20 11:29:14 +00:00
Henrik Levkowetz e996fa1037 Merged in [17061] and [17024] from rjsparks@nostrum.com:
Allow slides drag-drop between sessions for groups meeting with multiple sessions. Fixes #2700.
 - Legacy-Id: 17068
Note: SVN reference [17024] has been migrated to Git commit 1016b3a514

Note: SVN reference [17061] has been migrated to Git commit fabd2f6ca5
2019-11-20 10:36:16 +00:00
Henrik Levkowetz 19eb5de983 Merged in [17044] from valery@smyslov.net:
Make it clearer that a chair can't revise materials for a meeting once the proceedings deadline has passed

    Fixes issue #2612.
 - Legacy-Id: 17067
Note: SVN reference [17044] has been migrated to Git commit 182dae28a8
2019-11-20 10:10:31 +00:00
Henrik Levkowetz f09c404a5e Merged in [17037] from kivinen@iki.fi:
Added padding to the <th> column in the unavailability period list of
the reviewers page.
 - Legacy-Id: 17065
Note: SVN reference [17037] has been migrated to Git commit c41e5b5ddb
2019-11-20 09:40:08 +00:00
Henrik Levkowetz 8d5bd97423 Merged in [17036] from housley@vigilsec.com:
Drop old 'slides' section from agenda.json
 - Legacy-Id: 17064
Note: SVN reference [17036] has been migrated to Git commit 71a569f714
2019-11-20 07:44:01 +00:00
Henrik Levkowetz b6a82218f6 Merged in [17035] from housley@vigilsec.com:
Improve performance for some agenda-related pages
 - Legacy-Id: 17063
Note: SVN reference [17035] has been migrated to Git commit ff653634c8
2019-11-20 07:00:46 +00:00
Robert Sparks 38e73b6f89 Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830. Commit ready for merge.
- Legacy-Id: 17062
2019-11-19 21:27:23 +00:00
Robert Sparks fabd2f6ca5 python2->3 adjustments for r17025. Commit ready for merge.
- Legacy-Id: 17061
2019-11-19 18:25:06 +00:00
Sasha Romijn 3db8a0f39d Fix issue where queue might not advance correctly while managing
unassigned reviews, when some reviewers have a skip count.
 - Legacy-Id: 17060
2019-11-19 11:53:12 +00:00
Sasha Romijn b1eb2643f0 Cleanup. Branch ready for merge. (see email)
- Legacy-Id: 17059
2019-11-19 11:14:29 +00:00
Sasha Romijn 0c0980c641 Fix #2420 - Add reviewer back to top of the queue after rejected/withdrawn reviews.
- Legacy-Id: 17058
2019-11-19 10:57:56 +00:00
Henrik Levkowetz e070aacc86 Merged in [17034] from kivinen@iki.fi:
Added two new configuration settings for the review team secretary,
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
 - Legacy-Id: 17057
Note: SVN reference [17034] has been migrated to Git commit b5d864499f
2019-11-19 10:24:50 +00:00
Henrik Levkowetz 6333e7d842 Added an instance of force_text() to ensure non_ascii mail subjects are unicode when used for string interpolation, rather than bytes (which will trigger ascii decode()).
- Legacy-Id: 17055
2019-11-19 09:37:55 +00:00
Sasha Romijn 8bb6955d47 Fix #2418 - Account for previous rejected reviews in recommended assignment order
- Legacy-Id: 17053
2019-11-18 19:50:33 +00:00
Sasha Romijn abedd2d970 Add support for setting reviewer queue policies per team.
- Legacy-Id: 17052
2019-11-18 17:29:25 +00:00
Ole Laursen 0555879777 Rename Meeting.agenda to Meeting.schedule together with a bunch of
related internal things
 - Legacy-Id: 17051
2019-11-18 17:22:19 +00:00
Sasha Romijn 1e8dda0440 Add request_assignment_next to review overview template, missed in [17048]
- Legacy-Id: 17050
Note: SVN reference [17048] has been migrated to Git commit 554a839864
2019-11-18 16:10:57 +00:00
Sasha Romijn 57ec2b3ef8 Add LeastRecentlyUsed reviewer queue policy.
- Legacy-Id: 17049
2019-11-18 14:47:45 +00:00
Sasha Romijn 554a839864 Fix #2336 - Add "select me next for an assignment".
Reviewers can set this flag in their reviewer settings, which triggers
a mail to be sent to the secretary. They are then kept on top of the
recommended assignment order. This flag is automatically reset when any
assignment is made to the reviewer.
 - Legacy-Id: 17048
2019-11-18 12:30:11 +00:00
Sasha Romijn e188da5214 Remove development print statements and rename policy.
This should now be a finished implementation of
https://trac.tools.ietf.org/tools/ietfdb/wiki/ReviewerQueuePolicy
except for missing LeastRecentlyUsed.
 - Legacy-Id: 17047
2019-11-18 10:40:59 +00:00
Sasha Romijn c5ecfab29f Account for previous reviews of ancestor documents (see [16981])
- Legacy-Id: 17046
Note: SVN reference [16981] has been migrated to Git commit f740adcfc1
2019-11-18 10:27:18 +00:00
Valery Smyslov 182dae28a8 Fixes issue #2612. Commit ready for merge.
- Legacy-Id: 17044
2019-11-18 08:48:15 +00:00
Henrik Levkowetz 624ee270e0 Merged in [17033] from kivinen@iki.fi:
Reviewers page template changes. Changed draft names so they never wrap.
Changed the Unavailability period table so it is much narrower.
 - Legacy-Id: 17043
Note: SVN reference [17033] has been migrated to Git commit 996fcf8a54
2019-11-18 07:38:09 +00:00
Henrik Levkowetz d2ceafb0d1 Merged in [17031] from fenton@bluepopcorn.net:
Add edit button for Secreatriat on concluded groups. Fixes #2781.
 - Legacy-Id: 17042
Note: SVN reference [17031] has been migrated to Git commit da2733610c
2019-11-18 06:05:54 +00:00