Commit graph

15553 commits

Author SHA1 Message Date
Nicolas Giard 522443a5d5
fix: pin django_vite to <3 in requirements.txt 2023-11-15 18:06:38 -05:00
Jennifer Richards 53e232302e
fix: Sort milestones for groups not using dates (#6642)
* fix: Respect uses_milestone_dates == False

* test: Test milestone ordering

* test: Fix temp variable naming
2023-11-15 13:32:27 -06:00
Lars Eggert c36f63baf9
feat: Revamp AD dashboard (#6534)
* fix: Reorder conflict review columns

Fixes #6528

Also remove some redundant computation while I'm here.

* Remove some more stuff that isn't needed

* Progress

* Delivers current functionality

* Add some comments

* Handle expired docs

* Interim commit

* Fix tests

* Cleanup

* More cleanup

* Reduce differences to current view

* Interim commit

* More progress

* Getting close

* Make page functional again

* Remove unused variable

* Suppress mypy warning

* Fix #6553

* Log in as secretary to execute new code, and remove redundant check

* Remove unneeded code

* Fix #6608 by adding link to state description to state heading

* Missed part of this change in last commit.

Also fix an unrelated template nit while I'm here.
2023-11-15 11:25:30 -06:00
depfu[bot] 5eb2f568a0
chore(deps): update all Yarn dependencies (#6613)
* chore(deps): update all Yarn dependencies

* fix: yarn dependencies

---------

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: NGPixel <github@ngpixel.com>
2023-11-13 08:35:12 -06:00
Lars Eggert 5d2ac56858
feat: Now that charters are Markdown, render them as such on charter page (#6628) 2023-11-10 09:26:02 +01:00
depfu[bot] 1b4cb6b235
chore(deps): update all npm dependencies for playwright (#6609)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-11-09 09:08:59 +01:00
depfu[bot] 822068cb3e
chore(deps): update all npm dependencies for dev/coverage-action (#6610)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-11-09 09:08:43 +01:00
Nicolas Giard 5edd06fd04
chore: fix app.Dockerfile 2023-11-08 14:28:44 -05:00
Nicolas Giard fab078d14a
ci: Update base.Dockerfile 2023-11-07 21:26:39 -05:00
Nicolas Giard a49daddfad
ci: Update base.Dockerfile 2023-11-07 21:22:47 -05:00
Nicolas Giard 3ae3f3a7fe
ci: Update base.Dockerfile 2023-11-07 21:19:28 -05:00
Ryan Cross 2974e81624
fix: build proceedings attendee list from MeetingRegistration table. … (#6567)
* fix: build proceedings attendee list from MeetingRegistration table. Fixes #6265

* fix: move participants_for_meeting to meeting.utils

* fix: move test_participants_for_meeting to meeting tests
2023-11-07 13:09:19 +01:00
Paul Selkirk 2bec81da95
fix: Don't include csrf_token in GET-only form (#6549) 2023-11-07 09:50:23 +01:00
Peter Yee f1425e4a52
fix: move meeting management from base Docs to Meeting (#6586)
* fix: move meeting management from base Docs to Meeting

* fix: add permission check for ability to request an interim meeting

* fix: guard against no user being logged in

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-06 17:45:07 +01:00
Tero Kivinen f8a06f663e
fix: Add history entry when approving the slides. (#6588)
* Added history entry when approving the slides.

Also changed os.rename to shutils.move as the submissions and
proceedings are on the separate filesystems on the docker image,
and this same thing might happen in the real environment in the
future.

* Add migrations for the docevents type.
2023-11-06 17:19:32 +01:00
Paul Selkirk b5ee9ec9ab
fix: Don't allow group chair to change group parent (#6496)
* fix: Don't allow group chair to change group parent (#6037)

* test: Fix test_edit_parent_field, add test_edit_parent (whole form)

* test: Verify that the chair can't circumvent the system to change the group parent

* fix: 403 if user tries to edit an unknown or hidden field

* fix: Give edwg GroupFeatures a parent type

This tracks a change that was made directly in the production database
to fix the immediate cause of #6037.

* Empty commit to trigger github unit test
2023-11-05 12:32:03 +01:00
Paul Selkirk a3b4162841
fix: Don't redirect user to the login page when logging in (#6570)
* fix: Don't redirect user to the login page when logging in (#5876)

(Embrace and extend c4bf508cd8.)

* test: Add test case for login button

* refactor: The template filter just strips off a path prefix, so rename/recode accordingly

Also test with a non-trivial redirect target.
2023-11-05 11:09:07 +01:00
Lars Eggert 1df7319e26
fix: Remove time from materials cell (#6584)
Fixes #6542
2023-11-05 11:04:25 +01:00
Lars Eggert 275b3b2b0a
fix: Make authors take at least two lines in HTMLized (#6606)
From 32f8003712

Fixes #6575
2023-11-05 10:40:34 +01:00
Tero Kivinen 2f5bbebf70
Add link to review request page to review result page. (#6596)
Remove link to self on review result page.
2023-11-05 09:57:04 +01:00
dependabot[bot] fcf1a9a40d
chore(deps): bump actions/setup-node from 3 to 4 (#6565)
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-05 09:33:17 +01:00
Tero Kivinen 53d0014826
feat: add "add comment" feature to the review requests. (#6603) 2023-11-05 09:29:25 +01:00
Nicolas Giard d5e4ea8183
ci: Update build-base-app.yml workflow 2023-11-01 14:59:37 -04:00
Robert Sparks aed328b50a
Merge pull request #6527 from larseggert/feat-md-bs
feat: Render markdown agendas with bs5 styles
2023-10-30 13:26:42 -05:00
Lars Eggert d246879069
Fix code review comments 2023-10-27 17:29:09 -07:00
Lars Eggert e65277e6ee
Merge branch 'main' into feat-md-bs 2023-10-28 02:25:39 +02:00
Robert Sparks 4290396db8
ci: merge main to release 2023-10-26 12:06:34 -05:00
Robert Sparks 1130f1f790
Merge branch 'main' into feat-md-bs 2023-10-25 20:46:00 -05:00
Lars Eggert 6d87279895
fix: BCPs can normatively cite all other standards levels (#6530)
* fix: BCPs can normatively cite all other standards levels

Fixes #6524

* Revise the logic and add tests

* Fix bug in truth table
2023-10-25 20:43:05 -05:00
Lars Eggert 5f8bf4b6f7
Merge branch 'main' into feat-md-bs 2023-10-25 20:23:33 +02:00
Ryan Cross 601ab53db9
refactor: remove secr IPR admin link (#6540) 2023-10-25 12:45:22 -05:00
Jennifer Richards be4a6ef6f5
chore: Revert agenda editor font change (#6538)
* Revert "fix: Change some colors to make agenda tool work in dark mode (#6428)"

This reverts commit 699a8e2d9e.

* Revert "Revert "fix: Change some colors to make agenda tool work in dark mode (#6428)""

This reverts commit 5adafac4cb7896e9dd309a3385ec9aab5035e7d3.

* chore: Revert only font-family change

* chore: Add comment to ietf.scss
2023-10-25 12:43:17 -05:00
Lars Eggert c2a44dbad0
fix: Use d-none class instead of hide (#6535)
Fixes #6531
2023-10-25 08:37:14 -05:00
Lars Eggert 888a4f2efe
fix: Add link to session to material metadata (#6536)
* fix: Add link to session to material metadata

Fixes #6533

* Fix CI
2023-10-25 08:28:50 -05:00
Lars Eggert e7639e94ed
Merge branch 'main' into feat-md-bs 2023-10-24 19:49:17 +02:00
Lars Eggert fd03ab13d7
Small fixes 2023-10-23 17:44:12 -07:00
Martin Thomson 902d657c9f
Icons for sidebar collapse/expand (#6465)
This change uses [bi-arrow-bar-left](https://icons.getbootstrap.com/icons/arrow-bar-left/) and [bi-arrow-bar-right](https://icons.getbootstrap.com/icons/arrow-bar-right/).  This is a minimal change, but changes from .

I started off with just changing the open one to use [bi-layout-sidebar](https://icons.getbootstrap.com/icons/layout-sidebar/), which is the mirror of the collapsed icon.  I also considered changing the icon that shows when collapsed to [bi-layout-sidebar-text-reverse](https://icons.getbootstrap.com/icons/layout-text-sidebar-reverse/).  Both of those seemed less clear than these.

Note that the "shown"/"collapsed" classes on these elements appear to be reversed.  I didn't touch that.
2023-10-23 18:40:24 -05:00
Lars Eggert 0a4fc286cd
fix: More darkmode fixes (#6477)
* fix: More dark mode fixes

This first commit increases contrast of the leftmenu text.

* Fix own ballot position highlight in dark mode

* Fix dark mode axis color in timeline diagrams

* Enable highcharts dark mode

* Fix template

* Properly import our customized bs5 everywhere

* Fix #6499

* Use bs5 color for border-left

* Remove superfluous load
2023-10-23 18:38:35 -05:00
Lars Eggert 699a8e2d9e
fix: Change some colors to make agenda tool work in dark mode (#6428)
This is not a proper fix. This tool doesn't bootstrap much and is
hence full of custom CSS. Really needs a redo.
2023-10-23 18:34:59 -05:00
Lars Eggert caa4e837ad
fix: Remove menu item for outdated tutorials list (#6521)
Fixes #6473

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-10-23 18:32:08 -05:00
Ryan Cross c9e14cb45a
refactor: remove unused physical bluesheet functions (#6525)
* refactor: remove unused secr/console app

* refactor: remove unused secr/areas app

* refactor: remove unused physical bluesheets functions

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-10-23 18:31:47 -05:00
depfu[bot] 1f89174577
chore(deps): update all npm dependencies for playwright (#6515)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-10-23 15:32:41 -05:00
depfu[bot] 7f7f4391fd
chore(deps): update all npm dependencies for dev/deploy-to-container (#6516)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-10-23 15:10:17 -05:00
depfu[bot] 86094bdef3
chore(deps): update all npm dependencies for dev/diff (#6517)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-10-23 15:09:57 -05:00
depfu[bot] 8bdb653b1a
chore(deps): update all npm dependencies for dev/coverage-action (#6518)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-10-23 15:09:22 -05:00
Lars Eggert 3bfe90e755
fix: Add "numeric" option to localecompare (#6520)
Fixes #6493
2023-10-23 15:08:56 -05:00
depfu[bot] 0e46ca4638
chore(deps): update all Yarn dependencies (#6522)
* chore(deps): update all Yarn dependencies

* chore: fix yarn cache

---------

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: NGPixel <github@ngpixel.com>
2023-10-23 15:07:33 -05:00
Jennifer Richards 1efb19c8ec
chore: Update django-oidc-provider patch (#6526)
* chore: Fix line numbers in patch

File changed with django-oidc-provider v0.8.1

* chore: Limit django-oidc-provider version
2023-10-23 14:13:20 -05:00
Lars Eggert f5507daef1
feat: Render markdown agendas with bs5 styles
So that the look is consistent with the rest of the datatracker.
2023-10-23 18:55:31 +03:00
Jennifer Richards dc14308700
refactor: Drop submission validation via libmagic (#6500)
* refactor: Update parsers/base.py for Python3

* style: Black

* refactor: Remove mime type check from FileParser

* refactor: Validate that submission is UTF-8

The mime check distinguished us-ascii from UTF-8,
but as far as I can tell the code relying on it
treated both as equally valid.

* feat: Clear error when file is not valid XML

* chore: Remove unused import

* test: Update tests to match changes

* fix: Count bytes starting from 1

* test: Add tests of FileParser validations

* fix: Fix / simplify regexp

* test: Test error caused by bad XML submission

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-10-23 10:00:04 -05:00