Lars Eggert
26f34f4aef
Merge branch 'main' into fix-6343
2023-09-22 08:32:17 +03:00
Robert Sparks
48cb06d20d
fix: subseries specific docevent types. get_or_create contain relationship. remove spurious "
2023-09-21 16:38:41 -05:00
Jennifer Richards
b08d26d36e
feat: Scout monitoring for celery workers ( #6342 )
...
* feat: Scout APM instrumentation for celery
* fix: Remove guard that caused problem on production
2023-09-21 14:43:19 -05:00
Robert Sparks
0390f1868f
feat: subseries
2023-09-21 12:54:17 -05:00
Lars Eggert
e76201103f
Fix pyflake
2023-09-21 18:15:12 +03:00
Lars Eggert
9391985cbb
fix: Add link to public pages to private NomCom pages
...
Fixes #6343
Also fix highlighting of the active tab in the nav tab bar while I'm here.
2023-09-21 17:20:38 +03:00
Jennifer Richards
f15960d32d
Merge pull request #6328 from rjsparks/dochistory_rfcnumber
...
fix: populate rfc_number on DocHistory with type_id rfc
2023-09-15 20:41:43 -03:00
Jennifer Richards
f4629bc750
Merge pull request #6326 from rjsparks/email_expansions
...
fix: tune mailtrigger recipients and set relevant expansions for rfcs
2023-09-15 20:12:39 -03:00
Robert Sparks
a39a058a01
fix: populate rfc_number on DocHistory with type_id rfc
2023-09-15 17:33:05 -05:00
Robert Sparks
88e66048da
fix: make Was link go to the right place. Remove unreachable code.
2023-09-15 16:49:21 -05:00
Robert Sparks
bc177b08ea
chore: black
2023-09-15 16:15:47 -05:00
Robert Sparks
edadd99044
fix: tune mailtrigger recipients and set relevant expansions for rfcs
2023-09-15 16:02:08 -05:00
Robert Sparks
e0e647fa75
chore: repair merge damage
2023-09-15 13:59:19 -05:00
Robert Sparks
4811374014
chore: reorder migrations ( #6325 )
2023-09-15 13:10:19 -05:00
Robert Sparks
621528ad03
ci: Merge branch 'main' into feat/rfc
2023-09-15 11:48:44 -05:00
Lars Eggert
303ff70e64
fix: Linkify email address lists one-by-one ( #6315 )
...
* fix: Linkify email address lists one-by-one
Seems to work around a bug in mozilla/bleach.
Fixes #6307
* Cosmetic change
* Fix test
2023-09-15 10:45:58 -05:00
Jennifer Richards
b635045aab
Merge pull request #6309 from rjsparks/crawl-fixes
...
fix: missed docalias artifact removal. Better use of became_rfc.
2023-09-15 11:55:27 -03:00
Robert Sparks
4ddf132efb
fix: remove leftover docalias detritus
2023-09-15 09:51:15 -05:00
Robert Sparks
20f427e013
chore: remove unused view ( #6304 )
...
* chore: remove unused view
* chore: deflake
* chore: deflake
2023-09-14 17:10:26 -05:00
Robert Sparks
536c1fb6fc
fix: missed docalias artifact removal. Better use of became_rfc.
2023-09-14 16:43:26 -05:00
Robert Sparks
42c4c275d2
fix: move fewer docevents
2023-09-14 12:07:09 -05:00
Tero Kivinen
a3fb6a49a3
fix: add review team setting allowing reviewers to reject assignments past the deadline ( #5418 )
...
* Added a new review team setting
allow_reviewer_to_reject_after_deadline that will allow rejecting
review requests, even after the deadline is past. Also modified that
the secretary, or whoever manages the reviews is always allowed to
reject the review regardless of the deadline as he/she could change
the deadline anyways.
* Fixed but in view_reviews (wrong variable name), added more test
cases to the test_reviews.py for different reject cases.
* test: More thoroughly exercise assignment rejection
* chore: Renumber migration
* test: Unrelated user cannot reject assignments
---------
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-09-14 11:48:28 -05:00
Robert Sparks
92ea5a6a89
fix: correct cache variable assignment
2023-09-13 15:46:21 -05:00
Lars Eggert
d3d2f0d35f
fix: Enable js functionality on sortable tables ( #6301 )
...
Fixes #6263
Also fix the non-js "untrack_document" page while I'm here.
2023-09-13 15:31:01 -05:00
Jennifer Richards
69fd3a059e
fix: Validate string before calling int() ( #6268 )
2023-09-13 15:29:16 -05:00
Robert Sparks
a571151b03
fix: allow looking at slide revisions when the slides doc name starts with rfc
2023-09-13 14:17:27 -05:00
Robert Sparks
ececc456ab
fix: repair broken html
2023-09-13 14:10:29 -05:00
Robert Sparks
3a733a36db
fix: memoize became_rfc. Address review comments.
2023-09-13 14:07:40 -05:00
Jennifer Richards
8bc4507def
feat: Give AD the action in ad-f-up doc state ( #6272 )
...
* refactor: Add helper class to compare tag changes
* feat: Give AD the action in ad-f-up state
* refactor: Remove unnecessary check
* refactor: Reorganize update_action_holders()
* refactor: Remove unnecessary guard
* test: Update test for new AD handling
* test: Update another test
* test: Test ad-f-up effect on action holders
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-09-12 09:44:33 -05:00
Robert Sparks
bf50f88863
chore: remove debug
2023-09-12 09:37:13 -05:00
Robert Sparks
a307e0616c
chore: Merge branch 'feat/rfc' into rfc_htmlized
2023-09-12 09:33:45 -05:00
Robert Sparks
0c85c4169d
fix: repairs to the timeline graphic
2023-09-12 09:23:01 -05:00
Robert Sparks
5bbea70cb0
fix: repair many revision related issues with the main and htmlized views
2023-09-12 08:55:38 -05:00
Robert Sparks
be77cc9226
fix: correct missed replumbing of iprdisclosurebase
2023-09-12 08:54:11 -05:00
Robert Sparks
72d44d56c4
chore: black
2023-09-12 08:52:15 -05:00
Robert Sparks
b58ddd7674
fix: move rfc dochistory objects to rfc document objects
2023-09-12 08:51:17 -05:00
Jennifer Richards
18a1af22f8
fix: Reject nul characters in ipr search parameters ( #6292 )
...
* fix: Reject nul characters in ipr search parameters
Really ought to rework this as a form, but in the meantime
this should prevent 500s. Could probably reduce the number
of places we check the value.
* fix: Guard against absent parameters
* fix: Remove stray junk
* fix: Use correct response code (400, not 405)
* test: Test handling of null chars in IPR search
* refactor: Simplify branch statements
This helps my code validator see that "start" is
always set.
2023-09-12 08:32:16 -05:00
Paul Selkirk
febdeff85f
feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy ( #6231 )
...
* feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6088 )
* chore: Move PUBLISH_IPR_STATES from settings_local to settings
* fix: Add migration for removed_objfalse in IprEventTypeName
* fix: De-conflict migration
* fix: De-conflict migration
* style: Move PUBLISH_IPR_STATES ahead of not-production block
2023-09-11 13:14:46 -05:00
Robert Sparks
6b6c881353
fix: construct double-submit test correctly ( #6168 )
...
* fix: construct double-submit test correctly
* chore: remove unused import
2023-09-08 13:02:18 -05:00
Robert Sparks
7391ea7239
fix: rationalize document_rfc.html and the view driving it
2023-09-07 13:11:33 -05:00
Robert Sparks
7f074bf37f
fix: avoid redirects in mailarchive links ( #6282 )
2023-09-07 10:40:20 -05:00
Robert Sparks
d0bac8913d
fix: use type instead of state in templates
2023-09-05 18:04:16 -05:00
Paul Selkirk
cd56d43736
fix: Allow secretariat to change the state of a dead draft ( #6253 )
...
* fix: Allow secretariat to change the state of a dead draft (#6051 )
* refactor: Move the secretariat-can-edit-dead-state enablement to the template to limit side-effects.
* style: Correct whitespace to fully revert file
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-09-05 12:58:56 -05:00
Lars Eggert
fb4002dbbd
fix: Don't show deferred I-Ds in AD's missing ballot list ( #6162 )
...
* fix: Don't show deferred I-Ds in AD's missing ballot list
Fixes #6152
* Address code review comments
2023-09-05 12:16:33 -05:00
Robert Sparks
e0f27b9d52
ci: merge branch 'main' into feat/rfc
2023-09-05 12:02:07 -05:00
Robert Sparks
3c1fc3c0f9
chore: use factory-boy 3.3 ( #6269 )
2023-09-05 09:54:30 -05:00
Robert Sparks
87f0781ff3
chore: make some old things kept for documentation a little safer ( #6260 )
...
* chore: make some old things kept for documentation a little safer
* fix: sh syntax
2023-09-01 14:34:49 -05:00
Robert Sparks
f2dc32a310
chore: remove unused scipts from ietf/bin ( #6259 )
2023-09-01 14:31:23 -05:00
Robert Sparks
b5bf6789da
chore: remove one shot iab artifact importers ( #6258 )
2023-08-31 17:14:18 -05:00
Robert Sparks
c8c1ebdf12
chore: remove unnecessary .gitignore files ( #6262 )
2023-08-31 17:12:01 -05:00
Robert Sparks
232536c593
fix: migration order and names fixture
2023-08-31 13:12:21 -05:00
Robert Sparks
4b778c155d
fix: reorder name migrations
2023-08-31 08:49:09 -05:00
Robert Sparks
c2c48ff08d
chore: repair more damage
2023-08-30 17:32:55 -05:00
Robert Sparks
fda5edf256
chore: clean up after cleanup
2023-08-30 17:14:13 -05:00
Robert Sparks
ad1aabb4ad
chore: repair merge damage and adjust new files
2023-08-30 17:12:31 -05:00
Robert Sparks
f9c9644263
chore: merge main and fix conflicts
2023-08-30 16:35:20 -05:00
Robert Sparks
3efd44fa2f
chore: remove unnecessary list construction
2023-08-30 11:24:52 -05:00
Robert Sparks
852f9d90b9
feat: move IAB appeals into the datatracker ( #6229 )
...
* feat: basic models for appeals
* fix: modify appeal model to point to group
* fix: explicit date on Appeal objects
* feat: appeals importing management command
* feat: display appeals
* feat: admin for appeals
* fix: limit admin contentype choices
* feat: tastypie resources
* feat: factories and tests
* chore: update group migration
* fix: remove charset from pdf content type
* test: unittest download_name
* fix: admin for new name
2023-08-29 14:07:30 -05:00
Jennifer Richards
7f8cbaa211
feat: Distinguish failed from not-applied checkers ( #6220 )
...
* feat: Distinguish failed from not-applied checkers
* refactor: Only return applied checks from latest_checks()
* refactor: Use latest_checks() in submission_status view
* chore: Fix incorrectly phrased comment
* test: Test submission check summary
2023-08-28 11:06:35 -05:00
Jennifer Richards
6adead355d
fix: Improve status page for canceled submissions ( #6221 )
...
* fix: Show quieter alert for metadata error in canceled submission
* fix: Suppress metadata errors and show warning for canceled submissions
* style: Fix indentation in HTML
* fix: Give better notice of a processing error
2023-08-26 15:58:40 -05:00
Jennifer Richards
c65cd20f0c
fix: Move submission files using shutil.move() ( #6217 )
...
* fix: Use shutil.move in move_files_to_repository()
* refactor: Use shutil.move in rename_submission_files()
2023-08-25 11:47:28 -05:00
Lars Eggert
b304e07008
fix: Change color of error reporting link in menu bar ( #6213 )
...
Fixes #6179
2023-08-25 09:21:07 -05:00
Lars Eggert
16c250fa33
fix: Add theme switcher to document view ( #6202 )
...
* fix: Add theme switcher to document view
And reduce duplication in the page structure while I'm here.
Fixes #6200
* Fix tests
2023-08-24 13:46:03 -05:00
Jennifer Richards
2bcb2c04f9
chore: Fix (mostly harmless) quoting error ( #6209 )
2023-08-24 13:45:17 -05:00
Robert Sparks
bce70e74bc
feat: import iab agendas from iab website ( #6197 )
...
* feat: import iab agendas from wiki
* chore: adjust command help text
2023-08-24 11:53:10 -05:00
Lars Eggert
06d87b4097
fix: Reword I-D announcement emails to make first sentence more useful ( #6193 )
...
Fixes #6092
2023-08-24 08:19:30 -05:00
Lars Eggert
a8e904400d
fix: Color agenda table row based on AD position ( #6192 )
...
Fixes #6184
2023-08-23 09:43:03 -05:00
Robert Sparks
8ad4ab0a8d
fix: unrepair a migration
2023-08-22 08:50:22 -05:00
Robert Sparks
9649004159
chore: remove unused imports
2023-08-19 13:22:41 -05:00
Robert Sparks
7f229c9755
chore: add copyright
2023-08-19 13:22:14 -05:00
Robert Sparks
b646e183fe
chore: update names fixture
2023-08-19 13:19:54 -05:00
Robert Sparks
d801716e47
fix: include migrations
2023-08-19 13:19:30 -05:00
Robert Sparks
96fae0c436
feat: remove DocAlias
2023-08-19 13:17:21 -05:00
Robert Sparks
94e9f433f6
chore: moved away more legacy code
2023-08-19 13:11:51 -05:00
Robert Sparks
5489fea9f7
fix: untangle stats and iana sync
2023-08-19 12:58:01 -05:00
Robert Sparks
1ae0c0b838
fix: follow became_rfc in ipr searches
2023-08-19 09:33:04 -05:00
Robert Sparks
05b71bb50c
chore: flip sense of all_ids rfc dict
2023-08-18 18:10:10 -05:00
Robert Sparks
c0e2bb4521
chore: flip sense of all_ids2 rfc dict
2023-08-18 18:07:29 -05:00
Robert Sparks
63c3f23767
chore: fix test construction
2023-08-18 17:35:54 -05:00
Robert Sparks
c631cb17cb
chore: more bulk change damage repair
2023-08-18 16:48:01 -05:00
Robert Sparks
90ca856afa
chore: repair damage from bulk changes
2023-08-18 13:44:05 -05:00
Lars Eggert
aa955f0e9b
fix: Replace deprecated bootstrap CSS classes with 5.3 ones ( #6166 )
...
* fix: Replace deprecated bootstrap CSS classes with 5.3 ones
* Fix test
* Remove debug print
2023-08-18 13:41:02 -05:00
Robert Sparks
823281ba6c
chore: first pass at clearing out canonical_name
2023-08-18 10:59:55 -05:00
Robert Sparks
53be2c3793
feat: require draft revisions in ipr disclosures. Explain missing ones. ( #6160 )
...
* feat: require draft revisions in ipr disclosures. Explain missing ones.
* chore: update copyrights
* chore: address review comments
* fix: draft should be Internet-Draft
* test: cover single revision case
2023-08-18 07:47:12 -05:00
Robert Sparks
3b067a468a
fix: name corrections, flake removal
2023-08-17 16:34:26 -05:00
Robert Sparks
22dc5b6dc7
chore: cleanup typos
2023-08-17 16:24:22 -05:00
Robert Sparks
7441413032
chore: merge in and adjust rfceditor.py changes
2023-08-17 16:03:17 -05:00
Robert Sparks
9b59717b39
Merge branch 'feat/rfc' into nomoredocalias
2023-08-17 15:55:49 -05:00
Jennifer Richards
4706ac2a37
fix: Restore old handling of draft-iesg state
...
Missing state -> idexists, idexists -> idexists, anything
else becomes pub.
2023-08-16 11:53:58 -03:00
Robert Sparks
383899c5c4
chore: checkpoint: docalias mostly removed
2023-08-15 16:49:17 -05:00
Robert Sparks
4946430159
chore: checkpoint: halfway through removing docalias
2023-08-15 09:11:53 -05:00
Paul Selkirk
73c2a6aa8b
feat: Download questionnaire responses ( #6111 )
...
* feat: Download questionnaire responses (#4981 )
* style: Expand "questio" to "questionnaire"
2023-08-14 16:06:23 -05:00
Jennifer Richards
80a361c3c8
test: Check that no logs are emitted in test_rfc_index
2023-08-14 14:27:26 -03:00
Jennifer Richards
b565f104d8
test: Don't mix stream states in test_rfc_index()
...
Make the test a better simulation of actual practice.
2023-08-14 14:09:37 -03:00
Jennifer Richards
cf470a4680
fix: Use correct stream slugs
2023-08-14 14:08:48 -03:00
Jennifer Richards
06adb25e43
fix: Set draft-iesg state to "pub" when a draft is published
2023-08-14 13:37:24 -03:00
Jennifer Richards
92460319d1
refactor: Refactor handling of draft stream states
2023-08-14 13:06:48 -03:00
Jennifer Richards
f9ca1bc9d6
test: Test behavior of verified-errata tag
...
Also add comments flagging the near-miss between doc-id
and RFC number in the test_rfc_index() test data. It's
unclear whether these were intended to match, but the
test was self-consistent so I am not changing it.
2023-08-14 12:15:09 -03:00
Robert Sparks
e1c1daa13b
fix: allow rswg as a scheduling conflict ( #6133 )
2023-08-12 13:03:08 -05:00
Robert Sparks
f30d348765
fix: link from session details to group about ( #6134 )
2023-08-12 13:02:52 -05:00