Robert Sparks
d7362609b8
fix: re-align html and view for submit-to-iesg. Fixes #3913 ( #3914 )
2022-04-29 14:55:21 -05:00
Robert Sparks
86923dfe96
chore: update dependency requirements ( #3904 )
...
* chore: cleanup requirements.txt. Unpin factory-boy, ignoring resulting mypy complaints.
* chore: remove the upper limit as many dependencies as possible
* chore: remove unintended bookmark
* chore: normalize spaces before comments
* chore: improve comment explaining pinned Tastypie
* chore: shift dependencies minimum version requirements forward
2022-04-28 11:06:17 -05:00
Jennifer Richards
4e4569acc1
fix: use ModelMultipleChoiceField for 'bethere' when hidden ( #3894 )
...
The select2-based fields do not behave well on the SubmissionForm when
hidden=True. The ModelMultipleChoiceField is enough for this case.
2022-04-26 16:53:45 -05:00
Lars Eggert
53a2b61bbc
feat: Make the "report a bug" links more visible ( #3883 )
...
* feat: Make the "report a bug" links more visible
Also rework the page footer somewhat, while we're here.
* Revert empty change
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:30:21 -05:00
Lars Eggert
9db1d48258
fix: Correctly linkify all current TLDs ( #3868 )
...
* fix: Correctly linkify all current TLDs
* Pass a list to the build_*_re functions, not a string
* Need to sort TLDs by length to force longer ones to match first
* chore: silence incorrect mypy complaint.
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:25:18 -05:00
Lars Eggert
955d9ac489
fix: Spacing issues and colorization in conflict review display ( #3882 )
...
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:24:33 -05:00
Nicolas Giard
8ea883cb7e
chore: switch to Yarn 3 ( #3819 )
...
* refactor: switch to yarn 3
* chore: add other os+cpu to yarn supported architectures
* chore: add gitattributes
* chore: add missing yarn native modules rebuild step
* chore: replace npx with yarn in test_runner + update readme
* chore: remove bootstrap-datepicker github dependency, use local instead
2022-04-25 15:54:05 -05:00
Lars Eggert
cd9a2ee229
fix: Color the background of table rows for an AD based on their ballot ( #3867 )
...
Instead of just adding a colored bar on the right-hand side.
2022-04-22 11:05:37 -05:00
Robert Sparks
f4b0b459cb
feat: add analytics infrastructure ( #3862 )
2022-04-21 18:06:14 -05:00
Lars Eggert
ec13e071ba
fix: Whitespace issue ballot popup ( #3860 )
2022-04-21 11:55:48 -05:00
Lars Eggert
92e67aca8f
fix: Make the author button work on doc submit ( #3850 )
2022-04-20 10:52:54 -05:00
Lars Eggert
3fdfa3a6ef
fix: Show all liaison groups by default ( #3852 )
...
Requiring two characters to be entered before any options are shown makes no
sense here.
2022-04-20 10:51:50 -05:00
Lars Eggert
cef7b05981
fix: Don't change text color on hover for badge links ( #3845 )
2022-04-20 10:50:24 -05:00
Kesara Rathnayake
6b06542fab
fix: fix OIDC authorization bug ( #3842 )
2022-04-20 10:47:47 -05:00
Nicolas Giard
a32976c819
chore: set base dev version to 8.0.0-dev
2022-04-19 17:44:30 -04:00
Robert Sparks
87fac4e12a
test: align tests with new shepherd writeup template. ( #3838 )
2022-04-19 11:44:59 -05:00
Lars Eggert
f8c06fa5cf
fix: Use unique data-sort
attributes ( #3836 )
...
* fix: Use unique `data-sort` attributes
So list.js properly sorts columns.
* Address @rjsparks' comments
2022-04-19 10:16:32 -05:00
Lars Eggert
ea22b0fd3b
fix: Update the document shepherd template ( #3797 )
...
* fix: Update the document shepherd template
Along the lines of https://github.com/ietf-chairs/chairs.ietf.org/pull/5
* Rewrap manually
* Use relative Markdown links to improve readability
2022-04-19 09:32:39 -05:00
Jennifer Richards
43952a8c69
fix: do not prematurely dereference status change RelatedDocuments ( #3835 )
...
* test: add tests of the person_link tag
* fix: do not prematurely dereference status change RelatedDocuments
The urlize_related_source_list template tag expects the RelatedDocument
instances, not the source Document.
* test: add test cases for status changes on document_main view
2022-04-19 07:04:38 -05:00
Jennifer Richards
b8912a4eff
fix: treat str input as None in the person_link tag ( #3832 )
2022-04-15 15:49:16 -05:00
Robert Sparks
eef29cf35d
fix: improve ietf doc string urlization. Fixes #3828 . ( #3831 )
...
* fix: improve ietf doc string urlization. Fixes #3828 .
* fix: dont urlize names immediately after - or /. Avoids urizing in the middle of urls.
* fix: cover some additional corners when urlifying document names.
* chore: remove unnecessary code complication
2022-04-15 15:43:32 -05:00
Nicolas Giard
23fdf61ed4
fix: point to github releases in about page ( #3827 )
2022-04-14 16:21:51 -05:00
Robert Sparks
7c4205d49b
feat: reflect breaking change in internal release description ( #3826 )
...
BREAKING CHANGE: the datatracker now uses bootstrap 5 and html 5
see also 6eeae80207
2022-04-14 15:04:09 -05:00
Lars Eggert
81fe7a15cf
fix: add flex-wrap
to pagination
elements ( #3822 )
...
They seem to be one of the only bs5 elements that do not by default wrap, which
causes display issues on narrow screens when there are lots of page elements,
e.g., on http://127.0.0.1:8000/doc/draft-ietf-ipwave-vehicular-networking/
Adding `flex-wrap` (per https://github.com/twbs/bootstrap/issues/23504 ) makes
this better, but unfortunately doesn't fix it completely, because the layout
still jumps when the window is narrowed by the used. It does fix the issue on
first load and after a reload though.
2022-04-14 15:36:24 -03:00
Jennifer Richards
310e828262
fix: offset scrollspy so righthand-nav highlights the correct entry ( #3820 )
...
Also rewrites scroll_to_element() using javascript. This seems to be less flaky
than the ActionChains implementation. Slight change in behavior - now scrolls
the requested element to the middle of the window instead of barely into view.
2022-04-14 15:35:07 -03:00
Lars Eggert
79c7081181
* fix: Correctly urlize bis documents
...
The old code would first substitute the "rfx<nnnn>" part, and then again
on the full draft name. This now only ever applies one substitute,
and does longer ones first.
2022-04-14 15:33:47 -03:00
Jennifer Richards
966e1c806a
chore: remove editor_label field from ConstraintName model ( #3783 )
2022-04-14 15:30:11 -03:00
Jennifer Richards
a29965f37d
fix: remove potentially duplicate html entity id ( #3818 )
2022-04-13 11:42:14 -03:00
Jennifer Richards
30d1067082
test: update search in test to match template changes ( #3814 )
...
Fixes test failure caused by ietf-tools#3803.
2022-04-12 19:30:22 -03:00
Robert Sparks
0944312c20
feat: remove room-view. Fixes #3810 . ( #3815 )
...
Also changes .editorconfig to not strip trailing whitespace
2022-04-12 17:35:07 -03:00
Lars Eggert
d2edc5bda3
fix: Misc template fixes ( #3813 )
...
* fix: Remove extra whitespace around parentheses
* fix: Make heading capitalization consistent, colorize a "No"
* fix: Pagination element, spacing, replace text with icon
2022-04-12 12:07:22 -03:00
Lars Eggert
4f1dcd6f41
fix: Don't make a <tbody> for each row ( #3808 )
...
Fixes #3805 .
2022-04-12 12:04:57 -03:00
Jennifer Richards
c14a30392c
fix: clean up agenda personalization links ( #3803 )
2022-04-12 12:03:13 -03:00
Lars Eggert
09a898e88e
fix: Improve the layout of the photo pages ( #3807 )
2022-04-12 12:02:16 -03:00
Lars Eggert
f98cb8a4cd
fix: No need to escape here ( #3806 )
2022-04-12 11:27:52 -03:00
Robert Sparks
0b1388c39f
fix: report seven character prefix of release hash ( #3804 )
2022-04-11 15:57:25 -03:00
Lars Eggert
3245678e10
fix: Hide tooltips after review wish icon is clicked ( #3799 )
...
Similar how it's done with the track/untrack icon.
Also remove duplicate javascript for this functionality.
2022-04-08 14:55:41 -03:00
Lars Eggert
19e639f779
fix: .visually-hidden -> .d-none ( #3800 )
...
In bs5, `.visually-hidden` is the equivalent of bs3's `.sr-only`, i.e., it's
still shown on screen readers, which is not what we want. Use `.d-none` instead,
which is the equivalent of bs3's `.hidden`.
2022-04-08 14:53:56 -03:00
Jennifer Richards
2247a368dc
fix: improve RH panel behavior at small viewport sizes ( #3801 )
...
* fix: align nav links to top of RH panel
* fix: allow timezone picker to wrap
* fix: improve RH panel behavior at small viewport sizes
* drop card styling
* use `btn-group-sm` for compact timezone picker
* limit overall height of #righthand-panel
* remove redundant CSS merge artifact
2022-04-08 14:52:55 -03:00
Jennifer Richards
3619d3bfbf
fix: handle invalid fields properly in proc material upload form ( #3784 )
2022-04-07 22:58:01 -03:00
Jennifer Richards
eab4705dc1
fix: debug time zone widget and add to agenda RH nav panel ( #3792 )
2022-04-07 22:57:21 -03:00
Eric Vyncke
fd588d61b4
fix: add more explanations in BoF requests ( #3706 )
...
* Add more explanations in BoF requests
* Move IAB/IESG information to the template
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-04-07 17:34:53 -05:00
Jennifer Richards
68684be247
test: fix permissions on files for html validation ( #3795 )
...
* test: fix permissions on files for html validation
* test: rewind stdout before dumping output that caused error
2022-04-07 16:17:33 -05:00
Jennifer Richards
45df4f6dfd
fix: restore current session indicator/link on the agenda page ( #3790 )
2022-04-07 15:13:43 -03:00
Lars Eggert
3234f1a121
test: Validate HTML rendered during tests ( #3782 )
2022-04-07 13:30:38 -03:00
Jennifer Richards
db254f7a48
fix: tweak review assignment tooltips and control row height ( #3788 )
2022-04-07 09:48:23 -03:00
Robert Sparks
6867b1b667
fix: put unassigned review assignment contols on one small line ( #3780 )
2022-04-06 14:05:37 -03:00
Jennifer Richards
7738319c2a
fix: render meeting schedule editor icons using bootstrap-icons ( #3777 )
...
Uses template tags to render `ConstraintName` instances as HTML. Fixes #3557 .
2022-04-05 18:57:08 -03:00
Nicolas Giard
b65182150f
chore: remove legacy / deprecated files ( #3781 )
...
* chore: remove changelog files
* chore: remove data dir from source
* chore: exclude /data completely in gitignore
2022-04-05 15:45:01 -04:00
Jennifer Richards
016ee71855
feat: persist timeslot types made visible in the schedule editor ( #3778 )
...
This adds a POST action to the edit_meeting_schedule view that sets a list
of currently visible timeslot types in the user's session. On display of
the schedule editor, this is consulted before defaulting to show only 'regular'
timeslots. An ajax request is made to update the session when changing the
settings in the editor.
2022-04-05 16:00:59 -03:00
Nicolas Giard
cb3177efb9
chore: remove .gz from coverage file path in settings
2022-04-04 16:31:28 -04:00
Jennifer Richards
3865c4bc9c
fix: restore function of unassigned review management page ( #3774 )
...
* style: reformat manage-review-requests.js as StandardJS style
* refactor: use switch statement instead of if/else-if/else
* style: remove needless line break
* fix: fix jquery selectors to be less fragile and easier to read
* fix: clean up bs5 HTML/CSS for review request buttons
2022-04-01 17:42:12 -03:00
Jennifer Richards
2859c43677
fix: allow import of rev00 minutes and let secretariat edit materials ( #3776 )
...
* fix: show "Edit materials" button for all groups for a secretariat user
Fixes ietf-tools#3763
* fix: show "import minutes" button to import initial revision
* test: validate that import session minutes buttons are shown
* test: validate that "Edit materials" links are shown
2022-04-01 12:49:20 -03:00
Jennifer Richards
40c33b1281
fix: better handle corner cases for pre-IETF-64 agenda redirects ( #3775 )
...
Fixes #3669
2022-03-31 17:16:21 -03:00
Robert Sparks
ef4ad545b9
fix: left-align date columns in all tablesorter-classed tables. ( #3772 )
2022-03-30 18:45:39 -03:00
Robert Sparks
8373914678
fix: complete the removal of ietf.__init__.date. ( #3771 )
...
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-03-30 18:43:51 -03:00
Robert Sparks
cb4a288ab6
fix: separate tables on team review page. Fixes #3679 . ( #3770 )
2022-03-30 18:42:29 -03:00
Jennifer Richards
300f717c3d
fix: avoid needlessly blocking import of session minutes ( #3761 )
...
Fixes #3558
2022-03-30 18:38:47 -03:00
Robert Sparks
1d8746cd63
fix: add tooltips to calendar icons on group meeting pages. Fixes #3695 . ( #3767 )
2022-03-30 18:37:29 -03:00
Jennifer Richards
29bbe06ddb
test: remove test for empty JS console log ( #3769 )
2022-03-30 15:14:29 -05:00
Robert Sparks
2e373adcd2
feat: improve release information in footer. ( #3738 )
2022-03-30 11:53:07 -03:00
Kesara Rathnayake
65439960fe
fix: Use an input field for draft submit status search ( #3758 )
2022-03-29 12:35:46 -05:00
Jennifer Richards
9590303027
Merge remote-tracking branch 'origin/feat/bs5' into main-merge
2022-03-25 15:18:58 -03:00
Robert Sparks
38883e506f
fix: enable delegation for many group types. ( #3753 )
...
fixes #3740
2022-03-25 13:56:49 -03:00
Robert Sparks
eaf1f01e4d
fix: point wg about pages directly to jabber archives. Fixes #3462 and #3368 . ( #3750 )
2022-03-25 13:48:47 -03:00
Jennifer Richards
4e3330e80f
fix: remove duplicate lines from merge
2022-03-25 12:44:32 -03:00
Jennifer Richards
c0c8771370
Merge branch 'main' into main-merge
...
# Conflicts:
# .devcontainer/docker-compose.extend.yml
# .github/workflows/build-test-base.yml
# .github/workflows/build.yml
# README.md
# docker/app.Dockerfile
# docker/configs/settings_local.py
# docker/docker-compose.extend.yml
# docker/scripts/app-init.sh
# ietf/release/tests.py
# ietf/release/urls.py
# ietf/templates/500.html
# ietf/templates/api/index.html
# ietf/templates/base.html
# ietf/templates/base/menu.html
# ietf/templates/group/group_about_status_edit.html
# ietf/templates/meeting/agenda_filter.html
# ietf/templates/release/about.html
# ietf/utils/tests.py
# package-lock.json
2022-03-25 11:15:05 -03:00
Robert Sparks
87838725af
test: bypass html validation pending rework at template level ( #3748 )
2022-03-25 07:53:46 -05:00
Russ Housley
0024cc9ea1
chore: Remove references to settings.SECR_VIRTUAL_MEETINGS. Fixes #3717 . ( #3741 )
2022-03-25 04:26:50 -05:00
Robert Sparks
79bcc6448e
feat: redirect to release information at github ( #3746 )
...
* chore: remove unused import
* feat: redirect to release information at github.
2022-03-24 16:38:33 -04:00
Nicolas Giard
9a4505dc74
chore: remove svn/trac infrastructure ( #3649 ) ( #3739 )
...
* chore: Remove svn/trac related infrastructure
* chore: Remove more svn/trac infrastructure
* fix: remove commented out Trac requirement
2022-03-24 12:24:35 -05:00
Lars Eggert
870fed030f
fix: More fixes for narrow screens ( #3662 )
...
* fix: More fixes for narrow screens
Need to keep checking for issues, there are more.
* Make columns more narrow on narrow screens
* More fixes
* More fixes
* Test fixes
* Fix more tests
* Close tbody
2022-03-24 12:40:48 -03:00
Robert Sparks
66feccbc67
test: avoid edge case in test factory. Fixes #3513 . ( #3736 )
2022-03-24 09:13:33 -03:00
Eric Vyncke
65d4c99707
feat: use related docs pages count when no page count ( #3686 )
2022-03-22 13:41:37 -05:00
Jennifer Richards
4e437a9f2d
test: scroll swap timeslots button into view before clicking ( #3719 )
2022-03-22 13:33:48 -05:00
Russ Housley
fd9a0a4d9f
fix: Do not include concluded WGs in /list/nonwg. Fixes #3726 . ( #3727 )
2022-03-22 13:18:59 -05:00
Robert Sparks
902e37d24d
fix: improve looking into submission request for remote ip. ( #3720 )
2022-03-22 13:04:50 -05:00
Robert Sparks
3d529bad20
fix: improve validation of submission version. Add submission name validation tests.
...
Co-authored-by: russhousley <housley@vigilsec.com>
2022-03-22 14:51:25 -03:00
Lars Eggert
f516f86a17
ci: Add vnu to dev + test docker image ( #3724 )
...
* ci: Add vnu to dev docker image
* Use default-jdk from apt, and just download the vnu JAR blob
2022-03-22 13:13:28 -04:00
Robert Sparks
841f289b5d
fix: repair incorrect merge ( #3728 )
2022-03-22 13:51:02 -03:00
Lars Eggert
d47692546e
fix: Re-add agenda day navigation targets to right-hand nav ( #3723 )
...
Fixes #3698
2022-03-22 07:22:25 -05:00
Jennifer Richards
fd2adc86eb
fix: redirect to renamed schedule after saving a name change ( #3696 )
...
Fixes #3427
2022-03-21 16:22:28 -03:00
Jennifer Richards
6ee123d29b
fix: replace invalid bi-chat* icons with valid ones ( #3716 )
2022-03-21 16:10:56 -03:00
Nicolas Giard
adc6331727
ci: inject release hash + branch during build
2022-03-21 14:45:10 -04:00
Nicolas Giard
ffb6904b09
ci: inject release hash + branch during build
2022-03-21 14:44:58 -04:00
Lars Eggert
eb5423d084
ci: Also check generated HTML with the "vnu" validator ( #3682 )
...
* ci: Also check generated HTML with the "vnu" validator
Because HTML Tidy apparently misses a bunch of errors.
* thead -> tbody
* More fixes
* More fixes
* Start checker in test runner
2022-03-21 12:50:23 -05:00
Robert Sparks
6ecd4b40e2
fix: use better address calculation for schedule owner. Fixes #2611 . ( #3709 )
2022-03-21 10:21:22 -03:00
Jennifer Richards
be10d6bb10
fix: remove overflow-hidden from div#content ( #3681 )
...
Allows position="sticky" items to attach to the viewport instead of the #content element.
2022-03-20 14:13:58 -05:00
Robert Sparks
9f4634f531
fix: use approver's identity instead of System ( #3701 ) ( #3705 )
...
Fixes issue #3545
Conditionally tests if the approver is AnonymousUser, in which case
System is still used
Co-authored-by: Peter Yee <github@houseofyee.com>
2022-03-20 09:00:09 -05:00
Peter Yee
4dc0247976
fix: use approver's identity instead of System ( #3701 )
...
Fixes issue #3545
Conditionally tests if the approver is AnonymousUser, in which case
System is still used
2022-03-20 07:54:15 -05:00
Russ Housley
71b1f13a79
fix: improfe draft name syntax checks ( #3703 )
...
* fix: Include blocked charters in AD dashboard that are ub external review
* fix: Improve draft name syntax checks. Fixes #3677
2022-03-20 06:59:29 -05:00
Robert Sparks
5c5d052603
fix: remove unintended debug code ( #3704 )
2022-03-19 16:02:46 -03:00
Russ Housley
74d30529b6
fix: Include blocked charters in AD dashboard that are in external review ( #3689 )
2022-03-19 11:59:04 -05:00
Tero Kivinen
311bbf8826
fix: Fix the doc_name to have class text-nowrap as we want to keep the entries in one line if possible. ( #3683 )
2022-03-19 11:56:22 -05:00
Robert Sparks
f15d0fa8e3
test: match changes to release/about
...
* chore: bring docker-compose to root level (#3642 )
* test: match changes to release/about
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-03-19 16:06:38 +01:00
Robert Sparks
9df659b06e
fix: better draft name validation. Fixes #3539 . ( #3671 )
2022-03-18 18:01:25 -05:00
Jennifer Richards
3c91773e32
test: remove unused import that causes test failure ( #3667 )
2022-03-17 16:33:26 -05:00
Russ Housley
d40842e4ce
fix: Allow AD and Secretariat to update the people to notify about conflict-reviews until the are announced ( #3651 )
...
* Allow AD and Secretariat to update the people to notify about conflict-reviewss until the are announced. Fixes #3639 .
* fix: Allow notify list for conflict-review changes in any state
2022-03-16 14:16:55 -05:00
Robert Sparks
efc87dc35b
test: match changes to release/about
...
* chore: bring docker-compose to root level (#3642 )
* test: match changes to release/about
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-03-16 13:15:05 -05:00
Robert Sparks
9e06efeaba
feat: update the shepherd writeup template ( #3650 )
...
* feat: update the shepherd writeup template
Fixes #3580 .
* fix: correct the version date
2022-03-16 11:54:00 -05:00