fix: use approver's identity instead of System (#3701) (#3705)

Fixes issue #3545
Conditionally tests if the approver is AnonymousUser, in which case
System is still used

Co-authored-by: Peter Yee <github@houseofyee.com>
This commit is contained in:
Robert Sparks 2022-03-20 09:00:09 -05:00 committed by GitHub
parent 71b1f13a79
commit 9f4634f531
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -18,6 +18,7 @@ from django.db import transaction
from django.http import HttpRequest # pyflakes:ignore
from django.utils.module_loading import import_string
from django.template.loader import render_to_string
from django.contrib.auth.models import AnonymousUser
import debug # pyflakes:ignore
@ -337,11 +338,15 @@ def post_submission(request, submission, approved_doc_desc, approved_subm_desc):
# Add all the previous submission events as docevents
events += post_rev00_submission_events(draft, submission, submitter)
if isinstance(request.user, AnonymousUser):
doer=system
else:
doer=request.user.person
# Add an approval docevent
e = SubmissionDocEvent.objects.create(
type="new_submission",
doc=draft,
by=system,
by=doer,
desc=approved_doc_desc,
submission=submission,
rev=submission.rev,