Commit graph

888 commits

Author SHA1 Message Date
Henrik Levkowetz aabd237656 Fixed some pyflakes issues.
- Legacy-Id: 17304
2020-02-18 19:39:03 +00:00
Henrik Levkowetz 91d5d72a9d Tweaked send_mail_mime() to recognize settings.SERVER_MODE='repair', in order to avoid mail floods when running the 'mergedata' management command. It is assumed that the appropriate mails went out when the data was entered into the system the first time.
- Legacy-Id: 17301
2020-02-16 21:42:37 +00:00
Henrik Levkowetz 7b5bebc727 Added a management command to dump data based on table names and primary keys derived from a list of SQL 'INSERT INTO' commands representing the items to be dumped. The output formats are the same as for dumpdata, and are suitable for later use with the loaddata or mergedata management commands.
- Legacy-Id: 17300
2020-02-16 21:40:01 +00:00
Henrik Levkowetz e0c6f3abe2 Added a management command to merge data from one of two divergent django databases to the other, taking care to insert or update records as appropriate, and update foreign keys and many-to-many keys appropriately. Accepts the dump formats generated by the dumpdata command.
- Legacy-Id: 17299
2020-02-16 21:39:08 +00:00
Henrik Levkowetz 58d8c2fb47 Updated the check_referential_integrity command, adding a --delete command to remove dangling references to removed records, and also adding colorized success/fail indications for each FK and m2m key inspected.
- Legacy-Id: 17298
2020-02-16 21:05:12 +00:00
Henrik Levkowetz 8f0eca5032 Added a newline to test run output, to separate dot progress indication from teardown message.
- Legacy-Id: 17253
2020-01-22 23:17:44 +00:00
Henrik Levkowetz 288f4135e3 Added (currently inactive) code to trigger exceptions on failure to resolve template variables during tests, and added fixes for a couple of places that triggered such exceptions.
- Legacy-Id: 17226
2020-01-13 17:16:43 +00:00
Peter E. Yee bb7e504d14 12/13 merged into 6.113.1.dev0 with migration ordering failure
- Legacy-Id: 17149
2019-12-13 19:53:45 +00:00
Henrik Levkowetz fcb6806d17 Merged in work from sasha@dashcare.nl on Review Queue Managemnt:
This abstracts queue management, making it possible to implement different
policies for each team. It provides two concrete policies:
RotateAlphabeticallyReviewerQueuePolicy, which rotates an alphabetically
ordered reviewer list with consideration for skip indications, and is the
default policy; and LeastRecentlyUsedReviewerQueuePolicy, a simple
least-recently-used policy.  Also see issues #2721 and #2656.
 - Legacy-Id: 17121
2019-12-04 23:02:52 +00:00
Henrik Levkowetz ac6b664fa5 Added normalization of draft title extracted from submitted XML.
- Legacy-Id: 17119
2019-12-02 16:24:51 +00:00
Henrik Levkowetz 2c28cb3eb0 When group secretary email addresses occurred in some mailtrigger To: entries, they were given with both name and address parts, while when occurring in Cc: entries, no names were present. Fixed one case of this, and adjusted a test case for consistency. Also added a more general utility function to exclude selected email addresses from email address lists.
- Legacy-Id: 17107
2019-11-27 21:49:22 +00:00
Henrik Levkowetz 6333e7d842 Added an instance of force_text() to ensure non_ascii mail subjects are unicode when used for string interpolation, rather than bytes (which will trigger ascii decode()).
- Legacy-Id: 17055
2019-11-19 09:37:55 +00:00
Henrik Levkowetz c233f07b5d Added a management command to generate draft bibxml files, and also a trial version of datatracker draft bibxml pages.
- Legacy-Id: 16962
2019-11-05 18:10:29 +00:00
Henrik Levkowetz d5b6292060 Fixed a pyflakes issue.
- Legacy-Id: 16955
2019-11-04 18:11:59 +00:00
Henrik Levkowetz feaa5038a0 Rewrote the ietf/bin/fix-ambiguous-timestamps command as a management command (fix_ambiguous_timestamps) and made it look at all instances of DateTimeField by means of model introspection.
- Legacy-Id: 16954
2019-11-04 12:56:52 +00:00
Henrik Levkowetz 3c82dc6184 Merged in [16922] from sasha@dashcare.nl:
Fix #2584 - Add additional content validation for uploaded texts.
Permitted MIME types are now text/plain, text/markdown and text/x-rst.
This applies to all usages of get_cleaned_text_file_content(),
including reviews, but also other similar places where text can either
be written either into a textarea or uploaded.
 - Legacy-Id: 16930
Note: SVN reference [16922] has been migrated to Git commit fd53f98854
2019-10-26 15:42:58 +00:00
Sasha Romijn fd53f98854 Fix #2584 - Add additional content validation for uploaded texts.
Permitted MIME types are now text/plain, text/markdown and text/x-rst.
This applies to all usages of get_cleaned_text_file_content(),
including reviews, but also other similar places where text can either
be written either into a textarea or uploaded.

Commit ready for merge.
 - Legacy-Id: 16922
2019-10-23 20:15:30 +00:00
Henrik Levkowetz 45465f1174 Merged in [16818] from rjsparks@nostrum.com:
Make hybrid pdfs when converting ppt materials to pdf. Fixes #2769.
 - Legacy-Id: 16880
Note: SVN reference [16818] has been migrated to Git commit 84270a71d0e7373c5e05ddc834e91c445a1296ed
2019-10-21 13:17:33 +00:00
Henrik Levkowetz 447525de73 Tweaked the output of mypy_test().
- Legacy-Id: 16865
2019-10-15 16:48:23 +00:00
Henrik Levkowetz 24ede9a1ae In wordwrap(), consider lines consisting entirely of some non-alphanumeric characters like ---- or === to be block (paragraph) separators. Fixes issue #2806.
- Legacy-Id: 16790
2019-10-01 11:08:41 +00:00
Henrik Levkowetz 902f7769d1 Fixed incorrect type hints for Migration.dependencies.
- Legacy-Id: 16776
2019-09-30 16:25:58 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Henrik Levkowetz 2d858f2e0a Added mypy and django-stubs to Py3 requirements, and added a mypy test case.
- Legacy-Id: 16768
2019-09-30 15:37:32 +00:00
Henrik Levkowetz 8e313e4ed5 Adjusted migrations for Python2/3 compatibility.
- Legacy-Id: 16633
2019-08-08 17:11:14 +00:00
Henrik Levkowetz 2418459afc Prevent login case issues by generating apache permissions file entries for both uppercase and lowercase logins.
- Legacy-Id: 16597
2019-07-29 19:20:38 +00:00
Henrik Levkowetz 0a591e4b2e Merged in [16562] from rcross@amsl.com:
Added encoding='utf-8' parameter to io.open operations in tests that starting failing since adding unicode_literals.
 - Legacy-Id: 16588
Note: SVN reference [16562] has been migrated to Git commit d332bfd91d
2019-07-24 23:44:36 +00:00
Henrik Levkowetz 07c5e33bc4 Added conditional decoding of bytes subject text, before interpolating into a new unicode string.
- Legacy-Id: 16577
2019-07-22 18:19:55 +00:00
Ryan Cross d332bfd91d Added encoding='utf-8' parameter to io.open operations in tests that starting failing since adding unicode_literals. Commit ready to merge
- Legacy-Id: 16562
2019-07-20 22:54:14 +00:00
Henrik Levkowetz b3244242aa Fixed some issues with the Py2/3 changes to the populate_yang_model_dirs management command.
- Legacy-Id: 16520
2019-07-18 18:53:14 +00:00
Henrik Levkowetz fb3d4ddb0b Added information about versions (Datatracker, Python, and Django) at the beginning of test suite runs.
- Legacy-Id: 16516
2019-07-17 20:54:51 +00:00
Henrik Levkowetz 618d6021b0 Read pdf files as binary.
- Legacy-Id: 16510
2019-07-17 16:05:19 +00:00
Henrik Levkowetz db47cb6b0f Replaced the error on bad Submission.submitter email address with syslog logging.
- Legacy-Id: 16509
2019-07-17 14:30:57 +00:00
Henrik Levkowetz 627f8a7eab Modified code to write release coverage json data to gzip file under both Py2 and Py3.
- Legacy-Id: 16475
2019-07-16 21:58:38 +00:00
Henrik Levkowetz ad1821f63a Enabled the wiki management command under py2
- Legacy-Id: 16471
2019-07-16 19:12:00 +00:00
Henrik Levkowetz e03784132d Merged changes from current trunk to Py3 branch.
- Legacy-Id: 16468
2019-07-16 15:36:16 +00:00
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz 46aec6eb85 Python2/3 compatibility: tentative version of create_group_wikis; may need more work.
- Legacy-Id: 16459
2019-07-16 13:17:12 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz 44f51c1d64 The beginning of a dev file download helper.
- Legacy-Id: 16456
2019-07-15 19:03:35 +00:00
Henrik Levkowetz 831fb18f8a Python2/3 compatibility: Added force_str or force_bytes in some places, to ensure the argument right type
- Legacy-Id: 16450
2019-07-15 15:49:35 +00:00
Henrik Levkowetz eb42394534 Py2/3 compatibility: Added __future__ import.
- Legacy-Id: 16449
2019-07-15 15:47:31 +00:00
Henrik Levkowetz 855716e1d5 Py2/3 compatibility: Added __future__ import
- Legacy-Id: 16448
2019-07-15 15:46:06 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz 6ace81b25d Corrected the order of string prefix 'r' and 'b' under python2.
- Legacy-Id: 16445
2019-07-15 15:37:48 +00:00
Henrik Levkowetz 58eca93f9a Added validation of email addresses extracted by get_email_addresses_from_text().
- Legacy-Id: 16439
2019-07-09 13:02:49 +00:00
Henrik Levkowetz 6732e7acff Fixed an issue with a gzip file mode.
- Legacy-Id: 16436
2019-07-08 18:30:34 +00:00
Henrik Levkowetz f481f5c3e6 Replaced use of six with the equivalent pure python3 constructs.
- Legacy-Id: 16428
2019-07-08 10:43:47 +00:00
Henrik Levkowetz 671b4035ea Fixed a syntax issue and removed debug calls.
- Legacy-Id: 16421
2019-07-07 13:04:54 +00:00
Henrik Levkowetz 472a3ed039 Refined our parseaddr() to deal correctly with both bytes and str
- Legacy-Id: 16419
2019-07-07 13:03:11 +00:00
Henrik Levkowetz 40ab3c949f Added missing code to skip coverage measurement for skippable tests.
- Legacy-Id: 16406
2019-07-06 17:27:49 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports.
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output.
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz 3a35dfcee4 Changed our parseaddr() and formataddr() to work correctly with python3.
- Legacy-Id: 16399
2019-07-04 21:00:48 +00:00
Henrik Levkowetz a3d40ace9b Fixed a str/bytes issue with a hashlib function call, and removed an unused import.
- Legacy-Id: 16398
2019-07-04 20:59:40 +00:00
Henrik Levkowetz f33ecaa1a4 Fixed a test that compared an int with a meeting number string. Changed meeting test data to use meeting number 72 instead of 42, because proceedings code gives 404 for meetings before 65. Changed a number of StringIO() to BytesIO().
- Legacy-Id: 16378
2019-07-04 16:01:32 +00:00
Henrik Levkowetz 0589d0b313 Changed a bunch of regexes to use r strings; also miscellaneous smaller fixes.
- Legacy-Id: 16376
2019-07-04 15:51:05 +00:00
Henrik Levkowetz fb8d12ac3c Fixed a pyflakes issue.
- Legacy-Id: 16358
2019-07-01 19:27:08 +00:00
Henrik Levkowetz 8c66e95a57 Test changes to match production group type changes for some special groups.
- Legacy-Id: 16357
2019-07-01 18:30:59 +00:00
Henrik Levkowetz c8e75c554a Various changes to make yang-related management commands quieter
- Legacy-Id: 16355
2019-07-01 18:29:03 +00:00
Henrik Levkowetz f5e9583f59 Fixed str/bytes issues with hashlib function arguments.
- Legacy-Id: 16354
2019-07-01 14:09:53 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn().
- Legacy-Id: 16346
2019-06-30 21:03:34 +00:00
Henrik Levkowetz 20c44a9e1a Adapted the pipe() code to python3; API changes and str/byte handling.
- Legacy-Id: 16345
2019-06-30 21:01:44 +00:00
Henrik Levkowetz 36cac48063 Fixed a bunch of str/bytes issues.
- Legacy-Id: 16341
2019-06-30 20:54:09 +00:00
Henrik Levkowetz 70c00950b6 Fixed several email handling str/bytes issues.
- Legacy-Id: 16334
2019-06-29 13:30:36 +00:00
Henrik Levkowetz ea109f2b1b Fixed API changes in SMTPChannel
- Legacy-Id: 16329
2019-06-28 20:52:15 +00:00
Henrik Levkowetz 1e86ccb4ee Builtin function file() --> open()
- Legacy-Id: 16328
2019-06-28 20:51:13 +00:00
Henrik Levkowetz 318bd0d5ea Changed regex strings to r strings.
- Legacy-Id: 16320
2019-06-28 13:32:50 +00:00
Henrik Levkowetz e39ac52071 Removed 2to3-generated list() around .items() iterator in for loops.
- Legacy-Id: 16315
2019-06-27 18:11:17 +00:00
Henrik Levkowetz 06daf6ac65 Changed regex strings to raw strings.
- Legacy-Id: 16312
2019-06-27 18:08:02 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list.
- Legacy-Id: 16284
2019-06-18 12:40:19 +00:00
Henrik Levkowetz ba528a0c5e Adjusted the test_runner to generate migration coverage data also when permitting mixed migrations.
- Legacy-Id: 16280
2019-06-17 18:24:17 +00:00
Henrik Levkowetz 0e68f4bb4b Added a management command to update the index table used by some community list search rules.
- Legacy-Id: 16273
2019-06-17 13:02:57 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz ca1f3340c0 Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability.
- Legacy-Id: 16181
2019-05-02 12:38:41 +00:00
Henrik Levkowetz 7b93709a3b Tweaked the greate_group_wikis management command to accept trailing fileglob wildcards on adhoc wiki group acronyms. Added a generic NomCom wiki to the list of adhoc wikis to be created and maintained, with admins from active nomcom* groups.
- Legacy-Id: 16176
2019-04-29 12:30:36 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Henrik Levkowetz fc18cd93d4 Tweaked coverage_changes command. I suspect this would benefit from a rewrite.
- Legacy-Id: 16019
2019-03-11 16:52:09 +00:00
Henrik Levkowetz d698eb98df Changed the on-behalf-of name template from 'On behalf of ...' to '... via Datatracker' to make name come first.
- Legacy-Id: 16009
2019-03-07 14:42:11 +00:00
Henrik Levkowetz d57088b1f3 Modified one call and one exception point related to on_behalf_of() use for email sending.
- Legacy-Id: 16008
2019-03-06 19:13:15 +00:00
Henrik Levkowetz 8a669909bc Changed ietf/utils/mail.py to use unicode strings, and changed a call in ietf/reviv/utils.py to use unicode for mail Subject, to fix a server 500 issue.
- Legacy-Id: 16007
2019-03-06 16:57:00 +00:00
Henrik Levkowetz 5c6ab60f85 Changed a log() call to use unicode string interpolation to handle unicode email address names.
- Legacy-Id: 15999
2019-03-05 17:29:43 +00:00
Henrik Levkowetz ae8c1f2b91 Updated test_data email addresses.
- Legacy-Id: 15991
2019-03-04 20:13:02 +00:00
Henrik Levkowetz 849a3dcc97 Added another exception class to a catch instance in a function, triggered by a new usage case.
- Legacy-Id: 15990
2019-03-04 20:12:30 +00:00
Henrik Levkowetz 2b811b3d3d Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org.
- Legacy-Id: 15988
2019-03-04 20:08:48 +00:00
Henrik Levkowetz 46bb4539c5 Added two new functions to replace email From: of users with On-behalf-of addresses, with associated values in settings. Added a catchall stanza in the mail sending pipeline to catch anything not already changed to On-behalf-of addresses.
- Legacy-Id: 15987
2019-03-04 20:06:44 +00:00
Henrik Levkowetz fd62a25f4e Added a missing variable initialization.
- Legacy-Id: 15925
2019-02-04 11:26:29 +00:00
Henrik Levkowetz ef97f2a821 Merged in GroupFeatures refactoring and expansion from ^/personal/henrik/6.89.4.dev0@15911.
- Legacy-Id: 15912
2019-01-24 15:25:01 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Henrik Levkowetz d19228110c Applied a patch from dkg@fifthhorseman.net: py3 compatibility: fix another instance of integer division
- Legacy-Id: 15896
2019-01-15 17:50:33 +00:00
Henrik Levkowetz 98a74bd7f3 Moved __future__ imports down so as not to obscure the module docstring. Fixes inability to run '$ ietf/utils/draft.py -h'.
- Legacy-Id: 15894
2019-01-14 22:28:52 +00:00
Henrik Levkowetz 910d3d7723 Applied a patch from dkg@fifthhorseman.net: py3 compatibility: Use a list of dictionary keys
In python3, dict.keys() produces a dict_keys object, not a list.
    Since this code treats it as a list, we'll just be explicit about
    that.
 - Legacy-Id: 15893
2019-01-14 21:06:08 +00:00
Henrik Levkowetz c8f98e125c Applied a patch from dkg@fifthhorseman.net: Fix regex manipulation for word characters.
in python 3.7, re.sub() started treating unknown escape sequences in
     as errors.  Fix this by sending an escaped \ where we mean to
    pass it through raw.
    
    https://docs.python.org/3/library/re.html#re.sub
 - Legacy-Id: 15892
2019-01-14 21:03:28 +00:00
Henrik Levkowetz e39358312b Applied a patch from dkg@fifthhorseman.net: py3 compatibility: Use // for explicit integer division
Without this fix, in modern versions of python, the changed line
    produces:
    
    TypeError: 'float' object cannot be interpreted as an integer
 - Legacy-Id: 15891
2019-01-14 21:02:01 +00:00
Henrik Levkowetz e718272e71 Applied a patch from dkg@fifthhorseman.net: py3 compatibility: Use modern form of exception handling
- Legacy-Id: 15890
2019-01-14 21:00:50 +00:00
Henrik Levkowetz 8840efaef4 Applied a patch from dkg@fifthhorseman.net: py3 compatibility: use print function.
- Legacy-Id: 15889
2019-01-14 20:56:59 +00:00
Henrik Levkowetz 00544eb534 Merged in [15846] from rjsparks@nostrum.com:
Simple tests of some log utilities.
 - Legacy-Id: 15875
Note: SVN reference [15846] has been migrated to Git commit 1e1d92aa0d
2019-01-07 22:09:19 +00:00
Henrik Levkowetz 8e60e19d01 Merged in [15845] from rjsparks@nostrum.com:
simple test of BowerStorageFinder.
 - Legacy-Id: 15874
Note: SVN reference [15845] has been migrated to Git commit a4f334195e
2019-01-07 21:34:52 +00:00
Henrik Levkowetz 0cc7f73d58 Additional tweaks to submission yang testing and the test runner
- Legacy-Id: 15870
2019-01-07 13:38:44 +00:00
Robert Sparks 1e1d92aa0d Simple tests of some log utilities. Commit ready for merge.
- Legacy-Id: 15846
2018-12-20 20:33:02 +00:00
Robert Sparks a4f334195e simple test of BowerStorageFinder. Commit ready for merge.
- Legacy-Id: 15845
2018-12-20 19:13:35 +00:00
Henrik Levkowetz 2d0c503d33 Fixed pyflakes issues
- Legacy-Id: 15792
2018-11-30 00:07:49 +00:00
Henrik Levkowetz 0e8f63951e Added two new management commands to make it easier to load back selected objects that have been removed by mistake (providing they are available in a full database dump or backup that can be loaded and worked with): dumprelated and loadrelated.
- Legacy-Id: 15790
2018-11-29 15:17:46 +00:00
Henrik Levkowetz 2397f97da3 Updated test_unicode() to work with the latest version of the unidecode lib.
- Legacy-Id: 15780
2018-11-20 16:08:51 +00:00
Henrik Levkowetz 1d604b7cd9 Another name test tweak
- Legacy-Id: 15773
2018-11-13 21:50:28 +00:00
Henrik Levkowetz fad6311a13 Fixed a test problem.
- Legacy-Id: 15772
2018-11-13 21:12:25 +00:00
Henrik Levkowetz d6caf615e0 Added testing of test_unidecode() and another name_parts() test case, and removed some debug.statements.
- Legacy-Id: 15771
2018-11-13 19:31:18 +00:00
Henrik Levkowetz e471386cf2 Merged in [15715] from rcross@amsl.com:
Fix issue where new non-session location field value isn't saved.  Fixes #2625.
 - Legacy-Id: 15756
Note: SVN reference [15715] has been migrated to Git commit a47fba833f
2018-11-12 13:35:17 +00:00
Henrik Levkowetz 0735021d2b Added a test for various name part combinations, and fixed a couple of issues with utils.name.name_parts().
- Legacy-Id: 15753
2018-11-11 15:12:20 +00:00
Henrik Levkowetz e024cca8c4 Merged in [15708] and [15730] from housley@vigilsec.com:
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15747
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 20:32:42 +00:00
Ryan Cross a47fba833f Fix issue where new non-session location field value isn't saved. Fixes #2625. Commit ready for merge.
- Legacy-Id: 15715
2018-11-05 04:25:20 +00:00
Henrik Levkowetz ef3cbf4684 Merged in [15595] from rjsparks@nostrum.com:
Converted stats, submit, sync. and utils/test to use factories. Excluded utils/test_data from coverage checks.
 - Legacy-Id: 15599
Note: SVN reference [15595] has been migrated to Git commit 39e76a836996ec9ed8ea449c92bdfae91c3dbaae
2018-10-19 12:54:58 +00:00
Henrik Levkowetz d0b73e9b67 Tweaked the mail sending routines' handling of the copy flag.
- Legacy-Id: 15586
2018-10-16 15:05:17 +00:00
Henrik Levkowetz e20e8b7df5 Changed the mail sending routines so it's possible to not copy the debug archive on some messages.
- Legacy-Id: 15585
2018-10-16 14:32:10 +00:00
Henrik Levkowetz 0e52b30e5b Added the message-id to log lines for sent messages
- Legacy-Id: 15582
2018-10-15 18:46:45 +00:00
Henrik Levkowetz caeb6fcb87 Added a '--reminder' switch to the GDPR request mailer, for repeat notifications.
- Legacy-Id: 15530
2018-10-07 22:05:26 +00:00
Henrik Levkowetz 43dd7d5e90 Tweaked the management command to send GDPR consent request emails to correctly perform exclusion based on the time of previous consent request emails.
- Legacy-Id: 15504
2018-09-29 20:08:09 +00:00
Henrik Levkowetz 1dd47e18f5 Whitespace changes only.
- Legacy-Id: 15499
2018-09-29 12:46:12 +00:00
Henrik Levkowetz 7ea8a3f431 Tweaked the gdpr reminder command to avoid bounces to RT and copies to gmail.
- Legacy-Id: 15480
2018-09-24 18:37:45 +00:00
Henrik Levkowetz 30f456f83a Changed the default minimum response time used by the delete_data_lacking_consent management command from 14 to 7 days.
- Legacy-Id: 15466
2018-09-18 13:35:27 +00:00
Henrik Levkowetz 4fba531e9e Merged in the latest GDPR changes. This refines the handling of the consent checkbox on the account page; refines the Consent Needed warning given on login if consent is needed; tweaks several models to set the on_deletion fields for FK to User and Person appropriately; adds a Person.needs_consent() method to capture the logic of which fields require consent; refines the Person.plain_name() method and the user.log.log() function; and adds 2 management commands to send out consent requests and delete non-consent information, respectively.
- Legacy-Id: 15464
2018-09-16 23:12:43 +00:00
Henrik Levkowetz a389e24fb6 Refined utils.log.log() to flush stdout before logging if we're writing log messages to stderr.
- Legacy-Id: 15463
2018-09-16 14:14:26 +00:00
Henrik Levkowetz b85e1c46d9 Added a delete_data_lacking_consent management command that deletes person records and person information for which we need consent according to GDPR, but have not received it.
- Legacy-Id: 15461
2018-09-16 13:54:32 +00:00
Henrik Levkowetz 3f9dbeada8 Expanded the send_gdpr_consent_request command to add support for deletion dates, email reminder interval, email sending rate limiting, and sending to a list of users.
- Legacy-Id: 15460
2018-09-16 13:52:29 +00:00
Henrik Levkowetz b2bfc7858a Generalized the log.assertion() function a bit to be able to provide more information on assertion failure.
- Legacy-Id: 15426
2018-08-10 15:31:12 +00:00
Henrik Levkowetz e53318084d Added a tiny utility function unwrap() to unwrap wrapped text for matching expected strings in tests.
- Legacy-Id: 15396
2018-07-19 15:53:05 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Henrik Levkowetz e87442f33a Merged in [15282] from housley@vigilsec.com:
Set reply-to for I-D Announcements that include a CC to a mail list.  Fixes #2530.
 - Legacy-Id: 15289
Note: SVN reference [15282] has been migrated to Git commit 733c304e3d
2018-07-10 17:16:47 +00:00
Henrik Levkowetz dbfdb94c34 Merged in [15267] from rcross@amsl.com:
Fix issue with decorator on utils.html.remove_tags().
 - Legacy-Id: 15270
Note: SVN reference [15267] has been migrated to Git commit 0d255f7d0874f01163f292568e76fa9d830a54e2
2018-06-19 21:23:35 +00:00
Henrik Levkowetz 97db5f71b5 Added a management command to send out gdpr consent requests.
- Legacy-Id: 15269
2018-06-19 19:23:46 +00:00
Robert Sparks b86bd84278 Improvements to tests after converting to factories suggested by studying coverage_changes. Commit ready to merge.
- Legacy-Id: 15248
2018-06-13 22:09:01 +00:00
Henrik Levkowetz 4db4dd16b0 Merged in ^/personal/henrik/6.79.1-gdpr@15180 containing GDPR-adaptations.
- Legacy-Id: 15181
2018-05-28 11:26:24 +00:00
Henrik Levkowetz 2522082979 Changed the email origin field during test to hold user.username in order to exercise more of the code. Changed the EmailFactory to also use user.username as origin.
- Legacy-Id: 15172
2018-05-26 08:32:20 +00:00
Robert Sparks 25e9893a13 Changed how the mail utilities handle lists in their override and extra arguments. Added a test for send_mail_preformatted exercising override and extra. Commit ready for merge.
- Legacy-Id: 15153
2018-05-22 15:38:04 +00:00
Henrik Levkowetz df7df69a59 Updated comment text
- Legacy-Id: 15131
2018-05-05 12:49:39 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries.
- Legacy-Id: 15127
2018-05-05 12:40:30 +00:00
Henrik Levkowetz 61a16856ad Updated the admin interface to use the simple-history admin support for Person history.
- Legacy-Id: 15097
2018-05-01 11:07:12 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504.
- Legacy-Id: 15095
2018-04-27 14:00:33 +00:00
Henrik Levkowetz 198c003b6a Merged in [15084] from rjsparks@nostrum.com:
Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in.
 - Legacy-Id: 15092
Note: SVN reference [15084] has been migrated to Git commit ee346edaba
2018-04-26 13:41:22 +00:00
Henrik Levkowetz fac57c24a7 Tweaked the wording of coverage_changes output.
- Legacy-Id: 15048
2018-04-17 11:35:36 +00:00
Henrik Levkowetz ab8e73aca5 Included django.utils.html.escape() in the linkify() code, and removed it from various templates, to make sure escape is consistently applied before linkify. Fixes issue #2492.
- Legacy-Id: 15035
2018-04-09 16:36:07 +00:00
Henrik Levkowetz a96c6c4c5b Tweaked the test runner to more consistently force the test coverage tests to be run last.
- Legacy-Id: 15030
2018-04-08 12:42:03 +00:00
Henrik Levkowetz 675c652052 Additional changes to speed up the IESG agenda docs page: Changed telechat_page_count() to accept a list of documents if that's already been generated, to avoid double work. Changed the reviewed_by_teams list to provide acronyms directly, to avoid group lookups during template rendering. Provided page counts directly to the template instead of repeated (costly) filtering through telechat_page_count, with new document lookups. Removed the telechat_page_count template filter, due to its cost. Tweaked some lookups in fill_in_document_table_attributes() . Added to the select_related() list for documents in IESG agenda_documents().
- Legacy-Id: 14988
2018-04-01 18:51:48 +00:00
Henrik Levkowetz ec6424c9c4 Merged in [14882] from rjsparks@nostrum.com:
Replaced line that had mysteriously been deleted before commit.  Sorry for the noise.
 - Legacy-Id: 14905
Note: SVN reference [14882] has been migrated to Git commit 4a7cdf26d3
2018-03-24 13:39:49 +00:00
Henrik Levkowetz a485c74314 Merged in [14880] from rjsparks@nostrum.com:
Added a Draft test suite.
 - Legacy-Id: 14901
Note: SVN reference [14880] has been migrated to Git commit e09a28cad2
2018-03-22 16:34:10 +00:00
Robert Sparks 4a7cdf26d3 Replaced line that had mysteriously been deleted before commit. Commit ready for merge. Sorry for the noise.
- Legacy-Id: 14882
2018-03-20 21:14:46 +00:00