altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 5 Packages Projects Releases Wiki Activity
12922 commits 1 branch 0 tags 2.6 GiB
Commit graph

888 commits

Author SHA1 Message Date
Henrik Levkowetz 0679eaa8d4 Removed unused imports. 
- Legacy-Id: 16402
 2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit 
- Legacy-Id: 16401
 2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output. 
- Legacy-Id: 16400
 2019-07-04 21:01:39 +00:00
Henrik Levkowetz 3a35dfcee4 Changed our parseaddr() and formataddr() to work correctly with python3. 
- Legacy-Id: 16399
 2019-07-04 21:00:48 +00:00
Henrik Levkowetz a3d40ace9b Fixed a str/bytes issue with a hashlib function call, and removed an unused import. 
- Legacy-Id: 16398
 2019-07-04 20:59:40 +00:00
Henrik Levkowetz f33ecaa1a4 Fixed a test that compared an int with a meeting number string. Changed meeting test data to use meeting number 72 instead of 42, because proceedings code gives 404 for meetings before 65. Changed a number of StringIO() to BytesIO(). 
- Legacy-Id: 16378
 2019-07-04 16:01:32 +00:00
Henrik Levkowetz 0589d0b313 Changed a bunch of regexes to use r strings; also miscellaneous smaller fixes. 
- Legacy-Id: 16376
 2019-07-04 15:51:05 +00:00
Henrik Levkowetz fb8d12ac3c Fixed a pyflakes issue. 
- Legacy-Id: 16358
 2019-07-01 19:27:08 +00:00
Henrik Levkowetz 8c66e95a57 Test changes to match production group type changes for some special groups. 
- Legacy-Id: 16357
 2019-07-01 18:30:59 +00:00
Henrik Levkowetz c8e75c554a Various changes to make yang-related management commands quieter 
- Legacy-Id: 16355
 2019-07-01 18:29:03 +00:00
Henrik Levkowetz f5e9583f59 Fixed str/bytes issues with hashlib function arguments. 
- Legacy-Id: 16354
 2019-07-01 14:09:53 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn(). 
- Legacy-Id: 16346
 2019-06-30 21:03:34 +00:00
Henrik Levkowetz 20c44a9e1a Adapted the pipe() code to python3; API changes and str/byte handling. 
- Legacy-Id: 16345
 2019-06-30 21:01:44 +00:00
Henrik Levkowetz 36cac48063 Fixed a bunch of str/bytes issues. 
- Legacy-Id: 16341
 2019-06-30 20:54:09 +00:00
Henrik Levkowetz 70c00950b6 Fixed several email handling str/bytes issues. 
- Legacy-Id: 16334
 2019-06-29 13:30:36 +00:00
Henrik Levkowetz ea109f2b1b Fixed API changes in SMTPChannel 
- Legacy-Id: 16329
 2019-06-28 20:52:15 +00:00
Henrik Levkowetz 1e86ccb4ee Builtin function file() --> open() 
- Legacy-Id: 16328
 2019-06-28 20:51:13 +00:00
Henrik Levkowetz 318bd0d5ea Changed regex strings to r strings. 
- Legacy-Id: 16320
 2019-06-28 13:32:50 +00:00
Henrik Levkowetz e39ac52071 Removed 2to3-generated list() around .items() iterator in for loops. 
- Legacy-Id: 16315
 2019-06-27 18:11:17 +00:00
Henrik Levkowetz 06daf6ac65 Changed regex strings to raw strings. 
- Legacy-Id: 16312
 2019-06-27 18:08:02 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py 
- Legacy-Id: 16310
 2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates. 
- Legacy-Id: 16309
 2019-06-27 14:40:54 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list. 
- Legacy-Id: 16284
 2019-06-18 12:40:19 +00:00
Henrik Levkowetz ba528a0c5e Adjusted the test_runner to generate migration coverage data also when permitting mixed migrations. 
- Legacy-Id: 16280
 2019-06-17 18:24:17 +00:00
Henrik Levkowetz 0e68f4bb4b Added a management command to update the index table used by some community list search rules. 
- Legacy-Id: 16273
 2019-06-17 13:02:57 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias. 
- Legacy-Id: 16261
 2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs. 
- Legacy-Id: 16249
 2019-06-14 20:38:14 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias 
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
 2019-06-10 11:32:46 +00:00
Henrik Levkowetz ca1f3340c0 Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability. 
- Legacy-Id: 16181
 2019-05-02 12:38:41 +00:00
Henrik Levkowetz 7b93709a3b Tweaked the greate_group_wikis management command to accept trailing fileglob wildcards on adhoc wiki group acronyms. Added a generic NomCom wiki to the list of adhoc wikis to be created and maintained, with admins from active nomcom* groups. 
- Legacy-Id: 16176
 2019-04-29 12:30:36 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly. 
- Legacy-Id: 16020
 2019-03-11 17:01:33 +00:00
Henrik Levkowetz fc18cd93d4 Tweaked coverage_changes command. I suspect this would benefit from a rewrite. 
- Legacy-Id: 16019
 2019-03-11 16:52:09 +00:00
Henrik Levkowetz d698eb98df Changed the on-behalf-of name template from 'On behalf of ...' to '... via Datatracker' to make name come first. 
- Legacy-Id: 16009
 2019-03-07 14:42:11 +00:00
Henrik Levkowetz d57088b1f3 Modified one call and one exception point related to on_behalf_of() use for email sending. 
- Legacy-Id: 16008
 2019-03-06 19:13:15 +00:00
Henrik Levkowetz 8a669909bc Changed ietf/utils/mail.py to use unicode strings, and changed a call in ietf/reviv/utils.py to use unicode for mail Subject, to fix a server 500 issue. 
- Legacy-Id: 16007
 2019-03-06 16:57:00 +00:00
Henrik Levkowetz 5c6ab60f85 Changed a log() call to use unicode string interpolation to handle unicode email address names. 
- Legacy-Id: 15999
 2019-03-05 17:29:43 +00:00
Henrik Levkowetz ae8c1f2b91 Updated test_data email addresses. 
- Legacy-Id: 15991
 2019-03-04 20:13:02 +00:00
Henrik Levkowetz 849a3dcc97 Added another exception class to a catch instance in a function, triggered by a new usage case. 
- Legacy-Id: 15990
 2019-03-04 20:12:30 +00:00
Henrik Levkowetz 2b811b3d3d Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org. 
- Legacy-Id: 15988
 2019-03-04 20:08:48 +00:00
Henrik Levkowetz 46bb4539c5 Added two new functions to replace email From: of users with On-behalf-of addresses, with associated values in settings. Added a catchall stanza in the mail sending pipeline to catch anything not already changed to On-behalf-of addresses. 
- Legacy-Id: 15987
 2019-03-04 20:06:44 +00:00
Henrik Levkowetz fd62a25f4e Added a missing variable initialization. 
- Legacy-Id: 15925
 2019-02-04 11:26:29 +00:00
Henrik Levkowetz ef97f2a821 Merged in GroupFeatures refactoring and expansion from ^/personal/henrik/6.89.4.dev0@15911. 
- Legacy-Id: 15912
 2019-01-24 15:25:01 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code. 
- Legacy-Id: 15908
 2019-01-22 18:11:46 +00:00
Henrik Levkowetz d19228110c Applied a patch from dkg@fifthhorseman.net: py3 compatibility: fix another instance of integer division 
- Legacy-Id: 15896
 2019-01-15 17:50:33 +00:00
Henrik Levkowetz 98a74bd7f3 Moved __future__ imports down so as not to obscure the module docstring. Fixes inability to run '$ ietf/utils/draft.py -h'. 
- Legacy-Id: 15894
 2019-01-14 22:28:52 +00:00
Henrik Levkowetz 910d3d7723 Applied a patch from dkg@fifthhorseman.net: py3 compatibility: Use a list of dictionary keys 
In python3, dict.keys() produces a dict_keys object, not a list.
    Since this code treats it as a list, we'll just be explicit about
    that.
 - Legacy-Id: 15893
 2019-01-14 21:06:08 +00:00
Henrik Levkowetz c8f98e125c Applied a patch from dkg@fifthhorseman.net: Fix regex manipulation for word characters. 
in python 3.7, re.sub() started treating unknown escape sequences in
     as errors.  Fix this by sending an escaped \ where we mean to
    pass it through raw.
    
    https://docs.python.org/3/library/re.html#re.sub
 - Legacy-Id: 15892
 2019-01-14 21:03:28 +00:00
Henrik Levkowetz e39358312b Applied a patch from dkg@fifthhorseman.net: py3 compatibility: Use // for explicit integer division 
Without this fix, in modern versions of python, the changed line
    produces:
    
    TypeError: 'float' object cannot be interpreted as an integer
 - Legacy-Id: 15891
 2019-01-14 21:02:01 +00:00
Henrik Levkowetz e718272e71 Applied a patch from dkg@fifthhorseman.net: py3 compatibility: Use modern form of exception handling 
- Legacy-Id: 15890
 2019-01-14 21:00:50 +00:00
Henrik Levkowetz 8840efaef4 Applied a patch from dkg@fifthhorseman.net: py3 compatibility: use print function. 
- Legacy-Id: 15889
 2019-01-14 20:56:59 +00:00
Henrik Levkowetz 00544eb534 Merged in [15846] from rjsparks@nostrum.com: 
Simple tests of some log utilities.
 - Legacy-Id: 15875
Note: SVN reference [15846] has been migrated to Git commit 1e1d92aa0d
 2019-01-07 22:09:19 +00:00
Henrik Levkowetz 8e60e19d01 Merged in [15845] from rjsparks@nostrum.com: 
simple test of BowerStorageFinder.
 - Legacy-Id: 15874
Note: SVN reference [15845] has been migrated to Git commit a4f334195e
 2019-01-07 21:34:52 +00:00
Henrik Levkowetz 0cc7f73d58 Additional tweaks to submission yang testing and the test runner 
- Legacy-Id: 15870
 2019-01-07 13:38:44 +00:00
Robert Sparks 1e1d92aa0d Simple tests of some log utilities. Commit ready for merge. 
- Legacy-Id: 15846
 2018-12-20 20:33:02 +00:00
Robert Sparks a4f334195e simple test of BowerStorageFinder. Commit ready for merge. 
- Legacy-Id: 15845
 2018-12-20 19:13:35 +00:00
Henrik Levkowetz 2d0c503d33 Fixed pyflakes issues 
- Legacy-Id: 15792
 2018-11-30 00:07:49 +00:00
Henrik Levkowetz 0e8f63951e Added two new management commands to make it easier to load back selected objects that have been removed by mistake (providing they are available in a full database dump or backup that can be loaded and worked with): dumprelated and loadrelated. 
- Legacy-Id: 15790
 2018-11-29 15:17:46 +00:00
Henrik Levkowetz 2397f97da3 Updated test_unicode() to work with the latest version of the unidecode lib. 
- Legacy-Id: 15780
 2018-11-20 16:08:51 +00:00
Henrik Levkowetz 1d604b7cd9 Another name test tweak 
- Legacy-Id: 15773
 2018-11-13 21:50:28 +00:00
Henrik Levkowetz fad6311a13 Fixed a test problem. 
- Legacy-Id: 15772
 2018-11-13 21:12:25 +00:00
Henrik Levkowetz d6caf615e0 Added testing of test_unidecode() and another name_parts() test case, and removed some debug.statements. 
- Legacy-Id: 15771
 2018-11-13 19:31:18 +00:00
Henrik Levkowetz e471386cf2 Merged in [15715] from rcross@amsl.com: 
Fix issue where new non-session location field value isn't saved.  Fixes #2625.
 - Legacy-Id: 15756
Note: SVN reference [15715] has been migrated to Git commit a47fba833f
 2018-11-12 13:35:17 +00:00
Henrik Levkowetz 0735021d2b Added a test for various name part combinations, and fixed a couple of issues with utils.name.name_parts(). 
- Legacy-Id: 15753
 2018-11-11 15:12:20 +00:00
Henrik Levkowetz e024cca8c4 Merged in [15708] and [15730] from housley@vigilsec.com: 
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15747
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
 2018-11-10 20:32:42 +00:00
Ryan Cross a47fba833f Fix issue where new non-session location field value isn't saved. Fixes #2625. Commit ready for merge. 
- Legacy-Id: 15715
 2018-11-05 04:25:20 +00:00
Henrik Levkowetz ef3cbf4684 Merged in [15595] from rjsparks@nostrum.com: 
Converted stats, submit, sync. and utils/test to use factories. Excluded utils/test_data from coverage checks.
 - Legacy-Id: 15599
Note: SVN reference [15595] has been migrated to Git commit 39e76a836996ec9ed8ea449c92bdfae91c3dbaae
 2018-10-19 12:54:58 +00:00
Henrik Levkowetz d0b73e9b67 Tweaked the mail sending routines' handling of the copy flag. 
- Legacy-Id: 15586
 2018-10-16 15:05:17 +00:00
Henrik Levkowetz e20e8b7df5 Changed the mail sending routines so it's possible to not copy the debug archive on some messages. 
- Legacy-Id: 15585
 2018-10-16 14:32:10 +00:00
Henrik Levkowetz 0e52b30e5b Added the message-id to log lines for sent messages 
- Legacy-Id: 15582
 2018-10-15 18:46:45 +00:00
Henrik Levkowetz caeb6fcb87 Added a '--reminder' switch to the GDPR request mailer, for repeat notifications. 
- Legacy-Id: 15530
 2018-10-07 22:05:26 +00:00
Henrik Levkowetz 43dd7d5e90 Tweaked the management command to send GDPR consent request emails to correctly perform exclusion based on the time of previous consent request emails. 
- Legacy-Id: 15504
 2018-09-29 20:08:09 +00:00
Henrik Levkowetz 1dd47e18f5 Whitespace changes only. 
- Legacy-Id: 15499
 2018-09-29 12:46:12 +00:00
Henrik Levkowetz 7ea8a3f431 Tweaked the gdpr reminder command to avoid bounces to RT and copies to gmail. 
- Legacy-Id: 15480
 2018-09-24 18:37:45 +00:00
Henrik Levkowetz 30f456f83a Changed the default minimum response time used by the delete_data_lacking_consent management command from 14 to 7 days. 
- Legacy-Id: 15466
 2018-09-18 13:35:27 +00:00
Henrik Levkowetz 4fba531e9e Merged in the latest GDPR changes. This refines the handling of the consent checkbox on the account page; refines the Consent Needed warning given on login if consent is needed; tweaks several models to set the on_deletion fields for FK to User and Person appropriately; adds a Person.needs_consent() method to capture the logic of which fields require consent; refines the Person.plain_name() method and the user.log.log() function; and adds 2 management commands to send out consent requests and delete non-consent information, respectively. 
- Legacy-Id: 15464
 2018-09-16 23:12:43 +00:00
Henrik Levkowetz a389e24fb6 Refined utils.log.log() to flush stdout before logging if we're writing log messages to stderr. 
- Legacy-Id: 15463
 2018-09-16 14:14:26 +00:00
Henrik Levkowetz b85e1c46d9 Added a delete_data_lacking_consent management command that deletes person records and person information for which we need consent according to GDPR, but have not received it. 
- Legacy-Id: 15461
 2018-09-16 13:54:32 +00:00
Henrik Levkowetz 3f9dbeada8 Expanded the send_gdpr_consent_request command to add support for deletion dates, email reminder interval, email sending rate limiting, and sending to a list of users. 
- Legacy-Id: 15460
 2018-09-16 13:52:29 +00:00
Henrik Levkowetz b2bfc7858a Generalized the log.assertion() function a bit to be able to provide more information on assertion failure. 
- Legacy-Id: 15426
 2018-08-10 15:31:12 +00:00
Henrik Levkowetz e53318084d Added a tiny utility function unwrap() to unwrap wrapped text for matching expected strings in tests. 
- Legacy-Id: 15396
 2018-07-19 15:53:05 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held 
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
 2018-07-12 10:51:48 +00:00
Henrik Levkowetz e87442f33a Merged in [15282] from housley@vigilsec.com: 
Set reply-to for I-D Announcements that include a CC to a mail list.  Fixes #2530.
 - Legacy-Id: 15289
Note: SVN reference [15282] has been migrated to Git commit 733c304e3d
 2018-07-10 17:16:47 +00:00
Henrik Levkowetz dbfdb94c34 Merged in [15267] from rcross@amsl.com: 
Fix issue with decorator on utils.html.remove_tags().
 - Legacy-Id: 15270
Note: SVN reference [15267] has been migrated to Git commit 0d255f7d0874f01163f292568e76fa9d830a54e2
 2018-06-19 21:23:35 +00:00
Henrik Levkowetz 97db5f71b5 Added a management command to send out gdpr consent requests. 
- Legacy-Id: 15269
 2018-06-19 19:23:46 +00:00
Robert Sparks b86bd84278 Improvements to tests after converting to factories suggested by studying coverage_changes. Commit ready to merge. 
- Legacy-Id: 15248
 2018-06-13 22:09:01 +00:00
Henrik Levkowetz 4db4dd16b0 Merged in ^/personal/henrik/6.79.1-gdpr@15180 containing GDPR-adaptations. 
- Legacy-Id: 15181
 2018-05-28 11:26:24 +00:00
Henrik Levkowetz 2522082979 Changed the email origin field during test to hold user.username in order to exercise more of the code. Changed the EmailFactory to also use user.username as origin. 
- Legacy-Id: 15172
 2018-05-26 08:32:20 +00:00
Robert Sparks 25e9893a13 Changed how the mail utilities handle lists in their override and extra arguments. Added a test for send_mail_preformatted exercising override and extra. Commit ready for merge. 
- Legacy-Id: 15153
 2018-05-22 15:38:04 +00:00
Henrik Levkowetz df7df69a59 Updated comment text 
- Legacy-Id: 15131
 2018-05-05 12:49:39 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries. 
- Legacy-Id: 15127
 2018-05-05 12:40:30 +00:00
Henrik Levkowetz 61a16856ad Updated the admin interface to use the simple-history admin support for Person history. 
- Legacy-Id: 15097
 2018-05-01 11:07:12 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504. 
- Legacy-Id: 15095
 2018-04-27 14:00:33 +00:00
Henrik Levkowetz 198c003b6a Merged in [15084] from rjsparks@nostrum.com: 
Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in.
 - Legacy-Id: 15092
Note: SVN reference [15084] has been migrated to Git commit ee346edaba
 2018-04-26 13:41:22 +00:00
Henrik Levkowetz fac57c24a7 Tweaked the wording of coverage_changes output. 
- Legacy-Id: 15048
 2018-04-17 11:35:36 +00:00
Henrik Levkowetz ab8e73aca5 Included django.utils.html.escape() in the linkify() code, and removed it from various templates, to make sure escape is consistently applied before linkify. Fixes issue #2492. 
- Legacy-Id: 15035
 2018-04-09 16:36:07 +00:00
Henrik Levkowetz a96c6c4c5b Tweaked the test runner to more consistently force the test coverage tests to be run last. 
- Legacy-Id: 15030
 2018-04-08 12:42:03 +00:00
Henrik Levkowetz 675c652052 Additional changes to speed up the IESG agenda docs page: Changed telechat_page_count() to accept a list of documents if that's already been generated, to avoid double work. Changed the reviewed_by_teams list to provide acronyms directly, to avoid group lookups during template rendering. Provided page counts directly to the template instead of repeated (costly) filtering through telechat_page_count, with new document lookups. Removed the telechat_page_count template filter, due to its cost. Tweaked some lookups in fill_in_document_table_attributes() . Added to the select_related() list for documents in IESG agenda_documents(). 
- Legacy-Id: 14988
 2018-04-01 18:51:48 +00:00
Henrik Levkowetz ec6424c9c4 Merged in [14882] from rjsparks@nostrum.com: 
Replaced line that had mysteriously been deleted before commit.  Sorry for the noise.
 - Legacy-Id: 14905
Note: SVN reference [14882] has been migrated to Git commit 4a7cdf26d3
 2018-03-24 13:39:49 +00:00
Henrik Levkowetz a485c74314 Merged in [14880] from rjsparks@nostrum.com: 
Added a Draft test suite.
 - Legacy-Id: 14901
Note: SVN reference [14880] has been migrated to Git commit e09a28cad2
 2018-03-22 16:34:10 +00:00
Robert Sparks 4a7cdf26d3 Replaced line that had mysteriously been deleted before commit. Commit ready for merge. Sorry for the noise. 
- Legacy-Id: 14882
 2018-03-20 21:14:46 +00:00
Robert Sparks e09a28cad2 Failed to add a file in a previous commit. Commit ready for merge. 
- Legacy-Id: 14880
 2018-03-20 18:21:37 +00:00
Henrik Levkowetz 75deb35e10 Merged in [14851] from housley@vigilsec.com: 
Improve parser for references in Internet-Drafts. Fixes #2360
 - Legacy-Id: 14867
Note: SVN reference [14851] has been migrated to Git commit 565b10e00e
 2018-03-19 22:37:03 +00:00
Russ Housley 565b10e00e Improve parser for references in Internet-Drafts. Fixes #2360 
- Legacy-Id: 14851
 2018-03-17 18:25:31 +00:00
Henrik Levkowetz 63c97ad439 Fixed a bug in a RegexValidator error message string interpolation. 
- Legacy-Id: 14841
 2018-03-17 13:09:58 +00:00
Henrik Levkowetz 9341f96832 Tweaked the document sanitizer to insert a charset meta tag after sanitization. 
- Legacy-Id: 14832
 2018-03-16 11:13:03 +00:00
Henrik Levkowetz 428c451692 Added a missing tag to the sanitizer whitelist (telling lxml's Cleaner to not clean style with style=False is apparently not always enough). Fixes issue #2470. 
- Legacy-Id: 14794
 2018-03-14 18:52:11 +00:00
Henrik Levkowetz 02105889b6 Tweaked the mime type validator so it can be called also when there's no required mime types. 
- Legacy-Id: 14779
 2018-03-13 13:54:04 +00:00
Henrik Levkowetz 2b52919c5e Added sanitize_document() and replaced sanitize_html() with sanitize_fragment() in utils.html 
- Legacy-Id: 14776
 2018-03-13 13:21:41 +00:00
Henrik Levkowetz f3f77dce48 Changed order of arguments in a test assert for better error legibility. 
- Legacy-Id: 14774
 2018-03-13 12:38:53 +00:00
Henrik Levkowetz 724f1ceccc Added xmpp as an acceptable protocol in links when sanitizing. 
- Legacy-Id: 14766
 2018-03-12 13:17:41 +00:00
Henrik Levkowetz 3b7a191feb Removed a debug print statement 
- Legacy-Id: 14753
 2018-03-09 15:49:25 +00:00
Henrik Levkowetz 2c0348cc7a Found that django's urlize() does not deal well with adjacent parantheses. Replaced it with a filter based on bleach.linkify, which does better. 
- Legacy-Id: 14752
 2018-03-09 15:07:04 +00:00
Henrik Levkowetz 2fd344f810 Tweaks to handle text types better and make set operation clearer. 
- Legacy-Id: 14745
 2018-03-07 21:10:47 +00:00
Henrik Levkowetz 802f201d81 Modified the sanitizer and upload handler to strip also the content of some tags, and to produce valid files (if the content is otherwise valid). 
- Legacy-Id: 14744
 2018-03-07 19:00:24 +00:00
Henrik Levkowetz 5964cdd880 Removed unused data. 
- Legacy-Id: 14741
 2018-03-07 08:24:43 +00:00
Henrik Levkowetz 2828683cee Replaced html sanitization code that called html5lib directly with calls to bleach, and upgraded the requirements to let us use the latest html5lib and bleach. 
- Legacy-Id: 14739
 2018-03-06 18:35:34 +00:00
Henrik Levkowetz b92ad2f992 Added sanitization of uploaded html content for session agendas and minutes, and did some refactoring of the upload form classes. 
- Legacy-Id: 14738
 2018-03-06 15:55:30 +00:00
Henrik Levkowetz 0800304b67 Added TeX escaping utility functions and template filters. Removed 
html escaping and added TeX escaping for relevant parts of the bibtext
template.  Fixes issue #2459.
 - Legacy-Id: 14711
 2018-02-27 18:15:21 +00:00
Henrik Levkowetz 9ffe1e425a Reverted unintentional commit 
- Legacy-Id: 14709
 2018-02-27 17:58:25 +00:00
Henrik Levkowetz a5db4d00de Updated PLAN 
- Legacy-Id: 14708
 2018-02-27 17:55:43 +00:00
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11 
- Legacy-Id: 14695
 2018-02-25 19:55:16 +00:00
Henrik Levkowetz 71a9ffafc5 Changed allow_lazy to the @keep_lazy decorator. 
- Legacy-Id: 14674
 2018-02-22 00:13:32 +00:00
Henrik Levkowetz 36b5e2ef8e Changed name from .rel to .remote_field for remote accessors. 
- Legacy-Id: 14665
 2018-02-21 23:56:36 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations. 
- Legacy-Id: 14662
 2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models. 
- Legacy-Id: 14661
 2018-02-20 15:36:05 +00:00
Henrik Levkowetz c760792339 Added proxy ForeignKey and OneToOneField classes which set the now required on_delete parameter on the fields to the legacy value. 
- Legacy-Id: 14660
 2018-02-20 15:33:20 +00:00
Henrik Levkowetz dd7853c7a3 Check line lenght before assuming there's a first character. 
- Legacy-Id: 14619
 2018-02-06 15:18:11 +00:00
Henrik Levkowetz a4cc4bba2e Merged in ^/personal/henrik/6.68.4-ipr@14609 from henrik@levkowetz.com: 
Changes to the IPR disclosure pages, requested during WG Chairs Lunch where the changes to IPR handling introduced by RFC8179 were presented.
 - Legacy-Id: 14610
 2018-02-01 15:41:34 +00:00
Henrik Levkowetz 2687c8d839 Added a workaround for libmagic mislabelling plain text content with a line beginning with 'virtual' as text/x-c++. 
- Legacy-Id: 14586
 2018-01-30 08:29:21 +00:00
Henrik Levkowetz a3d1d5595d Added an option to list the slugs that can be used with the generate_apache_perms management command. 
- Legacy-Id: 14576
 2018-01-26 22:40:48 +00:00
Henrik Levkowetz fd01a612b7 Added a management command to generate apache 'Require user ...' stanzas from group:type:role specifications. 
- Legacy-Id: 14574
 2018-01-26 20:43:40 +00:00
Henrik Levkowetz d6e4404d63 Only do coverage set/reset operations if we're in test mode. Fixes a 500 error during draft submission yang checking. 
- Legacy-Id: 14569
 2018-01-25 11:31:38 +00:00
Henrik Levkowetz 717868cae2 Rewrote text_to_dict() and dict_to_text() to support unicode without RFC2822 encoding issues. Added initial values in IPR update forms, from the original disclosure, in order to make updates easier. Addresses issue #2413. 
- Legacy-Id: 14531
 2018-01-17 00:21:34 +00:00
Henrik Levkowetz 008eaf7fda Modified the run_yang_model_checks management command to accept document aliases on the command line. 
- Legacy-Id: 14443
 2017-12-19 14:09:40 +00:00
Henrik Levkowetz 6567e707ce Merged in ^/personal/henrik/6.64.2-ballotapi@14426. This provides personal API keys and a ballot position API at /api/iesg/position. Also added an endpoint description at /api/. 
- Legacy-Id: 14430
 2017-12-17 23:43:44 +00:00
Henrik Levkowetz a08c8dc76f Added an API endpoint to support automation of IESG ballot position posting, at /api/iesg/position. Added tests for the API endpoint, and updated the apikey validation decorator tests. Tweaked the decorator to handle a weakness found during testing. 
- Legacy-Id: 14429
 2017-12-17 21:55:27 +00:00
Henrik Levkowetz b0863c8963 Modified some names. 
- Legacy-Id: 14428
 2017-12-16 18:43:08 +00:00
Henrik Levkowetz ec4e238185 Added some missing files. 
- Legacy-Id: 14427
 2017-12-16 18:39:26 +00:00
Henrik Levkowetz e7209c6e50 Added a new personal event table to keep track of personal API key logins, and a management command to send out reports about activity to users with API keys. Added a weekly cronjob script to trigger weekly reports, and a monthly script for future use. Added a @require_api_key decorator to validate API keys for API key views and log in the API key owner. Modified the API key management urls to use create and disable rather than add and delete. Updated the API key list view. Added an API placeholder view function for ballot position setting, for test purposes. Added tests for the decorator and management command. 
- Legacy-Id: 14426
 2017-12-16 18:37:52 +00:00
Henrik Levkowetz 152261a869 Added new infrastructure for personal API keys, to generate, view, and delete them. 
- Legacy-Id: 14423
 2017-12-14 14:30:59 +00:00
Henrik Levkowetz 660c81c272 Tweaked the file content read refactoring in [14406] to try latin-1 conversion if unicode doesn't work. 
- Legacy-Id: 14410
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d
 2017-12-10 17:48:09 +00:00
Henrik Levkowetz 967ece7e7d Started refactoring of reading text from document files (drafts, charters, etc.) in order to normalise on one way of doing this, and making that return unicode rather than undecoded bytes. This is the first step of two, in order to gauge the possible issues and report on discrepancies. 
- Legacy-Id: 14406
 2017-12-08 21:51:11 +00:00
Henrik Levkowetz 3cd3c3526f Tweaked the coverage_changes management comand output. 
- Legacy-Id: 14402
 2017-12-06 13:31:33 +00:00
Henrik Levkowetz 57c18ef3fe Changed settings and handling of adhoc wiki paths to be more testing-friendly. 
- Legacy-Id: 14390
 2017-12-04 15:09:03 +00:00
Henrik Levkowetz 47a0b9d3ce Changed handling of yang modeules from drafts with errors, to not place them in separate directories, due to possible follow-on effects. Added use of IANA-held modules when validating, and regular rsyncing from IANA. 
- Legacy-Id: 14389
 2017-12-04 14:37:15 +00:00
Henrik Levkowetz 98d234cd86 Refactored the handling of BallotDocEvent in tests, only creating them as needed, in preparation for stricter checks on state transitions to avoid mismatches between state and ballot. 
- Legacy-Id: 14380
 2017-11-30 16:02:31 +00:00
Henrik Levkowetz b29e096f92 Added a test for the IESG past documents page, and tweaked some test documents to have titles. 
- Legacy-Id: 14303
 2017-11-04 16:15:39 +00:00
Henrik Levkowetz 260bac9346 Updated some tests to match api views refactoring. 
- Legacy-Id: 14295
 2017-11-03 16:42:09 +00:00
Henrik Levkowetz 3269a696fe Variable naming fix 
- Legacy-Id: 14286
 2017-11-03 10:36:50 +00:00
Henrik Levkowetz 23a3056260 Fixed a typo. 
- Legacy-Id: 14270
 2017-11-01 14:51:08 +00:00
Henrik Levkowetz 6e23f99019 Improved the help message for the run_yang_model_checks management command. 
- Legacy-Id: 14267
 2017-11-01 14:39:53 +00:00
Henrik Levkowetz 48fe02d58c Permit tildes in romanization of draft author names when looking for draft authors. Can be used in romanization of arabic names. 
- Legacy-Id: 14256
 2017-11-01 11:51:24 +00:00
Henrik Levkowetz af64f0e064 Fixed a call parameter list discrepancy. 
- Legacy-Id: 14252
 2017-11-01 05:07:35 +00:00
Henrik Levkowetz 09d8ad1e1b Fixed some pyflakes issues. 
- Legacy-Id: 14238
 2017-10-30 11:47:05 +00:00
Henrik Levkowetz 1a7e9b619a Added support for ad-hoc trac instances, with arbitrary names and filesystem paths, but still bound to a particular group's roles for management of trac admin rights. 
- Legacy-Id: 14232
 2017-10-30 11:10:15 +00:00
Henrik Levkowetz 9be7d57a03 Tweaked the test-runner random state handling to display the correct random state filename and make sure to set the same random state. 
- Legacy-Id: 14209
 2017-10-14 12:05:01 +00:00
Henrik Levkowetz 0e00adc5ee Another tweak to the draft author extraction code, to handle some name transliterations using multiple leading grave accents. 
- Legacy-Id: 14149
 2017-09-21 09:28:18 +00:00
Henrik Levkowetz 2c1438c240 Moved unidecode_name from utils.text to person.name. 
Modified UserFactory to use a new locale for each new user, instead of the
same locale for a whole test run.  This (almost) ensures the exercise of
code to deal with non-ascii names, something which would not happen if a
locale with ascii names was chosen at the start of a run.

Modified name.initials() to not use non-word characters as initials.

Modified unidecode_name() to do more normalization, to conform to the
conventions used in internet-drafts.

Added saving of the factory-boy random state in order to be able to re-run
a test suite with the same pseudo-random sequence as in a previous failed
run.

Fixed an issue with email formatting in test_api_submit_ok().

Modified the draft author extraction code to deal better with names with
embedded apostrophes.
 - Legacy-Id: 14141
 2017-09-20 15:36:30 +00:00
Henrik Levkowetz 1530a6c394 Added a new TestCase assertion: assertMailboxContains(), to be able to better express some test cases. 
- Legacy-Id: 14139
 2017-09-19 19:47:48 +00:00
Henrik Levkowetz 33b275b04f Added ietf.utils.text.unidecode_name() and replaced various uses of unidecode() with it, in order to normalize the generation of ascii versions of names, to avoid different practices in space stripping and space normalization in different parts of the code. 
- Legacy-Id: 14128
 2017-09-17 15:12:18 +00:00
Henrik Levkowetz 9f785c0dce Tweaked the test util function create_person() to create ascii-only .ascii fields, which it did not do before. 
- Legacy-Id: 14123
 2017-09-16 09:21:45 +00:00
Henrik Levkowetz aafd6290a6 Added an option to ietf.utils.draft.Draft to pull document name from the source file name. 
- Legacy-Id: 14089
 2017-08-31 14:48:43 +00:00
Henrik Levkowetz aaccbba6e8 Fixed a bug in coverage_changes. 
- Legacy-Id: 14037
 2017-08-10 10:53:59 +00:00
Henrik Levkowetz 1eeaf49c5c Added an error exit when the test runner is invoked with incompatible switches (--parallel and --html-report) 
- Legacy-Id: 14024
 2017-08-02 13:00:16 +00:00
Henrik Levkowetz 4dad8cdf9a Added a test to check for missing admin models, and added the admin models that were currently missing. 
- Legacy-Id: 14021
 2017-08-01 14:00:29 +00:00
Henrik Levkowetz 138f3d7382 Fixed a variable initialization issue. 
- Legacy-Id: 14009
 2017-07-30 14:33:34 +00:00
Henrik Levkowetz 2070a4efcf Fixed a pyflakes issue. 
- Legacy-Id: 14008
 2017-07-30 13:55:30 +00:00
Henrik Levkowetz 8a53653682 Added detailed line-by line changes in code coverage to the coverage_changes management command. Use verbosity 2 or higher. 
- Legacy-Id: 14007
 2017-07-30 13:50:06 +00:00
Henrik Levkowetz d00921b94b Added a new release-coverage format which whould make it easier to show line-by-line code test coverage changes in the future. 
- Legacy-Id: 13967
 2017-07-24 17:38:00 +00:00
Henrik Levkowetz 2de6855ccd Fixed a time arithmetics issue in meeting cutoff date methods 
- Legacy-Id: 13966
 2017-07-23 14:47:46 +00:00
Henrik Levkowetz 15f8b4504e Change the test telechat dates so that the first active telechat doesn't change to lie in the past if the tests are run across midnight. 
- Legacy-Id: 13889
 2017-07-15 10:01:35 +00:00
Henrik Levkowetz 86b252c90e Some refactoring of the agenda and minutes validation work. 
- Legacy-Id: 13850
 2017-07-13 10:42:48 +00:00
Henrik Levkowetz 46fc7b77fd Added more validation of extension, mime type, etc. for uploaded meeting agendas and minutes. Added '.md' (markdown) as an accepted file type. Html with frames is now rejected. Factored out validation code into separate functions. 
- Legacy-Id: 13849
 2017-07-12 22:45:57 +00:00
Henrik Levkowetz d2395f9521 Merged in [13832] from rjsparks@nostrum.com: 
Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so.
 - Legacy-Id: 13836
Note: SVN reference [13832] has been migrated to Git commit 2c92aa213d
 2017-07-11 21:57:01 +00:00
Robert Sparks 2c92aa213d Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so. Commit ready for merge. 
- Legacy-Id: 13832
 2017-07-11 19:12:21 +00:00
Henrik Levkowetz 95ddc35eae Added wiki creation for groups in state 'bof' 
- Legacy-Id: 13829
 2017-07-11 16:06:00 +00:00
Henrik Levkowetz 2c39de61ab Replaced the local copy of the draft/rfc htmlization code with rfc2html as installed modeule. 
- Legacy-Id: 13827
 2017-07-11 13:52:08 +00:00
Henrik Levkowetz eceed7476d Added the html_report switch setting to the test runner object. 
- Legacy-Id: 13822
 2017-07-09 18:10:51 +00:00
Henrik Levkowetz ca921fe45d Added a switch to control generation of the code coverage html report, which now defaults to false. The report can be generated post-testing with "coverage html -d static/coverage/". 
- Legacy-Id: 13821
 2017-07-09 16:50:38 +00:00
Henrik Levkowetz d26c7085c6 Added code coverage settings and configuration to ignore debug-related lines of code. 
- Legacy-Id: 13817
 2017-07-09 15:00:22 +00:00
Henrik Levkowetz 42b1a41227 Added the new format '4' to the list of recognized formats in the coverage_changes management command. 
- Legacy-Id: 13766
 2017-07-03 21:18:46 +00:00
Henrik Levkowetz 97a5ed1f6c Added a test to verify that we can load the 500 page template 
- Legacy-Id: 13765
 2017-07-03 21:17:45 +00:00
Henrik Levkowetz fb88596c59 Fixed an issue with the scope of the logfunc variable in production. 
- Legacy-Id: 13761
 2017-07-03 14:03:53 +00:00
Henrik Levkowetz db96292229 Added a utility function to show just the text content of the test client response. 
- Legacy-Id: 13737
 2017-06-30 11:45:24 +00:00
Henrik Levkowetz 2070bbfed6 Merged in [13722] and [13712] from rcross@amsl.com: 
Remove all use of request.session from secretariat apps.  Add tests for affected views.  Fixes #1455.
 - Legacy-Id: 13724
Note: SVN reference [13712] has been migrated to Git commit 915b445bcffcd4687fb1677230b98282d22dd9a0

Note: SVN reference [13722] has been migrated to Git commit 3a2cb9d3d846168f75d9796b4e5383bdf10b1f60
 2017-06-28 14:55:10 +00:00
Henrik Levkowetz f6f0278859 Changed the url coverage code to handle deeper chains of url includes, and to handle url includes through url lists in addition to url modules. Added information in the release coverage dictionaries about the view functions coupled to the urls. 
- Legacy-Id: 13706
 2017-06-22 15:07:06 +00:00
Henrik Levkowetz 5e80e00aea Corrected the settings names used in the yang extraction command. 
- Legacy-Id: 13695
 2017-06-20 14:06:42 +00:00
Henrik Levkowetz b42f1cbeb5 Replaced the use of unaccent.asciify(), which has similar functionality to unidecode.unidecode(). Changed the draft parser to work exclusively with unicode text, which both makes the removal of unaccent easier, and takes us closer to Py35 compatibility. Adjusted callers of the draft parser to send in unicode. 
- Legacy-Id: 13673
 2017-06-18 18:23:18 +00:00
Henrik Levkowetz be80e68b47 Corrected the spelling of norwegian words in unaccent.py 
- Legacy-Id: 13671
 2017-06-18 09:33:51 +00:00
Henrik Levkowetz a18cf20868 Removed code which has been marked as unreachable since February/March 2017 without triggering any usage indications. 
- Legacy-Id: 13667
 2017-06-17 17:54:40 +00:00
Henrik Levkowetz e6c8b6621c Changed mentions of people with roles on the various group pages to link to both their profile page and their email address. 
- Legacy-Id: 13664
 2017-06-17 17:05:38 +00:00
Henrik Levkowetz 34a2352288 Make sure wordwrap() and friend works as intended if they are used as template filters and given string arguments. 
- Legacy-Id: 13653
 2017-06-16 13:15:02 +00:00
Henrik Levkowetz 8d420d4d2f Added initial data to the versioninfo migration. 
- Legacy-Id: 13638
 2017-06-16 08:55:31 +00:00
Henrik Levkowetz c4b64e51af Updated the VersionInfo migration. 
- Legacy-Id: 13637
 2017-06-16 08:45:11 +00:00
Henrik Levkowetz d98054c103 Added a new yang checker, 'yanglint', to the existing Yang checker class, in 
addition to the existing 'pyang' checker.

Added modal overlay displays showing the yang check results every place the
yin/yang symbol is shown (red or green) to indicate the presencee and result
of yang checks.  Added a Yang Validation: line in the document
meta-information section on the document's page in the datatracker.

Added the result of the xym extaction to the yang check results, to make
extration failures visible.

Added the version of the used xym, pyang, and yanglint commands to the check
results.

Added an action to move successfully extracted and validated modules to the
module library directories immediately on submission.

Added the xym and pyang repositories as svn:external components, rather than
listing them in requirements.txt, as there has been delays of many months
between essential features in the repositories, and an actual release.  We may
get occasional buildbot failures if broken code is pulled in from the
repository, but better that than the functionality failure of severely
outdated componets.

Added a new management command to re-run yang validation for active drafts for
which yang modules were found at submission time, in order to pick up imported
models which may have arrived in the model libraries after the draft's
submission.  Run daily from bin/daily.

Added a table to hold version information for external commands.  The yang
checker output should include the version information of the used checkers,
but seems unnecessary to run each command with its --version switch every
time we check a module...

Added a new management command to collect version information for external
commands on demand.  To be run daily from bin/daily.

Added tests to verify that xym, pyang and yanglint information is available
on the submission confirmation page, and updated the yang module contained in
the test document to validate under both pyang and yanglint.

Updated admin.py and resource.py files as needed.
 - Legacy-Id: 13630
 2017-06-15 16:09:28 +00:00
Henrik Levkowetz 9bd64ba6f2 Merged in [13559] from rcross@amsl.com: 
When changing a TelechatDate in the admin interface, retain all document associations.  Fixes #1349.
 - Legacy-Id: 13577
Note: SVN reference [13559] has been migrated to Git commit 77f4bf21ff
 2017-06-10 05:33:36 +00:00
Henrik Levkowetz 4dcdda08d2 Added a test to the test suite which checks if there are interleaved schema and data migrations that have not been released yet. Having split migrations, first all schema and then all data, will permit doing 2 sequential releases; but if the data and schema migrations are interleaved (beyond this) it is problematic to arrange for release without ending up with a prolonged period when running code and table structure is out of sync (while the normally more time-consuming data migrations run). 
- Legacy-Id: 13576
 2017-06-09 21:37:14 +00:00
Henrik Levkowetz 7385a8be51 Changed name and signature for a log helper. 
- Legacy-Id: 13571
 2017-06-09 19:38:48 +00:00
Henrik Levkowetz 023a32715d Merged in ^/branch/iola/author-stats-r13145 from olau@iola.com, with additional features from ^/personal/henrik/6.52.1-authorstats. 
- Legacy-Id: 13550
 2017-06-06 18:36:59 +00:00
Henrik Levkowetz a34d078428 Commented out again a function that was commented in by mistake in the committed code. 
- Legacy-Id: 13543
 2017-06-06 16:30:53 +00:00