Don't offer to propose slides when the next view will not allow you to propose slides. Fixes#2763.
- Legacy-Id: 16847
Note: SVN reference [16813] has been migrated to Git commit 1ec4f7f41e6bf9945c4e4e5a55d50f7535b0fbbc
Fix#2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
- Legacy-Id: 16846
Note: SVN reference [16792] has been migrated to Git commit 486b6daa29
Improve alerts when looking at non-current versions of a charter document. Fixes#2774.
- Legacy-Id: 16845
Note: SVN reference [16785] has been migrated to Git commit 07637c27e1a76d3cbb92cc22b987b9f1426d8d52
Add migration intended for r16770. Related to #2782.
- Legacy-Id: 16842
Note: SVN reference [16771] has been migrated to Git commit f3fb0f8c20941710d675ca4bb2873635c2fa8624
Populate completed_on when rejecting a ReviewAssignment. Migrate past rejected assignments accordingly. Fixes#2782.
- Legacy-Id: 16841
Note: SVN reference [16770] has been migrated to Git commit 661e4c5369dc0d165bfcb56e3278906fe1de3b55
Refs #2277 - Send daily reminders of overdue reviews to secretaries
- Legacy-Id: 16839
Note: SVN reference [16765] has been migrated to Git commit cc64992204
Allow responsible AD to be None for documents in iesg states idexists and dead. Fixes#2803 and #993.
- Legacy-Id: 16838
Note: SVN reference [16763] has been migrated to Git commit 9f54af355d4e2b17404caa1755be74d22b5edad1
Use form validation to prevent interim slide titles that end with -nn until we change interims to use the modern HREF schemes. Fixes#2797.
- Legacy-Id: 16837
Note: SVN reference [16762] has been migrated to Git commit 40b066560cb01191a5f7995a0fd04a32f1abbddd
Restrict comments total on nomcom private index to comments on positions. Fixes#2792.
- Legacy-Id: 16826
Note: SVN reference [16759] has been migrated to Git commit 7aa57e9f57
Fix#2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
- Legacy-Id: 16823
Note: SVN reference [16705] has been migrated to Git commit ec56a03ec6
Fix#2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
- Legacy-Id: 16822
Note: SVN reference [16704] has been migrated to Git commit 179c151f9e
Ref #2231 - Fix send-review-reminders and add it to daily cron
This fixes a syntax error and a Python 3 incompatibility, and adds
send-review-reminders to the daily cron script.
Important notes:
- I have not tested to what degree the existing reminders work as they
should, as that's out of scope. It does have tests.
- I can't assess whether the virtualenv activation works in the
production setup, and it may be obsolete as bin/daily also
activates the virtualenv.
- The same Python 3 incompatibility (execfile() no longer exists) seems
to exist in various other scripts.
- Legacy-Id: 16821
Note: SVN reference [16703] has been migrated to Git commit 296b126c70
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to "requested", which means
it will be shown as an unassigned review in all interfaces.
Commit ready for merge.
- Legacy-Id: 16819
Fix issue where third session requests, which rerequire AD approval, get left with approved status, instead of scheduled, after Secretraiat sends out notifications of official schedule. Fixes#2765.
- Legacy-Id: 16817
Note: SVN reference [16607] has been migrated to Git commit 9a82586e1b
Add migration to remove any break / registration sessions that have already been created for future meetings. Goes with changes for #2713.
- Legacy-Id: 16816
Note: SVN reference [16701] has been migrated to Git commit 0bbdbca8ac
Fix#2478 - When completing review, show which addresses it is posted to.
- Legacy-Id: 16795
Note: SVN reference [16688] has been migrated to Git commit 68ea11a916
Fix#2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
- Legacy-Id: 16794
Note: SVN reference [16680] has been migrated to Git commit 1390ae073c
Fix#2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
- Legacy-Id: 16793
Note: SVN reference [16672] has been migrated to Git commit 88b7b45b0e
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
Commit ready for merge.
- Legacy-Id: 16792
Fix#2590 - Allow secretary to adjust date when completing a review.
This also fixes other issues identified in #2590, around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
created, set to current date/time.
- When the secretary records a review in the datatracker, they may
set a different completion date, which is autofilled if an email
is selected. One event is generated for the original completion
date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
existing events.
- Legacy-Id: 16791
Note: SVN reference [16670] has been migrated to Git commit 3942f9acc7
Fix#2560 - Sort names in history when changing list of members.
- Legacy-Id: 16789
Note: SVN reference [16668] has been migrated to Git commit de9cde9e43
