Ole Laursen
1febf2465d
Fix a bug in the logic that determines which roles are editable (the
...
bug had the reviewer field showing up on non-dir pages)
- Legacy-Id: 12186
2016-10-20 15:30:35 +00:00
Ole Laursen
4b987436c0
Fix a missing HttpResponseForbidden in review statistics, make the
...
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
- Legacy-Id: 12175
2016-10-19 11:58:49 +00:00
Ole Laursen
95bbabf384
Ignore duplicate review requests in importer - genart has had quite a
...
few of these
- Legacy-Id: 12171
2016-10-18 13:50:10 +00:00
Ole Laursen
d95be38ee7
Implement a reviewer blacklist in the importer and add "alice" in
...
genart to it
- Legacy-Id: 12170
2016-10-18 11:51:33 +00:00
Ole Laursen
2ce2f8d067
Change default of ReviewerSettings.min_interval to null - if it's not
...
specified for a reviewer, we don't take it into account
- Legacy-Id: 12169
2016-10-18 10:37:03 +00:00
Ole Laursen
d0877a0aa9
Change default of ReviewerSettings.min_interval to null - if it's not
...
specified for a reviewer, we don't take it into account
- Legacy-Id: 12168
2016-10-18 10:36:42 +00:00
Ole Laursen
78e4fa623e
Tweak the sort order so that the minimum interval between reviews is
...
considered of lower importance compared to previous reviews/wishes to
review the document
- Legacy-Id: 12167
2016-10-17 21:52:07 +00:00
Ole Laursen
a216694c4c
Add missing guard on the manage review button so it only shows up if
...
the user can access the manage review page
- Legacy-Id: 12166
2016-10-17 21:43:35 +00:00
Ole Laursen
6b492ccf59
Only suggest I-Ds for review, not other types of documents
...
- Legacy-Id: 12165
2016-10-17 21:38:15 +00:00
Ole Laursen
ed8f35e5a9
Scroll to top of textarea when clicking a message to use when
...
completing a review.
- Legacy-Id: 12164
2016-10-17 21:30:34 +00:00
Ole Laursen
e11a911d86
Include from in the list of messages when completing a review and
...
searching for the review email, redo layout somewhat to accommodate
this and improve the presentation of the message date.
- Legacy-Id: 12163
2016-10-17 21:26:36 +00:00
Ole Laursen
4450ff192c
Improve the looks of the previous commit by using an infinity sign in
...
case of a missing start or end date
- Legacy-Id: 12162
2016-10-17 19:44:19 +00:00
Ole Laursen
399bb3bf4d
Make UnavailablePeriod.start_date nullable and import the unavailable
...
periods from the Perl tool with start date null as we don't know when
they started.
- Legacy-Id: 12161
2016-10-17 19:37:56 +00:00
Ole Laursen
38109e5f13
Add a couple more of the scripts that aren't supposed to be tested
...
directly to TEST_CODE_COVERAGE_EXCLUDE
- Legacy-Id: 12152
2016-10-14 16:24:27 +00:00
Ole Laursen
da032407f7
Exclude review tool importer from code coverage check
...
- Legacy-Id: 12151
2016-10-14 16:17:42 +00:00
Ole Laursen
e1f69171b5
xslugify the last name part when constructing a name for the review document
...
- Legacy-Id: 12147
2016-10-14 09:42:34 +00:00
Ole Laursen
9a3996a286
Make sure that name_parts doesn't accidentally turn Unicode strings
...
into plain strings
- Legacy-Id: 12146
2016-10-14 09:41:21 +00:00
Ole Laursen
e864abdcdb
Fix some pyquery compatibility issues
...
- Legacy-Id: 12145
2016-10-14 09:40:12 +00:00
Ole Laursen
d59d0e8bdc
Fix spelling mistake in class name
...
- Legacy-Id: 12144
2016-10-14 09:29:52 +00:00
Ole Laursen
e3fbc070f9
Fix bug in reference in resources
...
- Legacy-Id: 12143
2016-10-14 08:43:21 +00:00
Ole Laursen
2b7fcf0b5f
Remove unused import
...
- Legacy-Id: 12142
2016-10-14 08:40:24 +00:00
Ole Laursen
e598b7209a
Update name fixture with the alphabetical ordering.
...
- Legacy-Id: 12137
2016-10-13 19:37:30 +00:00
Ole Laursen
505b4fcea3
Fix redirection problem when group_type is not given.
...
- Legacy-Id: 12136
2016-10-13 19:34:39 +00:00
Ole Laursen
9de2d49823
Fixup some of the migrations a bit upon the merge with trunk.
...
- Legacy-Id: 12135
2016-10-13 19:20:26 +00:00
Ole Laursen
60ec861bd6
Shorten the verbose names a bit, they make Django complain
...
- Legacy-Id: 12130
2016-10-13 17:10:04 +00:00
Ole Laursen
958ba5ba95
Make new branch from trunk and merge in review-tracker-r11921
...
- Legacy-Id: 12129
2016-10-13 16:38:47 +00:00
Ole Laursen
8f497af6e6
Add admin.py for review models
...
- Legacy-Id: 12128
2016-10-13 16:16:34 +00:00
Ole Laursen
5a878981fe
Guard against reviewer name not being filled in properly (still
...
containing a @) on the complete review page
- Legacy-Id: 12127
2016-10-13 15:54:11 +00:00
Ole Laursen
336e2bbc5e
In case the review data contains a proper name for a person we already
...
know, use that - this prevents problems with email addresses being
embedded in review document names.
- Legacy-Id: 12126
2016-10-13 15:53:14 +00:00
Ole Laursen
6d7bfd7b37
Actually commit the statistics section.
...
- Legacy-Id: 12125
2016-10-13 15:36:14 +00:00
Ole Laursen
bf55237112
Add statistics section with review statistics. Fix a couple of missing tests.
...
- Legacy-Id: 12124
2016-10-13 15:20:04 +00:00
Henrik Levkowetz
99b22efc96
Merged in [12104] from rjsparks@nostrum.com:
...
Don't show the request publication button for ise,irtf, and iab drafts after publication has already been requested. Fixes #2019 .
- Legacy-Id: 12122
Note: SVN reference [12104] has been migrated to Git commit 933134f4cc
2016-10-12 18:39:22 +00:00
Henrik Levkowetz
05c26ba4c9
The db api prefers resource URIs ending in slash -- make it so in json_agenda().
...
- Legacy-Id: 12121
2016-10-12 18:09:18 +00:00
Henrik Levkowetz
c6a633885c
Changed another class name that might trigger adblock. Related to issues #2016 and #2027 .
...
- Legacy-Id: 12120
2016-10-12 15:39:19 +00:00
Henrik Levkowetz
679c5d3f5f
Changed an unfortunate html class name 'adname' (Area Director name) which triggered adblock. Fixes issues #2016 and #2027 .
...
- Legacy-Id: 12119
2016-10-12 15:31:11 +00:00
Henrik Levkowetz
23532102f8
Fixed room_name() to not fail when a timeslog has no location. Fixes a server 500 for agenda.json
...
- Legacy-Id: 12118
2016-10-12 14:17:22 +00:00
Ole Laursen
293ecb1488
Don't use the bootstrap3 title plugin on th elements, it doesn't work
...
properly for those
- Legacy-Id: 12115
2016-10-11 11:44:49 +00:00
Henrik Levkowetz
06c10ff258
Changed the default setting for the htpasswd binary path.
...
- Legacy-Id: 12110
2016-10-08 20:34:10 +00:00
Robert Sparks
933134f4cc
Don't show the request publication button for ise,irtf, and iab drafts after publication has already been requested. Fixes #2019 . Commit ready for merge.
...
- Legacy-Id: 12104
2016-10-07 17:29:05 +00:00
Ole Laursen
46dd4682bf
Remove debug output
...
- Legacy-Id: 12102
2016-10-07 16:49:37 +00:00
Ole Laursen
59180240af
Add a simple reminder system for reviewers so that they can opt in to
...
being reminded X days before deadline of an assignment
- Legacy-Id: 12101
2016-10-07 16:43:29 +00:00
Henrik Levkowetz
269226a486
Merged in [12099] from rjsparks@nostrum.com:
...
Changes interim announcements and interim cancellation announcements to use mailtriggers. Adds irtf-announce to announcements for IRTF groups. Fixes #2018 .
- Legacy-Id: 12100
Note: SVN reference [12099] has been migrated to Git commit 5b32cc2da7
2016-10-07 15:30:43 +00:00
Robert Sparks
5b32cc2da7
Changes interim announcements and interim cancellation announcements to use mailtriggers. Adds irtf-announce to announcements for IRTF groups. Fixes #2018 . Commit ready for merge.
...
- Legacy-Id: 12099
2016-10-07 15:05:47 +00:00
Henrik Levkowetz
e06ac44060
Added a migration to remove most duplicate 'Upload' doc events.
...
- Legacy-Id: 12098
2016-10-06 18:40:04 +00:00
Henrik Levkowetz
8a5593e714
When converting submission events to doc events, post them in chronological order. Don't add upload doc events until we're past the possibility of submission cancellation.
...
- Legacy-Id: 12097
2016-10-06 17:03:23 +00:00
Ole Laursen
5e030ed206
Add reviews to IESG agenda text edition too
...
- Legacy-Id: 12096
2016-10-06 15:01:05 +00:00
Ole Laursen
227fdd7953
Add reviews to search results and IESG agenda. Support restricting
...
review types so that teams will only have those review types
listed and suggested that they are configured to have.
Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.
Fix a couple of bugs.
- Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Ole Laursen
168fc0425b
Fix formatting bug with multiple milestones in search results
...
- Legacy-Id: 12094
2016-10-06 12:52:43 +00:00
Henrik Levkowetz
5612a3f463
Merged in [12082] from rcross@amsl.com:
...
Fix issue where interim meeting request form didn't list research groups when user was a working group chair and a research group chair.
- Legacy-Id: 12093
Note: SVN reference [12082] has been migrated to Git commit adf28c922f
2016-10-05 18:17:28 +00:00
Henrik Levkowetz
e31bdff708
Apply string operations on the string, not on the Email object.
...
- Legacy-Id: 12092
2016-10-05 17:51:22 +00:00