Commit graph

6720 commits

Author SHA1 Message Date
Robert Sparks 483d9db895 Removes classes obviated in r12520. Commit ready for merge. Should be held for release after r12520 is released?
- Legacy-Id: 12521
2016-12-15 03:57:21 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge.
- Legacy-Id: 12520
2016-12-14 23:26:32 +00:00
Robert Sparks 18fdfc0617 Fixes href() for bluesheets. Fixes #2107. Commit ready for merge. Will patch into production
- Legacy-Id: 12518
2016-12-13 21:26:40 +00:00
Henrik Levkowetz 3c812b04cb Added a script to list role holder emails.
- Legacy-Id: 12516
2016-12-13 17:45:53 +00:00
Henrik Levkowetz f098e2ae94 Set version info and settings back to development mode
- Legacy-Id: 12513
2016-12-13 11:44:03 +00:00
Henrik Levkowetz d6c837a9ce Set version info to release version 6.40.0 before branching.
- Legacy-Id: 12511
2016-12-13 11:43:49 +00:00
Henrik Levkowetz 9a3f6b059b Merged Django-1.8 upgrade work to trunk. Adjusted migration names, and added migrations as necessary. Fixed some instances of broken html.
- Legacy-Id: 12507
2016-12-13 05:55:46 +00:00
Robert Sparks 962e3f8443 Show the review requester on review team summary pages. Fixes #2095. Commit ready for merge.
- Legacy-Id: 12506
2016-12-12 23:03:49 +00:00
Robert Sparks 1ea983a1c2 Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065. Commit ready for merge.
- Legacy-Id: 12505
2016-12-12 21:42:53 +00:00
Henrik Levkowetz 03d90163a5 Merged django-1.8 work forward to copy of 6.39.1
- Legacy-Id: 12504
2016-12-10 19:32:46 +00:00
Henrik Levkowetz 7935926a05 Set version info and settings back to development mode
- Legacy-Id: 12498
2016-12-09 12:56:30 +00:00
Henrik Levkowetz 138c17e42c Set version info to release version 6.39.1 before branching.
- Legacy-Id: 12496
2016-12-09 12:56:22 +00:00
Henrik Levkowetz 3c956c9896 Added migrations for new timezone data, validation on ReviewerSettings.filter_re, and new docevent types.
- Legacy-Id: 12493
2016-12-09 12:41:38 +00:00
Henrik Levkowetz 2978798f39 Made serialization work for RegexStringValidator
- Legacy-Id: 12492
2016-12-09 12:40:21 +00:00
Henrik Levkowetz 57eb5844e5 Merged in [12489] from rjsparks@nostrum.com:
Save a new reviewrequest for each team requested in the request form. Fixes #2094.
 - Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
2016-12-09 12:01:48 +00:00
Henrik Levkowetz e83cee2c8b Merged in [12487] from rjsparks@nostrum.com:
Make it clearer what version was requested and what version was reviewed on a reveiwers overview page. Fixes #2101.
 - Legacy-Id: 12490
Note: SVN reference [12487] has been migrated to Git commit 96390da5a7514cbe0bd70b61a927cb57260c9c44
2016-12-09 00:05:22 +00:00
Henrik Levkowetz 8c7a400683 Merged in [12486] from rjsparks@nostrum.com:
Fill in CC list defaults for review completion mail. Make the mail come from the reviewer instead of the default secretariat address. Fixes #2078 and #2054.
 - Legacy-Id: 12488
Note: SVN reference [12486] has been migrated to Git commit 062707f51b351e1fcd5d682b23af8c7feeb2442d
2016-12-08 23:44:50 +00:00
Henrik Levkowetz e40afaedf0 Check event type only when an event is available.
- Legacy-Id: 12484
2016-12-08 17:57:59 +00:00
Henrik Levkowetz 83a260c6c0 Merged in [12482] from rjsparks@nostrum.com:
Improves control of email headers for review summary messages. Provides team-specific templates for review summary messages. Fixes #2092 and #2082.
 - Legacy-Id: 12483
Note: SVN reference [12482] has been migrated to Git commit 06179c7485dac6c69b2aa30e66095a23a4460209
2016-12-08 17:55:37 +00:00
Henrik Levkowetz ef301c0f31 Merged in [12479] from olau@iola.dk:
Add missing team constraint in the check for previous reviews by a
reviewer.
 - Legacy-Id: 12481
Note: SVN reference [12479] has been migrated to Git commit 3f98a1a182
2016-12-08 16:43:45 +00:00
Henrik Levkowetz 2c27d5c611 Moved optional text wrapping before html escaping in markup_unicode(), used by get_unicode_document_content(). Fixes a problem with lines being wrapped when they should not be.
- Legacy-Id: 12480
2016-12-08 16:27:05 +00:00
Ole Laursen 3f98a1a182 Add missing team constraint in the check for previous reviews by a
reviewer. Commit ready for merge.
 - Legacy-Id: 12479
2016-12-08 12:49:56 +00:00
Henrik Levkowetz 19ec458668 Added migrations for the model changes done for the Django 1.8 upgrade.
- Legacy-Id: 12478
2016-12-07 19:41:48 +00:00
Henrik Levkowetz 53f343017e Use models.DurationField from django directly now that it's available, instead of the inlined copy of the 1.8 DurationField code.
- Legacy-Id: 12477
2016-12-07 19:40:18 +00:00
Henrik Levkowetz 217b31f109 Made the RegexStringValidator deconstructible so we can generate migrations.
- Legacy-Id: 12476
2016-12-07 19:28:01 +00:00
Henrik Levkowetz 7fbf2e8609 Changed the deprecated model._meta.get_all_field_names() to a supported construct.
- Legacy-Id: 12475
2016-12-07 18:27:57 +00:00
Henrik Levkowetz eb966c7545 Fixed the manage assigned reviews template to handle the case when reviewed rev is blank. Fixes issue #2086.
- Legacy-Id: 12474
2016-12-07 16:02:04 +00:00
Henrik Levkowetz c312967505 Removed unused legacy code
- Legacy-Id: 12473
2016-12-07 12:20:27 +00:00
Henrik Levkowetz 6304bfda69 Fixed template_coverage_collection initialisation. Tweaked a message. Updated coverage numbers.
- Legacy-Id: 12471
2016-12-07 11:33:33 +00:00
Henrik Levkowetz db7e554c5e Changed to using TestCase from ietf.utils, and turned off coverage checking when loading templates in TemplateChecksTestCase.
- Legacy-Id: 12470
2016-12-07 11:31:31 +00:00
Henrik Levkowetz 7d27849ee3 Fixed a typo.
- Legacy-Id: 12469
2016-12-07 11:29:23 +00:00
Henrik Levkowetz b628a0844b Changed to using TestCase from ietf.utils in some places, for consistent test-suite failure output.
- Legacy-Id: 12467
2016-12-07 11:03:32 +00:00
Henrik Levkowetz 7dfbe51913 Don't count the template loading done in TemplateChecksTestCase towards template coverage numbers.
- Legacy-Id: 12464
2016-12-06 15:55:39 +00:00
Henrik Levkowetz e4ce339235 Merged in [12461] from rjsparks@nostrum.com:
Added migration to fetch text from reviews in the mail archives and populate the review documents. Fixes #2064.  Will patch into production.
 - Legacy-Id: 12463
Note: SVN reference [12461] has been migrated to Git commit 63a9599bafdcacf49f1bb374b2156d8473da93d1
2016-12-05 21:03:49 +00:00
Henrik Levkowetz 8f6e51839f Fixed some additional places to use the new settings.TEMPLATES structure.
- Legacy-Id: 12459
2016-12-05 19:04:27 +00:00
Henrik Levkowetz 18f65e09a0 Removed bad select_related names.
- Legacy-Id: 12456
2016-12-05 15:23:27 +00:00
Henrik Levkowetz 14776bae70 Merged django18 work forward to r12447
- Legacy-Id: 12455
2016-12-05 15:03:40 +00:00
Henrik Levkowetz 3b6f30fc9a Fixed a type mismatch (no_review_from_teams_on_doc() is called with both Document and DocHistory instances; this has to be taken into account)
- Legacy-Id: 12453
2016-12-05 14:38:37 +00:00
Henrik Levkowetz bc683ccc67 Fixed a type issue found by the new django 1.8 query type checks.
- Legacy-Id: 12452
2016-12-05 14:13:00 +00:00
Henrik Levkowetz 1d5a7a692a Added a DB consistency check, and 2 new doc.statetype values found by the check for consistency.
- Legacy-Id: 12451
2016-12-05 14:12:19 +00:00
Henrik Levkowetz 8cf6b0010b Added a template string_if_invalid setting to TEMPLATES when DEBUG is True.
- Legacy-Id: 12450
2016-12-05 14:10:35 +00:00
Henrik Levkowetz 0bb7854591 Merged django18 work forward to 6.39
- Legacy-Id: 12449
2016-12-05 14:01:25 +00:00
Henrik Levkowetz 486e394cbf Added more document information to the personal profile pages at /person/<full name>, after a suggestion from Benoit Claise. Fixes issue #2066.
- Legacy-Id: 12447
2016-12-05 13:00:01 +00:00
Henrik Levkowetz b897519fff Changed the test runner to use the verbosity set on the command line when loading fixtures.
- Legacy-Id: 12446
2016-12-05 12:56:53 +00:00
Henrik Levkowetz cfd898b767 Updated the proceedings_templates fixture to provide the base proceedings template needed by tests, instead of a copy already instantiated for a specific meeting.
- Legacy-Id: 12445
2016-12-05 12:55:20 +00:00
Henrik Levkowetz be272a019a Changed settings to use the new TEMPLATES dictionary instead of the deprecated individual TEMPLATE_* settings.
- Legacy-Id: 12444
2016-12-05 12:53:21 +00:00
Henrik Levkowetz 5e48d7ec72 Fixed another year's end related test bug.
- Legacy-Id: 12443
2016-12-04 15:46:27 +00:00
Henrik Levkowetz e79368f15e Added new display columns to the reviewer settings admin page.
- Legacy-Id: 12442
2016-12-04 13:07:16 +00:00
Henrik Levkowetz 37f9aa06be Merged in [12438] from rjsparks@nostrum.com:
Don't show teams with only 'No response' reviews in the search result rows, using the same logic as used for the document main page. Fixes #2070.
 - Legacy-Id: 12441
Note: SVN reference [12438] has been migrated to Git commit d1c0c053327594c8a594ad2ad779fac9974d8eaa
2016-12-01 22:16:32 +00:00
Henrik Levkowetz 8b60560eed Fixed a typo. Fixes issue #2073.
- Legacy-Id: 12440
2016-12-01 21:51:01 +00:00
Henrik Levkowetz 5959b3a46a Added a validator for the reviewer settings' Filter Regexp field, to make sure that we don't later hit exceptions when trying to compile and use the regexp entered.
- Legacy-Id: 12439
2016-12-01 21:30:39 +00:00
Henrik Levkowetz e3ce2a9657 Tweaked the admin for doc.models.Document to capture a comment about changes made, and save those in the document history, using .save_with_history(). This makes the admin useful again for doing document changes. See issue #2067.
- Legacy-Id: 12434
2016-12-01 16:35:23 +00:00
Henrik Levkowetz c79b40bc88 Changed the handling of DocEvent 'rev' fields in document history. We should give DocEvent a 'rev' field which is always filled in; the current handling is error prone and much to complicated.
- Legacy-Id: 12433
2016-12-01 13:49:36 +00:00
Henrik Levkowetz c06e7af08c Fixed an error in the test_interim_request_series() test.
- Legacy-Id: 12431
2016-12-01 13:20:59 +00:00
Henrik Levkowetz 2a9a7afd0b Added a link to the meetecho session recording (not the youtube conversion) on the IETF agenda page.
- Legacy-Id: 12430
2016-11-30 21:02:33 +00:00
Henrik Levkowetz 9c9b15bec8 Added guards against picking up non-ascii title and abstract from drafts submitted in xml form.
- Legacy-Id: 12429
2016-11-30 15:56:22 +00:00
Henrik Levkowetz 1f1772a777 Set version info and settings back to development mode
- Legacy-Id: 12427
2016-11-30 14:45:02 +00:00
Henrik Levkowetz 9e78fb6be8 Set version info to release version 6.39.0 before branching.
- Legacy-Id: 12425
2016-11-30 14:44:53 +00:00
Henrik Levkowetz ca4ab7b402 Added a migration for updated help text on some review fields.
- Legacy-Id: 12422
2016-11-30 14:31:52 +00:00
Henrik Levkowetz b914f46313 Merged in ^/branch/iola/review-tracker-r12128@12397, bringing in the review tool functionality described in RFC7735. This adds the ability to set up review management pages for review teams such as genart, secdir, opsdir, etc.; letting the review team secretaries manage requested and completed reviews; letting the reviewers keep track of and document their reviews, and more. See the RFC for full specification, and the branch commit log for a full commit history.
- Legacy-Id: 12419
2016-11-29 14:54:19 +00:00
Henrik Levkowetz a66d0c5187 Set version info and settings back to development mode
- Legacy-Id: 12416
2016-11-29 13:07:59 +00:00
Henrik Levkowetz aaec56c69c Set version info to release version 6.38.2 before branching.
- Legacy-Id: 12414
2016-11-29 13:07:51 +00:00
Henrik Levkowetz 80aca950b3 Added new clarifying text to 3 IPR-related pages, based on direction from the IESG received 2016-11-28.
- Legacy-Id: 12411
2016-11-29 12:27:15 +00:00
Henrik Levkowetz cec0f33817 Removed unused stuff.
- Legacy-Id: 12409
2016-11-28 21:20:28 +00:00
Henrik Levkowetz e6121ac0f8 Fixed a bad filter argument found by the Django 1.8 code.
- Legacy-Id: 12408
2016-11-28 21:06:42 +00:00
Henrik Levkowetz 53d68af9cd Adapted the utils template tests to the new template handling in Django 1.8.
- Legacy-Id: 12407
2016-11-28 21:05:17 +00:00
Henrik Levkowetz 554ec2d78c Removed an unused import
- Legacy-Id: 12406
2016-11-28 21:04:15 +00:00
Henrik Levkowetz d589718c37 Fixed some pyflakes issues.
- Legacy-Id: 12405
2016-11-28 18:13:43 +00:00
Henrik Levkowetz 1deadeadc0 Added a migration to fix the mext meeting materials names and external links.
- Legacy-Id: 12404
2016-11-28 18:06:38 +00:00
Henrik Levkowetz 671df0492a Fixed an issue where a queryset filter argument didn't have the right datatype.
- Legacy-Id: 12403
2016-11-28 18:05:14 +00:00
Henrik Levkowetz 7c2a1b2ee4 Undid a FK to o2o change we don't want to do (we have instances where the FK is None).
- Legacy-Id: 12402
2016-11-28 17:50:08 +00:00
Henrik Levkowetz 7c23d0c52e Silenced a system check we won't always follow.
- Legacy-Id: 12401
2016-11-28 17:47:08 +00:00
Henrik Levkowetz 05379e2e2d Undid unintended change.
- Legacy-Id: 12399
2016-11-26 20:04:01 +00:00
Henrik Levkowetz a0ed8c7694 Made session minutes available with the same kind of url as session minutes: /meeting//minutes/. (Both of these need to be refined to handle multiple agendas and minutes, for groups having multiple sessions in a meeting.)
- Legacy-Id: 12398
2016-11-25 16:44:31 +00:00
Ole Laursen 7d8baf0015 Add reviewer name and completion date to previous reviews in manage
review page
 - Legacy-Id: 12397
2016-11-25 10:53:37 +00:00
Henrik Levkowetz 09259ae556 Merged in [12393] from rjsparks@nostrum.com:
Fixed bug where slides from multiple sessions for a group were not all showing. Improved handling of multiple minutes and agendas for groups. Fixes #2058.  Commit should be patched into production.
 - Legacy-Id: 12395
Note: SVN reference [12393] has been migrated to Git commit 2b0ec6df16
2016-11-23 18:31:10 +00:00
Robert Sparks 2b0ec6df16 Fixed bug where slides from multiple sessions for a group were not all showing. Improved handling of multiple minutes and agendas for groups. Fixes #2058. Commit ready for merge. Commit should be patched into production.
- Legacy-Id: 12393
2016-11-23 17:09:53 +00:00
Henrik Levkowetz b00824a6bf Merged in [12385] from rjsparks@nostrum.com:
Added an extra highlight to the ballot_icon box when the viewer holds a blocking position in that ballot. Fixes #2046.
 - Legacy-Id: 12388
Note: SVN reference [12385] has been migrated to Git commit 3c63fdb800
2016-11-18 13:43:28 +00:00
Henrik Levkowetz 7cb2194db6 Merged in [12384] from rjsparks@nostrum.com:
Adjust when materials links on the materials page show for the secretariat.
 - Legacy-Id: 12387
Note: SVN reference [12384] has been migrated to Git commit 4e7d077b16
2016-11-18 12:59:59 +00:00
Henrik Levkowetz 623ce0e1bd Merged in [12378] from rjsparks@nostrum.com:
Change the lines saying that a test has failed to make it easier to cut-paste to run the failed test again.
 - Legacy-Id: 12386
Note: SVN reference [12378] has been migrated to Git commit be51bc2e78
2016-11-18 10:45:40 +00:00
Robert Sparks 3c63fdb800 Added an extra highlight to the ballot_icon box when the viewer holds a blocking position in that ballot. Fixes #2046. Commit ready for merge.
- Legacy-Id: 12385
2016-11-18 04:52:13 +00:00
Robert Sparks 4e7d077b16 Adjust when materials links on the materials page show for the secretariat. Commit ready for merge.
- Legacy-Id: 12384
2016-11-17 22:45:29 +00:00
Ole Laursen a7cf886f3c Add telechat info to the manage review requests page
- Legacy-Id: 12383
2016-11-17 17:49:02 +00:00
Ole Laursen fb26a27bfa Add document state and telechat info to the review request overview page
- Legacy-Id: 12382
2016-11-17 17:46:50 +00:00
Ole Laursen 1970cbab16 Modify importer to take deadline from the document log if at all
possible, also add an extra assignment fallback using deadline =
assignment time + 30 days for early reviews that never had a deadline
(a few left in secdir)
 - Legacy-Id: 12381
2016-11-17 17:16:00 +00:00
Henrik Levkowetz 89294a558a Order materials on the agenda session materials popup according to the sessionpresentation order. Fixes issue #2049
- Legacy-Id: 12380
2016-11-17 08:45:49 +00:00
Henrik Levkowetz 216ed80529 Merged in code from rcross@amsl.com to bring back the automatic conversion of slides from powerpoint to pdf.
- Legacy-Id: 12379
2016-11-17 07:30:14 +00:00
Robert Sparks be51bc2e78 Change the lines saying that a test has failed to make it easier to cut-paste to run the failed test again. Commit ready for merge.
- Legacy-Id: 12378
2016-11-17 02:52:45 +00:00
Henrik Levkowetz b63f374749 Set version info and settings back to development mode
- Legacy-Id: 12375
2016-11-17 00:40:37 +00:00
Henrik Levkowetz f80ce150ab Set version info to release version 6.38.1 before branching.
- Legacy-Id: 12373
2016-11-17 00:40:29 +00:00
Henrik Levkowetz 0a15bf9bb6 Merged in [12326] from housley@vigilsec.com:
Allow WG Chairs to manage the meeting materials when starting from the old WG Chair Dashboard in ietf.secr.proceedings
 - Legacy-Id: 12370
Note: SVN reference [12326] has been migrated to Git commit a37f41823c
2016-11-17 00:26:51 +00:00
Henrik Levkowetz f4268ce9b4 Set version info and settings back to development mode
- Legacy-Id: 12368
2016-11-17 00:00:34 +00:00
Henrik Levkowetz d378030eda Set version info to release version 6.38.0 before branching.
- Legacy-Id: 12366
2016-11-17 00:00:17 +00:00
Ole Laursen d302875381 Don't limit the team choices for ResultUsedInReviewTeam, otherwise
it's not possible to make a new team
 - Legacy-Id: 12363
2016-11-16 10:42:18 +00:00
Henrik Levkowetz 1a6fc6dc04 Merged in [12353] from rjsparks@nostrum.com:
A second performance improvement for the proceedings pages.
 - Legacy-Id: 12361
Note: SVN reference [12353] has been migrated to Git commit a3cc9df465
2016-11-16 06:54:00 +00:00
Henrik Levkowetz a771e8fad6 Merged in [12352] from rjsparks@nostrum.com:
Add links to session materials pages to the rows on the by-type view of the agenda.
 - Legacy-Id: 12360
Note: SVN reference [12352] has been migrated to Git commit ba60c115fa
2016-11-16 04:22:51 +00:00
Henrik Levkowetz dd9eb3b0d4 Merged in [12351] from rjsparks@nostrum.com:
Tweaked button color and position on the last call form for status-change documents at the secretariat's request.
 - Legacy-Id: 12359
Note: SVN reference [12351] has been migrated to Git commit 6ed7fed3d2
2016-11-16 04:10:22 +00:00
Henrik Levkowetz 18518fe566 Merged in [12348] from rjsparks@nostrum.com:
Performance improvements for the proceedings page.
 - Legacy-Id: 12358
Note: SVN reference [12348] has been migrated to Git commit 224999e948
2016-11-16 03:55:59 +00:00
Henrik Levkowetz d2cc5c142a Merged in [12347] from rjsparks@nostrum.com:
Repaired broken links on the proceedings page.
 - Legacy-Id: 12357
Note: SVN reference [12347] has been migrated to Git commit b9e35747d5
2016-11-16 03:35:55 +00:00
Henrik Levkowetz 42573d744f Merged in [12341] from adam@nostrum.com.
- Legacy-Id: 12356
Note: SVN reference [12341] has been migrated to Git commit f11e1e247b
2016-11-16 03:16:47 +00:00