altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 2 Packages Projects Releases Wiki Activity

Remove "point raised - writup needed" from the set of substates the IESG can use with a document. Fixes #2968. Commit ready for merge.

Browse source 
- Legacy-Id: 17708
This commit is contained in:
Robert Sparks 2020-04-29 20:32:31 +00:00
parent d55f0aa084
commit fa492c3947
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ietf/doc/models.py
View file

@ -74,7 +74,7 @@ class State(models.Model):
ordering = ["type", "order"] ordering = ["type", "order"]
IESG_BALLOT_ACTIVE_STATES = ("lc", "writeupw", "goaheadw", "iesg-eva", "defer") IESG_BALLOT_ACTIVE_STATES = ("lc", "writeupw", "goaheadw", "iesg-eva", "defer")
IESG_SUBSTATE_TAGS = ('point', 'ad-f-up', 'need-rev', 'extpty') IESG_SUBSTATE_TAGS = ('ad-f-up', 'need-rev', 'extpty')
class DocumentInfo(models.Model): class DocumentInfo(models.Model):
"""Any kind of document. Draft, RFC, Charter, IPR Statement, Liaison Statement""" """Any kind of document. Draft, RFC, Charter, IPR Statement, Liaison Statement"""

6
ietf/doc/tests_draft.py
View file

@ -40,7 +40,7 @@ class ChangeStateTests(TestCase):
ad = Person.objects.get(user__username="ad") ad = Person.objects.get(user__username="ad")
draft = WgDraftFactory(ad=ad,states=[('draft','active'),('draft-iesg','iesg-eva')]) draft = WgDraftFactory(ad=ad,states=[('draft','active'),('draft-iesg','iesg-eva')])
DocEventFactory(type='started_iesg_process',by=ad,doc=draft,rev=draft.rev,desc="Started IESG Process") DocEventFactory(type='started_iesg_process',by=ad,doc=draft,rev=draft.rev,desc="Started IESG Process")
draft.tags.add("point") draft.tags.add("ad-f-up")
url = urlreverse('ietf.doc.views_draft.change_state', kwargs=dict(name=draft.name)) url = urlreverse('ietf.doc.views_draft.change_state', kwargs=dict(name=draft.name))
login_testing_unauthorized(self, "ad", url) login_testing_unauthorized(self, "ad", url)
@ -114,14 +114,14 @@ class ChangeStateTests(TestCase):
r = self.client.post(url, r = self.client.post(url,
dict(state=State.objects.get(used=True, type="draft-iesg", slug="review-e").pk, dict(state=State.objects.get(used=True, type="draft-iesg", slug="review-e").pk,
substate="point", substate="need-rev",
comment="Test comment")) comment="Test comment"))
self.assertEqual(r.status_code, 302) self.assertEqual(r.status_code, 302)
draft = Document.objects.get(name=draft.name) draft = Document.objects.get(name=draft.name)
self.assertEqual(draft.get_state_slug("draft-iesg"), "review-e") self.assertEqual(draft.get_state_slug("draft-iesg"), "review-e")
self.assertTrue(not draft.tags.filter(slug="ad-f-up")) self.assertTrue(not draft.tags.filter(slug="ad-f-up"))
self.assertTrue(draft.tags.filter(slug="point")) self.assertTrue(draft.tags.filter(slug="need-rev"))
self.assertEqual(draft.docevent_set.count(), events_before + 2) self.assertEqual(draft.docevent_set.count(), events_before + 2)
self.assertTrue("Test comment" in draft.docevent_set.all()[0].desc) self.assertTrue("Test comment" in draft.docevent_set.all()[0].desc)
self.assertTrue("IESG state changed" in draft.docevent_set.all()[1].desc) self.assertTrue("IESG state changed" in draft.docevent_set.all()[1].desc)

2
ietf/secr/telechat/forms.py
View file

@ -10,7 +10,7 @@ from ietf.name.models import BallotPositionName, DocTagName
# Globals # Globals
# ------------------------------------------------- # -------------------------------------------------
TELECHAT_TAGS = ('point','ad-f-up','extpty','need-rev') TELECHAT_TAGS = ('ad-f-up','extpty','need-rev')
# ------------------------------------------------- # -------------------------------------------------
# Forms # Forms