From fa492c3947a089f38daa10665a4f847d862577cd Mon Sep 17 00:00:00 2001
From: Robert Sparks <rjsparks@nostrum.com>
Date: Wed, 29 Apr 2020 20:32:31 +0000
Subject: [PATCH] Remove "point raised - writup needed" from the set of
substates the IESG can use with a document. Fixes #2968. Commit ready for
merge. - Legacy-Id: 17708
---
ietf/doc/models.py | 2 +-
ietf/doc/tests_draft.py | 6 +++---
ietf/secr/telechat/forms.py | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ietf/doc/models.py b/ietf/doc/models.py
index 3e7ea4511..4ac004661 100644
--- a/ietf/doc/models.py
+++ b/ietf/doc/models.py
@@ -74,7 +74,7 @@ class State(models.Model):
ordering = ["type", "order"]
IESG_BALLOT_ACTIVE_STATES = ("lc", "writeupw", "goaheadw", "iesg-eva", "defer")
-IESG_SUBSTATE_TAGS = ('point', 'ad-f-up', 'need-rev', 'extpty')
+IESG_SUBSTATE_TAGS = ('ad-f-up', 'need-rev', 'extpty')
class DocumentInfo(models.Model):
"""Any kind of document. Draft, RFC, Charter, IPR Statement, Liaison Statement"""
diff --git a/ietf/doc/tests_draft.py b/ietf/doc/tests_draft.py
index b89f76808..5bd705334 100644
--- a/ietf/doc/tests_draft.py
+++ b/ietf/doc/tests_draft.py
@@ -40,7 +40,7 @@ class ChangeStateTests(TestCase):
ad = Person.objects.get(user__username="ad")
draft = WgDraftFactory(ad=ad,states=[('draft','active'),('draft-iesg','iesg-eva')])
DocEventFactory(type='started_iesg_process',by=ad,doc=draft,rev=draft.rev,desc="Started IESG Process")
- draft.tags.add("point")
+ draft.tags.add("ad-f-up")
url = urlreverse('ietf.doc.views_draft.change_state', kwargs=dict(name=draft.name))
login_testing_unauthorized(self, "ad", url)
@@ -114,14 +114,14 @@ class ChangeStateTests(TestCase):
r = self.client.post(url,
dict(state=State.objects.get(used=True, type="draft-iesg", slug="review-e").pk,
- substate="point",
+ substate="need-rev",
comment="Test comment"))
self.assertEqual(r.status_code, 302)
draft = Document.objects.get(name=draft.name)
self.assertEqual(draft.get_state_slug("draft-iesg"), "review-e")
self.assertTrue(not draft.tags.filter(slug="ad-f-up"))
- self.assertTrue(draft.tags.filter(slug="point"))
+ self.assertTrue(draft.tags.filter(slug="need-rev"))
self.assertEqual(draft.docevent_set.count(), events_before + 2)
self.assertTrue("Test comment" in draft.docevent_set.all()[0].desc)
self.assertTrue("IESG state changed" in draft.docevent_set.all()[1].desc)
diff --git a/ietf/secr/telechat/forms.py b/ietf/secr/telechat/forms.py
index ae8fe8724..c28458e02 100644
--- a/ietf/secr/telechat/forms.py
+++ b/ietf/secr/telechat/forms.py
@@ -10,7 +10,7 @@ from ietf.name.models import BallotPositionName, DocTagName
# Globals
# -------------------------------------------------
-TELECHAT_TAGS = ('point','ad-f-up','extpty','need-rev')
+TELECHAT_TAGS = ('ad-f-up','extpty','need-rev')
# -------------------------------------------------
# Forms