altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 4 Packages Projects Releases Wiki Activity

feat: Prefill the abstract, shepherd and AD info into a ballot writeup (#5218)

Browse source 
* feat: Prefill the abstract, shepherd and AD info into a ballot writeup

* Suggestions from @rjsparks

* Remove instructions to add IANA Expert template.

* Make "notes" fields for various bodies conditioned on the doc stream
This commit is contained in:
Lars Eggert 2023-02-27 18:19:39 +00:00 committed by GitHub
parent a2bdd3109c
commit caf80efd84
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ietf/doc/mails.py
View file

@ -175,7 +175,7 @@ def generate_ballot_writeup(request, doc):
e.doc = doc e.doc = doc
e.rev = doc.rev e.rev = doc.rev
e.desc = "Ballot writeup was generated" e.desc = "Ballot writeup was generated"
e.text = force_text(render_to_string("doc/mail/ballot_writeup.txt", {'iana': iana})) e.text = force_text(render_to_string("doc/mail/ballot_writeup.txt", {'iana': iana, 'doc': doc }))
# caller is responsible for saving, if necessary # caller is responsible for saving, if necessary
return e return e

31
ietf/templates/doc/mail/ballot_writeup.txt
View file

@ -1,11 +1,12 @@
{% autoescape off %} {% load ietf_filters %}{% autoescape off %}Technical Summary
Technical Summary {% if doc.abstract %}
{{ doc.abstract.rstrip }}
{% else %}
Relevant content can frequently be found in the abstract Relevant content can frequently be found in the abstract
and/or introduction of the document. If not, this may be and/or introduction of the document. If not, this may be
an indication that there are deficiencies in the abstract an indication that there are deficiencies in the abstract
or introduction. or introduction.
{% endif %}
Working Group Summary Working Group Summary
Was there anything in the WG process that is worth noting? Was there anything in the WG process that is worth noting?
@ -26,23 +27,21 @@ Document Quality
Review, on what date was the request posted? Review, on what date was the request posted?
Personnel Personnel
{% if doc.shepherd and doc.ad %}{% filter wordwrap:"76" %}
The Document Shepherd for this document is {{ doc.shepherd.person.name }}. The Responsible Area Director is {{ doc.ad.name }}.{% endfilter %}
{% else %}
Who is the Document Shepherd for this document? Who is the Who is the Document Shepherd for this document? Who is the
Responsible Area Director? If the document requires IANA Responsible Area Director?
experts(s), insert 'The IANA Expert(s) for the registries {% endif %}
in this document are <TO BE ADDED BY THE AD>.' {% if doc.stream.slug == "irtf" %}IRTF Note
IRTF Note
(Insert IRTF Note here or remove section) (Insert IRTF Note here or remove section)
{% elif doc.stream.slug == "ietf" %}IESG Note
IESG Note
(Insert IESG Note here or remove section) (Insert IESG Note here or remove section)
{% endif %}
IANA Note IANA Note
{% if iana %} {% if iana %}
{% load ietf_filters %}{% filter wordwrap:"76"|indent:2 %}{{ iana }}{% endfilter %} {% filter wordwrap:"76"|indent:2 %}{{ iana }}{% endfilter %}
{% endif %} {% endif %}
(Insert IANA Note here or remove section) (Insert IANA Note here or remove section){% endautoescape%}
{% endautoescape%}