From a895e19882497579c583a559b52113720295bff6 Mon Sep 17 00:00:00 2001 From: Henrik Levkowetz Date: Tue, 8 Oct 2019 12:46:49 +0000 Subject: [PATCH] Merged in [16770] from rjsparks@nostrum.com: Populate completed_on when rejecting a ReviewAssignment. Migrate past rejected assignments accordingly. Fixes #2782. - Legacy-Id: 16841 Note: SVN reference [16770] has been migrated to Git commit 661e4c5369dc0d165bfcb56e3278906fe1de3b55 --- ietf/doc/tests_review.py | 1 + ietf/doc/views_review.py | 1 + 2 files changed, 2 insertions(+) diff --git a/ietf/doc/tests_review.py b/ietf/doc/tests_review.py index 5be7b9a99..23632c58f 100644 --- a/ietf/doc/tests_review.py +++ b/ietf/doc/tests_review.py @@ -481,6 +481,7 @@ class ReviewTests(TestCase): assignment = reload_db_objects(assignment) self.assertEqual(assignment.state_id, "rejected") + self.assertNotEqual(assignment.completed_on,None) e = doc.latest_event() self.assertEqual(e.type, "closed_review_assignment") self.assertTrue("rejected" in e.desc) diff --git a/ietf/doc/views_review.py b/ietf/doc/views_review.py index 889df45e5..0ecbc509b 100644 --- a/ietf/doc/views_review.py +++ b/ietf/doc/views_review.py @@ -337,6 +337,7 @@ def reject_reviewer_assignment(request, name, assignment_id): if form.is_valid(): # reject the assignment review_assignment.state = ReviewAssignmentStateName.objects.get(slug="rejected") + review_assignment.completed_on = datetime.datetime.now() review_assignment.save() ReviewAssignmentDocEvent.objects.create(