altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

feat: More clarity in nomcom feedback, and ... (#7191)

Browse source 
* feat: Remove trailing period from photo title, etc

For consistency, in email and photo tooltips, remove the trailing
period.

* feat: Remove email link in NomCom feedback

Seeing "User Name {envelope}" seems to confuse people; it's two links,
not one. So don't show the envelope-icon,

Also change text to say "current nomcom" when saying who gets it.

Fixes: #7032
This commit is contained in:
Rich Salz 2024-03-15 22:44:44 -04:00 committed by GitHub
parent cee69993b0
commit a637799795
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ietf/templates/nomcom/feedback.html
View file

@ -81,7 +81,7 @@
<small class="text-body-secondary">{{ form.nominee.email.person.name }} for {{ form.position.name }}</small> <small class="text-body-secondary">{{ form.nominee.email.person.name }} for {{ form.position.name }}</small>
</h2> </h2>
<p class="mt-3"> <p class="mt-3">
Provide feedback about {% person_link form.nominee.person %} Provide feedback about {% person_link form.nominee.person with_email=False %}
for the <b>{{ form.position.name }}</b> position. for the <b>{{ form.position.name }}</b> position.
</p> </p>
{% elif form.topic %} {% elif form.topic %}
@ -97,8 +97,8 @@
{% endif %} {% endif %}
<p> <p>
This feedback will only be available to This feedback will only be available to
<a href="{% url 'ietf.nomcom.views.year_index' year=year %}">NomCom {{ year }}</a>. <a href="{% url 'ietf.nomcom.views.year_index' year=year %}">the current NomCom</a>.
You may have the feedback mailed back to you by selecting the option below. You can have the feedback mailed back to you by selecting the option below.
</p> </p>
<form class="float-start" id="feedbackform" method="post"> <form class="float-start" id="feedbackform" method="post">
{% csrf_token %} {% csrf_token %}

6
ietf/templates/person/person_link.html
View file

@ -1,8 +1,8 @@
{% if email and email == "system@datatracker.ietf.org" or name and name == "(System)" %}<span class="text-body-secondary">(System)</span>{% else %}<span {% if class %}class="{{ class }}" {% if email and email == "system@datatracker.ietf.org" or name and name == "(System)" %}<span class="text-body-secondary">(System)</span>{% else %}<span {% if class %}class="{{ class }}"
{% endif %}>{% if email or name %}<a {% if class %}class="text-reset"{% endif %} {% endif %}>{% if email or name %}<a {% if class %}class="text-reset"{% endif %}
title="{% if title %}{{ title }}{% else %}Datatracker profile of {{ name }}.{% endif %}" title="{% if title %}{{ title }}{% else %}Datatracker profile of {{ name }}{% endif %}"
{% if email %} href="{% url 'ietf.person.views.profile' email_or_name=email %}" {% else %} href="{% url 'ietf.person.views.profile' email_or_name=name %}" {% endif %}>{{ name }}</a>{% if email and with_email %} <a {% if class %}class="text-reset"{% endif %} {% if email %} href="{% url 'ietf.person.views.profile' email_or_name=email %}" {% else %} href="{% url 'ietf.person.views.profile' email_or_name=name %}" {% endif %}>{{ name }}</a>{% if email and with_email %} <a {% if class %}class="text-reset"{% endif %}
href="mailto:{{ email|urlencode }}" href="mailto:{{ email|urlencode }}"
aria-label="Compose email to {{ email }}." aria-label="Compose email to {{ email }}"
title="Compose email to {{ email }}."> title="Compose email to {{ email }}">
<i class="bi bi-envelope"></i></a>{% endif %}{% else %}<span class="text-body-secondary">(None)</span>{% endif %}</span>{% endif %} <i class="bi bi-envelope"></i></a>{% endif %}{% else %}<span class="text-body-secondary">(None)</span>{% endif %}</span>{% endif %}

2
ietf/templates/person/photo.html
View file

@ -2,7 +2,7 @@
{% load origin static person_filters %} {% load origin static person_filters %}
<div class="card shadow-sm mb-3 text-center photo"> <div class="card shadow-sm mb-3 text-center photo">
{% if name or email %} {% if name or email %}
<a title="Datatracker profile of {{ person.name }}." <a title="Datatracker profile of {{ person.name }}"
href="{% if name %}{% url 'ietf.person.views.profile' email_or_name=name %}{% else %}{% url 'ietf.person.views.profile' email_or_name=email %}{% endif %}"> href="{% if name %}{% url 'ietf.person.views.profile' email_or_name=name %}{% else %}{% url 'ietf.person.views.profile' email_or_name=email %}{% endif %}">
{% endif %} {% endif %}
{% if person.photo_thumb %} {% if person.photo_thumb %}