From a6377997953ced70c78c8c3a3a33ee17a31dc8f3 Mon Sep 17 00:00:00 2001
From: Rich Salz <rsalz@akamai.com>
Date: Fri, 15 Mar 2024 22:44:44 -0400
Subject: [PATCH] feat: More clarity in nomcom feedback, and ... (#7191)

* feat: Remove trailing period from photo title, etc

For consistency, in email and photo tooltips, remove the trailing
period.

* feat: Remove email link in NomCom feedback

Seeing "User Name {envelope}" seems to confuse people; it's two links,
not one. So don't show the envelope-icon,

Also change text to say "current nomcom" when saying who gets it.

Fixes: #7032
---
 ietf/templates/nomcom/feedback.html    | 6 +++---
 ietf/templates/person/person_link.html | 6 +++---
 ietf/templates/person/photo.html       | 2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/ietf/templates/nomcom/feedback.html b/ietf/templates/nomcom/feedback.html
index effacdf67..8c9e8c824 100644
--- a/ietf/templates/nomcom/feedback.html
+++ b/ietf/templates/nomcom/feedback.html
@@ -81,7 +81,7 @@
                             <small class="text-body-secondary">{{ form.nominee.email.person.name }} for {{ form.position.name }}</small>
                         </h2>
                         <p class="mt-3">
-                            Provide feedback about {% person_link form.nominee.person %}
+                            Provide feedback about {% person_link form.nominee.person with_email=False %}
                             for the <b>{{ form.position.name }}</b> position.
                         </p>
                     {% elif form.topic %}
@@ -97,8 +97,8 @@
                     {% endif %}
                     <p>
                         This feedback will only be available to
-                        <a href="{% url 'ietf.nomcom.views.year_index' year=year %}">NomCom {{ year }}</a>.
-                        You may have the feedback mailed back to you by selecting the option below.
+                        <a href="{% url 'ietf.nomcom.views.year_index' year=year %}">the current NomCom</a>.
+                        You can have the feedback mailed back to you by selecting the option below.
                     </p>
                     <form class="float-start" id="feedbackform" method="post">
                         {% csrf_token %}
diff --git a/ietf/templates/person/person_link.html b/ietf/templates/person/person_link.html
index 74ab43b94..f3f7e1a5b 100644
--- a/ietf/templates/person/person_link.html
+++ b/ietf/templates/person/person_link.html
@@ -1,8 +1,8 @@
 {% if email and email == "system@datatracker.ietf.org" or name and name == "(System)" %}<span class="text-body-secondary">(System)</span>{% else %}<span {% if class %}class="{{ class }}"
       {% endif %}>{% if email or name %}<a {% if class %}class="text-reset"{% endif %}
-           title="{% if title %}{{ title }}{% else %}Datatracker profile of {{ name }}.{% endif %}"
+           title="{% if title %}{{ title }}{% else %}Datatracker profile of {{ name }}{% endif %}"
            {% if email %} href="{% url 'ietf.person.views.profile' email_or_name=email %}" {% else %} href="{% url 'ietf.person.views.profile' email_or_name=name %}" {% endif %}>{{ name }}</a>{% if email and with_email %} <a {% if class %}class="text-reset"{% endif %}
                href="mailto:{{ email|urlencode }}"
-               aria-label="Compose email to {{ email }}."
-               title="Compose email to {{ email }}.">
+               aria-label="Compose email to {{ email }}"
+               title="Compose email to {{ email }}">
                 <i class="bi bi-envelope"></i></a>{% endif %}{% else %}<span class="text-body-secondary">(None)</span>{% endif %}</span>{% endif %}
\ No newline at end of file
diff --git a/ietf/templates/person/photo.html b/ietf/templates/person/photo.html
index 4cea8ccb1..62c1ed991 100644
--- a/ietf/templates/person/photo.html
+++ b/ietf/templates/person/photo.html
@@ -2,7 +2,7 @@
 {% load origin static person_filters %}
 <div class="card shadow-sm mb-3 text-center photo">
     {% if name or email %}
-        <a title="Datatracker profile of {{ person.name }}."
+        <a title="Datatracker profile of {{ person.name }}"
            href="{% if name %}{% url 'ietf.person.views.profile' email_or_name=name %}{% else %}{% url 'ietf.person.views.profile' email_or_name=email %}{% endif %}">
     {% endif %}
     {% if person.photo_thumb %}