altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 4 Packages Projects Releases Wiki Activity

fix: construct double-submit test correctly (#6168)

Browse source 
* fix: construct double-submit test correctly

* chore: remove unused import
This commit is contained in:
Robert Sparks 2023-09-08 13:02:18 -05:00 committed by GitHub
parent 7f074bf37f
commit 6b6c881353
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ietf/doc/tests_review.py
View file

@ -23,7 +23,7 @@ import ietf.review.mailarch
from ietf.doc.factories import ( NewRevisionDocEventFactory, IndividualDraftFactory, WgDraftFactory, from ietf.doc.factories import ( NewRevisionDocEventFactory, IndividualDraftFactory, WgDraftFactory,
WgRfcFactory, ReviewFactory, DocumentFactory) WgRfcFactory, ReviewFactory, DocumentFactory)
from ietf.doc.models import ( Document, DocumentAuthor, RelatedDocument, DocEvent, ReviewRequestDocEvent, from ietf.doc.models import ( DocumentAuthor, RelatedDocument, DocEvent, ReviewRequestDocEvent,
ReviewAssignmentDocEvent, ) ReviewAssignmentDocEvent, )
from ietf.group.factories import RoleFactory, ReviewTeamFactory from ietf.group.factories import RoleFactory, ReviewTeamFactory
from ietf.group.models import Group from ietf.group.models import Group
@ -914,7 +914,8 @@ class ReviewTests(TestCase):
date_today().isoformat(), date_today().isoformat(),
] ]
review_name = "-".join(c for c in name_components if c).lower() review_name = "-".join(c for c in name_components if c).lower()
Document.objects.create(name=review_name,type_id='review',group=assignment.review_request.team)
ReviewFactory(name=review_name,type_id='review',group=assignment.review_request.team)
r = self.client.post(url, data={ r = self.client.post(url, data={
"result": ReviewResultName.objects.get(reviewteamsettings_review_results_set__group=assignment.review_request.team, slug="ready").pk, "result": ReviewResultName.objects.get(reviewteamsettings_review_results_set__group=assignment.review_request.team, slug="ready").pk,
@ -930,10 +931,9 @@ class ReviewTests(TestCase):
}) })
self.assertEqual(r.status_code, 302) self.assertEqual(r.status_code, 302)
r2 = self.client.get(r.url) r2 = self.client.get(r.url)
# FIXME-LARS: this fails when the tests are run with --debug-mode, i.e., DEBUG is set: self.assertEqual(r2.status_code, 200)
if not settings.DEBUG: self.assertEqual(len(r2.context['messages']),1)
self.assertEqual(len(r2.context['messages']),1) self.assertIn('Attempt to save review failed', list(r2.context['messages'])[0].message)
self.assertIn('Attempt to save review failed', list(r2.context['messages'])[0].message)
def test_partially_complete_review(self): def test_partially_complete_review(self):
assignment, url = self.setup_complete_review_test() assignment, url = self.setup_complete_review_test()