From 6b6c8813533d0bbec94190079b54e38a5b0700ce Mon Sep 17 00:00:00 2001
From: Robert Sparks <rjsparks@nostrum.com>
Date: Fri, 8 Sep 2023 13:02:18 -0500
Subject: [PATCH] fix: construct double-submit test correctly (#6168)
* fix: construct double-submit test correctly
* chore: remove unused import
---
ietf/doc/tests_review.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/ietf/doc/tests_review.py b/ietf/doc/tests_review.py
index 1f84303a9..5df8ab259 100644
--- a/ietf/doc/tests_review.py
+++ b/ietf/doc/tests_review.py
@@ -23,7 +23,7 @@ import ietf.review.mailarch
from ietf.doc.factories import ( NewRevisionDocEventFactory, IndividualDraftFactory, WgDraftFactory,
WgRfcFactory, ReviewFactory, DocumentFactory)
-from ietf.doc.models import ( Document, DocumentAuthor, RelatedDocument, DocEvent, ReviewRequestDocEvent,
+from ietf.doc.models import ( DocumentAuthor, RelatedDocument, DocEvent, ReviewRequestDocEvent,
ReviewAssignmentDocEvent, )
from ietf.group.factories import RoleFactory, ReviewTeamFactory
from ietf.group.models import Group
@@ -914,7 +914,8 @@ class ReviewTests(TestCase):
date_today().isoformat(),
]
review_name = "-".join(c for c in name_components if c).lower()
- Document.objects.create(name=review_name,type_id='review',group=assignment.review_request.team)
+
+ ReviewFactory(name=review_name,type_id='review',group=assignment.review_request.team)
r = self.client.post(url, data={
"result": ReviewResultName.objects.get(reviewteamsettings_review_results_set__group=assignment.review_request.team, slug="ready").pk,
@@ -930,10 +931,9 @@ class ReviewTests(TestCase):
})
self.assertEqual(r.status_code, 302)
r2 = self.client.get(r.url)
- # FIXME-LARS: this fails when the tests are run with --debug-mode, i.e., DEBUG is set:
- if not settings.DEBUG:
- self.assertEqual(len(r2.context['messages']),1)
- self.assertIn('Attempt to save review failed', list(r2.context['messages'])[0].message)
+ self.assertEqual(r2.status_code, 200)
+ self.assertEqual(len(r2.context['messages']),1)
+ self.assertIn('Attempt to save review failed', list(r2.context['messages'])[0].message)
def test_partially_complete_review(self):
assignment, url = self.setup_complete_review_test()