Send email to reviewer when request is closed with no response. Fixes #2176. Commit ready to merge.
- Legacy-Id: 13897
This commit is contained in:
parent
7a11217f6f
commit
617dac49d6
|
@ -504,7 +504,6 @@ def possibly_advance_next_reviewer_for_team(team, assigned_review_to_person_id,
|
|||
def close_review_request(request, review_req, close_state):
|
||||
suggested_req = review_req.pk is None
|
||||
|
||||
prev_state = review_req.state
|
||||
review_req.state = close_state
|
||||
if close_state.slug == "no-review-version":
|
||||
review_req.reviewed_rev = review_req.requested_rev or review_req.doc.rev # save rev for later reference
|
||||
|
@ -522,7 +521,6 @@ def close_review_request(request, review_req, close_state):
|
|||
state=review_req.state,
|
||||
)
|
||||
|
||||
if prev_state.slug != "requested":
|
||||
email_review_request_change(
|
||||
request, review_req,
|
||||
"Closed review request for {}: {}".format(review_req.doc.name, close_state.name),
|
||||
|
|
Loading…
Reference in a new issue