From 617dac49d6d240d46bcaf870290fc03c1fbee211 Mon Sep 17 00:00:00 2001 From: Robert Sparks Date: Sat, 15 Jul 2017 12:07:20 +0000 Subject: [PATCH] Send email to reviewer when request is closed with no response. Fixes #2176. Commit ready to merge. - Legacy-Id: 13897 --- ietf/review/utils.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/ietf/review/utils.py b/ietf/review/utils.py index acf0b02da..c20d701af 100644 --- a/ietf/review/utils.py +++ b/ietf/review/utils.py @@ -504,7 +504,6 @@ def possibly_advance_next_reviewer_for_team(team, assigned_review_to_person_id, def close_review_request(request, review_req, close_state): suggested_req = review_req.pk is None - prev_state = review_req.state review_req.state = close_state if close_state.slug == "no-review-version": review_req.reviewed_rev = review_req.requested_rev or review_req.doc.rev # save rev for later reference @@ -522,12 +521,11 @@ def close_review_request(request, review_req, close_state): state=review_req.state, ) - if prev_state.slug != "requested": - email_review_request_change( - request, review_req, - "Closed review request for {}: {}".format(review_req.doc.name, close_state.name), - "Review request has been closed by {}.".format(request.user.person), - by=request.user.person, notify_secretary=False, notify_reviewer=True, notify_requested_by=True) + email_review_request_change( + request, review_req, + "Closed review request for {}: {}".format(review_req.doc.name, close_state.name), + "Review request has been closed by {}.".format(request.user.person), + by=request.user.person, notify_secretary=False, notify_reviewer=True, notify_requested_by=True) def suggested_review_requests_for_team(team):