From 56003f66d87dbb8fedb8bd8846dcfb5435ea670a Mon Sep 17 00:00:00 2001 From: Sasha Romijn Date: Thu, 21 Nov 2019 11:03:21 +0000 Subject: [PATCH] Fix #2278 - Notify secretary when a review request is closed. The assigned reviewer was already notified, but secretaries were always excluded. Commit ready for merge. - Legacy-Id: 17085 --- ietf/doc/tests_review.py | 2 ++ ietf/review/utils.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ietf/doc/tests_review.py b/ietf/doc/tests_review.py index d0f94fa36..9b5faae75 100644 --- a/ietf/doc/tests_review.py +++ b/ietf/doc/tests_review.py @@ -189,6 +189,7 @@ class ReviewTests(TestCase): review_team = ReviewTeamFactory(acronym="reviewteam", name="Review Team", type_id="review", list_email="reviewteam@ietf.org", parent=Group.objects.get(acronym="farfut")) rev_role = RoleFactory(group=review_team,person__user__username='reviewer',person__user__email='reviewer@example.com',name_id='reviewer') RoleFactory(group=review_team,person__user__username='reviewsecretary',person__user__email='reviewsecretary@example.com',name_id='secr') + RoleFactory(group=review_team,person__user__username='reviewsecretary2',person__user__email='reviewsecretary2@example.com',name_id='secr') review_req = ReviewRequestFactory(doc=doc,team=review_team,type_id='early',state_id='assigned',requested_by=rev_role.person,deadline=datetime.datetime.now()+datetime.timedelta(days=20)) ReviewAssignmentFactory(review_request=review_req, state_id='accepted', reviewer=rev_role.person.email_set.first()) @@ -229,6 +230,7 @@ class ReviewTests(TestCase): self.assertEqual(len(outbox), 1) self.assertTrue('' in outbox[0]["To"]) self.assertFalse("" in outbox[0]["To"]) + self.assertTrue("" in outbox[0]["To"]) mail_content = outbox[0].get_payload(decode=True).decode("utf-8").lower() self.assertTrue("closed" in mail_content) self.assertTrue("review_request_close_comment" in mail_content) diff --git a/ietf/review/utils.py b/ietf/review/utils.py index b9cbd3492..b80e9b2ef 100644 --- a/ietf/review/utils.py +++ b/ietf/review/utils.py @@ -564,7 +564,7 @@ def close_review_request(request, review_req, close_state, close_comment=''): email_review_request_change( request, review_req, "Closed review request for {}: {}".format(review_req.doc.name, close_state.name), - msg=msg, by=request.user.person, notify_secretary=False, + msg=msg, by=request.user.person, notify_secretary=True, notify_reviewer=True, notify_requested_by=True) def suggested_review_requests_for_team(team):