From 2bad0b0bcde49701fcc05af382bd8937d83b816a Mon Sep 17 00:00:00 2001 From: Robert Sparks Date: Tue, 20 Dec 2016 22:22:44 +0000 Subject: [PATCH] Show other completed reviews of a document on page showing the status of a review request. Fixes #2083. Commit ready for merge. - Legacy-Id: 12596 --- ietf/review/models.py | 6 ++++++ ietf/templates/doc/review/review_request.html | 12 ++++++++++++ 2 files changed, 18 insertions(+) diff --git a/ietf/review/models.py b/ietf/review/models.py index 4a80c5512..625c040fa 100644 --- a/ietf/review/models.py +++ b/ietf/review/models.py @@ -158,6 +158,12 @@ class ReviewRequest(models.Model): def __unicode__(self): return u"%s review on %s by %s %s" % (self.type, self.doc, self.team, self.state) + def other_requests(self): + return self.doc.reviewrequest_set.exclude(id=self.id) + + def other_completed_requests(self): + return self.other_requests().filter(state_id__in=['completed','part-completed']) + def get_default_review_types(): return ReviewTypeName.objects.filter(slug__in=['early','lc','telechat']) diff --git a/ietf/templates/doc/review/review_request.html b/ietf/templates/doc/review/review_request.html index af7227489..a2abdfcbb 100644 --- a/ietf/templates/doc/review/review_request.html +++ b/ietf/templates/doc/review/review_request.html @@ -67,6 +67,18 @@ {% endif %} + + + Other Reviews + + {% for req in review_req.other_completed_requests %} + {% if req.reviewer == review_req.reviewer %}{% endif %} + {{req.team.acronym|capfirst}} {{req.type.name}} review of -{{req.reviewed_rev}} by {{req.reviewer.person.plain_name}} {% if req.reviewed_rev != req.doc.rev %} (diff){% endif %}
+ {% if req.reviewer == review_req.reviewer %}
{% endif %} + {% endfor %} + + + {% if review_req.comment %}