altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

fix: do not create ReviewRequestDocEvent when assigning a review req (#4913)

Browse source 
* fix: do not create ReviewRequestDocEvent when assigning a review req

* test: test docevent creation
This commit is contained in:
Jennifer Richards 2022-12-16 17:17:10 -04:00 committed by GitHub
parent ad5cf0bb01
commit 27469c1264
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ietf/doc/tests_review.py
View file

@ -345,6 +345,16 @@ class ReviewTests(TestCase):
self.assertIn("This team has completed other reviews", message) self.assertIn("This team has completed other reviews", message)
self.assertIn("{} -01 Serious Issues".format(reviewer_email.person.ascii), message) self.assertIn("{} -01 Serious Issues".format(reviewer_email.person.ascii), message)
# check events
assignment_events = assignment.reviewassignmentdocevent_set.all()
self.assertEqual(assignment_events.count(), 1)
e = assignment_events.first()
self.assertEqual(e.type, 'assigned_review_request')
self.assertIn('is assigned', e.desc)
self.assertEqual(e.doc, doc)
request_events = review_req.reviewrequestdocevent_set.all()
self.assertEqual(request_events.count(), 0)
def test_previously_reviewed_replaced_doc(self): def test_previously_reviewed_replaced_doc(self):
review_team = ReviewTeamFactory(acronym="reviewteam", name="Review Team", type_id="review", list_email="reviewteam@ietf.org", parent=Group.objects.get(acronym="farfut")) review_team = ReviewTeamFactory(acronym="reviewteam", name="Review Team", type_id="review", list_email="reviewteam@ietf.org", parent=Group.objects.get(acronym="farfut"))
rev_role = RoleFactory(group=review_team,person__user__username='reviewer',person__user__email='reviewer@example.com',person__name='Some Reviewer',name_id='reviewer') rev_role = RoleFactory(group=review_team,person__user__username='reviewer',person__user__email='reviewer@example.com',person__name='Some Reviewer',name_id='reviewer')

11
ietf/review/utils.py
View file

@ -398,15 +398,6 @@ def assign_review_request_to_reviewer(request, review_req, reviewer, add_skip=Fa
review_req.team.acronym.upper(), review_req.team.acronym.upper(),
reviewer.person if reviewer else "(None)") reviewer.person if reviewer else "(None)")
update_change_reason(assignment, descr) update_change_reason(assignment, descr)
ReviewRequestDocEvent.objects.create(
type="assigned_review_request",
doc=review_req.doc,
rev=review_req.doc.rev,
by=request.user.person,
desc=descr,
review_request=review_req,
state_id='assigned',
)
ReviewAssignmentDocEvent.objects.create( ReviewAssignmentDocEvent.objects.create(
type="assigned_review_request", type="assigned_review_request",
@ -416,7 +407,7 @@ def assign_review_request_to_reviewer(request, review_req, reviewer, add_skip=Fa
desc="Request for {} review by {} is assigned to {}".format( desc="Request for {} review by {} is assigned to {}".format(
review_req.type.name, review_req.type.name,
review_req.team.acronym.upper(), review_req.team.acronym.upper(),
reviewer.person, reviewer.person if reviewer else "(None)",
), ),
review_assignment=assignment, review_assignment=assignment,
state_id='assigned', state_id='assigned',