diff --git a/ietf/doc/tests_review.py b/ietf/doc/tests_review.py index bffd1fd27..f4c814005 100644 --- a/ietf/doc/tests_review.py +++ b/ietf/doc/tests_review.py @@ -345,6 +345,16 @@ class ReviewTests(TestCase): self.assertIn("This team has completed other reviews", message) self.assertIn("{} -01 Serious Issues".format(reviewer_email.person.ascii), message) + # check events + assignment_events = assignment.reviewassignmentdocevent_set.all() + self.assertEqual(assignment_events.count(), 1) + e = assignment_events.first() + self.assertEqual(e.type, 'assigned_review_request') + self.assertIn('is assigned', e.desc) + self.assertEqual(e.doc, doc) + request_events = review_req.reviewrequestdocevent_set.all() + self.assertEqual(request_events.count(), 0) + def test_previously_reviewed_replaced_doc(self): review_team = ReviewTeamFactory(acronym="reviewteam", name="Review Team", type_id="review", list_email="reviewteam@ietf.org", parent=Group.objects.get(acronym="farfut")) rev_role = RoleFactory(group=review_team,person__user__username='reviewer',person__user__email='reviewer@example.com',person__name='Some Reviewer',name_id='reviewer') diff --git a/ietf/review/utils.py b/ietf/review/utils.py index 1227aee2f..032b1fd41 100644 --- a/ietf/review/utils.py +++ b/ietf/review/utils.py @@ -398,15 +398,6 @@ def assign_review_request_to_reviewer(request, review_req, reviewer, add_skip=Fa review_req.team.acronym.upper(), reviewer.person if reviewer else "(None)") update_change_reason(assignment, descr) - ReviewRequestDocEvent.objects.create( - type="assigned_review_request", - doc=review_req.doc, - rev=review_req.doc.rev, - by=request.user.person, - desc=descr, - review_request=review_req, - state_id='assigned', - ) ReviewAssignmentDocEvent.objects.create( type="assigned_review_request", @@ -416,7 +407,7 @@ def assign_review_request_to_reviewer(request, review_req, reviewer, add_skip=Fa desc="Request for {} review by {} is assigned to {}".format( review_req.type.name, review_req.team.acronym.upper(), - reviewer.person, + reviewer.person if reviewer else "(None)", ), review_assignment=assignment, state_id='assigned',