c606461b22
Fix #2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button 'Submit unsolicited review' will now
appear next to 'Request review' on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
- Legacy-Id: 16932
Note: SVN reference [16924] has been migrated to Git commit
|
||
|---|---|---|
| bin | ||
| bootstrap | ||
| buildbot/masters/datatracker | ||
| data | ||
| djangobwr | ||
| docker | ||
| env | ||
| etc | ||
| hooks | ||
| ietf | ||
| media | ||
| notes | ||
| patch | ||
| pyzmail | ||
| static | ||
| test | ||
| vzic | ||
| .bowerrc | ||
| .editorconfig | ||
| .eslintrc.js | ||
| .gitignore | ||
| .pylintrc | ||
| changelog | ||
| changelog.py | ||
| control | ||
| debug.py | ||
| hold-for-merge | ||
| INSTALL | ||
| LICENSE | ||
| mypy.ini | ||
| PLAN | ||
| README-CDN.rst | ||
| README.datatracker | ||
| ready-for-merge | ||
| release-coverage.json.gz | ||
| requirements.txt | ||
| requirements3.txt | ||
| tzparse.py | ||
The "new" datatracker uses Twitter Bootstrap for the UI. Get familiar with http://getbootstrap.com/getting-started/ and use those UI elements instead of cooking up your own. We have some site-wide customization applied to the bootstrap version we keep in bootstrap/ (from which the minified dist version is built); it modifies some stuff under less/ We also apply some additional customizations in static/css/ietf.css; we should eventually move that under bootstrap/less/ if possible. (ietf.css was what Lars used initially for customization with an unmodified bootstrap.) Some ground rules: * Think hard before tweaking the bootstrap CSS, it will make it harder to upgrade to future releases. * No <style> tags in the HTML! Put CSS into the "morecss" block of a template instead. * CSS that is used by multiple templates goes into static/css/ietf.css. * Javascript that is only used on one template goes into the "js" block of that template. * Javascript that is used by multiple templates goes into static/js/ietf.js. * Every template includes jquery, so write jquery code and not plain Javascript. It's shorter and often faster. * No CSS, HTML styling or Javascript in the python code! * Templates that use jquery or bootstrap plugins include the css file in the "pagehead" block, and the Javascript in the "js" block.