The new API requires at least one event and will automatically save a snapshot of the document and related state. Document.save() will now throw an exception if called directly, as the new API is intended to ensure that documents are saved with both an appropriate snapsnot and relevant history log, both of which are easily defeated by just calling .save() directly. To simplify things, the snapshot is generated after the changes to a document have been made (in anticipation of coming changes), instead of before as was usual. While revising the existing code to work with this API, a couple of missing events was discovered: - In draft expiry, a "Document has expired" event was only generated in case an IESG process had started on the document - now it's always generated, as the document changes its state in any case - Synchronization updates like title and abstract amendmends from the RFC Editor were silently (except for RFC publication) applied and not accompanied by a descriptive event - they now are - do_replace in the Secretariat tools now adds an event - Proceedings post_process in the Secretariat tools now adds an event - do_withdraw in the Secretariat tools now adds an event A migration is needed for snapshotting all documents, takes a while to run. It turns out that a single document had a bad foreign key so the migration fixes that too. - Legacy-Id: 10101
155 lines
5.7 KiB
Python
155 lines
5.7 KiB
Python
import datetime
|
|
import subprocess
|
|
import os
|
|
import json
|
|
|
|
from django.http import HttpResponse, HttpResponseForbidden, HttpResponseServerError, HttpResponseRedirect, Http404
|
|
from django.shortcuts import render
|
|
from django.conf import settings
|
|
from django.contrib.auth.models import User
|
|
from django.contrib.contenttypes.models import ContentType
|
|
from django.views.decorators.csrf import csrf_exempt
|
|
|
|
from ietf.doc.models import DeletedEvent, StateDocEvent, DocEvent
|
|
from ietf.ietfauth.utils import role_required, has_role
|
|
from ietf.sync.discrepancies import find_discrepancies
|
|
from ietf.utils.serialize import object_as_shallow_dict
|
|
|
|
SYNC_BIN_PATH = os.path.abspath(os.path.join(os.path.dirname(os.path.abspath(__file__)), "../bin"))
|
|
|
|
#@role_required('Secretariat', 'IANA', 'RFC Editor')
|
|
def discrepancies(request):
|
|
sections = find_discrepancies()
|
|
|
|
return render(request, "sync/discrepancies.html", dict(sections=sections))
|
|
|
|
@csrf_exempt # external API so we can't expect the other end to have a token
|
|
def notify(request, org, notification):
|
|
"""Notify us that something has changed on an external site so we need to
|
|
run a sync script."""
|
|
|
|
known_orgs = {
|
|
"iana": "IANA",
|
|
"rfceditor": "RFC Editor",
|
|
}
|
|
|
|
if org not in known_orgs:
|
|
raise Http404
|
|
|
|
# handle auth, to make it easier for the other end, you can send
|
|
# the username/password as POST parameters instead of having to
|
|
# visit the login page
|
|
user = request.user
|
|
|
|
username = request.POST.get("username") or request.GET.get("username")
|
|
password = request.POST.get("password") or request.GET.get("password")
|
|
|
|
if username != None and password != None:
|
|
if settings.SERVER_MODE == "production" and not request.is_secure():
|
|
return HttpResponseForbidden("You must use HTTPS when sending username/password")
|
|
|
|
if not user.is_authenticated():
|
|
try:
|
|
user = User.objects.get(username=username)
|
|
except User.DoesNotExist:
|
|
return HttpResponse("Invalid username/password")
|
|
|
|
if not user.check_password(password):
|
|
return HttpResponse("Invalid username/password")
|
|
|
|
if not has_role(user, ("Secretariat", known_orgs[org])):
|
|
return HttpResponseForbidden("You do not have the necessary permissions to view this page")
|
|
|
|
known_notifications = {
|
|
"protocols": "an added reference to an RFC at <a href=\"%s\">the IANA protocols page</a>" % settings.IANA_SYNC_PROTOCOLS_URL,
|
|
"changes": "new changes at <a href=\"%s\">the changes JSON dump</a>" % settings.IANA_SYNC_CHANGES_URL,
|
|
"queue": "new changes to <a href=\"%s\">queue2.xml</a>" % settings.RFC_EDITOR_QUEUE_URL,
|
|
"index": "new changes to <a href=\"%s\">rfc-index.xml</a>" % settings.RFC_EDITOR_INDEX_URL,
|
|
}
|
|
|
|
if notification not in known_notifications:
|
|
raise Http404
|
|
|
|
if request.method == "POST":
|
|
def runscript(name):
|
|
p = subprocess.Popen(["python", os.path.join(SYNC_BIN_PATH, name)],
|
|
stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
|
|
out, _ = p.communicate()
|
|
return (p.returncode, out)
|
|
|
|
import syslog
|
|
syslog.syslog("Running sync script from notify view POST")
|
|
|
|
if notification == "protocols":
|
|
failed, out = runscript("iana-protocols-updates")
|
|
|
|
if notification == "changes":
|
|
failed, out = runscript("iana-changes-updates")
|
|
|
|
if notification == "queue":
|
|
failed, out = runscript("rfc-editor-queue-updates")
|
|
|
|
if notification == "index":
|
|
failed, out = runscript("rfc-editor-index-updates")
|
|
|
|
if failed:
|
|
return HttpResponseServerError("FAIL\n\n" + out, content_type="text/plain; charset=%s"%settings.DEFAULT_CHARSET)
|
|
else:
|
|
return HttpResponse("OK", content_type="text/plain; charset=%s"%settings.DEFAULT_CHARSET)
|
|
|
|
return render(request, 'sync/notify.html',
|
|
dict(org=known_orgs[org],
|
|
notification=notification,
|
|
help_text=known_notifications[notification],
|
|
))
|
|
|
|
@role_required('Secretariat', 'RFC Editor')
|
|
def rfceditor_undo(request):
|
|
"""Undo a DocEvent."""
|
|
events = []
|
|
events.extend(StateDocEvent.objects.filter(
|
|
state_type="draft-rfceditor",
|
|
time__gte=datetime.datetime.now() - datetime.timedelta(weeks=1)
|
|
).order_by("-time", "-id"))
|
|
|
|
events.extend(DocEvent.objects.filter(
|
|
type="sync_from_rfc_editor",
|
|
time__gte=datetime.datetime.now() - datetime.timedelta(weeks=1)
|
|
).order_by("-time", "-id"))
|
|
|
|
events.sort(key=lambda e: (e.time, e.id), reverse=True)
|
|
|
|
if request.method == "POST":
|
|
try:
|
|
eid = int(request.POST.get("event", ""))
|
|
except ValueError:
|
|
return HttpResponse("Could not parse event id")
|
|
|
|
for e in events:
|
|
if e.id == eid:
|
|
break
|
|
else:
|
|
return HttpResponse("Event does not exist")
|
|
|
|
doc = e.doc
|
|
|
|
# possibly reset the state of the document
|
|
all_events = StateDocEvent.objects.filter(doc=doc, state_type="draft-rfceditor").order_by("-time", "-id")
|
|
if all_events and all_events[0] == e:
|
|
if len(all_events) > 1:
|
|
doc.set_state(all_events[1].state)
|
|
else:
|
|
doc.unset_state("draft-rfceditor")
|
|
|
|
dump = DeletedEvent()
|
|
dump.content_type = ContentType.objects.get_for_model(type(e))
|
|
dump.json = json.dumps(object_as_shallow_dict(e), indent=2)
|
|
dump.by = request.user.person
|
|
dump.save()
|
|
|
|
e.delete()
|
|
|
|
return HttpResponseRedirect("")
|
|
|
|
return render(request, 'sync/rfceditor_undo.html', dict(events=events))
|