d4e5f070af
Refactored editing the notify field to remove redundant code. Changed the default notification list to include .all for documents, and the wg list for wg documents. Allowed recalculating the notification list for all document types. Improved the calculated notification list value for charters, conflict-reviews, and status-changes. Adds shepherds to the notification list when they are assigned to a document. Adds the working group email list to the notification list when a document is adopted. Fixes #1438 - Legacy-Id: 8385 Note: SVN reference [8293] has been migrated to Git commit 640c5eb52ace8bb6d2c1b3ca6c14ef10ad0f324f
439 lines
18 KiB
Python
439 lines
18 KiB
Python
# Copyright The IETF Trust 2011, All Rights Reserved
|
|
|
|
import os, shutil, datetime
|
|
from StringIO import StringIO
|
|
from pyquery import PyQuery
|
|
|
|
from django.conf import settings
|
|
from django.core.urlresolvers import reverse as urlreverse
|
|
|
|
from ietf.doc.models import ( Document, State, BallotDocEvent, BallotType, NewRevisionDocEvent,
|
|
TelechatDocEvent, WriteupDocEvent )
|
|
from ietf.doc.utils_charter import next_revision, default_review_text, default_action_text
|
|
from ietf.group.models import Group, GroupMilestone
|
|
from ietf.iesg.models import TelechatDate
|
|
from ietf.person.models import Person
|
|
from ietf.utils.test_utils import TestCase
|
|
from ietf.utils.mail import outbox
|
|
from ietf.utils.test_data import make_test_data
|
|
from ietf.utils.test_utils import login_testing_unauthorized
|
|
|
|
class EditCharterTests(TestCase):
|
|
def setUp(self):
|
|
self.charter_dir = os.path.abspath("tmp-charter-dir")
|
|
os.mkdir(self.charter_dir)
|
|
settings.CHARTER_PATH = self.charter_dir
|
|
|
|
def tearDown(self):
|
|
shutil.rmtree(self.charter_dir)
|
|
|
|
def test_startstop_process(self):
|
|
make_test_data()
|
|
|
|
group = Group.objects.get(acronym="mars")
|
|
charter = group.charter
|
|
|
|
for option in ("recharter", "abandon"):
|
|
self.client.logout()
|
|
url = urlreverse('charter_startstop_process', kwargs=dict(name=charter.name, option=option))
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
|
|
# normal get
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
|
|
# post
|
|
r = self.client.post(url, dict(message="test message"))
|
|
self.assertEqual(r.status_code, 302)
|
|
if option == "abandon":
|
|
self.assertTrue("abandoned" in charter.latest_event(type="changed_document").desc.lower())
|
|
else:
|
|
self.assertTrue("state changed" in charter.latest_event(type="changed_state").desc.lower())
|
|
|
|
def test_change_state(self):
|
|
make_test_data()
|
|
|
|
group = Group.objects.get(acronym="ames")
|
|
charter = group.charter
|
|
|
|
url = urlreverse('charter_change_state', kwargs=dict(name=charter.name))
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
|
|
first_state = charter.get_state()
|
|
|
|
# normal get
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
q = PyQuery(r.content)
|
|
self.assertEqual(len(q('form select[name=charter_state]')), 1)
|
|
|
|
# faulty post
|
|
r = self.client.post(url, dict(charter_state="-12345"))
|
|
self.assertEqual(r.status_code, 200)
|
|
q = PyQuery(r.content)
|
|
self.assertTrue(len(q('form ul.errorlist')) > 0)
|
|
self.assertEqual(charter.get_state(), first_state)
|
|
|
|
# change state
|
|
for slug in ("intrev", "extrev", "iesgrev"):
|
|
s = State.objects.get(used=True, type="charter", slug=slug)
|
|
events_before = charter.docevent_set.count()
|
|
mailbox_before = len(outbox)
|
|
|
|
r = self.client.post(url, dict(charter_state=str(s.pk), message="test message"))
|
|
self.assertEqual(r.status_code, 302)
|
|
|
|
charter = Document.objects.get(name="charter-ietf-%s" % group.acronym)
|
|
self.assertEqual(charter.get_state_slug(), slug)
|
|
events_now = charter.docevent_set.count()
|
|
self.assertTrue(events_now > events_before)
|
|
|
|
def find_event(t):
|
|
return [e for e in charter.docevent_set.all()[:events_now - events_before] if e.type == t]
|
|
|
|
self.assertTrue("state changed" in find_event("changed_state")[0].desc.lower())
|
|
|
|
if slug in ("intrev", "iesgrev"):
|
|
self.assertTrue(find_event("created_ballot"))
|
|
|
|
self.assertEqual(len(outbox), mailbox_before + 1)
|
|
self.assertTrue("state changed" in outbox[-1]['Subject'].lower())
|
|
|
|
def test_edit_telechat_date(self):
|
|
make_test_data()
|
|
|
|
group = Group.objects.get(acronym="mars")
|
|
charter = group.charter
|
|
|
|
url = urlreverse('charter_telechat_date', kwargs=dict(name=charter.name))
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
|
|
# get
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
|
|
# add to telechat
|
|
self.assertTrue(not charter.latest_event(TelechatDocEvent, "scheduled_for_telechat"))
|
|
telechat_date = TelechatDate.objects.active()[0].date
|
|
r = self.client.post(url, dict(name=group.name, acronym=group.acronym, telechat_date=telechat_date.isoformat()))
|
|
self.assertEqual(r.status_code, 302)
|
|
|
|
charter = Document.objects.get(name=charter.name)
|
|
self.assertTrue(charter.latest_event(TelechatDocEvent, "scheduled_for_telechat"))
|
|
self.assertEqual(charter.latest_event(TelechatDocEvent, "scheduled_for_telechat").telechat_date, telechat_date)
|
|
|
|
# change telechat
|
|
telechat_date = TelechatDate.objects.active()[1].date
|
|
r = self.client.post(url, dict(name=group.name, acronym=group.acronym, telechat_date=telechat_date.isoformat()))
|
|
self.assertEqual(r.status_code, 302)
|
|
|
|
charter = Document.objects.get(name=charter.name)
|
|
self.assertEqual(charter.latest_event(TelechatDocEvent, "scheduled_for_telechat").telechat_date, telechat_date)
|
|
|
|
# remove from agenda
|
|
telechat_date = ""
|
|
r = self.client.post(url, dict(name=group.name, acronym=group.acronym, telechat_date=telechat_date))
|
|
self.assertEqual(r.status_code, 302)
|
|
|
|
charter = Document.objects.get(name=charter.name)
|
|
self.assertTrue(not charter.latest_event(TelechatDocEvent, "scheduled_for_telechat").telechat_date)
|
|
|
|
def test_no_returning_item_for_different_ballot(self):
|
|
make_test_data()
|
|
|
|
group = Group.objects.get(acronym="ames")
|
|
charter = group.charter
|
|
url = urlreverse('charter_telechat_date', kwargs=dict(name=charter.name))
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
login = Person.objects.get(user__username="secretary")
|
|
|
|
# Make it so that the charter has been through internal review, and passed its external review
|
|
# ballot on a previous telechat
|
|
last_week = datetime.date.today()-datetime.timedelta(days=7)
|
|
BallotDocEvent.objects.create(type='created_ballot',by=login,doc=charter,
|
|
ballot_type=BallotType.objects.get(doc_type=charter.type,slug='r-extrev'),
|
|
time=last_week)
|
|
TelechatDocEvent.objects.create(type='scheduled_for_telechat',doc=charter,by=login,telechat_date=last_week,returning_item=False)
|
|
BallotDocEvent.objects.create(type='created_ballot',by=login,doc=charter,
|
|
ballot_type=BallotType.objects.get(doc_type=charter.type,slug='approve'))
|
|
|
|
# Put the charter onto a future telechat and verify returning item is not set
|
|
telechat_date = TelechatDate.objects.active()[1].date
|
|
r = self.client.post(url, dict(name=group.name, acronym=group.acronym, telechat_date=telechat_date.isoformat()))
|
|
self.assertEqual(r.status_code, 302)
|
|
|
|
charter = Document.objects.get(name=charter.name)
|
|
telechat_event = charter.latest_event(TelechatDocEvent, "scheduled_for_telechat")
|
|
self.assertEqual(telechat_event.telechat_date, telechat_date)
|
|
self.assertFalse(telechat_event.returning_item)
|
|
|
|
def test_edit_notify(self):
|
|
make_test_data()
|
|
|
|
charter = Group.objects.get(acronym="mars").charter
|
|
|
|
url = urlreverse('charter_edit_notify', kwargs=dict(name=charter.name))
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
|
|
# get
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
|
|
# post
|
|
self.assertTrue(not charter.notify)
|
|
newlist = "someone@example.com, someoneelse@example.com"
|
|
r = self.client.post(url, dict(notify=newlist,save_addresses="1"))
|
|
self.assertEqual(r.status_code, 302)
|
|
|
|
charter = Document.objects.get(name=charter.name)
|
|
self.assertEqual(charter.notify, newlist)
|
|
|
|
# Ask the form to regenerate the list
|
|
r = self.client.post(url,dict(regenerate_addresses="1"))
|
|
self.assertEqual(r.status_code,200)
|
|
charter= Document.objects.get(name=charter.name)
|
|
# Regenerate does not save!
|
|
self.assertEqual(charter.notify,newlist)
|
|
q = PyQuery(r.content)
|
|
formlist = q('form input[name=notify]')[0].value
|
|
self.assertTrue('marschairman@ietf.org' in formlist)
|
|
self.assertFalse('someone@example.com' in formlist)
|
|
|
|
def test_edit_ad(self):
|
|
make_test_data()
|
|
|
|
charter = Group.objects.get(acronym="mars").charter
|
|
|
|
url = urlreverse('charter_edit_ad', kwargs=dict(name=charter.name))
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
|
|
# normal get
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
q = PyQuery(r.content)
|
|
self.assertEqual(len(q('select[name=ad]')),1)
|
|
|
|
# post
|
|
self.assertTrue(not charter.ad)
|
|
ad2 = Person.objects.get(name='Ad No2')
|
|
r = self.client.post(url,dict(ad=str(ad2.pk)))
|
|
self.assertEqual(r.status_code, 302)
|
|
|
|
charter = Document.objects.get(name=charter.name)
|
|
self.assertEqual(charter.ad, ad2)
|
|
|
|
def test_submit_charter(self):
|
|
make_test_data()
|
|
|
|
group = Group.objects.get(acronym="mars")
|
|
charter = group.charter
|
|
|
|
url = urlreverse('charter_submit', kwargs=dict(name=charter.name))
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
|
|
# normal get
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
q = PyQuery(r.content)
|
|
self.assertEqual(len(q('form input[name=txt]')), 1)
|
|
|
|
# faulty post
|
|
test_file = StringIO("\x10\x11\x12") # post binary file
|
|
test_file.name = "unnamed"
|
|
|
|
r = self.client.post(url, dict(txt=test_file))
|
|
self.assertEqual(r.status_code, 200)
|
|
self.assertTrue("does not appear to be a text file" in r.content)
|
|
|
|
# post
|
|
prev_rev = charter.rev
|
|
|
|
latin_1_snippet = '\xe5' * 10
|
|
utf_8_snippet = '\xc3\xa5' * 10
|
|
test_file = StringIO("Windows line\r\nMac line\rUnix line\n" + latin_1_snippet)
|
|
test_file.name = "unnamed"
|
|
|
|
r = self.client.post(url, dict(txt=test_file))
|
|
self.assertEqual(r.status_code, 302)
|
|
|
|
charter = Document.objects.get(name="charter-ietf-%s" % group.acronym)
|
|
self.assertEqual(charter.rev, next_revision(prev_rev))
|
|
self.assertTrue("new_revision" in charter.latest_event().type)
|
|
|
|
with open(os.path.join(self.charter_dir, charter.canonical_name() + "-" + charter.rev + ".txt")) as f:
|
|
self.assertEqual(f.read(),
|
|
"Windows line\nMac line\nUnix line\n" + utf_8_snippet)
|
|
|
|
def test_edit_announcement_text(self):
|
|
draft = make_test_data()
|
|
charter = draft.group.charter
|
|
|
|
for ann in ("action", "review"):
|
|
url = urlreverse('ietf.doc.views_charter.announcement_text', kwargs=dict(name=charter.name, ann=ann))
|
|
self.client.logout()
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
|
|
# normal get
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
q = PyQuery(r.content)
|
|
self.assertEqual(len(q('textarea[name=announcement_text]')), 1)
|
|
# as Secretariat, we can send
|
|
if ann == "review":
|
|
mailbox_before = len(outbox)
|
|
by = Person.objects.get(user__username="secretary")
|
|
r = self.client.post(url, dict(
|
|
announcement_text=default_review_text(draft.group, charter, by).text,
|
|
send_text="1"))
|
|
self.assertEqual(len(outbox), mailbox_before + 1)
|
|
|
|
# save
|
|
r = self.client.post(url, dict(
|
|
announcement_text="This is a simple test.",
|
|
save_text="1"))
|
|
self.assertEqual(r.status_code, 302)
|
|
self.assertTrue("This is a simple test" in charter.latest_event(WriteupDocEvent, type="changed_%s_announcement" % ann).text)
|
|
|
|
# test regenerate
|
|
r = self.client.post(url, dict(
|
|
announcement_text="This is a simple test.",
|
|
regenerate_text="1"))
|
|
self.assertEqual(r.status_code, 200)
|
|
q = PyQuery(r.content)
|
|
self.assertTrue(draft.group.name in charter.latest_event(WriteupDocEvent, type="changed_%s_announcement" % ann).text)
|
|
|
|
def test_edit_ballot_writeupnotes(self):
|
|
draft = make_test_data()
|
|
charter = draft.group.charter
|
|
by = Person.objects.get(user__username="secretary")
|
|
|
|
BallotDocEvent.objects.create(
|
|
type="created_ballot",
|
|
ballot_type=BallotType.objects.get(doc_type="charter", slug="approve"),
|
|
by=by,
|
|
doc=charter,
|
|
desc="Created ballot",
|
|
)
|
|
|
|
url = urlreverse('ietf.doc.views_charter.ballot_writeupnotes', kwargs=dict(name=charter.name))
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
|
|
default_action_text(draft.group, charter, by)
|
|
|
|
# normal get
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
q = PyQuery(r.content)
|
|
self.assertEqual(len(q('textarea[name=ballot_writeup]')), 1)
|
|
|
|
# save
|
|
r = self.client.post(url, dict(
|
|
ballot_writeup="This is a simple test.",
|
|
save_ballot_writeup="1"))
|
|
self.assertEqual(r.status_code, 200)
|
|
self.assertTrue("This is a simple test" in charter.latest_event(WriteupDocEvent, type="changed_ballot_writeup_text").text)
|
|
|
|
# send
|
|
mailbox_before = len(outbox)
|
|
r = self.client.post(url, dict(
|
|
ballot_writeup="This is a simple test.",
|
|
send_ballot="1"))
|
|
self.assertEqual(len(outbox), mailbox_before + 1)
|
|
|
|
def test_approve(self):
|
|
make_test_data()
|
|
|
|
group = Group.objects.get(acronym="ames")
|
|
charter = group.charter
|
|
|
|
url = urlreverse('charter_approve', kwargs=dict(name=charter.name))
|
|
login_testing_unauthorized(self, "secretary", url)
|
|
|
|
with open(os.path.join(self.charter_dir, "%s-%s.txt" % (charter.canonical_name(), charter.rev)), "w") as f:
|
|
f.write("This is a charter.")
|
|
|
|
p = Person.objects.get(name="Aread Irector")
|
|
|
|
BallotDocEvent.objects.create(
|
|
type="created_ballot",
|
|
ballot_type=BallotType.objects.get(doc_type="charter", slug="approve"),
|
|
by=p,
|
|
doc=charter,
|
|
desc="Created ballot",
|
|
)
|
|
|
|
charter.set_state(State.objects.get(used=True, type="charter", slug="iesgrev"))
|
|
|
|
due_date = datetime.date.today() + datetime.timedelta(days=180)
|
|
m1 = GroupMilestone.objects.create(group=group,
|
|
state_id="active",
|
|
desc="Has been copied",
|
|
due=due_date,
|
|
resolved="")
|
|
# m2 isn't used -- missing test?
|
|
m2 = GroupMilestone.objects.create(group=group, # pyflakes:ignore
|
|
state_id="active",
|
|
desc="To be deleted",
|
|
due=due_date,
|
|
resolved="")
|
|
# m3 isn't used -- missing test?
|
|
m3 = GroupMilestone.objects.create(group=group, # pyflakes:ignore
|
|
state_id="charter",
|
|
desc="Has been copied",
|
|
due=due_date,
|
|
resolved="")
|
|
m4 = GroupMilestone.objects.create(group=group,
|
|
state_id="charter",
|
|
desc="New charter milestone",
|
|
due=due_date,
|
|
resolved="")
|
|
|
|
# normal get
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
q = PyQuery(r.content)
|
|
self.assertTrue("Send out the announcement" in q('input[type=submit]')[0].get('value'))
|
|
self.assertEqual(len(q('pre')), 1)
|
|
|
|
# approve
|
|
mailbox_before = len(outbox)
|
|
|
|
r = self.client.post(url, dict())
|
|
self.assertEqual(r.status_code, 302)
|
|
|
|
charter = Document.objects.get(name=charter.name)
|
|
self.assertEqual(charter.get_state_slug(), "approved")
|
|
self.assertTrue(not charter.ballot_open("approve"))
|
|
|
|
self.assertEqual(charter.rev, "01")
|
|
self.assertTrue(os.path.exists(os.path.join(self.charter_dir, "charter-ietf-%s-%s.txt" % (group.acronym, charter.rev))))
|
|
|
|
self.assertEqual(len(outbox), mailbox_before + 2)
|
|
self.assertTrue("WG Action" in outbox[-1]['Subject'])
|
|
self.assertTrue("approved" in outbox[-2]['Subject'].lower())
|
|
|
|
self.assertEqual(group.groupmilestone_set.filter(state="charter").count(), 0)
|
|
self.assertEqual(group.groupmilestone_set.filter(state="active").count(), 2)
|
|
self.assertEqual(group.groupmilestone_set.filter(state="active", desc=m1.desc).count(), 1)
|
|
self.assertEqual(group.groupmilestone_set.filter(state="active", desc=m4.desc).count(), 1)
|
|
|
|
def test_charter_with_milestones(self):
|
|
draft = make_test_data()
|
|
charter = draft.group.charter
|
|
|
|
NewRevisionDocEvent.objects.create(doc=charter,
|
|
type="new_revision",
|
|
rev=charter.rev,
|
|
by=Person.objects.get(name="(System)"))
|
|
|
|
m = GroupMilestone.objects.create(group=draft.group,
|
|
state_id="active",
|
|
desc="Test milestone",
|
|
due=datetime.date.today(),
|
|
resolved="")
|
|
|
|
url = urlreverse('charter_with_milestones_txt', kwargs=dict(name=charter.name, rev=charter.rev))
|
|
r = self.client.get(url)
|
|
self.assertEqual(r.status_code, 200)
|
|
self.assertTrue(m.desc in r.content)
|