6c8629c4a9
This set of changes focuses on improvements to the nomcom portion of
the datatracker.
These changes:
- Simplify the nomcom form for comments. Make it more obvious who
receives mail when a comment is supplied. Fixes #1849.
- Simplify the nomcom form for nominations. Provide a primary workflow
where nominations choose an existing Person, and a secondary
workflow for nominating new people.
- Allow nominees to add a comment when accepting or declining a
nomination. Fixes #1845.
- Organize the list of nominees on the feedback page. Fixes #1786 and
#1809.
- Simplify the mechanisms used to display feedback message counts.
- Regroup the feedback view to make it easier to see where to spend
review effort. Fixes #1866.
- Capture when nomcom members last reviewed feedback for a given
nominee. Add badges when new feedback is avaliable. Improve the
layout of the feedback index page. Fixes #1850.
- Reorganize the tab navigation on the nomcom private pages. Made it
more obvious when the chair is doing something that only the chair
gets to see. Fixes #1788 and #1795.
- Regroup multiselect options to make classifying pending feedback
simpler. Make the control larger and resizable. Fixes #1495.
- Simplify the chair's views for editing nominee records. Replace the
merge nominee form with a request to the secretariat to merge Person
records. Fixes #1847.
- Added merging nominees to the secretariat's persson merging script.
- Show information for concluded nomcoms. Close feedback and
nomination for concluded nomcoms. Fixes #1856.
- Improve the questionnaire templates, reminding the nominee that
receiving the questionnaire does not imply they have accepted a
nomination. Fixes #1807.
- Remove the description field from Postion. Simplify the Position
list and the Position edit form. Make the nomcom pages more self
documenting. Add a page to help nomcom chiars through setting up a
new nomcom. Fixes #1867 and #1768.
- Remove the type from the template pathname for the requirements
templates. Make the requirements views work for both types plain and
rst. Changed the default type for new nomcom requirement templates
to rst.
- Remove 'incumbent' from the models. Fixes #1771.
- Adjust the models for Nominee and Nomination to better associate
Nominee objects with Person objects.
- Remove BaseNomcomForm and the implementation of custom fieldsets.
- Replace the custom message framework with the django provided
messages framework.
- Improve SearchablePersonField to show the primary email address for
any search result where a name appears more than once.
- Add the use of factory-boy for generating test data. Normalize
management of a test directory for test nomcom public keys.
Significantly improve test coverage of the nomcom related code.
- Legacy-Id: 10703
Note: SVN reference [10629] has been migrated to Git commit
|
||
|---|---|---|
| bin | ||
| bootstrap | ||
| buildbot/masters/datatracker | ||
| data | ||
| docker | ||
| etc | ||
| form_utils | ||
| hooks | ||
| ietf | ||
| notes | ||
| redesign | ||
| static | ||
| test | ||
| timedelta | ||
| vzic | ||
| .editorconfig | ||
| .eslintrc.js | ||
| .gitignore | ||
| changelog | ||
| changelog.py | ||
| control | ||
| debug.py | ||
| hold-for-merge | ||
| INSTALL | ||
| LICENSE | ||
| LICENSE.django | ||
| PLAN | ||
| README-CDN.rst | ||
| README.datatracker | ||
| ready-for-merge | ||
| release-coverage.json.gz | ||
| requirements.txt | ||
| tzparse.py | ||
The "new" datatracker uses Twitter Bootstrap for the UI. Get familiar with http://getbootstrap.com/getting-started/ and use those UI elements instead of cooking up your own. We have some site-wide customization applied to the bootstrap version we keep in bootstrap/ (from which the minified dist version is built); it modifies some stuff under less/ We also apply some additional custiomizations in static/css/ietf.css; we should eventually move that under bootstrap/less/ if possible. (ietf.css was what Lars used initially for customization with an unmodified bootstrap.) Some ground rules: * Think hard before tweaking the bootstrap CSS, it will make it harder to upgrade to future releases. * No <style> tags in the HTML! Put CSS into the "morecss" block of a template instead. * CSS that is used by multiple templates goes into static/css/ietf.css. * Javascript that is only used on one template goes into the "js" block of that template. * Javascript that is used by multiple templates goes into static/js/ietf.js. * Every template includes jquery, so write jquery code and not plain Javascript. It's shorter and often faster. * No CSS, HTML styling or Javascript in the python code! * Templates that use jquery or bootstrap plugins include the css file in the "pagehead" block, and the Javascript in the "js" block.